 Tim van der Lippe
|
25a6adb9c1
|
Reland "Fix all issues found by StyleLint 14"
This reverts commit f746fe4a57.
Reason for revert: fix the missing script_args variable.
Original change's description:
> Revert "Fix all issues found by StyleLint 14"
>
> This reverts commit fb8852321b.
>
> Reason for revert: breaks the presubmit. Since the tree is closed,
> a fix forward is not landing soon. Therefore, let's pre-emptively revert.
>
> Original change's description:
> > Fix all issues found by StyleLint 14
> >
> > These are mostly auto-fixed by Stylelint 14 with a couple of manual
> > fixes (adding quotes around urls and fixing some shorthand properties).
> >
> > A follow-up CL will update us to Stylelint 14, at which point they will
> > be enforced.
> >
> > R=szuend@chromium.org
> >
> > Bug: none
> > Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
> > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> > Commit-Queue: Simon Zünd <szuend@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> Bug: none
> Change-Id: I155ef7e0633cba15b47439a37a71158b6dcb8f91
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259702
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: none
Change-Id: I81b402e4a30981cb1a0360053b3553cd1934cbe6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
|
2021-11-05 15:41:29 +00:00 |
|
|
Tim van der Lippe
|
f746fe4a57
|
Revert "Fix all issues found by StyleLint 14"
This reverts commit fb8852321b.
Reason for revert: breaks the presubmit. Since the tree is closed,
a fix forward is not landing soon. Therefore, let's pre-emptively revert.
Original change's description:
> Fix all issues found by StyleLint 14
>
> These are mostly auto-fixed by Stylelint 14 with a couple of manual
> fixes (adding quotes around urls and fixing some shorthand properties).
>
> A follow-up CL will update us to Stylelint 14, at which point they will
> be enforced.
>
> R=szuend@chromium.org
>
> Bug: none
> Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>
Bug: none
Change-Id: I155ef7e0633cba15b47439a37a71158b6dcb8f91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259702
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
2021-11-04 16:13:19 +00:00 |
|
|
Tim van der Lippe
|
fb8852321b
|
Fix all issues found by StyleLint 14
These are mostly auto-fixed by Stylelint 14 with a couple of manual
fixes (adding quotes around urls and fixing some shorthand properties).
A follow-up CL will update us to Stylelint 14, at which point they will
be enforced.
R=szuend@chromium.org
Bug: none
Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
|
2021-11-04 15:20:38 +00:00 |
|
|
Tim van der Lippe
|
a53672de83
|
Check license headers for CSS files during PRESUBMIT
This mirrors the license header checks we perform for
Python-like files and apply the same logic for CSS.
To do so, we modify the relevant regexes and patch
function to use the correct version of comment structure
for CSS files (which use `/*` rather than `#` as delimiters).
R=jacktfranklin@chromium.org
Bug: 1106746
Change-Id: I51d51e9b793a1015aeb20a3b3a55e075c2ee748f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3014756
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
|
2021-07-13 12:28:56 +00:00 |
|
|
Jack Franklin
|
453a2ba7ca
|
[Dark mode] make changesSidebar.css consistent with sources sidebar
Bug: chromium:1152736, chromium:1210894
Change-Id: I6b3b9af30fbe0b0e1fdddb6c10a4bc4647909093
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2910103
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
|
2021-05-21 21:24:12 +00:00 |
|
|
Jack Franklin
|
ccc02155cc
|
[Dark Mode] changeSidebar.css
Bug: chromium:1152736
Change-Id: Ifad64a29f1b97c9b564e2d9128d247263629395b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905505
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
|
2021-05-19 12:32:33 +00:00 |
|
|
Tim van der Lippe
|
ad935d1203
|
Move changes to panels/changes
R=aerotwist@chromium.org
Bug: 1187573
Change-Id: Ie491631f84a89c24a8a1feedd74d667c8c38b3d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2767265
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
|
2021-03-18 13:38:37 +00:00 |
|