zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 20:39:31 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
9 Commits
Author SHA1 Message Date
Tim van der Lippe 25a6adb9c1 Reland "Fix all issues found by StyleLint 14" 
This reverts commit f746fe4a57.

Reason for revert: fix the missing script_args variable.

Original change's description:
> Revert "Fix all issues found by StyleLint 14"
>
> This reverts commit fb8852321b.
>
> Reason for revert: breaks the presubmit. Since the tree is closed,
> a fix forward is not landing soon. Therefore, let's pre-emptively revert.
>
> Original change's description:
> > Fix all issues found by StyleLint 14
> >
> > These are mostly auto-fixed by Stylelint 14 with a couple of manual
> > fixes (adding quotes around urls and fixing some shorthand properties).
> >
> > A follow-up CL will update us to Stylelint 14, at which point they will
> > be enforced.
> >
> > R=​szuend@chromium.org
> >
> > Bug: none
> > Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
> > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> > Commit-Queue: Simon Zünd <szuend@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> Bug: none
> Change-Id: I155ef7e0633cba15b47439a37a71158b6dcb8f91
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259702
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: none
Change-Id: I81b402e4a30981cb1a0360053b3553cd1934cbe6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-05 15:41:29 +00:00
Tim van der Lippe f746fe4a57 Revert "Fix all issues found by StyleLint 14" 
This reverts commit fb8852321b.

Reason for revert: breaks the presubmit. Since the tree is closed,
a fix forward is not landing soon. Therefore, let's pre-emptively revert.

Original change's description:
> Fix all issues found by StyleLint 14
>
> These are mostly auto-fixed by Stylelint 14 with a couple of manual
> fixes (adding quotes around urls and fixing some shorthand properties).
>
> A follow-up CL will update us to Stylelint 14, at which point they will
> be enforced.
>
> R=​szuend@chromium.org
>
> Bug: none
> Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

Bug: none
Change-Id: I155ef7e0633cba15b47439a37a71158b6dcb8f91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259702
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-11-04 16:13:19 +00:00
Tim van der Lippe fb8852321b Fix all issues found by StyleLint 14 
These are mostly auto-fixed by Stylelint 14 with a couple of manual
fixes (adding quotes around urls and fixing some shorthand properties).

A follow-up CL will update us to Stylelint 14, at which point they will
be enforced.

R=szuend@chromium.org

Bug: none
Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-04 15:20:38 +00:00
Tim van der Lippe 5522bfcbad Rewrite the change diff viewer to no longer be an editor 
R=tvanderlippe@chromium.org

Bug: 1241848
Change-Id: I8dd11ed4a418cce74095e99c839d831812b57e35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3217626
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-10-14 14:02:57 +00:00
Jack Franklin 92fb5f5b91 [DarkMode] changesView.css 
Bug: chromium:1152736
Change-Id: Iae6c0d050d5f0593a1ff3eff0fa4e95641b5412d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905503
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-05-19 12:07:42 +00:00
Tim van der Lippe af02decd68 Disallow !important in CSS files 
To make sure that any newly written CSS files for new components
do not use !important, since they will be using shadow DOM. Moreover,
!important is usually an anti-pattern that makes it harder to reason
about CSS cascading. It is also disallowed internally at Google.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Idcd2c90d01ff2e782a02d0a4631be384b1a3ca74
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2871716
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2021-05-04 16:14:35 +00:00
Jack Franklin 9b1435f00c Prefix more legacy CSS variables with --legacy-*. 
Bug: chromium:1152736
Change-Id: I2a122a944061a85764e4dfdd5c46025b8606e706
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854688
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-28 14:12:24 +00:00
Jack Franklin 374ec39011 Remove --toolbar-bg-color and --tab-selected-bg-color 
These were both aliased to new colors anyway, so this CL removes the
legacy colors and updates all usages to point to the new CSS
variables.

Bug: chromium:1152736
Change-Id: Ibe034fd8ca9fb8057f92dc6d3974dc73f28f8f92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2853384
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-28 09:29:44 +00:00
Tim van der Lippe ad935d1203 Move changes to panels/changes 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ie491631f84a89c24a8a1feedd74d667c8c38b3d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2767265
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-03-18 13:38:37 +00:00