zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-06 20:11:38 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
108 Commits
Author SHA1 Message Date
Simon Zünd 7a5852438e Update @typescript-eslint/plugin to 5.20.0 
Our current @typescript-eslint version does not support TypeScript 4.6.
The update fixes that.

.eslintrc.js changes taken from https://crrev.com/c/3583292.

DISABLE_THIRD_PARTY_CHECK="Update contains a breaking change. Requires
updated config"

Bug: None
Change-Id: Id1d9f4f073f068ec95af6632a6d061adbee63cca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3592593
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-04-19 07:12:14 +00:00
Jan Keitel 8363c28e52 Add devtools support for HWB color format. 
Extend HWB conversion support in Color class and add HWB
format to ColorPicker and ColorSwatch.

Bug: 1288883
Backend-CL: https://crrev.com/c/3404291
Change-Id: I6442ef8d36fe56711bb768d49247aff4a26f28d1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3513834
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Jan Keitel <jkeitel@google.com>
 2022-03-10 10:03:32 +00:00
Alex Rudenko dc48499246 Revert "Reland "Batch rendering commands and skip rendering if commands are same"" 
This reverts commit 8e6a222bff.

Reason for revert: breaks the overlay (crbug/1281801)

Original change's description:
> Reland "Batch rendering commands and skip rendering if commands are same"
>
> This is a reland of 2288c1657c + a fix
> for the issue when hiding and showing the same overlay lead to the
> overlay not being painted.
>
> Note: on my CPU this optimization reduces cpu usage from ~60% to ~30%
> when inspecting a single element that does not change.
>
> Original change's description:
> > Batch rendering commands and skip rendering if commands are same
> >
> > Bug: 1062574
> > Change-Id: I2bd2d02055f36a318ecd56194817fb531eb614b9
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3301392
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
>
> Bug: 1062574
> Change-Id: I82e6ed03cd7c44f0e8ac7fd78f3623bed8e23187
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3308808
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>

Bug: 1062574
Change-Id: I88848f84d5b7d588877e513a02d7cc23a3a5a598
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3352204
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2021-12-21 16:21:24 +00:00
Alex Rudenko 8e6a222bff Reland "Batch rendering commands and skip rendering if commands are same" 
This is a reland of 2288c1657c + a fix
for the issue when hiding and showing the same overlay lead to the
overlay not being painted.

Note: on my CPU this optimization reduces cpu usage from ~60% to ~30%
when inspecting a single element that does not change.

Original change's description:
> Batch rendering commands and skip rendering if commands are same
>
> Bug: 1062574
> Change-Id: I2bd2d02055f36a318ecd56194817fb531eb614b9
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3301392
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>

Bug: 1062574
Change-Id: I82e6ed03cd7c44f0e8ac7fd78f3623bed8e23187
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3308808
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-12-13 07:38:32 +00:00
Alex Rudenko 716813300a Revert "Batch rendering commands and skip rendering if commands are same" 
This reverts commit 2288c1657c.

Reason for revert: does not work as expected and has minor issues.

Original change's description:
> Batch rendering commands and skip rendering if commands are same
>
> Bug: 1062574
> Change-Id: I2bd2d02055f36a318ecd56194817fb531eb614b9
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3301392
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>

Bug: 1062574
Change-Id: I4f72ba6256b00af75c58b026b1d2a8d4aaec91de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306505
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-11-30 14:05:24 +00:00
Alex Rudenko 2288c1657c Batch rendering commands and skip rendering if commands are same 
Bug: 1062574
Change-Id: I2bd2d02055f36a318ecd56194817fb531eb614b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3301392
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-29 20:51:56 +00:00
Alex Rudenko 22ed10122d Support drawingFinished event in the overlay 
Backend CL: crrev.com/c/3296293
Bug: 1062574
Change-Id: Ie829e488aa496354c6fc2393270fd75c0ce281dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3298825
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-25 07:03:57 +00:00
Tim van der Lippe adf814f1f3 Remove unit test folder exemption 
Previously, we exempted our unit tests from importing only entrypoints.
However, we later realized that we always have to import the entrypoint
to avoid build non-determinism problems. Therefore, remove these exemptions,
which incidentally caught some existing violations.

The ColorUtils file is special in inspector_overlay, so we can safely
exempt that one as a one-off. The e2e-test need to import the helpers
as all other e2e-tests do. The hello-world is an example, so let's ignore
that one for now.

R=jacktfranklin@chromium.org

Bug: 1271490
Change-Id: Ib05d799b547e46cde4349b8738a5ecd63d50f3e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3291160
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-19 14:44:06 +00:00
Tim van der Lippe 25a6adb9c1 Reland "Fix all issues found by StyleLint 14" 
This reverts commit f746fe4a57.

Reason for revert: fix the missing script_args variable.

Original change's description:
> Revert "Fix all issues found by StyleLint 14"
>
> This reverts commit fb8852321b.
>
> Reason for revert: breaks the presubmit. Since the tree is closed,
> a fix forward is not landing soon. Therefore, let's pre-emptively revert.
>
> Original change's description:
> > Fix all issues found by StyleLint 14
> >
> > These are mostly auto-fixed by Stylelint 14 with a couple of manual
> > fixes (adding quotes around urls and fixing some shorthand properties).
> >
> > A follow-up CL will update us to Stylelint 14, at which point they will
> > be enforced.
> >
> > R=​szuend@chromium.org
> >
> > Bug: none
> > Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
> > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> > Commit-Queue: Simon Zünd <szuend@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> Bug: none
> Change-Id: I155ef7e0633cba15b47439a37a71158b6dcb8f91
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259702
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: none
Change-Id: I81b402e4a30981cb1a0360053b3553cd1934cbe6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-05 15:41:29 +00:00
Tim van der Lippe f746fe4a57 Revert "Fix all issues found by StyleLint 14" 
This reverts commit fb8852321b.

Reason for revert: breaks the presubmit. Since the tree is closed,
a fix forward is not landing soon. Therefore, let's pre-emptively revert.

Original change's description:
> Fix all issues found by StyleLint 14
>
> These are mostly auto-fixed by Stylelint 14 with a couple of manual
> fixes (adding quotes around urls and fixing some shorthand properties).
>
> A follow-up CL will update us to Stylelint 14, at which point they will
> be enforced.
>
> R=​szuend@chromium.org
>
> Bug: none
> Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

Bug: none
Change-Id: I155ef7e0633cba15b47439a37a71158b6dcb8f91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259702
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-11-04 16:13:19 +00:00
Tim van der Lippe fb8852321b Fix all issues found by StyleLint 14 
These are mostly auto-fixed by Stylelint 14 with a couple of manual
fixes (adding quotes around urls and fixing some shorthand properties).

A follow-up CL will update us to Stylelint 14, at which point they will
be enforced.

R=szuend@chromium.org

Bug: none
Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-04 15:20:38 +00:00
Andrey Kosyakov 1b5f94829b Send non-stringified rect in overlay Screenshot tool 
The back-end counterpart: https://crrev.com/c/3194764

Change-Id: I16c8b0a6f8d6045eed85be8d1c24fae298e4b679
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3195045
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-10-01 18:40:50 +00:00
Changhao Han 8709d85833 Enable isolation mode for container query containers 
screencast: https://imgur.com/a/61Tvewc

backend CL: https://crrev.com/c/3173212

Bug: chromium:1146422
Change-Id: I57abf59ae8d22927c3fb514e4dd684d5656b410a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3175289
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2021-09-30 07:53:11 +00:00
Alex Rudenko 9bae604356 gn: explicitly define rollup as an input in inspector_overlay 
Fixed: chromium:1253235
Change-Id: I6c8dfbe68ea4de3ce904f9046c4b214b119de63d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3185488
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-09-27 10:55:45 +00:00
Alex Rudenko c30660f498 Overlay: render viewport size for media queries 
See the description of the issue in the backend CL: https://crrev.com/c/3157564

Bug: chromium:1246967, chromium:1064297
Change-Id: I113b13eacf98c91ac2c2ecb6d52da4d9b72c2fcb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3157958
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-09-14 08:20:07 +00:00
Changhao Han 6f2632929a Add persistent overlay to container queries 
Corresponding backend CL: https://crrev.com/c/3075106

Screenshot: https://imgur.com/a/64z9jhp

Design doc: Design doc: https://docs.google.com/document/d/1FGwUsRC3UHXJjcJ5H2DhMi2E2bIFY2tmUBuL984UK-I/edit#heading=h.48af6be715km

Bug: chromium:1146422
Change-Id: I04ca10c1f1cee5914c7a8c18f352bfc94843a7ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080307
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
 2021-08-09 18:14:13 +00:00
Kriti Sapra 56daf78ddb Updated no-multiple-empty-lines to only have 1 as max 
DISABLE_THIRD_PARTY_CHECK=updated linting formatting
Bug: 1106746
Change-Id: I371bca95b7cf1e8b7eaa4f9e7c3860af4eedee3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3057042
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-28 14:10:15 +00:00
Kriti Sapra 05286716f0 Updated nodeText.css to use --override pattern 
Bug: 1227651
Change-Id: I1521b67acc149865267370fef5efebc691fc2013
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3030762
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-07-15 13:22:26 +00:00
Tim van der Lippe a53672de83 Check license headers for CSS files during PRESUBMIT 
This mirrors the license header checks we perform for
Python-like files and apply the same logic for CSS.

To do so, we modify the relevant regexes and patch
function to use the correct version of comment structure
for CSS files (which use `/*` rather than `#` as delimiters).

R=jacktfranklin@chromium.org

Bug: 1106746
Change-Id: I51d51e9b793a1015aeb20a3b3a55e075c2ee748f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3014756
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-13 12:28:56 +00:00
Changhao Han a7e1eac63b Add container-outline overlay for container queries 
Backend CL: https://crrev.com/c/3014915

Design doc: https://docs.google.com/document/d/1FGwUsRC3UHXJjcJ5H2DhMi2E2bIFY2tmUBuL984UK-I/edit

There will be follow-up CLs to implement the Isolation Mode.

Bug: chromium:1146422
Change-Id: I17e94a95c5bfe280f01e6d6e6f37c0230e59a2df
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3015737
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2021-07-09 20:58:52 +00:00
Alex Rudenko fde72bcc0e Visualize visual viewport if provided 
Backend CL: https://crrev.com/c/2988300

Bug: chromium:1064297
Change-Id: Ibb407f51d2c48ac47a1bfa36380fb6e65da4eea4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987786
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-06-28 07:47:50 +00:00
Takuto Ikuta 0e87680f36 Reland "Reland "use python3 in devtools-frontend by default"" 
This reverts commit 7c57958680.

Reason for revert:
This uses dict instead of set in modular_build.py for deterministic
output.
ref: https://softwaremaniacs.org/blog/2020/02/05/dicts-ordered/en/

I confirmed that devtools_app.js is the same in repeated builds.

Original change's description:
> Revert "Reland "use python3 in devtools-frontend by default""
>
> This reverts commit 0d4947c37e.
>
> Reason for revert: https://crbug.com/1211770
>
> Original change's description:
> > Reland "use python3 in devtools-frontend by default"
> >
> > This reverts commit a8336c1e58.
> >
> > Reason for revert:
> > use universal_newlines instead of text for
> > https://docs.python.org/3/library/subprocess.html#subprocess.Popen
> >
> > I tried to divide this CL in to make py2/3 compatible and switch in
> > another CL. But that hit another issue due to the difference of string
> > type around io.StringIO and cStringIO.StringIO like
> > https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8846743161604002304/+/u/compile/raw_io.output_failure_summary_
> >
> > So decided to re-land the switch with fix for known issue.
> >
> > I confirmed this works for python3.6 too.
> >
> > Original change's description:
> > > Revert "use python3 in devtools-frontend by default"
> > >
> > > This reverts commit 37c0bf698d.
> > >
> > > Reason for revert:
> > > Compatibility issues with python 3.6.
> > >
> > > Original change's description:
> > > > use python3 in devtools-frontend by default
> > > >
> > > > Fixed: 1205624, 1205625
> > > > Change-Id: Iddaf2a49bffd92140d1877784ffd9f5dd83ac3de
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2902988
> > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> > > > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> > >
> > > Change-Id: Ic426154f58798dd8631f9bac101521f0b25ea54c
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2906060
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> >
> > Bug: 1210939, 1205624, 1205625
> > Change-Id: Ia7ddf5ab37c8df3e2f682bf89cb55ef30e663341
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2909053
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
>
> Bug: 1210939
> Bug: 1205624
> Bug: 1205625
> Bug: 1211770
> No-Tree-Checks: true
> No-Presubmit: true
> Change-Id: Ic3a6add15b4126dfe818b445a5227253d296ee96
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2910016
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>

Bug: 1210939
Bug: 1205624
Bug: 1205625
Bug: 1211770
Change-Id: I2acb2968e68f55a663cd5221c1c92b16301392cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2910020
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2021-05-24 09:58:37 +00:00
Takuto Ikuta 7c57958680 Revert "Reland "use python3 in devtools-frontend by default"" 
This reverts commit 0d4947c37e.

Reason for revert: https://crbug.com/1211770

Original change's description:
> Reland "use python3 in devtools-frontend by default"
>
> This reverts commit a8336c1e58.
>
> Reason for revert:
> use universal_newlines instead of text for
> https://docs.python.org/3/library/subprocess.html#subprocess.Popen
>
> I tried to divide this CL in to make py2/3 compatible and switch in
> another CL. But that hit another issue due to the difference of string
> type around io.StringIO and cStringIO.StringIO like
> https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8846743161604002304/+/u/compile/raw_io.output_failure_summary_
>
> So decided to re-land the switch with fix for known issue.
>
> I confirmed this works for python3.6 too.
>
> Original change's description:
> > Revert "use python3 in devtools-frontend by default"
> >
> > This reverts commit 37c0bf698d.
> >
> > Reason for revert:
> > Compatibility issues with python 3.6.
> >
> > Original change's description:
> > > use python3 in devtools-frontend by default
> > >
> > > Fixed: 1205624, 1205625
> > > Change-Id: Iddaf2a49bffd92140d1877784ffd9f5dd83ac3de
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2902988
> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> > > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> >
> > Change-Id: Ic426154f58798dd8631f9bac101521f0b25ea54c
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2906060
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
>
> Bug: 1210939, 1205624, 1205625
> Change-Id: Ia7ddf5ab37c8df3e2f682bf89cb55ef30e663341
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2909053
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>

Bug: 1210939
Bug: 1205624
Bug: 1205625
Bug: 1211770
No-Tree-Checks: true
No-Presubmit: true
Change-Id: Ic3a6add15b4126dfe818b445a5227253d296ee96
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2910016
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
 2021-05-21 13:19:43 +00:00
Takuto Ikuta 0d4947c37e Reland "use python3 in devtools-frontend by default" 
This reverts commit a8336c1e58.

Reason for revert:
use universal_newlines instead of text for
https://docs.python.org/3/library/subprocess.html#subprocess.Popen

I tried to divide this CL in to make py2/3 compatible and switch in
another CL. But that hit another issue due to the difference of string
type around io.StringIO and cStringIO.StringIO like
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8846743161604002304/+/u/compile/raw_io.output_failure_summary_

So decided to re-land the switch with fix for known issue.

I confirmed this works for python3.6 too.

Original change's description:
> Revert "use python3 in devtools-frontend by default"
>
> This reverts commit 37c0bf698d.
>
> Reason for revert:
> Compatibility issues with python 3.6.
>
> Original change's description:
> > use python3 in devtools-frontend by default
> >
> > Fixed: 1205624, 1205625
> > Change-Id: Iddaf2a49bffd92140d1877784ffd9f5dd83ac3de
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2902988
> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
>
> Change-Id: Ic426154f58798dd8631f9bac101521f0b25ea54c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2906060
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>

Bug: 1210939, 1205624, 1205625
Change-Id: Ia7ddf5ab37c8df3e2f682bf89cb55ef30e663341
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2909053
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
 2021-05-20 07:49:35 +00:00
Michael Achenbach a8336c1e58 Revert "use python3 in devtools-frontend by default" 
This reverts commit 37c0bf698d.

Reason for revert:
Compatibility issues with python 3.6.

Original change's description:
> use python3 in devtools-frontend by default
>
> Fixed: 1205624, 1205625
> Change-Id: Iddaf2a49bffd92140d1877784ffd9f5dd83ac3de
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2902988
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Change-Id: Ic426154f58798dd8631f9bac101521f0b25ea54c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2906060
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
 2021-05-19 17:13:34 +00:00
Takuto Ikuta 37c0bf698d use python3 in devtools-frontend by default 
Fixed: 1205624, 1205625
Change-Id: Iddaf2a49bffd92140d1877784ffd9f5dd83ac3de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2902988
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-05-18 14:41:02 +00:00
Jack Franklin c62a50c7e0 Add INFRA_OWNERS to inspector_overlay 
Bug: none
Change-Id: I98f5ebce718f222671dd337a920739b04f573819
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2891762
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-05-18 10:49:24 +00:00
Patrick Brosset 8ac4a1cd6f Match extended grid line colors to line color 
Extended grid lines are normally light fray, which makes them really
hard to see on some backgrounds.
This change makes extended grid lines use the same color as the lines
themselves, so they can be seen on all backgrounds more easily.

The grid container already has a solid line around it, so it's easy to
see where the grid starts and ends, even if lines and extended lines are
the same color.

Before/after: https://imgur.com/a/OvW46yn

Bug: 1207301
Change-Id: I5d363edf00acf8aa99e1d642c9088f0880286a10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897261
Reviewed-by: Leo Lee <leolee@microsoft.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
 2021-05-17 07:58:22 +00:00
Jack Franklin 33b3951b92 Fix ESLint import extensions being missed 
Bug: none
Change-Id: Ie3341a56224d7887b42c230ba966cc5eeba38fe4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2886932
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-05-12 14:30:57 +00:00
Jack Franklin a75ae7cbb3 Enforce import type when importing TS types. 
Bug: none
Change-Id: I02ef1182143b7fe091ce92d59f04ac2188903e0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2886925
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-05-11 14:00:22 +00:00
Tim van der Lippe af02decd68 Disallow !important in CSS files 
To make sure that any newly written CSS files for new components
do not use !important, since they will be using shadow DOM. Moreover,
!important is usually an anti-pattern that makes it harder to reason
about CSS cascading. It is also disallowed internally at Google.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Idcd2c90d01ff2e782a02d0a4631be384b1a3ca74
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2871716
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2021-05-04 16:14:35 +00:00
Alex Rudenko 447bf8b2a5 Better indicate snap areas by using half circles for alignment points 
The center alignment points remain visible as a full circle.

Screenshot: https://i.imgur.com/bkzAtRt.png

Bug: 1197450
Change-Id: I6c70a9b39cd4254c39c2c6579302fc5500da286b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2823704
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Peter Müller <petermueller@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-04-14 08:30:31 +00:00
Tim van der Lippe 124fb1d9e6 Replace rjsmin with terser in inspector_overlay 
We can use the terser plugin for Rollup (which the frontend also
uses) to minify our source code, rather than the Python-based
minifier.

When using terser, we can reduce the maximum file size from 110000
to 65000 bytes (~40% reduction).

R=alexrudenko@chromium.org

Bug: none
Change-Id: Ib2d7fd296ab20150dab44224f5ced03c725f798b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815120
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-04-12 11:37:33 +00:00
Alex Rudenko 8cb7637d02 Change rendering order in the scroll snap overlay 
Previously, the container border was rendered before snap areas.
This was leading to the container border being overwritten by
the areas when there are no margins between the container and the
areas. This CL changes the order so that the container border is
rendered on top of the areas.

Before: https://i.imgur.com/iz4kTnM.png
After: https://i.imgur.com/xmpkyKk.png

Fixed: chromium:1196566
Change-Id: Ie3a29013d4c62c72f9f11c55ac12b5e516403bd9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2810274
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
 2021-04-07 13:17:09 +00:00
Tim van der Lippe 7696157ed2 Move common to core/common 
R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: Ia0d2b3a5f6ec2b025e5fe19dc14fbb29e1a2b83c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799759
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-06 11:24:38 +00:00
Alex Rudenko e633829116 Implements an overlay to visualise CSS scroll snapping 
Also, the CL includes a new adorner to control the overlay.

Screenshot: https://i.imgur.com/SZ6zkVm.png
Design doc: https://docs.google.com/document/d/1P1AmuxVpPuSMerPpK4XuWpqKGYqGlvN_G5g5ZQJwetY
Bug: chromium:862450
Change-Id: I21546d99d72fe95a6f20a72606b542c3b10c31f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2763879
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2021-04-01 08:11:13 +00:00
Alex Rudenko da6ba5ab72 Use box sizing to visualise flex items 
Corresponding backend CL: crrev.com/c/2794394
Bug: chromium:1192584
Change-Id: I33e6bd51d427ea0e4aa7fb43f5a313a0b3945016
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2794557
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-03-31 09:43:33 +00:00
Alex Rudenko 78fb5b6688 Update flexbox icon in the overlay 
Screenshot: https://i.imgur.com/NqXhWxS.png
Fixed: chromium:1154598
Change-Id: Ic054b2bff831691c6f8d4dca50f85b707258110b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2794551
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-03-31 09:38:24 +00:00
Alex Rudenko fe5fa1d8be Don't render flex item arrows when the points are the same 
Bug: chromium:1192584
Change-Id: I7532d8902c6c0eda2fbcc3e57ba301a5c67eea9e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2792587
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-03-30 12:18:59 +00:00
Alex Rudenko 314100ad63 Reland "Exclude data files from inspector_overlay targets" 
This is a reland of d5d9b950cb
This CL has to be landed after crrev.com/c/2732043 lands.

Original change's description:
> Exclude data files from inspector_overlay targets
>
> Fixed: chromium:1180230
> Change-Id: I99f736d53f7b653a46da8ecd572e4b3766e1798f
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2716289
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: chromium:1180230
Change-Id: I3afb837b8f59a0a11dee9b74e3db54f0e2c4e48f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2732386
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-03-04 13:45:23 +00:00
Eric Leese a121a6bae6 Revert "Exclude data files from inspector_overlay targets" 
This reverts commit d5d9b950cb.

Reason for revert: Seems to have broken the autoroller due to missing files in fuchsia build. Reland if problem doesn't go away.

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8853712067071111344/+/steps/compile__with_patch_/0/stdout

Original change's description:
> Exclude data files from inspector_overlay targets
>
> Fixed: chromium:1180230
> Change-Id: I99f736d53f7b653a46da8ecd572e4b3766e1798f
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2716289
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Change-Id: I044148c6d76898657e52634a7fd0205bad355a7e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2732385
Auto-Submit: Eric Leese <leese@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-03-04 06:55:13 +00:00
Alex Rudenko d5d9b950cb Exclude data files from inspector_overlay targets 
Fixed: chromium:1180230
Change-Id: I99f736d53f7b653a46da8ecd572e4b3766e1798f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2716289
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-03-03 19:13:05 +00:00
Patrick Brosset 02948c657a Highlight flex items on hover of flex/grow/shrink/basis properties 
This extends the number of properties we highlight on hover in the
styles pane to flex, flex-grow, flex-shrink and flex-basis.

Now that we have a flex item overlay that shows an arrow indicating if
an item grew or shrank, we can use it to nicely inform users about what
these properties do when they hover over them in the styles pane.

To do this, the only necessary changes are the ones in StylesSidebarPane
and OverlayModel.

The rest of the code is for this one edge case: when an item is also a
container, we normally don't draw the item overlay. So in our case that
means we wouldn't draw the flexibility arrow when hovering over flex:1
if that element was also a flex container.
To avoid this, we check if there actually is any (non-transparent) flex
container config passed to the overlay. If there isn't, we can safely
draw the flex item overlay.

Demo: https://imgur.com/g7UtduW

Bug: 1173995
Change-Id: I6236e869ea88b889ba274dbf37601e90a8c94e84
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2729506
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
 2021-03-03 17:55:15 +00:00
Tim van der Lippe bfbb58f10a Use import type for imports in same folder 
This CL is the result of applying the following regex:

```
import (.+) from '(.+)';\s+// eslint-disable-line no-unused-vars
```

and replace it with

```
import type $1 from '$2';
```

in all `*.ts` files. Some manual cleanups are performed when there
were imports that included both types and actual symbol references.

R=aerotwist@chromium.org

No-Presubmit: True
Bug: none
Change-Id: Ia520129af8518b7285c2691a15332a472515cfd3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2720252
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-02-25 17:58:29 +00:00
Patrick Brosset 74a4f4f8e3 [Flexbox] Overlay front-end for drawing flex items 
If the backend responds back with the information for a flex item, then
this draws the base size and flexibility arrow, like so:

+---+-------+
|///|       |
|///|------>|
|///|       |
+---+-------+

The idea is when there is a base size we can detect (which can come from
flex-basis or width or height), then we draw this base size area, and
also draw an arrow from that base size to the final size of the item.

The base size can be smaller than the item, or bigger, if the item
shrank.

+-----------+ -  -  - +
|///////////|/////////|
|///////////|<--------|
|///////////|/////////|
+-----------+ -  -  - +

Screenshot of the new debug page: https://imgur.com/qqjsUwW.jpg

Bug: 1173995
Change-Id: I8e16785c58b801f09340317eae0b922ab1c59422
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2687242
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-18 09:30:14 +00:00
Sigurd Schneider 4b024d2a06 Enforce naming convention in inspector_overlay 
Bug: chromium:1057042
Change-Id: Ia493669b771f16177933de28138a0064fa3cd8d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692783
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-15 14:09:54 +00:00
Alex Rudenko b861859af4 Remove duplicate global type definitions 
Bug: none
Change-Id: Id47291375d5306d48307ab38e9fd085eeab1e04b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2687508
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-11 16:00:21 +00:00
Alex Rudenko 6eedd7e43f Remove backward compatibility check in inspector_overlay 
Bug: none
Change-Id: I26e8bb3bbe66b0271606fcc3e6d050212fd84b04
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2681738
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-02-09 15:37:31 +00:00
Alex Rudenko 529498f949 Use text opacity when computing the contrast in overlay 
Fixed: chromium:1086432
Change-Id: Ic4879bcbd45861670bf1c34262d5e0dcba97bbb2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678095
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-08 11:09:28 +00:00
Sigurd Schneider 1576186355 Enforce member delimiters 
This CL enforces member delimiters following
https://google.github.io/styleguide/tsguide.html#member-property-declarations

Bug: chromium:1057042
Change-Id: I2553aeebb8187235cdf0e7f0585da36ea53388bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2672032
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-04 09:03:57 +00:00