Commit Graph
2 Commits
Author SHA1 Message Date
Alex Rudenko 913515def9 Inspector overlay: remove common.css resource
common.css is included in the main resource so standalone resource
can be removed. This CL depends on:

- crrev.com/c/2484719
- crrev.com/c/2484429

Bug: 1139862
Change-Id: I23ef81c410022137230ccdb5582bd388d1bd40f6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484724
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-10-20 07:21:20 +00:00
Alex Rudenko 6dface0617 Combine overlays into a single resource
This CL combines all overlays in a single entrypoint so that all
overlays are shipped in a single bundle. It introduces a new
call `setOverlay` that is made by the backend to specify which
overlay is active. Overlays implement install/uninstall methods
which allow enabling/disabling overlays without destroying the
page. Note that old entrypoints such as tool_highlight.js can be
removed after this CL lands. The changes give the following
advantages:

- we ship less code by shipping a single bundle (previously, different
bundles contained the same modules).
- we are one step closer to shipping the overlay page via CDP.
- we are able to more easily combine different overlays.

Backend CL: https://crrev.com/c/2461111

Change-Id: I872a1d801879d90cc6d73adec5e88879216d1985
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2460917
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2020-10-13 12:13:18 +00:00