 Tim van der Lippe
|
a53672de83
|
Check license headers for CSS files during PRESUBMIT
This mirrors the license header checks we perform for
Python-like files and apply the same logic for CSS.
To do so, we modify the relevant regexes and patch
function to use the correct version of comment structure
for CSS files (which use `/*` rather than `#` as delimiters).
R=jacktfranklin@chromium.org
Bug: 1106746
Change-Id: I51d51e9b793a1015aeb20a3b3a55e075c2ee748f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3014756
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
|
2021-07-13 12:28:56 +00:00 |
|
|
Jack Franklin
|
0d88cbb6fd
|
Ban named-colors in our CSS
Used
https://css-tricks.com/snippets/css/named-colors-and-hex-equivalents/ as
the reference and did a bunch of find and replaces. Should be no visible
changes; have checked by running DevTools locally and looking for
anything that looks off.
Note that system colors (e.g. HighlightText) are still permitted.
Fixed: chromium:1171775
Bug: chromium:1104187
Change-Id: I99c281886822deb5a5292ac8691a4f2f9e026428
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2656243
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
|
2021-02-01 09:33:45 +00:00 |
|
|
Alex Rudenko
|
b25ebef142
|
Extract inline CSS in inspector overlay
This CL extracts CSS for most tools. Since the order of unit test
execution is not guaranteed and something has changed with these changes
I updated a few tests that relied on global vars set by other tests.
Also I keep the grid styles inline for now because unit tests depend on
it.
Bug: 1100925
Change-Id: I883fe3f9e4e2fded3530cda037588f803632885b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2416526
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
|
2020-09-21 08:57:10 +00:00 |
|