Commit Graph
6 Commits
Author SHA1 Message Date
Liviu Rau 3f146240d2 Run deps scripts with vpython3
+ drive-by imports cleanup

DISABLE_THIRD_PARTY_CHECK=Migrating multiple scripts to py3
Bug: 1292013
Change-Id: I6d004c6fd54253cc3694cf02cfe94731c7d2146d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484199
Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
2022-02-25 10:14:22 +00:00
Takuto Ikuta b7bebb0c26 use urllib.request.urlcleanup() in download_emscripten.py
ref: https://docs.python.org/3/library/urllib.request.html#urllib.request.urlcleanup

Fixed: 1280064
Change-Id: Id39085d6d0ba871dd840e1bc8d74b4e7a3495565
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3341215
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
2021-12-15 12:06:48 +00:00
Tim van der Lippe 8e12f92229 Use Python version bundled with depot_tools for all scripts
depot_tools ships a "vpython" binary that is added to the $PATH
for all Chromium engineers. This binary is versioned by depot_tools
which we roll in ourselves as part of `gclient sync`.

By using `vpython` instead of `python`, we are no longer depended
on the Python version installed locally and instead use the version
we pull in from DEPS.

R=liviurau@chromium.org

Change-Id: If49a54c24b6cf129ff843cd9ca1140a723a78afb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2571462
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-12-04 14:08:59 +00:00
Philip Pfaffe 8e8994436d Fix caching in emscripten download script
Change-Id: I14376ad9e9856a28a57ed266fff2a83a1fbeef16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2485082
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2020-10-20 09:53:30 +00:00
Philip Pfaffe 3351394f22 Update DEPS and gitignore for building with emscripten
Drive-by: Address post-commit comments from crrev.com/c/2409951

Bug: chromium:1128888
Change-Id: I47a8f0c2deee7db15c574195f45a362c4a6d9fbd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2466179
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
2020-10-15 08:14:33 +00:00
Philip Pfaffe 02376092a3 Download emscripten-releases binaries for building wasm tests
This CL adds a DEPS hook that will download tagged emscripten-releases
binaries from googlestorage that will be used to build wasm debugging
tests.

Bug: chromium:1128888

Change-Id: Ib5d0488fe3fe2c3514faa9f76b07e84c51296c25
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2409951
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2020-09-29 11:28:38 +00:00