This checks in the InspectorBackendCommands in the source tree file
and ensures that it is kept in sync whenever the third_party
location has been updated.
In the process, I discovered multiple misconfigurations in the formatting
presubmit check. First of all, it was never running, because the
.eslintignore had an empty line. Second of all, it was running twice,
which is unnecessary since we now check for changed files at the end
of the presubmit. Lastly, it was only formatting JS files, while it
should check all files.
I have also updated the _CheckGeneratedFiles check to only run if it
is actually necessary. If there are no changes made to any affected of
the files, it will skip the step. This should thus reduce the presubmit
time and we will only pay the cost if we actually update any of the
files.
Lastly, it will now properly format and lint the generated files. This
makes reading the code a lot easier and makes it easier to digest the
diff when a protocol update goes through. I have verified that, in a
full build, the files are still minified. Thus, this has no impact on
the loading performance.
DISABLE_THIRD_PARTY_CHECK=Updating protocol generation
Fixed: 1056614
Change-Id: If49b0e749978ea1a7838992ec13507ee761ad76c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2087765
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Previous output:
```
Running web tests with args: ~/projects/chromium/src/third_party/blink/tools/run_web_tests.py,inspector*,http/tests/inspector*,http/tests/devtools,--build-directory,~/projects/chromium/src/out,--target,Release,--additional-driver-flag=--debug-devtools,--additional-driver-flag=--remote-debugging-port=9222,--time-out-ms=6000000,runtime/runtime-evaluate-bad-unicode.js
```
This patch changes the output to:
```
Running web tests with args: ~/projects/chromium/src/third_party/blink/tools/run_web_tests.py inspector* http/tests/inspector* http/tests/devtools --build-directory ~/projects/chromium/src/out --target Release --additional-driver-flag=--debug-devtools --additional-driver-flag=--remote-debugging-port=9222 --time-out-ms=6000000 runtime/runtime-evaluate-bad-unicode.js
```
This way, the output contains the actual command that's being run, making it more readable and copy-paste friendly.
Change-Id: Ib5341514f3802937a052f1c5d257e45ee64c17a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016751
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
The script previously assumed it would always be run from within the
chromium/src/third_party/devtools-frontend/src folder. It would fail
when run from the standalone repository at devtools/devtools-frontend.
This patch makes it work even in that case, as long as the `devtools`
directory in `devtools/devtools-frontend` lives on the same level as
the `chromium` repository.
Change-Id: I3cf81c8144fd3f03389a4ec395b8ec3acdbb8e55
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1939798
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Weizhong Xia