This reverts commit 056ad78a21.
Reason for revert: Suspected to make e2e tests on the windows bot more flaky.
Original change's description:
> Reland: [e2e] Use pre-allocated DevTools and target tabs
>
> This CL relands https://crrev.com/c/3461563.
> The main difference is that while we enable the pool implementation,
> we configure the pool size to be 0 unconditionally. This way, we get
> the benefit of spinning up fresh DevTools and inspected tabs while
> preserving the old behavior of doing the setup of these tabs right
> before a test executes and not in the background.
>
> Original CL description:
> > [e2e] Use pre-allocated DevTools and target tabs
> >
> > This CL changes the conductor to use new DevTools frontend and target
> > tabs for each individual test. A pool prepares a set of frontend/target
> > tab pairs in the background so the conductor doesn't need to waste time
> > resetting tabs in between tests.
> >
> > For debugging e2e tests we disable the pool and use on-demand tab
> > creation instead. It would be annoying to deal with ~12 open tabs
> > and trying to find the right ones in a debugging session.
> >
> > This CL also increases the general e2e test timeout from 5 to 10
> > seconds. This is because of the more volatile nature of e2e tests
> > now. In some edge cases a tab for the currently running test might
> > not get enough CPU time to run in time. This can happen when a
> > serious of short running tests deplete the pool and multiple
> > Devtools frontend instances have to be prepared in the background.
> >
> > R=jacktfranklin@chromium.org
> >
> > Bug: 1297458
> > Change-Id: I6b6c4a15e5d83f7e2bdc6082972993df179a5d87
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3461563
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
> > Commit-Queue: Simon Zünd <szuend@chromium.org>
>
> Bug: 1297458
> Change-Id: Iac0294116f1a9e762a3847bcb0738955bba957b2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641403
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Bug: 1297458
Change-Id: I4758c4c9cb3e7919f12bccc28c9310ab7225c729
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3645451
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
This CL adds the ability to create header overrides from the list of
network requests in the network panel via the context menu.
If a local folder for storing local overrides has already been
configured beforehand, the context menu takes the user straight to the
'.headers' file where header overrides are to be specified. If
overrides have not been configured before, the user has to name a
local folder for storing overrides first.
Video: https://i.imgur.com/kLGlOtL.mp4
Bug: 1297533
Change-Id: I8b31fe41d922e1662da68320fcc188c596c0a058
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3542245
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
This CL relands https://crrev.com/c/3461563.
The main difference is that while we enable the pool implementation,
we configure the pool size to be 0 unconditionally. This way, we get
the benefit of spinning up fresh DevTools and inspected tabs while
preserving the old behavior of doing the setup of these tabs right
before a test executes and not in the background.
Original CL description:
> [e2e] Use pre-allocated DevTools and target tabs
>
> This CL changes the conductor to use new DevTools frontend and target
> tabs for each individual test. A pool prepares a set of frontend/target
> tab pairs in the background so the conductor doesn't need to waste time
> resetting tabs in between tests.
>
> For debugging e2e tests we disable the pool and use on-demand tab
> creation instead. It would be annoying to deal with ~12 open tabs
> and trying to find the right ones in a debugging session.
>
> This CL also increases the general e2e test timeout from 5 to 10
> seconds. This is because of the more volatile nature of e2e tests
> now. In some edge cases a tab for the currently running test might
> not get enough CPU time to run in time. This can happen when a
> serious of short running tests deplete the pool and multiple
> Devtools frontend instances have to be prepared in the background.
>
> R=jacktfranklin@chromium.org
>
> Bug: 1297458
> Change-Id: I6b6c4a15e5d83f7e2bdc6082972993df179a5d87
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3461563
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>
Bug: 1297458
Change-Id: Iac0294116f1a9e762a3847bcb0738955bba957b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641403
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Adding a sandboxed file system via `window.webkitRequestFileSystem` to
hosted mode enables using local overrides in hosted mode. Since e2e-
tests run in hosted mode, this enables adding e2e tests for local
overrides. This CL adds a first such e2e-test testing a simple response
header override.
Bug: 1313436
Change-Id: I6eb3e2ff9de336fa62648647fe48042009743d18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3620364
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
At long last, we can remove the old unused fields now that no
deprecation messages are untranslated.
This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Add milestone and status links
(7) Document milestone and status links
(8) Migrate DeprecationInfo::WithDetails {CHROMIUM}
(9) Roll deps
(10) Migrate DeprecationInfo::WithDetails {DEVTOOLS}
(11) Document changes in development process
(12) Migrate DeprecationInfo::* {CHROMIUM}
(13) Roll deps
(14) Migrate DeprecationInfo::* {DEVTOOLS}
(15) Cleanup Deprecations {CHROMIUM}
(16) Cleanup Deprecations {DEVTOOLS}
(17) Final documentation tweaks
DISABLE_THIRD_PARTY_CHECK=Fields are being removed, so we have to touch non-gen code
Bug: 1264960
Change-Id: If5a286a50cafc073ff99f5e0d8f3d38d5e8ba83a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3613607
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
The change [1] added style pane support for indicating that highlight
rules are overridden in the highight cascade (showing them as
crossed-out). However, custom highlights were left out because custom
highlights of different names would otherwise be shown as overriding
each other, since all custom highlights were grouped into the same
cascade.
This change enables support for custom highlights by splitting
them up into separate cascades for each highlight name.
See [2] for a screenshot of this.
An alternative approach would be to change the inspector protocol
and the StyleResolver on the Blink side such that custom
highlights start out grouped by highlight name. However the
necessary style resolver changes look to be complex enough that
it's probably simpler (or at least not more complicated overall)
to arrange things on the DevTools side.
[1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3563627
[2] https://docs.google.com/document/d/1WHYEp6JfMjsAZLghCJa03HG5FEQEzRCi-naa5dmlQr4/edit?usp=sharing
Bug: 1024156, 1164461
Change-Id: Ib684889b347d9797b6f9c993fe6626053deb8c1a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3603063
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
This is a reland of commit 1b596f3b4b.
Changes:
1. Gated behind an experiment
2. Removed changes that are currently not used since it's gated
(i.e. test changes)
Original change's description:
> Enable synchronization on instrumentation breakpoints
>
> This CL introduces the synchronization point for setting
> breakpoints on new scripts using instrumentation breakpoints.
>
> Instrumentation breakpoints will trigger at the first statement
> of a newly run script. Afterwards we wait for all resources
> that we need to set a breakpoint (if one is cached for that
> particular script), set it, and resume.
>
> Note: this will not correctly synchronize the case where we
> just opened DevTools or just created a new target, as at this
> point some scripts might have started running. For this, we
> need to synchronize the Debugger.enable call, which is something
> that is left to take care of.
>
> Bug: chromium:1229541, chromium:1133307, chromium:1300509
> Change-Id: I44e9b053a7cf64cc1f477a68ce9389cd92a1d05d
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470237
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Bug: chromium:1229541, chromium:1133307, chromium:1300509
Change-Id: I19553ddac9530fa3ccac6b245a3dd89da88c6d51
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3542248
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Simon Zünd