This CL adds content to the endpoints table in the Application panel's
Reporting API view. For each endpoint it shows the origin which
configured the endpoint, the endpoint name and the endpoint URL.
Bug: 1200732
Change-Id: Ie3b94bd81d85d7c6001fd38484434d989a32f9cf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3291155
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
When a frame is being turned into an OOPIF, the frame is being detached
from its original target and added to a new target. Usually the order of
events is:
1) added to original target
2) added to new target
3) detached from original target
But there is no guarantee for this order of events and sometimes the
order of steps 2) and 3) is inverted (detected by a flaky test on the
Mac bot). This CL ensures that the FrameManager is able to correctly
handle both cases. This mainly means taking care of copying frame
creation stack traces.
Disable test CL: https://crrev.com/c/2862803
Update and enable test CL: https://crrev.com/c/2862770
Bug: 1202024
Change-Id: Ie42efcaf75c4aa8a0e71649c9790b23c7eff9e33
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2846335
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Previously these stack traces would be lost when a frame is transferred
out-of-process. By bringing the stack trace along and keeping track of
the relevant target, we can now display those stack traces for OOPIFs
too.
Bug: 1159334
Change-Id: I0063d5dc72ba2b02ae3924d4c908c6d80653315d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686657
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
There are a handful of e2e tests which test regressions, and consequently
have a bug assiciation. This association was part of the test names in
the same way as we reference bugs for skipped tests. If such a test is
then skipped it needs to start with two crbug references. That's
confusing for the reader as well as a the skipped test lint check, for
which the regression bug references can lead to false negatives. This CL
introduces a new lint check that prevents bug references in non-skipped
tests with the same syntax as skipped tests.
Bug: none
Change-Id: Ibdf59091aba942f85424c1f12cc31160d9fe786a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2761357
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Failing tests all windows fail because the double click on the Cookies
item in the application panel doesn't work. One reason could be that the
item is clicked before it has any children. This CL explicitly waits for
the children marker to appear before attemptying to click.
Bug: chromium:1186150
Change-Id: Idafd9c6d669ab554fa352168bf64f4204c8c9a68
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2760240
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
This CL takes care of rendering a placeholder for the document resource
of an iframe which has been written to via JS's 'document.write()'.
The backend considers the document containing the 'document.write()'
call as the document of the frame being written to. Since this could
confuse users, instead of showing this document or showing no document
at all, this CL renders a placeholder "Document not available" resource,
which explains the situation to the user.
Bug: 1107766
Change-Id: Ie982b85ae89ccc8d8a95790fd1b9e002639859fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2643513
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
This CL adds SW update cycle timeline to the Service Workers
view, Application pane. See the explainers below for
requirements.
A summary of features implemented:
- For the service worker associated with the current target, for
every version still alive (including redundant ones), show a
timeline of the install, wait, or activate events.
- The timeline is a waterfall style, different than in the explainer
but similar to that in network timing.
- Such a timeline is based on the observation in the frontend and
is intended to show for example, if an event takes extra long
time in waiting. It is not meant to be a measurement of execution
time of the event handler at the backend.
- Each event's timeline may be expanded to reveal details of
the event handler, such as the starting and ending time of
the event handling.
- Other details in the explainer are not included.
Timeline for an active sw.
https://imgur.com/o2OHnYq
Timeline for one active and one redundant sw. Note the bar is ultra thin
https://imgur.com/4VBKrH5
Bug:1066604
Explainer:
https://docs.google.com/document/d/1M2xKrlFHrojGHIJ9AVpQdGrmUUU0G8YVToa3kZz3RZA/edit?usp=sharing
Change-Id: I0b3725b342eeb32470ef759bab8a7da5a350dba9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2409192
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Brian Cui <brcui@microsoft.com>
Even though writing to a frame's document via JS is not considered a
navigation by the backend, it can change the information DevTools is
showing about a frame in the frame tree. We are adding a new CDP event
'Page.documentOpen' in the backend, which in the frontend triggers
the same cascade a frame navigation would. This ensures that
ResourceTreeFrame and therefore the frame tree is kept up to date.
Design Doc:
http://docs/document/d/1l-XzjFMdASjRzX4-vMxOoK-MXoxY5uhCe0GNfDsXeDo
Backend CL: https://crrev.com/c/2498482
DISABLE_THIRD_PARTY_CHECK=depedency
Bug: chromium:1140540, chromium:1140481
Change-Id: Ieb72c3ef0830aff19964310b1728d218d6da9943
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2519702
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
This CL introduces the infrastructure and first test for what we're calling
"Interaction tests". These are tests that can be used to test component
behaviour that cannot be tested via Karma unit tests but don't require an e2e
test either.
The best example here is complex user interactions: clicking and dragging a
mouse, or doing multiple tabs to navigate through the UI.
Note that the one interaction test added here for theme_colors isn't the best
example of a complex test, but it's a test that's good enough for now whilst we
get everything set up on infrastructure and make sure it runs without flaking.
Bug: 1153281
Change-Id: Ifb37639a557c459974f703b8954ae68a93d5d368
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566808
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
This cl changes the default behaviour of removing all cookies that are
somehow related to the current page when clicking the "Clear site data"
button in the Storage tab of the Application panel. This lead to people
unexpectedly removing their session cookies on third party websites like
Google or Facebook when resources from them were included in the page.
To go back to the previous behaviour, this cl adds a checkbox next to
the button to also clear 3rd party cookies.
Screenshot: https://imgur.com/a/2PCz2gi
Bug:chromium:1012337
Change-Id: I171a6e3e07d56d5cbeafb0b2b030e3a5e24aad3b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2537954
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Jack Franklin
