Commit Graph
9 Commits
Author SHA1 Message Date
Simon Zünd a52ed495f4 [e2e] Extract error reporting and stdout/stderr handling
This CL extracts some functions from hook.ts that are related to
stdout/stderr and general exception handling.

The most important goal of the refactoring is that we can re-use the
logic for more than one DevTools frontend puppeteer.Pages.

R=jacktfranklin@chromium.org

Bug: 1297458
Change-Id: I7a0272e3618e22bc600a358e34fb8696f569bc7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3461559
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2022-02-16 07:31:02 +00:00
Alex Rudenko 7598323d8d Enable flaky assertion tests
Fixed: 1145969
Change-Id: Ibbe9032f31eebf43aefd409ddc3fa5cb0db0f8c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2727707
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2021-03-02 15:54:17 +00:00
Eric Leese c569330690 Disable flaky security and assertion tests
Bug: 1183304, 1183321
Change-Id: Iaaca79c620fe263fd6422ac1cc852a9e3f5b8111
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2727394
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
2021-03-01 17:50:24 +00:00
Alex Rudenko afa17b48cf Disable flaky e2e tests
Bug: 1178496, 1178497, 1145969
Change-Id: I5fab85bfbabb3073f99824242183668875a38d87
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2695571
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2021-02-15 15:23:00 +00:00
Yang Guo fa36737aeb Fix assertions in assertion_test
R=wolfi@chromium.org

Bug: 1145969
Change-Id: Ic9ae39907161c4d26c975beb96592fc785da5d17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2529363
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2020-11-10 18:12:28 +00:00
Wolfgang Beyer e8b471ea65 Disable flaky console.error assertion test
This is a revival of https://crrev.com/c/2520821 because we are still
seeing the same build failures.

Bug: 1145969
Change-Id: I999682502dbda10c515c6339078a43c8b1ce7dcd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2529349
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2020-11-10 17:11:58 +00:00
Yang Guo ff6d2bb252 Add stack trace for assertion failures in e2e tests
R=aerotwist@chromium.org

Bug: 1132333
Change-Id: Ie196a1a3f6d31570702bac10c0938459e6c12079
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2521917
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-11-06 11:19:22 +00:00
Yang Guo bd744c4303 Introduce allow list for expected assertion failures
R=aerotwist@chromium.org

Bug: 1145969
Change-Id: I1ada0d5a4daa74c5c63c85f5ebdcd9e194c548dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2521915
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2020-11-06 10:02:22 +00:00
Yang Guo e41c35aae5 Consider console.{assert, error, exception} messages e2e test failures
R=aerotwist@chromium.org

Bug:chromium:1132333
Change-Id: I2c5046430eec006bbd950df7aebaa6ee26b98969
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431514
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-09-29 15:28:58 +00:00