zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 04:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
3 Commits
Author SHA1 Message Date
Benedikt Meurer 277ee38b07 [console] Include column numbers in formatted errors. 
In particular for minified JavaScript, having easy access to the column
number is crucial for debugging, and V8 already provides the column
information for errors, we just removed it so far when we pretty printed
the error stack.

Before: https://imgur.com/Y6uDiUy.png
After: https://imgur.com/0BWpQUD.png
Fixed: chromium:1073064
Change-Id: I3e26115ed129139f6e57eb07fda179d495cc848a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234177
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-10-20 11:23:04 +00:00
Benedikt Meurer aef3b59541 [console] Correctly symbolize stack traces with async frames. 
This is a pragmatic fix for the issue. It adds an E2E test to
specifically test for the relevant case. We clearly need to refactor
this logic in the future.

Fixed: chromium:1189091
Change-Id: I9f2a4937bb49435137568fcf7a634b36f61fa033
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2767267
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2021-03-17 17:01:26 +00:00
Sigurd Schneider 8d0fe54ba6 Apply source maps to all outputs that look like an Error stack 
Previously, we'd only try to apply source maps to the following
error names:
  EvalError, ReferenceError, SyntaxError,
  TypeError, RangeError, Error, URIError

This CL applies it to everything ending in Error. This is a
developer pain point, and we're landing this band-aid until
we have a way to report structured stack traces from V8.

Bug: b/173826328
Change-Id: Ie6a0465c64ab3b442ac5359517e800dcacb88cb0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2766902
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2021-03-17 13:49:37 +00:00