zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-06 20:11:38 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
79 Commits
Author SHA1 Message Date
Jack Franklin e839c0cf22 Enable long import wrapping for JS imports 
DISABLE_THIRD_PARTY_CHECK=big clang format run against all files in
front_end and test/

Bug: 1319340
Change-Id: I1fff63cb07544ccd0e3059fc901f9a48ff4af13b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3598879
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-03 10:22:12 +00:00
Ari Chivukula a68cb30948 [i18n DevTool Deprecation Issue] (16) Cleanup Deprecations {DEVTOOLS} 
At long last, we can remove the old unused fields now that no
deprecation messages are untranslated.

This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Add milestone and status links
(7) Document milestone and status links
(8) Migrate DeprecationInfo::WithDetails {CHROMIUM}
(9) Roll deps
(10) Migrate DeprecationInfo::WithDetails {DEVTOOLS}
(11) Document changes in development process
(12) Migrate DeprecationInfo::* {CHROMIUM}
(13) Roll deps
(14) Migrate DeprecationInfo::* {DEVTOOLS}
(15) Cleanup Deprecations {CHROMIUM}
(16) Cleanup Deprecations {DEVTOOLS}
(17) Final documentation tweaks

DISABLE_THIRD_PARTY_CHECK=Fields are being removed, so we have to touch non-gen code

Bug: 1264960
Change-Id: If5a286a50cafc073ff99f5e0d8f3d38d5e8ba83a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3613607
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
 2022-04-28 11:45:32 +00:00
Benedikt Meurer 20fac7a3bc [e2e] Re-enable issues-link test. 
The back-end functionality was brought back, but the test was forgotten.

Bug: chromium:1241860
Change-Id: Iccbabcb6cadac4aac851d0e752362d617d797556
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3596241
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2022-04-20 12:54:35 +00:00
Juba Borgohain 74d821da11 Show issue when cookie attribute exceeds max size 
These changes trigger a DevTools issue warning that a cookie
attribute exceeds the max size. It also includes the approved
description.

Bug: 1254192
Change-Id: I259574a31901d3c35b05f658145490374e4e7daf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3503133
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Juba Borgohain <juba@chromium.org>
 2022-04-06 12:07:35 +00:00
Ari Chivukula 32461347cb [i18n DevTool Deprecation Issue] (4) Translate demo Issue {DEVTOOLS} 
This CL adds support for translated issues in devtools_frontend.
The next step is to document (5) and start translating issues (6).

This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Translate more Issues ...

Bug: 1264960
Change-Id: I5813a3b6ff5649dc78144a0f92f20480fa069634
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3561186
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-03-31 17:02:40 +00:00
Ari Chivukula cb7ada2da5 [i18n DevTool Deprecation Issue] (2) Translate issue title 
This CL starts the process of translating the deprecation issue message
by focusing on the title first. I noticed the markdown files aren't
auto-translated so this step seems necessary.

This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Translate more Issues ...

Bug: 1264960
Change-Id: Ie6548e441f88931c1930e8d2864db7513b7b196f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3533216
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-03-21 06:59:00 +00:00
Ari Chivukula 8ad687341f [Client Hint Issue] (3) Implement devtools issue {DEVTOOLS} 
Now that third-party delegation via markup for client hints is in M99,
we need to start alerting developers where they use unsupported
features. These features will be expanded and extended as more client
hint features launch.
https://docs.google.com/document/d/1lDEvj8tMeuvUs1HTTqL-44YiI-7ljeQkusM_WhUfIeE/edit

This CL is a part of a series:
(1) Implement devtools issue {CHROMIUM}
(2) Update devtools protocol {DEVTOOLS}
(3) Implement devtools issue {DEVTOOLS}

Bug: 1219359
Change-Id: Ia8aaf05b98894fd32f5aad8f973fcdf774e1634c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3343149
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Rowan Merewood <merewood@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
 2021-12-16 12:12:18 +00:00
Wolfgang Beyer 0dc36933e4 Allow links from deprecation issues 
This allows all links going to `www.chromestatus/feature/xxx` to be
displayed in Issue descriptions. In addition several other links found
in deprecation issues[1] are whitelisted as well.

The test for SAB issues needed to be updated, because there are now 2
issues showing up. Previously the deprecation issue was not shown due
to causing an error when rendering it.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/deprecation.cc?q=deprecation.cc

Fixed: 1275681
Change-Id: I9f175ff1d65b97f486005aebc89c94005f87376b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3320451
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-12-09 09:43:36 +00:00
Wolfgang Beyer dc4a43902d Add issue for CorsError.InvalidResponse 
Backend CL: https://crrev.com/c/3320301
Screenshot: https://i.imgur.com/84j7bnK.png

Bug: 1272445
Change-Id: I91dd86cc650a3d34ec7a3dcf57cf2f1032b544f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3323172
Reviewed-by: Titouan Rigoudy <titouan@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-12-08 16:52:34 +00:00
Wolfgang Beyer afed9f7b21 Add issues for Private Network Access preflight requests 
Screenshot: https://i.imgur.com/UoaIEGM.png

Bug: 1272445
Change-Id: I23eaa0a1d7ccbbbbfca55386a77e666fdfd53e51
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3307444
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Titouan Rigoudy <titouan@chromium.org>
 2021-12-03 09:13:18 +00:00
Kateryna Prokopenko 93f315e66d Improve accessibility of hide issues 3 dot menu 
Change menu icon color to have proper contrast with background,
highlight icon on hover. Show icon on issue hover and when the hide
issues context menu is expanded, otherwise do not display it.

Bug: 1254681
Change-Id: Ibc2741e97fd79d3fac058ae4100832ba113d4489
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259544
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-05 12:45:50 +00:00
Ari Chivukula 86d4791e9d [Deprecation Console->Issue] (8) Implement Deprecation Issue (DevTools) 
This implements the deprecation protocol code per:
https://docs.google.com/document/d/1gU2caqBEek2x8AeKop9SrSxqlO51ipealPMV4aisQNE/edit
https://docs.google.com/document/d/1Jot9P30LFW9TQtc6eaQP9wRBwjLpUn-hIaxRJRUBFvI/edit

This is a part of a set of CLs:
(1) Remove legacy CSS Deprecation path
(2) Consolidate DeprecationInfo
(3) Streamline redundant Deprecation messages
(4) Add features for console/issue deprecation
(5) Fix feature status detail link
(6) Implement Deprecation Issue (Chromium)
(7) Move DeprecationIssue.ts code
(8) Implement Deprecation Issue (DevTools)
(9) Disable Console Deprecation
(10) Remove Console Deprecation

Bug: 1248484
Change-Id: I59b2ce66dfaea82bf38bf36dc905f9ab13172a21
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3258023
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-03 17:29:27 +00:00
Wolfgang Beyer 34b53dccd5 Unflake e2e-tests 
Drive-by: remove enabling of experiment which is already enabled by
default

Bug: 1175722
Change-Id: I9014ee89aa92ac6bcfc4d47e8557efb54011bbf2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3211727
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-10-07 12:26:49 +00:00
Wolfgang Beyer fc18f8af80 Temporarily skip flaky tests 
Bug: 1175722
Change-Id: I1aef0baf0d3122a7f0694c32930659c881f2d297
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3211726
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-10-07 08:55:59 +00:00
Wolfgang Beyer b0505f2dab Added HideIssuesMenu to group by kind row headers 
This cl includes logic which allows users to hide issues that are currently grouped by kind.

Bug:1175722
Change-Id: Ia367918b11a0d107d0f99578b37e37b6289d7885
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3102246
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-10-07 06:34:49 +00:00
Wolfgang Beyer 145e077027 Group Issues in the issues panel by IssueKind 
This cl includes logic which allows users to toggle grouping issues by issue kinds.

Screenshot: https://drive.google.com/file/d/1-blXNVQT185XJSnx4Tkq8CLj9jFvpc6X/view?usp=sharing

Bug:1175722
Change-Id: Ic6e0bc664f548b3f594df5fa79a5ec0f1455fd79
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3099005
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-10-05 14:19:33 +00:00
Kateryna Prokopenko 7a84f0f42f Add view for GenericIssue 
Bug: 1246855
Change-Id: I908eebfe1cadaa9fde7984262d89cfa7c51e43e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3190271
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2021-10-05 07:18:55 +00:00
Wolfgang Beyer fed6a88ba4 Unhiding issues button: Replace icon button with text button 
Bug:1175722
Change-Id: I35b41c6296f80173e2c18702cf15a7e66bc2badc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3178869
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-09-24 10:35:53 +00:00
Simon Zünd 2084e90955 Skip e2etest that is blocking the Chromium roll 
The "link to issue from console" test relies on exception metadata,
which was reverted.

R=pfaffe@chromium.org

Bug: 1241860
Change-Id: Id124759c58bdab1f35b6ac67e42112b6e7b73195
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3161981
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2021-09-15 09:34:47 +00:00
Johan Bay 91a583c15a Skip test for cross-origin wasm sharing issue 
Bug: 1247980
Change-Id: Iba3a9d6924ed1d081b95a852d519243802f04889
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3150285
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
 2021-09-09 10:15:08 +00:00
Sigurd Schneider 20e1748d7d Add e2e test for issue caching 
Bug: chromium:1240622
Change-Id: I0dcb417a32859b15351a7c5510766a3e6309c900
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3138092
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-09-03 10:54:27 +00:00
Rahat Muneeb bac6ae33b7 Caching Hidden Issue Views in the IssuePane 
Bug:1175722
Change-Id: I0e63cd46a63af18b58e3a95c39601618f9f60430
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093148
Commit-Queue: Rahat Muneeb <irahatmuneeb@gmail.com>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-08-16 14:17:23 +00:00
Rahat Muneeb fa08487c25 Moved Unhide all issues button from issues pane toolbar to hidden issues row header 
Bug:1175722
Change-Id: I7f9a3ce43b405689600f34e15b4267a626065e50
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093146
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-08-13 17:30:48 +00:00
Rahat Muneeb adc1e1a010 Unhide-issues in the Hidden Issues Row. 
This cl introduces the Hidden Issues Row and gives users the ability to unhide issues by IssueCode

Screenshot: https://drive.google.com/file/d/1PWIouPeSc_CqFO8vj98qspsfEGzlVd3E/view?usp=sharing

Bug:1175722
Change-Id: Ic188a091e596175981e24db280d91dc2078b47a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3085194
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-12 14:56:23 +00:00
Rahat Muneeb a0f7f48f0c IssueView reparent on parent change. 
This cl includes logic to reparent IssueViews into parents depending upon existing grouping without having to reinstantiate new IssueViews

Bug:1175722
Change-Id: I64e00b59990a996aa2ef40193e340d061eb15b0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3087357
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-11 13:19:55 +00:00
Rahat Muneeb 0200fc96fe Hide issues in the Issues panel 
This feature allows users to hide issues in the issues panel

Bug:1175722
Change-Id: I5d1b40be670635b2242f1619a18cc3d4d6e92008
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2985466
Commit-Queue: Rahat Muneeb <irahatmuneeb@gmail.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-07-30 12:42:56 +00:00
Sigurd Schneider f795223ccf Add test for issue links 
Bug: chromium:1213393
Change-Id: Ide3de6e612d3d8ba93b08ef70e5f594752864486
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3062564
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-07-30 10:42:36 +00:00
Wolfgang Beyer be0727c813 Turn assertNotNull() into assertNotNullOrUndefined() for e2e tests 
`assertNotNull()` of `undefined` does not cause the test to fail,
whereas `assertNotNullOrUndefined()` does.

Because of import restrictions, platform.js's
`assertNotNullOrUndefined()` is copied to helper.ts.

Bug: 1072335
Change-Id: Iaa56492c2f58f735cb93b434f6a73c65cdb740c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3057046
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-07-30 08:50:56 +00:00
Sigurd Schneider 9b0b7261b6 Update link to Wasm module sharing deprecation 
The article was published today, this updates the link.

Bug: chromium:1224881
Change-Id: I951ded7196d69b449253256fcacc4205b7cff6b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3059608
Reviewed-by: Lutz Vahl <vahl@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-07-29 11:24:16 +00:00
Sigurd Schneider 5a9892c359 Add issue for cross-origin shared Wasm modules 
Bug: chromium:1224881
Change-Id: Iebc6cc281609594dfa5da5fa9e1c56d7e79d4763
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003261
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-07-06 12:31:10 +00:00
Sigurd Schneider 5b85fc51fe Use await pattern in TWA issue e2etests 
Bug: chromium:1223300
Change-Id: I90a099ced835619fc94054eb03f6c0a26da35790
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987967
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-28 08:09:10 +00:00
Sigurd Schneider 20ec8a5f2d Use await pattern in sab issue e2etest 
Bug: chromium:1223300
Change-Id: I6c7793aa3d9891e5dc1dcb08010cc1b78ca7006f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987966
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-28 07:45:50 +00:00
Sigurd Schneider 6e7618301a Use await pattern in quirks mode e2etests 
Bug: chromium:1223300
Change-Id: I08e7bae7250c0d9d6bea4babd00c7167a8997cc0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987965
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-28 07:10:30 +00:00
Sigurd Schneider 77d9eb1c72 Await resouce section in navigator-user-agent-issues e2etest 
Bug: chromium:1223300
Change-Id: Ia6c738d0fa318b36aeeaed5302f7fca825de5746
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987964
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-28 06:41:30 +00:00
Sigurd Schneider 9028e9a9ca Await resource section in low text contrast tests 
Bug: chromium:1223300
Change-Id: Ia12aa07e859f91ac5d73ef99ca185de1a31f6b91
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2983023
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-25 11:58:16 +00:00
Sigurd Schneider 375ca3a602 Await resource section in heavy ads issue test 
Bug: chromium:1223300
Change-Id: Ia762f2073e986f5e5f3cf4fddf98a1f6aa2bb597
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2983022
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-24 09:02:47 +00:00
Sigurd Schneider 72dd75dc6c Await resource table in issue tests 
This refactors some of the issue tests to await the table contents
instead of just checking it. This refactoring allows to test content
that may change dynamically, e.g. when new information becomes available
such as a network request.

Bug: chromium:1223300
Change-Id: Iadced03ffbec6c23f521093168c7dcab82edc424
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2983020
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-24 08:41:47 +00:00
Sigurd Schneider 76cb0e9d20 Refactor matching helpers to support tables 
Bug: chromium:1223300
Change-Id: Ifb464b5c7bc3c068e71ccc0f71cf995b3103bfb2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2983019
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-24 08:07:48 +00:00
Sigurd Schneider 9dfafb3241 Add issue for usage of user agent in JS 
This adds an issue about the usage of navigator.userAgent (and friends)
to the issues tab. This issue will be triggered on a lot of pages,
but since the change is risky, discussion revealed that this was a
good way of making people aware of the change.

Bug: chromium:1210842
Change-Id: Ib9912d33bf9391772488da1e00fb7760931aee0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905504
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Mike Taylor <miketaylr@chromium.org>
 2021-05-19 14:22:24 +00:00
Changhao Han b47c101bea Fix Array#sort comparison in Quirks Mode issue test 
Bug: chromium:622660
Change-Id: Ie857b1b2285075934c27ae81e89b187b6a734525
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905500
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-05-19 10:34:52 +00:00
Sigurd Schneider afd7a79f29 Fix ordering issue in test/e2e/issues/quirks-mode-issues_test.ts 
The order in which quirks mode issues arrive for iframes is not
determined; add sorting to the test to accept either order.

Bug: chromium:622660
Change-Id: Ic2d3bb50af543fd853b681eb2956d1cd1ddca93a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905496
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2021-05-19 09:35:32 +00:00
Changhao Han 79d5f4274f Add QuirksMode issue to the Issues tab 
Design doc: https://docs.google.com/document/d/13JFp5igs0yNr7CT6Nu-qGoFMbtbrrH5UcCyrH-JwvcY/edit

Screenshot: https://imgur.com/a/p4OWNX9

Backend CL: https://crrev.com/c/2875213

Bug: chromium:622660
Change-Id: I137fd4cf25a767b1dfbda4fa0148b4dc99997d24
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2878731
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-05-17 10:09:22 +00:00
Sigurd Schneider 3aa8ba4983 Add issues for CORS redirect mode problems 
This CL adds issues for the CORS error codes

NoCorsRedirectModeNotFollow

Screenshot: https://imgur.com/a/ZfaMTu6

Bug: chromium:1141824
Change-Id: I0fe496219bfc4b43414d21d1eed48022464203c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897287
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-05-17 09:57:22 +00:00
Sigurd Schneider eeb3765890 Add issues for CORS disabled scheme problems 
This CL adds issues for the CORS error codes

CorsDisabledScheme

Screenshot: https://imgur.com/a/3nVmUn6

Bug: chromium:1141824
Change-Id: I29f085e660ba6985b028cbc52e9460857525da52
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897284
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-05-17 08:54:02 +00:00
Sigurd Schneider 0404498fbf Add issues for CORS same-origin problems 
This CL adds issues for the CORS error codes

DisallowedByMode

Screenshot: https://imgur.com/a/XBVhWCs

Bug: chromium:1141824
Change-Id: If2292961beaba23e18b41b580c2d20f453b5faf3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897282
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-05-17 08:41:32 +00:00
Sigurd Schneider d460aae69d Simplify CORS e2e test logic 
Bug: chromium:1141824
Change-Id: I68a1720874cf660adfad11683248486a4b7b3932
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897281
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-05-14 14:34:40 +00:00
Jack Franklin a75ae7cbb3 Enforce import type when importing TS types. 
Bug: none
Change-Id: I02ef1182143b7fe091ce92d59f04ac2188903e0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2886925
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-05-11 14:00:22 +00:00
Wolfgang Beyer 40834929d4 [l10n] Simplify pluralisation for issues' affected resources 
Bug: 1183249, 1189877
Change-Id: Icbb77c1bc3d294ff2bb0da9f077377fd138c6499
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2882759
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-05-10 13:17:42 +00:00
Sigurd Schneider c86b89fe67 Wait for CSP violations tab to update 
Bug: chromium:1205766
Change-Id: I896ff541308437d4ee927dd33aec81ecc2939235
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2874129
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-05-05 09:16:46 +00:00
Sigurd Schneider 9149c7abd5 Add issue for private network request (preflights) 
This CL adds an issue indicating that private network requests are going
to require a preflight request in the future.

Bug: chromium:1141824
Change-Id: I7e63872b7612f5a2b6e483a508704f73287c8977
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2848228
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Lutz Vahl <vahl@chromium.org>
 2021-04-27 12:00:41 +00:00