Commit Graph
2 Commits
Author SHA1 Message Date
Andres Olivares 13a0de6f16 Always reveal Sources panel with quick open menu
With crrev.com/c/2960171 the sources panel was set to be opened when a
breakpoint was hit only if an experiment was enabled. However this
behaviour was extended to other triggers of the sources panel, like when
a file is selected using the quick open menu. This means that using the
quick open menu to open a file in the sources panel would only work if
the experiment discussed before is enabled.

To fix this, the check for the experiment value was moved to the call
sites triggered specifically after a Debugger.paused event

Bug: none
Change-Id: I9eb53091b04e63627813e14a8ed6bc6605e92b3b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3271700
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
2021-11-11 12:16:44 +00:00
Andres Olivares 0fea598ca7 Adds e2e test for Quick Open file list
It tests that the available files are listed when the file quick-open is
opened.

Bug: 1195352
Change-Id: I4b96a1443c963d8f06f247ccf7c01d9f41fdfa25
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2807964
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-04-07 14:45:19 +00:00