Commit Graph
3 Commits
Author SHA1 Message Date
chait pinnamaneni 6bc1c12883 Service worker button to show network panel in drawer.
Original PR: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841

Original PR has been reverted because of failing e2e test, fixed faulty e2e test

Bug: 1137050
Change-Id: I7612eedd8a92b5671d365865139ae61f333c9a00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2506129
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
2020-10-30 18:02:09 +00:00
Simon Zünd 6801ec8c55 Revert "Service worker button to show network panel in drawer."
This reverts commit e1374b563d.

Reason for revert: e2e tests introduced in this CL fail consistently
on the Mac Bot. First fail: https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Mac/1562

Original change's description:
> Service worker button to show network panel in drawer.
>
> Explainer for this feature is https://docs.google.com/document/d/14qJ1rZyMtnIa8hPJc1V8DJRxk4lVI3hlWYGvBDICog0/edit?ts=5f7c13ce
>
> Button to show network panel in drawer
> https://i.imgur.com/vnStScF.png
>
> Network panel in drawer
> https://i.imgur.com/3SmdLFK.png
>
> Closing the drawer will move it back to main tabs unless user moved it to bottom.
>
> Change-Id: I7af563869304da912bf10a85376835b9b8e0417a
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841
> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Changhao Han <changhaohan@chromium.org>
> Reviewed-by: Songtao Xia <soxia@microsoft.com>

TBR=petermarshall@chromium.org,bmeurer@chromium.org,aerotwist@chromium.org,joselea@microsoft.com,changhaohan@chromium.org,soxia@microsoft.com,cpinnamaneni@microsoft.com

Change-Id: I76dfebe2d2baeb264e39e220c3e23cf4ef6922c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2505129
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2020-10-28 07:34:30 +00:00
chait pinnamaneni e1374b563d Service worker button to show network panel in drawer.
Explainer for this feature is https://docs.google.com/document/d/14qJ1rZyMtnIa8hPJc1V8DJRxk4lVI3hlWYGvBDICog0/edit?ts=5f7c13ce

Button to show network panel in drawer
https://i.imgur.com/vnStScF.png

Network panel in drawer
https://i.imgur.com/3SmdLFK.png

Closing the drawer will move it back to main tabs unless user moved it to bottom.

Change-Id: I7af563869304da912bf10a85376835b9b8e0417a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Songtao Xia <soxia@microsoft.com>
2020-10-27 17:19:47 +00:00