zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 04:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
24 Commits
Author SHA1 Message Date
Wolfgang Beyer c4b6220179 Un-flake issues-toolbar e2e tests 
Fixed: 1317582
Change-Id: I78c4f04c9304137c7a2707ca8e30483a3d5d1e40
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3602505
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2022-04-25 05:39:36 +00:00
Yang Guo 94734947c4 Implement intuitive filter for console groups 
Until now, console group titles were always shown despite filter.

Now, a console message is shown if:
 - its message content matches the filter
 - the title of the group (or parent group, grand-parent group, etc.
   matches the filter.

If a console message is shown, then the group it belongs to
(including parent group, grand-parent group, etc.) are also shown.


Fixed: 1068788
Change-Id: I04f280b185d183bd9992b9b65ef9a9d20da0a36f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3364094
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2022-01-03 15:38:16 +00:00
Danil Somsikov 82873eeb1c Add option to hide CORS errors in console 
Bug: 1251176
Change-Id: I321fc4864bbbb15bfd7ad46e5a1a7f7d066a0ebf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3175286
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-09-30 10:51:17 +00:00
Tim van der Lippe 72f2d4bcc8 Add e2e-tests for focus interactions of console messages 
This replaces http/tests/devtools/console/viewport-testing/console-key-navigation.js
as an e2e-test.

R=aerotwist@chromium.org

Bug: 1203169
Change-Id: I461f742e84f13e44eecc74553ced77b5041d3340
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3010115
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-07-07 10:23:47 +00:00
Sigurd Schneider a38d50d7d2 Ensure we're not hitting quirks mode in some e2e tests 
Bug: chromium:1072335
Change-Id: I234d2ed0b23c8f55c2c6972a5751f0efa632f33b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897289
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-05-14 16:13:50 +00:00
Sigurd Schneider 2094d2ea25 Re-enable SAB-related UMA test 
Drive-by: Deduplicate 4 copies of empty.html

Bug: chromium:1196618
Change-Id: I582ad73ec2b67a507e3ad1cdd7926def55fff5ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831433
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-04-16 10:15:25 +00:00
Benedikt Meurer aef3b59541 [console] Correctly symbolize stack traces with async frames. 
This is a pragmatic fix for the issue. It adds an E2E test to
specifically test for the relevant case. We clearly need to refactor
this logic in the future.

Fixed: chromium:1189091
Change-Id: I9f2a4937bb49435137568fcf7a634b36f61fa033
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2767267
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2021-03-17 17:01:26 +00:00
Wolfgang Beyer 681ae6ae81 Hide ignore-listed sources in stack traces 
We do not want source locations which are on the ignore-list to show up
in stack traces. Ignore-listed stack frames should only be shown after
clicking a 'show more' link.

This behaviour was broken, most likely since the introduction of async
live source locations.

This CL fixes the behaviour by updating the stack traces after the
LiveLocations have been updated.

Screenshots:
(before clicking 'show more') https://i.imgur.com/Gzrv5uw.png
(after clicking 'show more') https://i.imgur.com/DVj7EJ2.png

Bug: 1183325
Change-Id: I2fea963acbed6c6f18ea2426fd3a60960158b18d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2727495
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-03-09 13:04:55 +00:00
Sigurd Schneider 71c7ce1f25 Show issue count in console status bar instead of as console message 
Design-doc: https://docs.google.com/document/d/17URPPpxSqSawyKKFpLfj_Tgo_fcop94rCmD9Lr3KnDI/edit
Bug: chromium:1140516
Change-Id: I0cf0e4c99824a82bf60907beb768b96290087a2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2659020
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-12 11:56:22 +00:00
Eric Leese b1b9bce6c9 Compare script ids when comparing console messages 
This will support collapsing multiple messages when we don't have
the url as an identifier.

Bug: 1132260
Change-Id: Id5d69fef5ec21d0ec8d2282202bbec802d1cdbf2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2614978
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2021-01-08 11:07:37 +00:00
Peter Marshall 5763061db1 Reland "Don't bypass CSP restrictions on eval from the console" 
This is a reland of f6f9f51fd5

Forgot to copy the .html resource to the gen dir.

Original change's description:
> Don't bypass CSP restrictions on eval from the console
>
> Previously the console would allow evals even when the target page
> blocked evals via Content Security Policy. This made it hard to debug
> CSP-related issues on the page because users couldn't reproduce CSP
> eval errors in the console.
>
> Use the new flag to Runtime.evaluate() that will cause CSP failures
> for eval from the console, if CSP on the page prevents unsafe eval.
>
> Add a test.
>
> Bug: chromium:1084558
> Change-Id: I916f36a2c02fbc1843de50851b72b54d2a3a7b8c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2253904
> Commit-Queue: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

Bug: chromium:1084558
Change-Id: I6c5342240963f4283552caaeaf336f9bdaa55af3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2256988
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-07-10 09:27:38 +00:00
Tim van der Lippe ea5df6afa1 Move copy_to_gen into build/ninja 
Also rename it to `copy.gni`, since I will be adding a separate
`copy_to_resources` template that copies the content to
`resources/inspector/`.

R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1098730
Change-Id: If4266a9f701ac591614125442b4986d4fe38aafe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2278476
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-07-06 15:59:51 +00:00
Kim-Anh Tran 79644085c5 Port console filter tests 
Bug: chromium:1099603
Change-Id: I8947c1a94d77eab8b3af1047f0b4fa4c4a35b405
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2270229
Reviewed-by: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2020-07-03 11:59:08 +00:00
Tim van der Lippe 080e864790 Revert "Don't bypass CSP restrictions on eval from the console" 
This reverts commit f6f9f51fd5.

Reason for revert: https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8876785684094997456/+/steps/E2E_tests/0/stdout

1) The Console Tab
       eval in console fails for pages with CSP that blocks eval:
     AssertionError: Didn't find expected CSP error message: expected '2' to include '\'unsafe-eval\' is not an allowed source of script'
      at Context.<anonymous> (out\Release\gen\test\e2e\console\console-eval-blocked-by-CSP_test.js:47:23)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:94:5)

Original change's description:
> Don't bypass CSP restrictions on eval from the console
> 
> Previously the console would allow evals even when the target page
> blocked evals via Content Security Policy. This made it hard to debug
> CSP-related issues on the page because users couldn't reproduce CSP
> eval errors in the console.
> 
> Use the new flag to Runtime.evaluate() that will cause CSP failures
> for eval from the console, if CSP on the page prevents unsafe eval.
> 
> Add a test.
> 
> Bug: chromium:1084558
> Change-Id: I916f36a2c02fbc1843de50851b72b54d2a3a7b8c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2253904
> Commit-Queue: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

TBR=petermarshall@chromium.org,szuend@chromium.org

Change-Id: I59d3db7e9f0f1758c29e0edb67dce5ef92c4a735
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1084558
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2256986
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-06-22 14:15:55 +00:00
Peter Marshall f6f9f51fd5 Don't bypass CSP restrictions on eval from the console 
Previously the console would allow evals even when the target page
blocked evals via Content Security Policy. This made it hard to debug
CSP-related issues on the page because users couldn't reproduce CSP
eval errors in the console.

Use the new flag to Runtime.evaluate() that will cause CSP failures
for eval from the console, if CSP on the page prevents unsafe eval.

Add a test.

Bug: chromium:1084558
Change-Id: I916f36a2c02fbc1843de50851b72b54d2a3a7b8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2253904
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-06-22 14:05:03 +00:00
Tim van der Lippe bc913faa45 Copy all e2e-resources to gen/ 
R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1088463
Change-Id: I7f9f43879a36d760afbec05d5b9110730f2b46ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2224808
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-06-02 10:45:30 +00:00
Wolfgang Beyer 7accf14812 [issues] Fix behaviour of console toolbar linking to issues panel 
Toolbar now shows up even when DevTools are opened after page has
already loaded (no refresh necessary). Page navigation is handled
so that toolbar is displayed for pages with issues and hidden on
pages without issues.

Fixed: chromium:1077700
Change-Id: I9e917db0a12311f7700c4768ddeb5808610f84d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2178580
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-05-05 07:19:05 +00:00
Mathias Bynens 0a48503ad6 Simplify test resources 
Test resources should act as minimal repro cases: they should be as
small and simple as possible, without any unnecessary code that
distracts from what’s important.

This patch applies that thinking to the existing test resources, with
only a few exceptions for 1) descriptive <title>s and 2) the mandatory
license headers.

This came up during review of [1].

[1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107525

Change-Id: I1081bb06129d2b6ce98daf1349d20b2bf2fd9401
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2116445
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-03-24 12:55:22 +00:00
Paul Lewis e76848de18 [e2e] Adds licences; updates expectations 
The existing e2e test resources did not have a license header. This CL
updates them so they do, and updates the expectations against line
numbers etc to match.

Change-Id: I5d6ae76fbf748dcdeabfcedc236d1e067d27b1c2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084576
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-03-03 12:46:05 +00:00
Tim van der Lippe 3997764c7f Test that document.write console messages properly show up 
This replaces
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/resources/document-write.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63?originalUrl=https:%2F%2Fcs.chromium.org%2F
as an e2etest.

Bug: 1047671
Change-Id: I46026713f8191c8c7e2f9feb10d5f5f88905f43c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2039353
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-02-06 14:52:17 +00:00
Tim van der Lippe 2ab3956295 Add remaining console startup tests 
These tests verify error handling as well as frame navigations.

Bug: 1047671
Change-Id: Ic91c5db794b2628ce8235cd049970ff594adff1b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2038702
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-05 16:51:03 +00:00
Tim van der Lippe 6748861535 Add tests for various console.log interactions 
This replaces
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/console/resources/console-format-startup.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63?originalUrl=https:%2F%2Fcs.chromium.org%2F
as an e2etest.

Bug: 1047671
Change-Id: I277949f690f375c9d2a7f4b75908f5f70adcf0af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2037471
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-05 11:18:23 +00:00
Tim van der Lippe 00a610e676 Add console uncaught promises e2etest 
This replaces
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/console/resources/console-uncaught-promise-no-inspector.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63?originalUrl=https:%2F%2Fcs.chromium.org%2F
as an e2etest

Bug: 1047671
Change-Id: Ie24e4eab5f08fd5bf9bb2c390a3f9ef6ec600e9f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2035948
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-04 16:05:11 +00:00
Tim van der Lippe 58c5bcf4da Add console BigInt e2etest 
This replaces
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/console/resources/console-format-startup-bigint.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63?originalUrl=https:%2F%2Fcs.chromium.org%2F
as an e2etest

Bug: 1047671
Change-Id: I397fd817a18364c081e2f23b2d34bd1c267fecca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2035947
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-04 16:01:02 +00:00