Commit Graph
7 Commits
Author SHA1 Message Date
Mathias Bynens ba288cfa8d Clean up inspector overlay HTML
This patch simplifies the inspector overlay HTML and makes it more
consistent through minor changes like the following:

- drop redundant type="text/css" from <link rel="stylesheet">
- move <title> as early as possible (i.e. immediately after
  <meta charset="utf-8">)

Some HTML files used in e2e tests had the same patterns and were changed
accordingly.

Change-Id: Ib18657f6c919186e8d264ae1542427a61eb4c823
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2308537
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2020-07-21 08:58:02 +00:00
Tim van der Lippe ea5df6afa1 Move copy_to_gen into build/ninja
Also rename it to `copy.gni`, since I will be adding a separate
`copy_to_resources` template that copies the content to
`resources/inspector/`.

R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1098730
Change-Id: If4266a9f701ac591614125442b4986d4fe38aafe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2278476
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-07-06 15:59:51 +00:00
Patrick Brosset 60bf7bf331 DevTools: E2E test covering going from perf to sources
Simple test in the existing workflow_tests.ts file to make sure
this user flow works.
A similar CL was landed and then reverted before, as this test is just
a tad slow and will often timeout.
This new CL removes a single waitFor in the performance-helpers.ts file
in an attempt to make the test run a little faster.
It also increases the timeout for this test suite to 5s instead of 3s.
Indeed, moving from panel to panel takes time in DevTools and 3s was
just not enough for the test to pass every time.

Bug: 1079076
Change-Id: Ib6e31e943ccbddc9d82aea5da394c371499c1aab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2230774
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
2020-06-08 17:34:28 +00:00
Tim van der Lippe 3060e0de13 Revert "DevTools: E2E test covering going from perf to sources"
This reverts commit 5b66e1b439.

Reason for revert: https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8878435719671585216/+/steps/E2E_tests/0/stdout

Original change's description:
> DevTools: E2E test covering going from perf to sources
>
> Really simple test in the existing workflow_tests.ts file to make sure
> this user flow works.
>
> Bug: chromium:1079076
> Change-Id: Ic7bbef26840bab8482d2162a5202149629ca5802
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2213936
> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
> Reviewed-by: Jose Leal <joselea@microsoft.com>
> Reviewed-by: Jan Scheffler <janscheffler@chromium.org>

TBR=joselea@microsoft.com,tvanderlippe@chromium.org,janscheffler@chromium.org,patrick.brosset@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

No-Tree-Checks: true
Bug: chromium:1079076
Change-Id: Id96fde6d85527ddbdc1a57e2cd6387412d21284f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2230502
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-06-04 09:44:51 +00:00
Patrick Brosset 5b66e1b439 DevTools: E2E test covering going from perf to sources
Really simple test in the existing workflow_tests.ts file to make sure
this user flow works.

Bug: chromium:1079076
Change-Id: Ic7bbef26840bab8482d2162a5202149629ca5802
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2213936
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
2020-06-02 14:37:20 +00:00
Tim van der Lippe bc913faa45 Copy all e2e-resources to gen/
R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1088463
Change-Id: I7f9f43879a36d760afbec05d5b9110730f2b46ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2224808
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-06-02 10:45:30 +00:00
Jose Leal Chapa dd4d881300 End to end tests: Add cross tool integration tests
Bug: 1079076
Change-Id: I588fd64e5d724c1203db7b072ffc01739962941a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2186850
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jose Leal <joselea@microsoft.com>
2020-05-21 19:13:31 +00:00