This CL configures custom host resolver rules for the Chromium binary
that puppeteer is using to run e2e test.
With host resolver rules, all resources can now be loaded via
arbitrary '.test' domains while still being served from localhost.
E.g. an e2e test might navigate to 'devtools.test/foo.html' while
also including an iframe with Url 'bar.test/iframe.html', with both
files being served from localhost.
This unlocks testing for a whole class of features that was
previoulsy impossible to test.
This CL also adds a new helper 'goToResourceWithCustomHost', that
supplements the existing 'goToResource' with a modifiable host part.
R=aerotwist@chromium.org, sigurds@chromium.org
Bug: chromium:1177676
Change-Id: I1f51aa8419619e11352989457b24cc56cfc78e52
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692148
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
This CL add new metrics enums to allow measuring when an issue in the
issue panel is expanded and when a resource is opened.
The corresponding chromium CL is at https://crrev.com/c/2305018
Design doc: https://docs.google.com/document/d/1XfVyiQAe9sT9hj0EigQ2skmJP4gCrrnUJVLd-qpFk7A
There are two elements that we can't track the telemetry because
they are stopping the propagation of the event for "click" and
"keydown" if the key is the enter key.
I have open two issues to track them separately.
- Learn More link: https://crbug.com/1108501
- Source link: https://crbug.com/1108503
Summary:
This CL purpose is to answer the question "Which issues are
useful for developers?"
For that purpose this will track when an user expand an issue and
when a resource inside the issue is clicked.
Tracking this two things can help us to answer the previous
question. i.e: "if we see users clicking an issue
but *not* clicking on a resource, that may tell us
the issue needs to be changed or removed"
Bug: 1100658
Change-Id: I4a6f86f107dc710bc64edbf21670a4a3bd2a3d60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2303882
Commit-Queue: Jesus David Garcia Gomez <jegarc@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Wolfgang Beyer