While working on refactoring the color and var swatches recently, I had
to disable a few web tests in chromium.src.
Instead of fixing them and re-enabling them now, I'm taking this
opportunity to convert them to the appropriate unit or e2e tests in the
frontend (this helps reduce the dependency for frontend-only features on
chromium.src).
Here is the list of disabled web_tests and what I did for each:
1. third_party/blink/web_tests/http/tests/devtools/elements/styles-1/color-swatch.js
Converted to both new unit and e2e test cases for what wasn't already
covered.
2. third_party/blink/web_tests/http/tests/devtools/elements/styles/url-color-swatch.js
Added new e2e test cases for what wasn't already covered.
3. third_party/blink/web_tests/http/tests/devtools/elements/css-variables/color-swatch.js
Also added new e2e test cases to cover this.
3. third_party/blink/web_tests/http/tests/devtools/sources/color-swatch-position.js
This one is different as it tests editing CSS code in the Sources
panel. Because the current e2e helpers lack support for this, I will
fix and re-enable this web_test in chromium.src. It doesn't seem
worth it right now to create a bunch of new helpers just for the
color swatch. But we should do this too eventually.
Backend CL: https://chromium-review.googlesource.com/c/chromium/src/+/2507510/
Bug: 1137438
Change-Id: Ic260e460ba215dd9a317ae2843d927c2d1bace3d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2506954
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
The recently introduced CSSVarSwatch component was handling color-like
variables on its own, by displaying a color swatch when needed.
This color swatch did not support shift-click format changes, nor click
to change the color.
This change removes this handling and uses the new color swatch
component instead.
This way, click and shift-click on color swatches for CSS vars does work
as expected (even if it "computed" the value and therefore removes the
var link).
GIF: https://imgur.com/egBMRU6.gif
Bug: 1137438
Change-Id: Ie7b6cf31833b6c3e0b8b225da5f4bdf512876a17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2495208
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Michael Liao
