zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 04:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
33 Commits
Author SHA1 Message Date
Wolfgang Beyer ecdb1c9323 Add sandboxed FileSystem to hosted mode (enables using local overrides) 
Adding a sandboxed file system via `window.webkitRequestFileSystem` to
hosted mode enables using local overrides in hosted mode. Since e2e-
tests run in hosted mode, this enables adding e2e tests for local
overrides. This CL adds a first such e2e-test testing a simple response
header override.

Bug: 1313436
Change-Id: I6eb3e2ff9de336fa62648647fe48042009743d18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3620364
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-10 15:03:01 +00:00
Ross A. Wollman 33f61e8c21 Add repro for stuck Service Worker pending request 
The main request for a Service Worker scripts currently gets stuck in
the "(pending)" state.

This test will currently fail like:

```
1) network/network-datagrid_test.ts: The Network Tab
      shows the main service worker request as complete:

    AssertionError: expected { Object (status, time, ...) } to have property 'status' of '200OK', but got '(pending)'
    + expected - actual

    -(pending)
    +200OK
```

The issue appears to be rooted in the misalignment of network request ids
between the inial network CDP event for the request compared with
subsequent events.

Running this test with an executable built from https://chromium-review.googlesource.com/c/chromium/src/+/3544685
passes.

Bug: 1304795
Change-Id: I14f8d64d58fad16e4ddb0acf2058ed4c613c5500
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3566669
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2022-04-08 19:13:36 +00:00
Wolfgang Beyer b2af463419 Update tests to not use <link>-based APIs for Web Bundles 
Support for <link>-based APIs has been removed in
https://crrev.com/c/3565580

Bug: 1314256
Change-Id: I4d3b716100b6ba723d2094d4e3fbc4be07e73ae3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3578718
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-04-08 13:59:26 +00:00
Danil Somsikov 0957e53050 Update test webbundle resources to use uuid-in-package instead of removed urn:uuid: 
Bug: 1314256
Change-Id: Ife2c4c7e9ad6cac97eb80aef11ef8614512280b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3575950
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-04-07 17:09:25 +00:00
Philip Pfaffe 95bce20a24 Prevent making requests in the network request preview tab 
When filling the iframe that's showing the preview for html requests, we
encode the html contents as a data-url and also set the sandbox property
on the frame. This avoids remaking the request from within devtools.
It's still possible for the iframe to spawn some requests. With this CL
we prevent requests by setting the csp for the iframe.

Bug: 833147
Change-Id: Id77321465c91fd68e5d6c6c3681e48b39cb32d14
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3557989
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2022-03-30 12:09:32 +00:00
Danil Somsikov 19f1ef45e1 Add test cases from third_party/blink/web_tests/http/tests/devtools/network/network-filter{,-internals} to the third_party/devtools-frontend/src/test/e2e/network/network-filter_test.ts so that we can delete the former. 
Bug: 1238279
Change-Id: I2cea6156e089f11a6414390dcb960f9cbc088a5a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3455494
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2022-02-14 14:22:48 +00:00
Danil Somsikov 1afa110fd3 Ensure payload tab is selected when selecting different request 
Bug: 1267891
Change-Id: I06883acc2cee6eec11b107a4c30c79f3ea9204e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302736
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-11-26 11:04:31 +00:00
Jesper van den Ende 0113884bf6 Use mousedown event for activating network requests. 
The click event only fires for elements that receive both a mousedown
and a mouseup event. Since DataGrid elements in the Network panel get
replaced every time a message is received on WebSockets, the click
event doesn't get fired if you click before a message and release after
the message. To fix this we'll listen for the mousedown event instead.
This has the added benefit that the request panel becomes visible
sooner, making it feel more responsive.

Fixed: 1222382
Change-Id: Ia44c47a90b4822530081caf63aec682e9f32186c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3293092
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-11-23 06:57:58 +00:00
ergunsh ee4a613851 Add keyboard shortcut for Replay XHR 
Bug: chromium:1050021
Change-Id: I5566ae7de3b1b8f3b3ad3184d50f7f4220c2adc1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3251579
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2021-11-08 07:43:18 +00:00
Danil Somsikov 55304c6cd8 Added a smoke test for the Header tab in Network view. 
This should give us a little bit more confidence when extracting
Payload tab.

Bug: 1214030
Change-Id: I26039ad49980255f411655156c0d4ac2ae545c40
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3151803
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-09-10 14:40:11 +00:00
Danil Somsikov 1e996707c5 Apply websocket message filter on view load. Try#2 
Improved tests to wait for exact number of messages instead of minimum amount, which was causing flakiness.

Bug: 1228705
Change-Id: I2fb2b095d8a544eec4ff22e7674b3312ecfe7179
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3053741
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2021-07-26 14:28:27 +00:00
Simon Zünd 1ee58f9874 Revert "Apply websocket message filter on view load." 
This reverts commit 89d49c6e7b.

Reason for revert: Newly added test fails on linux.
See: https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8840656112097708576/+/u/E2E_tests/stdout

Original change's description:
> Apply websocket message filter on view load.
>
> Bug: 1228705
> Change-Id: Idd3bb46e3754ef85733303b89114d635db292c9e
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3048478
> Auto-Submit: Danil Somsikov <dsv@chromium.org>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

Bug: 1228705
Change-Id: Ifda4fdc91f6845074df448e1355ae95b27d3162a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3053739
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-07-26 11:59:27 +00:00
Danil Somsikov 89d49c6e7b Apply websocket message filter on view load. 
Bug: 1228705
Change-Id: Idd3bb46e3754ef85733303b89114d635db292c9e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3048478
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-26 09:05:17 +00:00
Danil Somsikov 721956a238 Add filter UI for third-party requests 
See https://imgur.com/a/7cXareV

Bug: 1057457
Change-Id: Iab186b9cf42cf4b488b6c6045cbcfdc0ac089a25
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3009815
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-07-07 14:14:01 +00:00
Danil Somsikov cd1691bc4f Show pending requests from the previous page as unknown. 
Only keep alive requests can survive page unload and there's no more
connection to devtools to report the request status.

Bug: 1072006
Change-Id: Ibd30bbd5ea240f2acf56258c2e67eed52d4d12ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2963192
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2021-06-17 13:11:17 +00:00
Danil Somsikov 73839bd1b0 Mark resource from the WebBundle as such and show WebBundle-specific errors. 
Bug: 1182537
Change-Id: I1a35a676005cf60d725f23fac0a3900c1a1c21bc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2949050
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-06-09 15:31:48 +00:00
Sigurd Schneider 19c6127030 Attempt to unflake test/e2e/sources/icon-row-bucket_test.ts 
Bug: chromium:1184162
Change-Id: I928ad0f6129a8a41f208648c4879c38ebb19867d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2804261
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-14 14:18:21 +00:00
Simon Zünd 2ea5538644 Keep Network tab selection between panel switches 
If the user prefroms the following steps:
  1) Inspect a Network request
  2) Select a Tab different from 'Header' (e.g 'Timing')
  3) Open Performance (or any other) panel
  4) Switch back to Network panel

Currently the Network panel will show the 'Header' tab instead of the
tab selected in 2). This is due to a wrong assumption in the code
that assumes the View is always freshly constructed. This is not
always the case.

This CL fixes this by force-selecting the tab only once, the first
time the view is shown after construction.

R=sigurds@chromium.org

Bug: chromium:1184578
Change-Id: I444ffacf1bd0d2377af3ab6f9f30482514f1e0c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2732384
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-03-31 09:59:13 +00:00
Sigurd Schneider fd69513352 Improve flakiness of icon row bucket tests further 
Bug: chromium:1184162
Change-Id: I51546af386c66e9981e71dd8a191211015471943
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2742814
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-03-09 08:52:15 +00:00
Alfonso Castaño f74238620c [Backend] Show Issue next to corresponding line in Source Tab 
This CL contains the backend changes, the UI changes are in a followup CL.

UI CL: https://chromium-review.googlesource.com/c/2567969
Design-doc: https://docs.google.com/document/d/1TgMAUsruc_xAPAseG96H0-NHRT_PiXciedD58hgq1e4/
Screenshot: https://i.imgur.com/2iOUMqK.png
Bug: chromium:1150883
Change-Id: If252699ea6b6e33f0608bb824c00dbb9f4aacb73
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2558298
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-12-11 12:14:17 +00:00
Sigurd Schneider 7b0711cb76 Show the initiator's network IP address space in the network panel 
This is currently not showing up for all requests, as the back-end
implementation is WIP.

This helps debugging CORS RFC 1918 related problems.

Note for jec@: Don't include in what's new for M89.

Screenshot: https://imgur.com/a/Aa9nrxD
Bug: chromium:1128885
Change-Id: I3d63c3ef18b3d1f0b3eaad50373811a6d6df9544
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557042
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2020-11-26 09:21:43 +00:00
Alfonso Castaño 13dcbd22d4 Breakpoint on Trusted Type violation (Devtools) 
This CL introduces a categorized sidebar pane to set breakpoints on Trusted Type violations.

DISABLE_THIRD_PARTY_CHECK=protocol change
https://docs.google.com/document/d/1rlRtq_Ai0leS9sqlRvoOL5RNc1BR6Q1yAVvLLJFasMA/
Screenshot: https://i.imgur.com/8Aythwz.png
Bug: chromium:1142804
Change-Id: I3e14e35165f1b157da922f534be52a10df9178ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2517571
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Alfonso Castaño <alcastano@google.com>
 2020-11-19 11:55:14 +00:00
Alfonso Castaño b60a4fdffc E2E test for report-only CSP issues 
New E2E test to verify that the status of the violation is blocked or report-only.

DISABLE_THIRD_PARTY_CHECK=<Introduce report-only field in CDP issues>

Bug: chromium:1139223, chromium:1124712
Change-Id: Ibf01624a069fb83013a8fa162235d307bc3e07ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2485086
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-10-21 13:56:45 +00:00
Tim van der Lippe ea5df6afa1 Move copy_to_gen into build/ninja 
Also rename it to `copy.gni`, since I will be adding a separate
`copy_to_resources` template that copies the content to
`resources/inspector/`.

R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1098730
Change-Id: If4266a9f701ac591614125442b4986d4fe38aafe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2278476
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-07-06 15:59:51 +00:00
Patrick Brosset fb005807e6 Introducing a general UI interaction test for the Network panel 
The Network panel did have 1 e2e test file which covered some very
specific cases such as encoding, mime type and checkbox interaction.
But it did not have a simple and general test for the main UI
interaction flows: displaying the list and selecting requests.

Adding this test means that we now have a place for checks that
verify that the panel works at all.

Bug: 1079076
Change-Id: Idd798d87951393563b0e2c9cd5cf383e5251755f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2228759
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
 2020-06-03 12:22:14 +00:00
Tim van der Lippe bc913faa45 Copy all e2e-resources to gen/ 
R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1088463
Change-Id: I7f9f43879a36d760afbec05d5b9110730f2b46ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2224808
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-06-02 10:45:30 +00:00
Benedikt Meurer 255362421f Revert "Introducing a general UI interaction test for the Network panel" 
This reverts commit 255926129b.

Reason for revert: redness on the bots, i.e. https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Linux/1793

Original change's description:
> Introducing a general UI interaction test for the Network panel
> 
> The Network panel did have 1 e2e test file which covered some very
> specific cases such as encoding, mime type and checkbox interaction.
> But it did not have a simple and general test for the main UI
> interaction flows: displaying the list and selecting requests.
> 
> Adding this test means that we now have a place for checks that
> verify that the panel works at all.
> 
> Bug: 1079076
> Change-Id: Ice25dee7743a375c033485c9af4853e477a938ca
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2210313
> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
> Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

TBR=Rob.Paveza@microsoft.com,jacktfranklin@chromium.org,patrick.brosset@microsoft.com

Change-Id: I2f3dbd3583aab0c9c1c82bee0cc1301b078a8744
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1079076
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2224813
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2020-06-02 08:28:58 +00:00
Patrick Brosset 255926129b Introducing a general UI interaction test for the Network panel 
The Network panel did have 1 e2e test file which covered some very
specific cases such as encoding, mime type and checkbox interaction.
But it did not have a simple and general test for the main UI
interaction flows: displaying the list and selecting requests.

Adding this test means that we now have a place for checks that
verify that the panel works at all.

Bug: 1079076
Change-Id: Ice25dee7743a375c033485c9af4853e477a938ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2210313
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-06-02 07:51:57 +00:00
Mathias Bynens 0a48503ad6 Simplify test resources 
Test resources should act as minimal repro cases: they should be as
small and simple as possible, without any unnecessary code that
distracts from what’s important.

This patch applies that thinking to the existing test resources, with
only a few exceptions for 1) descriptive <title>s and 2) the mandatory
license headers.

This came up during review of [1].

[1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107525

Change-Id: I1081bb06129d2b6ce98daf1349d20b2bf2fd9401
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2116445
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-03-24 12:55:22 +00:00
Paul Lewis e76848de18 [e2e] Adds licences; updates expectations 
The existing e2e test resources did not have a license header. This CL
updates them so they do, and updates the expectations against line
numbers etc to match.

Change-Id: I5d6ae76fbf748dcdeabfcedc236d1e067d27b1c2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084576
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-03-03 12:46:05 +00:00
Tim van der Lippe 54c6faa18b Add e2etest for cacheable responses in the network panel 
I also discovered that the checkboxes we had in DevTools where not
properly accessible. While there was some logic to let a label element
be the aria-describedby for the input element, because they were both in
the shadow dom, it didn't do anything. Setting the appropriate
aria-label fixes that issue.

Secondly, the hosted_mode server now implements caching based on ETags.

This replaces
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/resource-tree/resource-tree-mimetype.js;l=1;drc=77578ccb4082ae20a9326d9e673225f1189ebb63?originalUrl=https:%2F%2Fcs.chromium.org%2F
as an e2etest

Bug: 1044632
Change-Id: I3283b791d1d9a9673363d7cbb897d3f5c6c03ed0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2062603
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-20 16:02:26 +00:00
Tim van der Lippe 822e99179c Add test for utf-8 character encoding 
It also updates the hosted_mode server to serve JavaScript files with
the correct encoding. If we don't, the unicode characters that we use in
the DevTools implementations are garbled in either the source code or
test code.

This replaces
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/resource-tree/main-resource-content.js;l=1;drc=77578ccb4082ae20a9326d9e673225f1189ebb63?originalUrl=https:%2F%2Fcs.chromium.org%2F
as an e2etest

Bug: 1044632
Change-Id: Ie6b714f33685bc0d67b63b24c61911b0c8ecefe3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2062588
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-20 15:39:16 +00:00
Tim van der Lippe 1e74ce74a9 Add e2etest for Last-Modified parsing in network tab 
It uses a `.rawresponse` file that forcibly sets the `Last-Modified`
header. We then open the network panel, add the `Last-Modified` column
to the data-grid and then introspect its values.

As part of this patch, each context submenu now gets an `aria-label`.
These attributes are redundant here, since they mirror the computed
accessible name of these elements. The reason they're added is that we
use this label in the selectors of the end-to-end test.

This replaces
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/resources/cached-resource-metadata.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63?originalUrl=https:%2F%2Fcs.chromium.org%2F
as an e2etest.

Bug: 1047671
Change-Id: I89efc145c915f1a083dbcfb3765674122d9748fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2039270
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-02-07 12:55:30 +00:00