zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-06 20:11:38 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
108 Commits
Author SHA1 Message Date
Adam Raine 89128af9ea Fix Lighthouse web tests for new panel 
The new panel will refresh it's entire content after a runtime setting
is changed. After the first refresh, the web tests were working with
checkboxes that were no longer in the DOM. This CL updates the web tests
so they are always working with the checkboxes in the DOM.

Follow up to:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3636197
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3643856

Bug: None
Change-Id: I7b315b3310761f40ce4fe5b1cfacd9debebe0966
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3645230
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2022-05-12 20:23:03 +00:00
Simon Zünd 36c54939b9 [web tests] Move expected files to the new location 
Expectation files moved upstream in Chromium so we also have to
mirror the new structure in DevTools.

R=alexrudenko@chromium.org

Bug: None
Change-Id: I934d40bf371c3155ff013d3fc3be59ff734ce51e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3643856
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2022-05-12 10:41:03 +00:00
Adam Raine 50fb83d1ec [Lighthouse] Roll Lighthouse 9.6.1 
Bug: 772558
Change-Id: I75b6b6b55bf0fdff09c6c6bfd5d4d2ee82afdf10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3642441
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2022-05-12 07:03:02 +00:00
Paul Irish 9d89967044 [Lighthouse] Roll Lighthouse 9.6.0 
Bug: 772558
Change-Id: I3264b8ea518edd305d4ef996a98b6384547807b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3639625
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Adam Raine <asraine@chromium.org>
 2022-05-10 21:08:41 +00:00
Adam Raine ae48655147 Order Lighthouse categories by how they appear in the report 
Bug: 1291284
Change-Id: I79697ab9c1ad8d5f7c1f25e11b5f900257c5516e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3621278
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2022-05-03 01:41:30 +00:00
Benedikt Meurer 4fa82285f4 [CodeMirror] Upgrade to CodeMirror.next 0.20.0 
Bug: 1241848, 1215072
Change-Id: I21bc62922c5b8c9d4033ba411924cd641b091e3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3598871
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2022-04-21 09:50:46 +00:00
Connor Clark 4d17e989f0 [Lighthouse] Roll Lighthouse 9.5.0 
Bug: 772558
Change-Id: I02d731970e535c3dfb13fe7208743704ea48017b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3523733
Reviewed-by: Adam Raine <asraine@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2022-03-15 16:52:26 +00:00
Adam Raine b2305a0e89 [Lighthouse] Roll Lighthouse 9.4.0 
Bug: 772558
Change-Id: I6ef12a8401f28235d0fee402074730ec56d4f21e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470457
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2022-02-17 01:43:02 +00:00
Adam Raine 9312c5bd24 Add Lighthouse FR Navigation Mode 
Puppeteer is a dependency for the new mode. This CL modifies the
`getPuppeteerConnection` function from the recorder panel. The new
version of this function can be shared between the Lighthouse worker
and the recorder panel.

Bug: 1291284
Change-Id: Ie2cc144f5bd27b9970392638f08f968019b039c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3412356
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Randolf Jung <jrandolf@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2022-02-10 18:34:21 +00:00
Mathias Bynens 2b8d9b85fe Clean up redundant Promise.resolve() in call-stack-a11y-test.js 
Bug: chromium:1161501
Change-Id: I253d7ee8f91e1f3d151c9363bc006342a433db6f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3430924
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2022-02-02 12:18:01 +00:00
Adam Raine 71a818efde [Lighthouse] Roll Lighthouse 9.3.0 
Bug: 772558
Change-Id: Ic834caf191e355bd8f384fb3c98ac610ca72fe2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3427562
Commit-Queue: Adam Raine <asraine@google.com>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2022-01-31 18:01:40 +00:00
Adam Raine 75ed83a95a [Lighthouse] Roll Lighthouse 9.2.0 
Bug: 772558
Change-Id: I12d0cca0ee7e057f6ebda54e41c7faafeda18c9b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3344775
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Adam Raine <asraine@google.com>
 2021-12-20 17:16:22 +00:00
Tim van der Lippe b154da2d03 Upgrade CodeMirror 
R=tvanderlippe@chromium.org

Bug: 1241848
Change-Id: I72391b6e203d5010d13733ff76896fed597db336
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317336
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-07 14:41:47 +00:00
Connor Clark 4d66021885 [Lighthouse] Roll Lighthouse 9.1.0 
Bug: 772558
Change-Id: Ica2e7ecb15aace8cf26edf4dbfc13c443c9e35ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3307496
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-01 12:01:26 +00:00
Marijn Haverbeke f034f0b144 Reland "Port the console prompt to CodeMirror 6" 
This reverts commit d635360712.

Reason for revert: tests should be fixed now

Original change's description:
> Revert "Port the console prompt to CodeMirror 6"
>
> This reverts commit 71cd14a337.
>
> Reason for revert: This CL caused the waterfall to go red
> https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Mac/6200/test-results
>
> Original change's description:
> > Port the console prompt to CodeMirror 6
> >
> > And fix some autocompletion issues that came up when testing it.
> >
> > R=​tvanderlippe@chromium.org
> >
> > Bug: 1241848
> > Change-Id: I70d7fefa5fe3c9e09429d0b9a8fc4e39f0fe3f44
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289305
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
>
> Bug: 1241848
> Change-Id: Ied3d3eb14ddf495e70445a1cb7076cdfab5f38fa
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3291584
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Nancy Li <nancyly@chromium.org>
> Auto-Submit: Nancy Li <nancyly@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: 1241848
Change-Id: If88bafb86bd1730a0b81a0f362ed781584013289
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295531
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-22 16:10:18 +00:00
Marijn Haverbeke 7b0a00ed9e Upgrade CodeMirror.next 
R=tvanderlippe@chromium.org

Bug: 1269206
Change-Id: I5192ddf4eb65657b185176052d32ea4ba751a493
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3293282
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-22 14:44:58 +00:00
Nancy Li d635360712 Revert "Port the console prompt to CodeMirror 6" 
This reverts commit 71cd14a337.

Reason for revert: This CL caused the waterfall to go red
https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Mac/6200/test-results

Original change's description:
> Port the console prompt to CodeMirror 6
>
> And fix some autocompletion issues that came up when testing it.
>
> R=​tvanderlippe@chromium.org
>
> Bug: 1241848
> Change-Id: I70d7fefa5fe3c9e09429d0b9a8fc4e39f0fe3f44
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289305
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: 1241848
Change-Id: Ied3d3eb14ddf495e70445a1cb7076cdfab5f38fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3291584
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Nancy Li <nancyly@chromium.org>
Auto-Submit: Nancy Li <nancyly@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-18 15:40:37 +00:00
Marijn Haverbeke 71cd14a337 Port the console prompt to CodeMirror 6 
And fix some autocompletion issues that came up when testing it.

R=tvanderlippe@chromium.org

Bug: 1241848
Change-Id: I70d7fefa5fe3c9e09429d0b9a8fc4e39f0fe3f44
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289305
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-18 13:04:57 +00:00
Connor Clark 93a4454b7c [Lighthouse] Roll Lighthouse 9.0.0 
Bug: 772558
Change-Id: Ibd9cfe1aa2a4b429ed55bfda78eee8c62af2356e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3283799
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-16 18:27:44 +00:00
Tim van der Lippe c1ab112d90 Port the sources panels to CM6 
R=tvanderlippe@chromium.org

Bug: 1241848
Change-Id: Idfe1658c9c2948b5c79c2845b9fd9472746a62b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3247435
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-12 16:47:28 +00:00
Tim van der Lippe a91f92e8cf Remove panels/sources/module.json 
R=szuend@chromium.org

Bug: 1127902
Change-Id: Ib867035055da48bb0e6e4d1044fcd31221adabde
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253022
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-03 13:52:43 +00:00
Tim van der Lippe 9667b4fe60 Remove panels/settings/module.json 
R=szuend@chromium.org

Bug: 1127902
Change-Id: Ida10bb785b347699946725ddcc4b113d6575eb9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3247444
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-28 10:45:56 +00:00
Eric Leese 5c94fd9c20 Provide more visible warning of call frame issues 
When call frames have warnings, this is now displayed at the top
of the call stack.

Bug: 1261832
Change-Id: If13f652f4f19994b083761c8652adc452015f6a6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3234192
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2021-10-25 16:54:19 +00:00
Tim van der Lippe 89bdd334ff Remove panels/changes/module.json 
R=szuend@chromium.org

Bug: 1127902
Change-Id: I00d8c81058e00aa86324dc27914742744d0804bc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240947
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-25 16:22:29 +00:00
Tim van der Lippe 381b71fb73 Remove ui/legacy/components/quick_open/module.json 
R=szuend@chromium.org

Bug: 1127902, 1190991
Change-Id: Ie9cf2843e8bb523028e863c99b7b92c4c479abba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240945
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-10-25 15:40:19 +00:00
Adam Raine 1ab82801cd [Lighthouse] Roll Lighthouse 8.5.0 
Bug: 772558
Change-Id: Idf8a82cae172293877fcf99115bb84a8a6d73119
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3174531
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@google.com>
 2021-09-22 17:52:10 +00:00
Connor Clark 649a979e4d [Lighthouse] Roll Lighthouse 8.4.0 
Bug: 772558
Change-Id: I9ff13942ecab69cf2df41f8e2c05162eee446726
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3149892
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2021-09-08 20:13:35 +00:00
Jan Scheffler 01eab3cff4 [Underscore Migration] Migrate ui/legacy 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: I5ffc2c13077016933e6a77c34e94b279212ce004
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093160
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-16 17:58:29 +00:00
Jan Scheffler 77646c7212 [Underscore Migration] Migrate panels/elements 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: I29215cc92260c73e86f2ae14001d3f78cb508362
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3090591
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-14 09:58:55 +00:00
Jan Scheffler cd49c32674 [Underscore Migration] Migrate panels/application 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: Ib0ba7b50bf3193a647a81c6c702b24bd4a59b05f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3090585
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-14 09:53:20 +00:00
Jan Scheffler a222c6375e Reland "[Underscore Migration] Migrate panels/sources" 
This is a reland of 198dd8191b

Original change's description:
> [Underscore Migration] Migrate panels/sources
>
> This patch is part of the underscore migration that adds the private
> keyword to all properties that start with an underscore and removes the
> underscore.
>
> R=tvanderlippe@chromium.org
>
> Bug:chromium:1207342
> Change-Id: I0edea64030322835c035c083c8d2df486ef7ad1a
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3079534
> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
> Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: chromium:1207342
Change-Id: If36a54ebbee5c69cc6edae08e82070e8f81b76ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3089348
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-13 18:06:34 +00:00
Jan Scheffler f9867913bf [Underscore Migration] Migrate panels/timeline 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: If5bfa1146a3c5874948e5166b1c5fc006a201c20
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3090595
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-13 10:07:36 +00:00
Jan Scheffler aebe0a2511 [Underscore Migration] Migrate panels/settings/emulation 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: If301d164de50c27e6020e9d8a32485d469273c08
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3090594
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-13 10:05:14 +00:00
Adam Raine 663d38164a [Lighthouse] Roll Lighthouse 8.3.0 
Bug: 772558
Change-Id: I6240117ff3b4b1f4c33eb83f5efea159740e97c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3088413
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Adam Raine <asraine@google.com>
 2021-08-12 15:05:05 +00:00
Changhao Han 8eb616e81a Revert "[Underscore Migration] Migrate panels/sources" 
This reverts commit 198dd8191b.

Reason for revert: caused blink_web_tests to fail and tree closed: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/DevTools%20Linux/5848/overview

Original change's description:
> [Underscore Migration] Migrate panels/sources
>
> This patch is part of the underscore migration that adds the private
> keyword to all properties that start with an underscore and removes the
> underscore.
>
> R=​tvanderlippe@chromium.org
>
> Bug:chromium:1207342
> Change-Id: I0edea64030322835c035c083c8d2df486ef7ad1a
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3079534
> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
> Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: chromium:1207342
Change-Id: I1e8036a094e5868799f826a5f5ae649b96ae43b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3087345
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-08-11 05:46:26 +00:00
Jan Scheffler 198dd8191b [Underscore Migration] Migrate panels/sources 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: I0edea64030322835c035c083c8d2df486ef7ad1a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3079534
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 17:56:31 +00:00
Jan Scheffler 8bdc35dea1 [Underscore Migration] Migrate panels/security 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: Iec3f55db4416fce0a035ef64ada7741f81933a6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3079530
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 12:51:01 +00:00
Jan Scheffler 9d4136d7cf [Underscore Migration] Migrate panels/lighthouse 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

Bug:chromium:1207342
Change-Id: I7e2496708924f93973388ecc1a6b70eb69468ae0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3079523
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 12:07:12 +00:00
Jan Scheffler b2e972040c [Underscore Migration] Migrate panels/changes 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: I900a8dcbf88b34ebb0528ed5c1d12944ba5da3de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077394
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 11:39:41 +00:00
Jan Scheffler 608c518de2 [Underscore Migration] Migrate panels/browser_debugger 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: Iab9b1b9439442f7e55913f251c3f150f95febae4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077392
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 11:18:02 +00:00
Jan Scheffler 1d8eab6152 [Underscore Migration] Migrate panels/settings 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: Ib360512a1a7badbff0c1e32c78af161e5af81690
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3079532
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 11:06:41 +00:00
Jan Scheffler 2a0ff4eaa3 [Underscore Migration] Migrate panels/sensors 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: Ic2fbd8eca212157e14d501af9026fd541d34617b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3079531
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 10:41:35 +00:00
Connor Clark b3f623ee76 [Lighthouse] Roll Lighthouse 8.2.0 
Bug: 772558
Change-Id: I68a141387f5b4b236c0327374c298e9e705fdd6f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3072299
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2021-08-05 09:11:53 +00:00
Tim van der Lippe f76ee1c0ce Replace custom tooltip implementation with native HTML tooltips 
DevTools has had a custom tooltip implementation for a long time.
The primary reason for adopting a custom tooltip implementation
is the lack of styling of a native HTML tooltip.

Unfortunately, maintaining a custom tooltip implementation is
complicated and we regularly run into complicated bugs such as
crbug.com/1219947, crbug.com/1081140 and crbug.com/1217978

Besides that, the remote device view uses the tooltips which
ends up not working, since the remote device view is in a
different frame, which doesn't have access to the custom
tooltip.

All in all, the problems the custom tooltip implementation are
causing are not outweighing the benefits of the slightly
improved styling of the tooltips. The native HTML tooltips
are sufficient for DevTools and adopting the tooltips prevents
a vast variety or problems for our users.

In a follow-up CL, all usages of `install` will be migrating to
setting the `title` attribute directly instead.

R=mraz@chromium.org,jacktfranklin@chromium.org

Bug: 1223391
Change-Id: I06f9317a86dd1c7cc10e52e170b9c62d787f02bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3008794
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-19 15:11:30 +00:00
Connor Clark 16d96a25f2 [Lighthouse] Roll Lighthouse 8.1.0 
Bug: 772558
Change-Id: If6cc24742594ce7176375ea6ed5fc51fc01fb129
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3025260
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2021-07-14 19:03:02 +00:00
Tim van der Lippe a53672de83 Check license headers for CSS files during PRESUBMIT 
This mirrors the license header checks we perform for
Python-like files and apply the same logic for CSS.

To do so, we modify the relevant regexes and patch
function to use the correct version of comment structure
for CSS files (which use `/*` rather than `#` as delimiters).

R=jacktfranklin@chromium.org

Bug: 1106746
Change-Id: I51d51e9b793a1015aeb20a3b3a55e075c2ee748f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3014756
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-13 12:28:56 +00:00
Connor Clark 62b16561e4 [Lighthouse] Roll Lighthouse 8.0.0 
Bug: 772558
Change-Id: Ib1182e2e3dddf8b0859cee85ca4dd5c7e5812cb3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2930996
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2021-06-02 00:51:06 +00:00
Adam Raine 287be69dde Remove Web SQL from Lighthouse web test 
This web test has become flaky downstream in Lighthouse. Web SQL is not
always surfaced in the warning message.

The warning message can still be tested with just IndexedDB, so we can
remove Web SQL from this test.

Bug: none
Change-Id: Ia73ad928bcb724049ee3578722b29beb3e57108f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2929758
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2021-06-01 19:28:06 +00:00
Connor Clark 4cef9324af [Lighthouse] Roll Lighthouse 7.5.0 
Bug: 772558
Change-Id: I9db2b3ca6a17b14e66c14eaea103fda77d82737e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2902746
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2021-05-18 16:38:52 +00:00
Adam Raine d17898e62f [Lighthouse] Roll Lighthouse 7.4.0 
Bug: 772558
Change-Id: I444630c73af5858dda08f70001ff972b3a6a6a6a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2855397
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@google.com>
 2021-04-27 22:04:22 +00:00