zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-30 01:43:36 +08:00
Code Issues Packages Projects Releases Wiki Activity
15,004 Commits 43 Branches 79 Tags
bf8e3bda617e1cc98c2daf33ef8868bbfd019521
Commit Graph
82 Commits
Author SHA1 Message Date
Nikolay Vitkov 42be2661bd [Recorder] Metrics for Code View and Copy 
Add metrics for toggling code View and coping recording or step.

Backend CL: crrev.com/c/4156913

Bug: 1406450
Change-Id: I6ca1818b2befc384ce90db32625b59f104317906
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4157231
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Luc Nguyen <lucnguyen@google.com>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2023-01-12 16:20:01 +00:00
Danil Somsikov cf4748a382 Revert "Record changes to the "Show CORS errors" setting in UMA" 
This reverts commit f7c7c92719.

Reason for revert: The current distribution is basically 40:60 for showing CORS errors in the Console. So this seems to be a useful feature. Removing the histogram.

Original change's description:
> Record changes to the "Show CORS errors" setting in UMA
>
> Bug: 1251176
> Change-Id: I078f03153482636dec13e2fa2f207cbb00b7574b
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3196174
> Auto-Submit: Danil Somsikov <dsv@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: 1251176
Change-Id: Icec658ad845ca6c1f3a6137d6b281fde1f2407b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4061718
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2022-12-05 13:23:00 +00:00
Adam Raine dcd975155c [Lighthouse] Add mode histogram to devtools_compatibility.js 
Follow-up to: https://crrev.com/c/4026664

Bug: 1291284
Change-Id: I5cdff9b488cdc9f58ce007341dadf161b6f4828a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4063841
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2022-11-30 17:42:21 +00:00
Benedikt Meurer b485427927 [metrics] Hook up Network preview media type histogram. 
This extends the current media type recording to also record media types
of files opened in the response preview tab of the Network panel.

Corresponding chromium change: https://crrev.com/c/4061230

Bug: chromium:1385374
Change-Id: I8b81802909d71e519ce01364fdcd3d2bb5ad08b8
Fixed: chromium:1392055
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4061308
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2022-11-28 12:02:39 +00:00
Benedikt Meurer dbe90fa988 [metrics] Hook up metrics for the file formats in the Sources panel. 
Corresponding chromium change: https://crrev.com/c/4041266

Bug: chromium:1385374
Change-Id: I044336f55bdc55a34f10542feead0de1da1de0c9
Fixed: chromium:1392055
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4040465
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2022-11-21 13:14:55 +00:00
Kim-Anh Tran 3015698f12 [BreakpointsSidebarPane] Allow for independent pause on exception 
This CL allows non-node targets to independently select
"pause on caught" or "pause on uncaught exceptions". For node
targets (for compatibility reasons of Node LTS), we are currently
disallowing this and will lift it as soon as Node LTS has caught
up with the back-end change that allows for independent toggles
(https://crrev.com/c/4013330). For node, one can only pause on
caught exceptions if one is pausing on uncaught exceptions.

Drive-by: Only add the BreakpointsSidebarPane as listener to flavor changes if the experiment is on
Screenshot: https://imgur.com/a/7nQoaCN
Bug: 1324920, 1382762
Change-Id: Id44a6eb6d7c59870b029e9f0d3899569bbaf7e7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4016814
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2022-11-15 10:27:44 +00:00
Kim-Anh Tran 5efbb9fc6c [uma] Correct UMA name in devtools_compatibility 
This CL corrects the UMA name to correctly match what is defined in
InspectorFrontendHostAPI.ts

Bug: 1381018
Change-Id: Ib7d4929c5013b652ec3582c452dfaac1bf86185a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4003762
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
 2022-11-07 09:10:01 +00:00
Kim-Anh Tran 9ebe6e30e7 [UMA] Add metrics around breakpoints 
This adds the following metrics:
* BreakpointWithConditionAdded
* BreakpointEditDialogRevealedFrom

And expands the Action metric with:
* BreakpointRemovedFromRemoveButton
* BreakpointGroupExpandedStateChanged

Bug: 1381018
Change-Id: I4f710c51c64c1a846d8e2d9cc6f765901ab71622
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3998783
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2022-11-03 11:26:56 +00:00
Alex Rudenko 75884795d2 [CSSHints] Add metric name to devtools_compatibility.js 
Drive-by: sorted alphabetically.

Bug:1178508
Change-Id: I015b5aef9b9db140ffe539575b0804906077d134
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3945173
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2022-10-12 08:30:39 +00:00
Eric Leese 9441d8775b Update ignore list settings UI 
Update UI of ignore list settings page
 - Ignore list rules are now enabled/disabled with a checkbox
 - Another checkbox to disable ignore-listing entirely
 - Auto-hide Add pattern button when editing an entry
 - Other changes for better visual hierarchy

Design doc: https://docs.google.com/document/d/1S5zFI_i092sKn50gCucGGPB4hklKAkrRfJu2ZPfXCfk/edit

Bug: 1356517
Change-Id: I9f34caca40c6d07ab32014bcd34f676d6bf2f7f4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3909889
Commit-Queue: Eric Leese <leese@chromium.org>
Commit-Queue: Victor Porof <victorporof@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
 2022-09-26 10:24:40 +00:00
Victor Porof e09e489c2b Add a checkbox that controls automatic ignore listing 
Third-party code can be automatically ignore-listed based on source map hints. Chrome DevTools has introduced a source map extension to identify third-party sources in source maps with the `x_google_ignoreList` field.

This CL adds the ability for the user to toggle this functionality on/off. It is enabled by default.

Bug: 1323199
Change-Id: Id35c74063af2526b4b27f60164ffe36f66a66a72
Signed-off-by: Victor Porof <victorporof@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3779791
Reviewed-by: Eric Leese <leese@chromium.org>
 2022-07-21 16:37:36 +00:00
Kristin Lee 1aa36584d5 Create sub-panes for Applications Pane 
Adds sub-panes to the Manifest side pane in Applications when Manifest is detected. The sub-pane items will be subsections that exist in the Manifest view (Identity, Presentation, and Icons (TBA: Protocol Handlers)). When a sub-pane item is clicked, the view will scroll to that specific section in Manifest.

Explainer: https://docs.google.com/document/d/1XsKG_yqHEwWYvI2O0drMliDhF3GaLLGTkC2XmETMSrI/edit?usp=sharing

Related CL: 3640142: Add Protocol Handlers section to Application Panel | https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3640142

Gif Demo: https://drive.google.com/file/d/1BgBio7TDThJw659V-EsF_Yk9DVD3NNsz/view?usp=sharing

Backend CL for Telemetry: https://chromium-review.googlesource.com/c/chromium/src/+/3749217

Change-Id: I59d5dc5c20f06f0ed74506f38a2d873e3c755378
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3575416
Commit-Queue: Kristin Lee <v-kristinlee@microsoft.com>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Michael Liao <michael.liao@microsoft.com>
 2022-07-08 05:01:14 +00:00
Eric Leese 6bc65d0595 Add option to group by Authored/Deployed 
- adds a menu item to change the sources tree layout to group
   authored content from source maps under a separate subtree
   to make it easier to find sources likely to be of interest
 - default remains unchanged
 - legacy Treeoutline now supports new Icon component so that
   new icons do not need to be added to legacy icon sheets
 - lays groundwork for future changes to script identity for
   source deduplication, as we may now need to deduplicate
   sources in the tree view that would previously only have
   been deduplicated when opening source tabs

Bug: 960909
Change-Id: I2fcee95eb5cb1da5a7725301e72e67df42bf3f11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3653566
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2022-05-24 09:00:33 +00:00
Ergün Erdoğmuş c71550c756 Add UMA for replay speed in Recorder panel 
Bug: 1306756
Change-Id: I24753e4dad52aa1698c3a7a391edc246dfbd7e12
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3624020
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2022-05-13 11:45:23 +00:00
Changhao Han 935ee90b0e Add metrics for copying style texts 
Backend CL: https://crrev.com/c/3529067

Bug: 1268754
Change-Id: I74aac83d85a16e2ed7f39b8b10bfaea6832be382
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3529446
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-03-17 09:28:47 +00:00
Mathias Bynens 6dc409767c Drop support for Chrome 44 
Chrome 44 was released in 2015-07.

Bug: chromium:1293784
Change-Id: I51a72e32668b14c2fa1aa9d8477b6919f9e70347
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3436426
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2022-02-07 12:56:34 +00:00
Danil Somsikov 1f74767043 Option to forbid certain origins for devtools extensions. 
This is used and tested in crrev.com/c/3429170

Bug: 1115460
Change-Id: I55df48f3d10a0c2163bad068e16bd630ba4b6c8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3428454
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2022-02-02 13:40:41 +00:00
Alex Rudenko a9a491e39a Add Settings.forceGet method 
The new method always bypasses the local cache
and gets the value from the backing store.

Backend CL: crrev.com/c/3302814
Bug: 1273058
Change-Id: I921edf3a4c741261a3823310c6f23b57934a9ad1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302733
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2022-01-11 10:21:34 +00:00
Yang Guo e0c66bc191 Remove dead code for DualScreenDeviceEmulated histogram 
R=wolfi@chromium.org

Bug:1125666
Change-Id: Ibb03349f6a4b1379fbd41eaeb54b20786f5e0d9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3329542
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2021-12-10 15:53:09 +00:00
Simon Zünd da9ff39438 [sync] Fix settings sync UMA by adding it to devtools_compatibility.js 
The "DevTools.SyncSetting" histogram is missing from the host bindings
JS side, so we didn't collect any UMA up until now.

R=alexrudenko@chromium.org

Fixed: 1275456
Change-Id: I4fac223eb5453afd8870c156fbfd8bed4c225e58
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3307448
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-12-01 08:55:25 +00:00
Yang Guo 1d553f1ea0 Remove obsolete histograms 
R=changhaohan@chromium.org

Fixed: 1235544, 1125666
Change-Id: Ib5b28a500cea5c37f433d79ede256c61480804ef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306501
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2021-11-30 14:28:15 +00:00
Marijn Haverbeke 3ea8755408 Remove machinery surrounding CodeMirror 5 
The third_party module is still there because a few of its scripts are
used for tokenizing.

R=tvanderlippe@chromium.org

Bug: 1241848
Change-Id: I576b7c1a0fb6c78ca83422fdb9117f169a75efb7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295489
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-29 15:10:46 +00:00
Alex Rudenko e3c100e5f7 Add UMA for the Recorder panel 
Backend CL: crrev.com/c/3268130
Bug: 1267792
Change-Id: I62857d299b9e6cd9da0ef369554508df23229053
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268285
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-10 07:44:13 +00:00
Simon Zünd 21ec5df2a1 [sync] Add getSyncInformation host binding 
This CL is part of a chain:
  1. https://crrev.com/c/3217452 adds the binding in the backend
  2. https://crrev.com/c/3217093 adds the binding in the frontend
  3. https://crrev.com/c/3217454 adds a test for the backend CL
The test only works after 2) has landed, so we need to land it
separately.

R=alexrudenko@chromium.org

Bug: 1245541
Change-Id: I99650112219cc3e7af4a55ebaf2608f6a9a20b6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3217093
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-10-13 06:33:52 +00:00
Danil Somsikov f7c7c92719 Record changes to the "Show CORS errors" setting in UMA 
Bug: 1251176
Change-Id: I078f03153482636dec13e2fa2f207cbb00b7574b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3196174
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-09-30 14:29:32 +00:00
Simon Zünd 2e06713e60 Add 'registerPreference' host binding 
The host binding was introduced with https://crrev.com/c/3162281 on
the backend side. This CL adds the 'registerPreference' method to
the injected bindings (devtools_compatability.js) as well as the
interface used by the DevTools frontend.

R=alexrudenko@chromium.org

Bug: 1245541
Change-Id: Ica432c14a7d4332c3190af3bf933b6167752839d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3195870
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-09-30 10:29:31 +00:00
Andrey Kosyakov ad41328d28 Support browser-level connection for service workers 
- if browserConnection query param is set, assume the default connection
    to be the browser one;
- await for initial connection id from the host and attach it;
- use Target.autoAttachRelated on the browser level so that we remain
    attached to newer targets even if the original target is gone;

Back-end change: https://chromium-review.googlesource.com/c/chromium/src/+/3114919

Test: https://chromium-review.googlesource.com/c/chromium/src/+/3115848

Design doc: https://docs.google.com/document/d/1udjdBvQNzOLltTM-uZeuu9akU2tgdxgoLji_bX_K_Jo

Bug: 1213714
Change-Id: Ie7363200103a09512e696aa9cf69905982cf4564
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3115448
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-31 19:33:42 +00:00
Alex Rudenko 2f29f1b55a Remove FixedColor metric 
The metric has been active for almost a year and we won't probably
need it anymore. This CL removes the instrumentation from DevTools
frontend.

Bug: chromium:1242479
Change-Id: I5ec743cff683a745e2bedbdd7202d87019a58bce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3122336
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-08-27 08:40:52 +00:00
Simon Zünd f6a47f0186 [uma] Record UMA histogram for used DevTools UI language 
The histogram is recorded right after DevTools is booted up and the
used UI language was determined. The DevTools UI language only changes
in between reboots, so we get exactly one event per DevTools session.

Backend CL: https://crrev.com/c/3115087

R=sigurds@chromium.org

Bug: 1242811
Change-Id: Ib0930eb9bbe7472a061047daedbd107b78ff9800
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3115967
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-08-26 13:48:55 +00:00
Sigurd Schneider 8fc6f1b872 Remove createElementWithClass from document prototype 
Bug: chromium:1050549
Change-Id: Ic74b62bae1c416e7b4df909b02f07e8481fe3542
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2998545
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-07-01 10:59:59 +00:00
Benedikt Meurer 55398c049e [lmi] Implement metrics for the Memory Inspector. 
Backend: https://crrev.com/c/2720183
Doc: http://docs/document/d/1HJrIWaWnDzXDWhtoGNIus2G-TD9HElWJP4ScLLzE5Rg
Fixed: chromium:1174400
Change-Id: I68c64b029538b048e4eb4c76cb5d7acdc39b7517
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2720239
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2021-03-02 10:50:47 +00:00
Jesus David Garcia Gomez 76111edfec Remove option Don't show Chrome Data Saver warning from settings. 
This CL removes the option "Don't show Chrome Data Saver warning" from
settings because Chrome Data Saver has been deprecated.

Before: https://i.imgur.com/Ggf8hlz.jpg
After: https://i.imgur.com/pSekZs5.jpg

Bug: 1056922
Change-Id: I0ed955e085d96c6bc677b47720994b43040c26cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698373
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jesus David Garcia Gomez <jegarc@microsoft.com>
 2021-02-17 18:44:24 +00:00
Sigurd Schneider a709974a86 Record schemes of developer resources via UMA 
Drive-by: Cleanup in user-metrics_test.ts
Drive-by: Cleanup metrics mixup in PageResourceLoader

Bug: chromium:1069378
Change-Id: Icbdf6e533ddc5a99c7684d951cb1afea00846c4c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2637697
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-20 08:45:41 +00:00
Sigurd Schneider 8d62769d7e Collect UMA on developer resource loads 
Bug: chromium:1069378
Change-Id: I324712b50ee50c39620fa76669125f1e3b5e01d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622195
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-01-13 10:48:33 +00:00
Tim van der Lippe d7cfd14814 Fix no-implicit-coercion errors in front_end/ 
R=jacktfranklin@chromium.org

No-Presubmit: True
Bug: 1082789
Change-Id: Ic77884bf7e9b5dc74053915b3b10699368841b66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2595268
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-07 12:40:16 +00:00
Wolfgang Beyer a175e1f23c [Issues] Add UMA metrics for which types of issues are created 
The issue code for the various issue types is aligned to follow a
similar schema (except for MixedContentIssues, where there is no
additional info to be embedded in the issue code).

Backend CL: https://crrev.com/c/2574985
Bug: 1072335

Change-Id: I6545297ce38f32f0e4af875c683beac931cdeafc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567967
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-15 09:25:17 +00:00
Michael Liao 07a11ed089 [Telemetry]: Adding CSS Editor Opened telemetry 
This CL adds telemetry for CSS editor openings.  The telemetry event triggers when a user clicks on a swatch or the font editor button.  The different CSS editors pass in a different ID to differentiate the telemetry events from different swatches/buttons.

chromium/src change: https://chromium-review.googlesource.com/c/chromium/src/+/2410650

Bug: 1149589
Change-Id: I7309591c6fc6ea6524f43a6e3924278446fcf194
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2410431
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Songtao Xia <soxia@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
 2020-12-08 15:27:43 +00:00
Tim van der Lippe f52d4a0d1e Remove remaining unrestricted annotations 
These weren't found by the regexes used in the previous cleanups,
as their formatting was off. After this CL, no unrestricted
annotations remain in the codebase.

R=szuend@chromium.org

Bug: 1011811
Change-Id: Ief25abab1f981b2315adf61fc56765f2da69fb81
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569760
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-02 15:41:12 +00:00
Mathias Bynens a0d60451e1 Remove custom setImmediate implementation 
All of the existing callsites passed only a callback parameter, with
no additional `args` parameters, and so this functionality is
equivalent to the built-in queueMicrotask().

Note that there are some upstream tests that currently still use
setImmediate. These tests are ported in [1], which should be merged
before this patch can land.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/2563476

Bug: chromium:1050549
Change-Id: Iee3d286d38bcb17d9b78ca89f9897e8ca37b6d94
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2554560
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-30 14:20:29 +00:00
Changhao Han 45d8473c1a Remove deprecated CSS Grid UMAs 
The removed UMAs include:
CSSGridSettings
GridOverlayOpenedFrom
HighlightedPersistentCSSGridCount

Bug: chromium:1138261, chromium:1138260, chromium:1138259
Change-Id: Ic17695b2b5efaff1e5e52d4d0a4e81309c282146
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2562700
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-11-27 12:18:16 +00:00
Peter Marshall 355af6adb9 Add showSurvey and canShowSurvey to InspectorFrontendHost 
These two methods are used to trigger in-product surveys for new
devtools features.

The two new bindings are added in this chrome CL:
http://crrev.com/c/2509570

Bug: 1112738
Change-Id: Ib44333bf7ca8ac226e7d4e31d6dd51f868144ab3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2361683
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-04 07:12:37 +00:00
Changhao Han 429410096a Remove ComputedStyleGrouping UMA in M88 
Bug: chromium:1127956
Change-Id: Icee8ad4d5d42c47135563de678d9164e03bdb8a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2485087
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-10-20 11:34:20 +00:00
Changhao Han 03c4838e78 Add UMA for Grid overlays opened source 
Backend CL: https://crrev.com/c/2410069

Bug: chromium:1047356
Change-Id: I42d4b9e933d6d136b6b6f6da5d312cb25d8eff08
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2410229
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-09-16 12:22:07 +00:00
Jesus David Garcia Gomez 0c37bf0f19 [Issues] UMA tracking for the issues panel 
This CL add new metrics enums to allow measuring when an issue in the
issue panel is expanded and when a resource is opened.

The corresponding chromium CL is at https://crrev.com/c/2305018
Design doc: https://docs.google.com/document/d/1XfVyiQAe9sT9hj0EigQ2skmJP4gCrrnUJVLd-qpFk7A

There are two elements that we can't track the telemetry because
they are stopping the propagation of the event for "click" and
"keydown" if the key is the enter key.

I have open two issues to track them separately.

  - Learn More link: https://crbug.com/1108501
  - Source link: https://crbug.com/1108503

Summary:

This CL purpose is to answer the question "Which issues are
useful for developers?"

For that purpose this will track when an user expand an issue and
when a resource inside the issue is clicked.

Tracking this two things can help us to answer the previous
question. i.e: "if we see users clicking an issue
but *not* clicking on a resource, that may tell us
the issue needs to be changed or removed"

Bug: 1100658
Change-Id: I4a6f86f107dc710bc64edbf21670a4a3bd2a3d60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2303882
Commit-Queue: Jesus David Garcia Gomez <jegarc@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-09-10 17:13:53 +00:00
Patrick Brosset 77ed48ad21 Grid: New histogram to track how many grids users highlight in the page 
There is a backend part to this change:
https://chromium-review.googlesource.com/c/chromium/src/+/2379254/

The goal is to track how many grids people highlight in web pages using either
the adorner in the Elements tree, or the checkboxes in the Layout panel.

The histogram is done in a way where we track when users highlight 0, 1, 2, 3, 4
grids, and then between 5 and 9, 10 and 19, 20 and 49, and more than 50.
We have more granularity at the bottom end of the spectrum as the expectation is
that users will mostly highlight few grids at a time.

Bug: 1047356
Change-Id: If3a5282d3909e85ba73b96714fae1d4e2bc9ba36
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2379098
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-09-04 08:48:52 +00:00
Changhao Han ca13f09d78 Add UMA to track computed style grouping usage 
Bug: chromium:1096230
Change-Id: I13dd4029ea802b44c2888655f66b45e783663e90
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2392240
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-09-03 06:13:21 +00:00
Paul Lewis 90faf09ce9 Update Closure Compiler and fix associated errors 
Change-Id: I07cc1ea6b1b135571359136dfdec120ab4649b9e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2388060
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-02 08:41:50 +00:00
Changhao Han f51d07946b Add UMA for showing sidebar panes 
Backend CL: https://crrev.com/c/2378025

Bug: chromium:1119895
Change-Id: I5c24b4b49437cea977bcdddc6327cb3702fa88c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2377585
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-08-27 12:02:55 +00:00
Alex Rudenko b77998026e Simplify the grid tooling settings 
This CL simplifies the Layout settings for grids according to the
latest design.

Screenshot: https://i.imgur.com/g31WbOz.png
Backend CL: https://crrev.com/c/2367833

Bug: 1109177
Change-Id: Ibbba60cc80aa5bc0903ca386e41b6c81fdcd4f0c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2366793
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-08-26 10:45:25 +00:00
Alex Rudenko 3de657afc9 [Metrics] UMA tracking for suggest color feature in Color Picker 
This CL adds UMA tracking histogram for the new feature of
automatically fixing low-contrast colors to help answer the questions:

- how often is the feature used?
- what contrast threshold is being primarily used?

Backend CL: https://crrev.com/2360069

Bug: 1093227
Change-Id: I3568358e5b26bc63a7c5b569947ccd1d152bb592
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2360010
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2020-08-20 08:17:24 +00:00