Commit Graph
61 Commits
Author SHA1 Message Date
Andrés Olivares dd0c9ed791 Remove Inputs panel
It's a precursor to the Recorder and should be removed now that we
have the Recorder.

Bug: 1362483
Change-Id: I416de768195a539622af31cd0853d40a4e660aea
DISABLE_THIRD_PARTY_CHECK=Removing a panel from DevTools
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3918632
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
2022-09-29 08:56:50 +00:00
Danil Somsikov c1abf4cd44 An option to run Karma unit tests with a fullt bootstrapped frontend and real CDP connection.
This is needed to instantiate some classes e.g. CPUProfileView.

Bug: 1306830
Change-Id: Ib59ebc4235bfd08ef847e49f478351f2a830081a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3545148
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
2022-03-23 17:12:52 +00:00
Tim van der Lippe 55278a6c23 Remove final few side-effects in platform/utilities.ts
The final few can be added to TestRunner.js which can expose them to the
global scope for the legacy layout tests. The other usages of the final
global have been removed from the legacy defs and ported in the code.

As such, we can now consider crbug.com/1050549 finalized and all globals
properly exported.

R=jacktfranklin@chromium.org

Fixed: 1050549
Change-Id: I9945ecb15e6324ee1982a81fbab669c63fb62512
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313065
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2021-12-02 15:37:43 +00:00
Tim van der Lippe 097a90e611 Change shell to TypeScript-authored
All entrypoints are now also TypeScript-authored, so we can make this a
`.ts` file as well.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I250ba868a121d87f434d0a53a4438bbbf5a59042
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313064
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-12-02 14:55:13 +00:00
Tim van der Lippe 07805ea8f9 Remove entrypoints/startup/
None of the entrypoints require this anymore, so we can clean it up.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I2cd507ea169952c3bdb39388a7c4eff21746ef17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310870
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-12-02 12:15:37 +00:00
Tim van der Lippe 19b714a693 Remove entrypoints/shell/shell.json
Shell no longer has any content, so we can remove it from all
entrypoints. We still want to share the contents of the meta files and
all, so keep these in. However, since we are no longer processing the
`shell.js` file `build_release_applications`, we can now fold in
`shell-meta-files.ts` into `shell.js`.

Ideally, we also change `shell` to be TypeScript-authored, but we can
only do that after all entrypoints that import it (in their respective
`.js` files) are TypeScript. So we will have to do that last.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I47239286f6f1dbff63ce69cf8ca4c78bd4761030
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306497
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-11-29 15:55:52 +00:00
Marijn Haverbeke 3ea8755408 Remove machinery surrounding CodeMirror 5
The third_party module is still there because a few of its scripts are
used for tokenizing.

R=tvanderlippe@chromium.org

Bug: 1241848
Change-Id: I576b7c1a0fb6c78ca83422fdb9117f169a75efb7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295489
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-11-29 15:10:46 +00:00
Tim van der Lippe 43054a8e75 Remove ui/legacy/components/source_frame/module.json
R=jacktfranklin@chromium.org

Bug: 1190991, 1127902
Change-Id: If8255f800147ad5a0421c5a557dbdfcb5e8555ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289764
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-11-18 12:31:11 +00:00
Tim van der Lippe 46c04d0b5a Remove panels/profiler/module.json
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I7ddbed1f42044f8d4e7ef427e96f7bde7677abf3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3282586
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-11-17 14:51:31 +00:00
Tim van der Lippe 9f3d6ffa9a Remove ui/legacy/module.json
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I75d32fe5ac66df9c0571a1dd235dab7b8ab19638
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3284812
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-11-16 16:57:23 +00:00
Tim van der Lippe b5fb91dfa5 Move legacy file loading to legacy_test_runner
DevTools startup has slowed down a bit over the last year. The main
suspect that we have is the amount of files that are loaded at startup.
We have historically made significant improvements by removing file
loading out of the critical path, for example by removing the `module.json`
files from various modules. These have all attributed to improvements.

For our shell, we were still loading these legacy files. However, now
that we are fully type-checked with TypeScript, we have for the most part
removed our reliance on globals. There are only a handful of places where
we still rely on globals, most notably `MainImpl` for instantiation of
singletons and a single declaration in `ui/legacy/Panel.ts` which sets
values on `UI.panels`. Other than that, there don't appear to be anymore
usages of globals.

Therefore, we can move these legacy files out of our main shell and into
the legacy_test_runner. Doing so, our production build will now include
fewer files and hopefully also boot faster, while we still load the
legacy files for our layout tests (which still rely on globals).

It isn't clear what the performance impact will be, but cleaning this up
is good and we are relatively confident this will alleviate at least
some of the performance problems that have been reported.

R=yangguo@chromium.org

Bug: none
Change-Id: Ie34fbf6b82f3d1ba11bed623a9cc3d2a03c4c0c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264212
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2021-11-15 14:39:55 +00:00
Tim van der Lippe 1b5567f78a Remove resources from perf_ui
To remove the module.json file in perf_ui, we need to migrate the
resources to the new `generate_css` template. However, perf_ui is a bit
special, in that it doesn't properly use the widget structure. As such,
it sometimes injects CSS in places where there is no clear shadowRoot
available. Therefore, it is not possible to migrate to CSSStyleSheet in
combination with adoptedStylesheets.

As a workaround (to unblock the module.json removal), we augment
`generate_css` to add legacy file generation. All remaining resources in
DevTools will migrate to these `.css.legacy.js` files. That's because
these resources either are special (perf_ui) or are used in the
`device_mode_emulation_frame` which can't use `CSSStyleSheet` itself.

The files export an object, rather than a plain string. That's because
we need to be able to distinguish what string is referencing a CSS file
path and which strings contain the actual CSS styles. By using an
object, we can remain using the `typeof` check for string in the legacy
CSS infrastructure and otherwise destructure the object.

After this, we can remove perf_ui from the module.json structure and
properly bundle+minify the CSS resources.

R=jacktfranklin@chromium.org

Bug: 1190991, 1127902
Change-Id: I7523333e8025ae5fe5ed74b99b4e45907ff9ad97
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3275787
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-11-12 15:25:03 +00:00
Tim van der Lippe 9d79e55bd8 Remove entrypoints/main/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I5d752140d5ce265b087f166ba8b0015cb2872dbb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264208
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-08 11:17:38 +00:00
Tim van der Lippe 2247144f3c Remove panels/protocol_monitor/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I9b1cf01957407265566a8236bd9ab4c3f6535100
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253023
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-03 14:24:51 +00:00
Tim van der Lippe a91f92e8cf Remove panels/sources/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Ib867035055da48bb0e6e4d1044fcd31221adabde
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253022
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-03 13:52:43 +00:00
Tim van der Lippe 196d154fae Remove panels/coverage/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Ib039b4d84796aad290fe87484b6d54504e192346
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253020
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-02 15:02:50 +00:00
Tim van der Lippe f8b49324ba Remove panels/console/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I18b832b9b2a00e06fe9c93e24a21dfa39df23b43
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253019
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-02 12:47:16 +00:00
Tim van der Lippe ae9e00a5c3 Make both text_editor and source_frame autostart
These modules contain CSS files that are about to be (partially)
removed with the CodeMirror 6 upgrade. To avoid merge conflicts and
breakages, let's make them autostart for now. This allows us to
clean up and remove numerous other module.json files, which were
blocked on just these two. In a future Chrome release, we will
remove the legacy text_editor altogether, at which we can remove
all these files.

R=szuend@chromium.org

Bug: 1127902
Change-Id: Ib44927067931f40a0212f4e0209815d736025000
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253018
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
2021-11-02 07:23:42 +00:00
Tim van der Lippe 105f14cabc Remove panels/event_listeners/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Iea91581b6e57d196943c8f4b801c18699c87174d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252965
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
2021-10-29 12:05:14 +00:00
Tim van der Lippe 0f53a91595 Reland "Remove ui/legacy/components/color_picker/module.json"
This reverts commit 04e525377a.

Reason for revert: CL was unlikely the culprit.

Original change's description:
> Revert "Remove ui/legacy/components/color_picker/module.json"
>
> This reverts commit 416944ab56.
>
> Reason for revert: failing CI
>
> Original change's description:
> > Remove ui/legacy/components/color_picker/module.json
> >
> > R=​szuend@chromium.org
> >
> > Bug: 1190991, 1127902
> > Change-Id: Idf344c4c49ae1486313cfe73248b3e0490aab431
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250786
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> Bug: 1190991, 1127902
> Change-Id: I85a882ba79f31582cd47d4ead3edfefce2a1e7d5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252950
> Auto-Submit: Maksim Sadym <sadym@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Maksim Sadym <sadym@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>

Bug: 1190991, 1127902
Change-Id: Idb52d139f6505ae2e780ddaa7b10a59e80ecf43a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252963
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Maksim Sadym <sadym@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Maksim Sadym <sadym@chromium.org>
2021-10-29 11:01:32 +00:00
Tim van der Lippe cab72e5e68 Remove ui/legacy/components/inline_editor/module.json
R=szuend@chromium.org

Bug: 1190991, 1127902
Change-Id: I3602e2681847567580a193725f4e3b349d94a3ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250789
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-29 10:21:33 +00:00
Maksim Sadym 04e525377a Revert "Remove ui/legacy/components/color_picker/module.json"
This reverts commit 416944ab56.

Reason for revert: failing CI

Original change's description:
> Remove ui/legacy/components/color_picker/module.json
>
> R=​szuend@chromium.org
>
> Bug: 1190991, 1127902
> Change-Id: Idf344c4c49ae1486313cfe73248b3e0490aab431
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250786
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

Bug: 1190991, 1127902
Change-Id: I85a882ba79f31582cd47d4ead3edfefce2a1e7d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252950
Auto-Submit: Maksim Sadym <sadym@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Maksim Sadym <sadym@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2021-10-29 09:21:00 +00:00
Tim van der Lippe 416944ab56 Remove ui/legacy/components/color_picker/module.json
R=szuend@chromium.org

Bug: 1190991, 1127902
Change-Id: Idf344c4c49ae1486313cfe73248b3e0490aab431
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250786
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 14:40:36 +00:00
Tim van der Lippe cb1605f3eb Remove panels/console_counters/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I695980f897678ce846c2053bf6dc64997108df32
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250782
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 11:40:46 +00:00
Tim van der Lippe b3f9132666 Remove panels/input/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Id2426975d86026b35fa5949806158eda08b8dc08
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250780
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 11:36:56 +00:00
Tim van der Lippe 9667b4fe60 Remove panels/settings/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Ida10bb785b347699946725ddcc4b113d6575eb9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3247444
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 10:45:56 +00:00
Tim van der Lippe ffaefd6c34 Remove panels/search/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I79d9a8361e1e67d8b36dff30e6b7d008b4b69985
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3247442
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
2021-10-27 17:27:55 +00:00
Tim van der Lippe 10b7ad2a85 Remove ui/legacy/components/object_ui/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I5219ea30cf74a0c0dbe4b912cf394c6fb3e85c8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3242146
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-26 13:30:38 +00:00
Tim van der Lippe 395be8fe64 Remove ui/legacy/components/data_grid/module.json
R=szuend@chromium.org

Bug: 1190991, 1127902
Change-Id: I64c80db0fcd141ee18e8e6622e0835ef71793ee2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3242142
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-26 11:03:15 +00:00
Tim van der Lippe 89bdd334ff Remove panels/changes/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I00d8c81058e00aa86324dc27914742744d0804bc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240947
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-25 16:22:29 +00:00
Tim van der Lippe 09e01456d9 Remove panels/snippets/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I7a8ac1e990749e2b38995648cc11bfc1611fbcbc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240946
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-25 15:52:14 +00:00
Tim van der Lippe 381b71fb73 Remove ui/legacy/components/quick_open/module.json
R=szuend@chromium.org

Bug: 1127902, 1190991
Change-Id: Ie9cf2843e8bb523028e863c99b7b92c4c479abba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240945
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-10-25 15:40:19 +00:00
Tim van der Lippe 123aa0f84c Remove ui/legacy/components/utils/module.json
This also includes the refactoring to use adoptedStylesheet
in JSPresentationUtils.ts.

R=jacktfranklin@chromium.org
CC=kritisapra@google.com

Bug: 1106746, 1127902
Change-Id: I93a8009e1c950f7fe2aa4d4d7075cc58abfcbd19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3145218
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-09-09 11:35:48 +00:00
Tim van der Lippe b353e31242 Remove models/persistence/module.json
R=jacktfranklin@chromium.org
CC=kritisapra@google.com

Bug: 1127902
Change-Id: I3d25122ebf28a0426190bfc7384830aee3cf32e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3145215
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-09-08 11:23:05 +00:00
Tim van der Lippe effef52092 Remove models/workspace_diff/module.json
R=jacktfranklin@chromium.org
CC=kritisapra@google.com

Bug: 1127902
Change-Id: I913d29863b93d720d3f7a2ba80afd27f3c0981fc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3145214
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-09-08 10:54:52 +00:00
Tim van der Lippe 528987f049 Remove models/extensions/module.json
All existing usages now load ui/legacy/components/utils.

R=jacktfranklin@chromium.org
CC=kritisapra@google.com

Bug: 1127902
Change-Id: I0403bffffebed36ed85c708d5c9e9b2d0030aec3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3145212
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-09-07 14:05:46 +00:00
Tim van der Lippe 727227900c Dynamically optimize svgs
Currently, we optimize our SVGs out-of-sync and have a Python
script and PRESUBMIT check to make sure that the SVGs are correctly
optimized. This means that the SVGs are duplicated in the Images
folder and requires developers to install `svgo` on their command
line, which could be using differing versions.

Instead, we can optimize the SVG images (which is computationally
cheap) during build time using the rollup-plugin-import-meta-assets
and svgo packages. The rollup plugin traverses the required SVG
image files and puts them and rewrites them to the Images/ folder
(rather than in src/), while also allowing us to optimize them
along the way.

DISABLE_THIRD_PARTY_CHECK=Removing script from package.json
R=jacktfranklin@chromium.org

Bug: 1216402
Change-Id: Ieb6932b9a81753be5ecbccd00a5d84bd0efa23f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2939994
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-06-10 10:09:30 +00:00
Tim van der Lippe 6892da0014 Add GN visibility to entrypoints
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I5ff52856d177529c26655e79f1fa5db96fa06196
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2856775
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-29 08:54:21 +00:00
Tim van der Lippe 2211a5f79e Remove unused legacy files
All of the symbols declared in these legacy files are no longer used
by the legacy layout tests.

R=alexrudenko@chromium.org

Bug: 1174013
Change-Id: I8e040047e0f6044d1fd3e4e3eacf9b5b0ce0391c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2848223
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2021-04-23 13:23:18 +00:00
Tim van der Lippe e083e41023 Move cm/codemirror.css to third_party/codemirror
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I29f75e79fe47b5c4c21cee7fd1ae04b444d36954
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2843312
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-21 13:46:45 +00:00
Tim van der Lippe 339ad2698a Move components to ui/legacy/components/utils
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ib55515e9a436e21c4b1e7a014a95220b46021136
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2843311
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-21 13:42:05 +00:00
Tim van der Lippe 4c592ddd16 Move workspace_diff to models/workspace_diff
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I38bb15a1df8652f86e10737528c3f7b48457ff0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831984
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-20 14:37:25 +00:00
Tim van der Lippe 48f46804a1 Move main to entrypoints/main
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I4c22f094bcf91f13a71c04fb8ea0b4b5b0489d98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831980
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-20 09:16:53 +00:00
Tim van der Lippe 945c4b77aa Move settings to panels/settings
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I8398fe6f219d26ba799cc6d5154f8807f2e521b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831972
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-19 12:59:09 +00:00
Tim van der Lippe eb75111549 Move snippets to panels/snippets
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I5c9c27398f331fb853eabfe6c278ddc4cc306034
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831971
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-19 12:49:39 +00:00
Tim van der Lippe 021c75731a Move sources to panels/sources
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I9a783dc6a0f359d75cb3b3354cc2c804ea629969
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831450
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-19 11:35:31 +00:00
Sigurd Schneider 7670c3304e Move LogManager to models/logs
This removes the browser_sdk/ library. In a follow-up, I want to move
NetworkLog to models/logs as well, but this is currently blocked on
tests in chromium.

Bug: chromium:1199668
Change-Id: Ibc263b6536f84c82499b68837177b112def2f359
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831446
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-04-16 14:47:35 +00:00
Tim van der Lippe ded8282ae3 Move quick_open to ui/legacy/components/quick_open
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ia923d20bdfbe8452ae0d292cff51ddb2ab895587
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828292
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-16 13:53:15 +00:00
Tim van der Lippe dbb97be22a Move startup to entrypoints/startup
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: If71a7d4eeda376e240fe7b1e12f94c853b3cba53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828129
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-15 16:45:15 +00:00
Tim van der Lippe 22cf52b9f5 Move search to panels/search
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I158380494ded60f533c554a948dcfb11acff1bfb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828127
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-15 16:17:45 +00:00