zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-11 06:04:55 +08:00
Code Issues Packages Projects Releases Wiki Activity
4,889 Commits 45 Branches 79 Tags
bfa40d4e91ced7805cd4f74201b7624764fa9aba
Commit Graph
4889 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Tim van der Lippe bfa40d4e91 [globals] General cleanup 
Some issues I found scattered around the codebase that should have been
cleaned up in the previous CLs, but were left behind.

R=jacktfranklin@chromium.org

Bug: 1058320
Change-Id: Ic2709b35fc5f81087aafe226b0e9e31b28a82abf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2398825
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-09 07:53:21 +00:00
devtools-ci-autoroll-builder b7a88f49d2 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I3ebdfca426f4b59cc25107d5a72cbfba3afe3250
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2399668
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-09 06:34:18 +00:00
Alex Rudenko c8ded2e768 Move inspector overlay unit tests 
Change-Id: I2c6fe5cda57feb1213461f87ddd1a72b00665472
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2396135
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-09 06:26:18 +00:00
Alex Rudenko ca9078f199 Move unittests karma config out of the frontend folder 
Change-Id: I06e28e5a9afbbf7daa569a9b699c60e4554ed5a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2395404
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-09 06:02:48 +00:00
devtools-ci-autoroll-builder 023c3cd685 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/e4867e8..9c1d422

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9218ba2..fb6d901

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: If82b9d8dc920a2640b26fb026b21caae9f832296
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2399665
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-09 03:22:18 +00:00
Paul Lewis a67d868f6c Adds Puppeteer support to frontend 
This CL adds Puppeteer as frontend dependency. There are no call sites
that use this, and in this first CL only the Puppeteer Connection class
is exposed for use. As Puppeteer is agnostified to its environment, more
of it can be made available for use within the DevTools frontend
codebase.

Bug: 1107392
Change-Id: Ie29907af389eddb2e3a7bd260b64237529a9aeba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2354098
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 19:22:45 +00:00
Paul Lewis 2b9224ffd9 Bypass third_party files when linting in presubmit 
The presubmit sends a list of files that have changed to the linter. It
doesn't, however, remove files in front_end/third_party from that list.
This CL filters third_party files from that list.

TBR=yangguo@chromium.org

Change-Id: Idca43c882cc7e0fec26112ad2f499b292d634d32
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2398830
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
 2020-09-08 19:18:05 +00:00
Paul Lewis 0cf22e5ad8 [loc] Escape paths correctly 
The localization_utils check a list of excluded directories against the
subdirectories of front_end. However, the list of directories hardcoded
the / separator, which is incorrect on Windows. This led to localization
checks in third_party subdirectories, causing build breakages and
performance regressions. This CL updates the paths to use the node
path.sep value, which in turn means that the string matching works on all\
platforms.

R=tvanderlippe@chromium.org

Change-Id: I5e1f2400b3f331ff4ac7acf953042b2ad900d40b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2398827
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-08 16:42:39 +00:00
Tim van der Lippe 4b505928d5 Update CodeMirror to 5.57.0 
This required updating the FormatterWorker.js to use the proper version
of the StringStream constructor. Otherwise, pretty-printing files would
throw an error, as the first argument wasn't a string but an array.

R=bmeurer@chromium.org

Fixed: 1109347
Change-Id: I56524a92227eaf73cc3dc40d9fe8638b792fafb0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2398824
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-08 16:04:39 +00:00
Jack Franklin 0d6a124f0b Update lit-html to 1.3.0 
Changelog is here: https://github.com/Polymer/lit-html/blob/master/CHANGELOG.md

No breaking changes or large changes to cause concern, but we'd like to use the new `live` directive that was added.

Change-Id: I0d86084dd1d7b6478888d30e0d90354793aa597e
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2397871
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-08 15:45:14 +00:00
Tim van der Lippe cac65d4fa0 Remove skip_rollup 
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-08 15:44:09 +00:00
Tim van der Lippe 9c9fb12c56 [globals] self.UI.shortcutRegistry 
R=aerotwist@chromium.org

Bug: 1058320
Change-Id: I962f9a795b8e5ce12d00d35710ec92d3c3d424a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391227
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 15:41:19 +00:00
Tim van der Lippe cc37f9b04b [globals] self.Persistence.persistence 
R=aerotwist@chromium.org

Bug: 1058320
Change-Id: I04e6fca49686bf445489719cad1b7bdfa16cc890
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391246
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 15:01:39 +00:00
Tim van der Lippe 23d36b408b [globals] self.UI.shortcutsScreen 
R=aerotwist@chromium.org

Bug: 1058320
Change-Id: Ia363d9f232f249b7d58d55e3b268c5d158d265c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391249
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 14:55:39 +00:00
Andres Olivares 30a60c8869 [ts] Typecheck css_overview/CSSOverviewController.js with TypeScript 
Bug: chromium:1011811
Change-Id: I6dfe7eb704943e0ff267f54fef01a66b7ba7a9b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2394593
Auto-Submit: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-08 14:53:29 +00:00
devtools-ci-autoroll-builder 7e3252b443 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/2dc8141..e4867e8

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I003eb623334226189032d7864b5860c218a33403
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2398213
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-08 13:18:49 +00:00
Tim van der Lippe 321dcca8b2 [globals] self.SDK.domDebuggerManager 
R=aerotwist@chromium.org

Bug: 1058320
Change-Id: I523b32d769c6e240ce678e6657a66cd54e2c4c8d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391244
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 13:17:19 +00:00
Tim van der Lippe d5de9a0d88 [globals] self.SDK.isolateManager 
R=aerotwist@chromium.org

Bug: 1058320
Change-Id: Id455a3c9e5c9a9f220f7a933279196dc5e66f2cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391250
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 13:04:19 +00:00
Tim van der Lippe b2541af131 [globals] self.SDK.domModelUndoStack 
Seems like this one was already cleaned up in
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2218011
with this reference missing.

R=aerotwist@chromium.org

Bug: 1058320
Change-Id: I07af486ba9685bf868a85808a0a494a3bb92d220
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391251
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 12:58:09 +00:00
Tim van der Lippe e9eaf5ce5d [globals] self.UI.dockController 
R=aerotwist@chromium.org

Bug: 1058320
Change-Id: I35c14444a2f62ad91ae3b96e8be895f78c64a7e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391226
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 12:16:39 +00:00
Alex Rudenko 0e8d7f4c64 Move inspector_overlay to the top level 
This CL moves inspector_overlay out of the front_end folder.
Unit tests remain under the front_end for now as we need to see
how to move them (they rely on karma config and helpers).

Design doc: https://docs.google.com/document/d/1yuQoNPtH2KxSFKoz3bRrQKu9wrPUjW4hx7idzAxb_B4/edit

Bug: 1100925
Change-Id: I0da88d9aae33602572d11485a3cbb46b5e3d588f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2395397
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-09-08 10:38:09 +00:00
Peter Marshall d7e4614b54 Avoid layout shift when rendering pie charts 
Either provide the initial size before inserting the pie chart into the
DOM or move the DOM insertion to after we set .data so that we always
have the final size when inserted into the DOM.

Fixed: 1125929
Change-Id: I0c2ce0c8882a2f083c7b48556741c65fc36b2ada
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2397869
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 08:50:29 +00:00
Sigurd Schneider dffda9321b Don't override background of tabbed-pane-header-tab 
This ensures the current tab in the Settings (and possibly
other places) is correctly highlighted in dark mode, and
introduces highlighting in light mode as well.

Screenshot: https://imgur.com/a/TAKyIJK
Bug: chromium:1125940, chromium:1122511
Change-Id: I9a792d0772460e4e325bbf124b2db0556c242db2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2397870
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-09-08 08:48:09 +00:00
Changhao Han 91fd72f945 Add style-map directive from lit-html 
I have an upcoming component CL that relies on style-map, hence I'm
creating this separate CL to include style-map directive first.

Change-Id: Iade3c276f12fb984786271ec5c7f1803c7608ce7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2396144
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 08:32:59 +00:00
Julian Geppert f8ce40c16f Add filter for full request url in network tab 
This CL adds a new url: filter to the network tab that filters
on the full URL, including the protocol information (e.g. https://)
in the search query.

Note on default filtering: Originally this CL modified the default
filtering by using the full request url, instead of the current
implementation which relies on the request path and name. Since this
change might have confused power-users and a more thorough rework
of the filtering is planned, the decision was made to add an additional
url: filter instead.

Bug: 1104188
Change-Id: Ibddd26eca7fb56eb9d08277df72c0da3acbb53a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2318146
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-09-08 08:29:19 +00:00
devtools-ci-autoroll-builder 645d2252d8 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Idbd8772cedbf079efa39a5cccc9e27fc473c0637
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2397145
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-08 06:22:59 +00:00
Christy Chen 5422981b71 [network] Fix Null Pointer Exception with data grid createCells 
This CL guard against the null cases of this.dataGrid which is an optional (nullable) property, and will not try to create new cells.

During some occurrences of the Network Data Grid refresh, there may be
a race condition where this.dataGrid is set to null as mentioned in this CL https://chromium-review.googlesource.com/c/devtools/devtools-frontend/%2B/1978966

Change-Id: Iec20024fe057f5085382c0fdf7cb41b031d45c58
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2393462
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-09-08 04:31:29 +00:00
devtools-ci-autoroll-builder cafd6b6578 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/4b6f7d1..2dc8141

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I2544ffe997fd6b750cd756fe5cbd1f50d7ed968e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2397140
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-08 03:23:09 +00:00
Philip Pfaffe 0c069f3956 Tidy up the debugger language plugins test case 
A little bit of cleanup:
- Remove most uses of any. Two remain where I didn't find an
  alternative.
- Add typedefs for the plugin interface
- I couldn't manage to factor out the common plugin definitions in a way
  that made the plugins acutally easier to use or write, but I simplified
  them a little.

Drive-By: AsyncScope-ify a helper in sources-helpers.

Change-Id: I92cd1ce21aaec0629ea60534246d33a2ecd380e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2374215
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-07 17:17:48 +00:00
Philip Pfaffe e687f6142d [wasm-debug] Show variable values on mouse over 
The code editor is able to tokenize the C++ code and can identify
variables just as for JavaScript. Given a variable name, we search the
paused call stack's source scope view if it contains a variable of that
name.

Bug: chromium:1113215
Change-Id: I0bafec3eae32821f4914e9f6c6fc8d0ec8c24243
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2339318
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2020-09-07 15:09:28 +00:00
Patrick Brosset dc2787706c Console: Fix copying content when selection reaches un-rendered items 
In bug 1115011 I made a change to the console whereby when the user
tries to copy content, we check if one of the selected message is a
table.
Unfortunately, the way I did this was by iterating over the
_renderedItems array, using the text selection as start and end indices.
The problem is  the _renderedItems array only contains the subset of
items that are rendered, and the selection may span more than this
subset.

This is causing "Cannot read property 'consoleMessage' of undefined"
exceptions and preventing users from copying altogether.

In this change, I made use of the _providerElement function instead.

Bug: 1115011
Change-Id: I10f9d55a6d6cdb4a15d7810f9a48ec694256068c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2393463
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-09-07 14:00:58 +00:00
devtools-ci-autoroll-builder 4e3a68fcd2 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/fc95b89..4b6f7d1

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a070dd1..9218ba2

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: If07684b510523fbee5f2e8785caabee25275e842
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2396036
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-07 12:23:18 +00:00
Alex Rudenko 9ba4f99238 Add typechecks for InplaceEditor 
Change-Id: Ic65d07963a9635200513164ab23dea97f0bc1cf0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2395402
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-09-07 12:07:49 +00:00
Andres Olivares 1e6d9c6358 [ts] Typecheck css_overview/CSSOverviewModel.js with TypeScript 
Bug: chromium:1011811
Change-Id: I7bb1096c6a4e4969f3a849873982c7b66600ff97
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2390572
Auto-Submit: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-07 10:21:09 +00:00
Changhao Han c1817b2ea7 TypeScriptify ComputedStyleWidget.js 
Bug: chromium:1011811
Change-Id: I97ce494e32afd04600b838c1e0c9d897f8bca8bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2395398
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-07 09:24:38 +00:00
devtools-ci-autoroll-builder 49a60520d0 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I64eaa650bf41fc4fc0222fa92440522b7f593aab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2394863
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-07 06:31:38 +00:00
Simon Zünd ca6b6027b4 [ts] Type-check sdk/CSSRule.js with TypeScript 
R=tvanderlippe@chromium.org

Bug: chromium:1011811
Change-Id: I649f35fe26371d592c02edd30c1fca53fc63ffea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2388385
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-09-07 06:22:28 +00:00
devtools-ci-autoroll-builder 9de988b61c Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/2b8377b..fc95b89

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I9a0dbd2f8d6ecdf8c5d38260098bcb2d3faf4b91
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2394856
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-07 03:32:58 +00:00
devtools-ci-autoroll-builder c8f4177cf4 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ifd2f6c6b21a24f7e04378b7ef862c0d3dfcebb42
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2394352
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-06 06:30:56 +00:00
devtools-ci-autoroll-builder fe00a9e9cf Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I97dd7c36935fdc726a762862d05a3211ca5243e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2394139
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-05 06:30:35 +00:00
devtools-ci-autoroll-builder 87fb11b83d Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/a9ca728..2b8377b

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5dba9c9..a070dd1

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ie609a8b8d15f57e24874c29e7cf6e4feaf160733
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2393888
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-05 03:27:22 +00:00
Patrick Brosset 77ed48ad21 Grid: New histogram to track how many grids users highlight in the page 
There is a backend part to this change:
https://chromium-review.googlesource.com/c/chromium/src/+/2379254/

The goal is to track how many grids people highlight in web pages using either
the adorner in the Elements tree, or the checkboxes in the Layout panel.

The histogram is done in a way where we track when users highlight 0, 1, 2, 3, 4
grids, and then between 5 and 9, 10 and 19, 20 and 49, and more than 50.
We have more granularity at the bottom end of the spectrum as the expectation is
that users will mostly highlight few grids at a time.

Bug: 1047356
Change-Id: If3a5282d3909e85ba73b96714fae1d4e2bc9ba36
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2379098
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-09-04 08:48:52 +00:00
devtools-ci-autoroll-builder a6842d3aa4 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I0a937ffb920d5759c1f2428d07b76d96383d5a55
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2393347
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-04 06:23:02 +00:00
Christy Chen 23909d8cfc [Loc] Presubmit performance improvement 
The current Loc presubmit are doing two checks: check_localizable_resources and check_localizability
(Details of what they are checking: https://docs.google.com/document/d/1L6TkT2-42MMQ72ZSBMFwUaq7M6mDgA2X0x8oHHKaV_U/edit#heading=h.w1no7qaa0mi0)

This CL merge two checks into one single check. check_localizability are modified into a utils file, and check_localizable_resources will also run those localizability checks when the files are visited. By doing this, we avoid the extra call to node during presubmit, and all files and nodes will only be visited once.

Also adding these fixes
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2370103
Fix:
- Pass the fullpath for comparison.(itemPath)
- Normalize comparison between paths
- using native fs.promises instead of promisify (https://github.com/nodejs/node/pull/26581)

Bug: 1116989
Change-Id: I054040d83a65b5f798a21c040096422e287bc799
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2381320
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-09-04 05:07:07 +00:00
devtools-ci-autoroll-builder bef95be956 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/62caf80..a9ca728

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d9c616f..5dba9c9

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Icff072879dc8fd18a2beabbf9800a3bfeef3fe36
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2393340
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-04 03:23:37 +00:00
Changhao Han 66d4faca55 Refactor away externally adding property onto imported object 
This is to prepare for ComputedStyleWidget.js's TypeScript check. This
CL removes the behavior that adds an internal property `_propertySymbol`
to an imported definition: UI.TreeOutline.TreeElement. This field
cannot and shouldn't be registered in TreeElement's definition, and
removing it will make TS-check much easier.

Change-Id: I4ac5018e145e6ca4c0c9aa5f59585840d290f31f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391252
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-09-03 20:49:47 +00:00
Rob Paveza d86bb47552 We received feedback that "Learn more" was insufficiently descriptive 
for users relying on screen readers to understand the context about it.
This change makes it explicit.

After: https://imgur.com/a/0q7f68i

Bug: 963183
Change-Id: I0431cea94e5162ddd598550cbc58ac9a530765f6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2392858
Reviewed-by: Brian Cui <brcui@microsoft.com>
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-09-03 18:53:57 +00:00
Patrick Brosset 436d8ac8c5 Don't make NodeText a block element to apply ellipsis in Layout panel 
In bug 1109177 I cleaned up the display of nodes listed in the Layout
panel by making them not wrap, and have an ellipsis when they were too
long.
This caused a visual regression in the breadcrumbs of the Elements tree.
The nodes there use the same component and they were affected by my
CSS change.
Namely, the focus outline became taller and got cropped.

In this change, I'm just reverting the change of CSS to NodeText.
Instead, I'm moving this to the layoutPane.css, so it now only applies
to nodes in the Layout pane, and not the breadcrumbs anymore.

Before: https://imgur.com/CTGA6SO.jpg
After: https://imgur.com/sFfUQLk.jpg

Bug: 1124250
Change-Id: I9433cf0187be17a0044766472236470bb1be4b79
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2389035
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Michael Liao <michael.liao@microsoft.com>
 2020-09-03 17:25:07 +00:00
Kateryna Prokopenko b0a518212b Add sources panel link e2e test for Issues tab 
Check that a correct line is highlighted in Sources panel when a link is clicked in affected resources of an issue

Bug: chromium:1124712
Change-Id: Ia5af7bc8d9fe9e463b8b7ec88f38727f7862e23c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391243
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-09-03 16:12:17 +00:00
Wolfgang Beyer ed9c15fc40 Reland of "Fix context menu for issues banner" 
Reland fixes e2e-test for MacOS

Original CL: https://crrev.com/c/2382862
Revert: https://crrev.com/c/2391248

Bug: chromium:1123455
Change-Id: If827a8656f2e09b90f7d9f5b84719beac466aa82
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391228
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-09-03 13:38:21 +00:00