zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-12 17:45:49 +08:00
Code Issues Packages Projects Releases Wiki Activity
4,889 Commits 45 Branches 79 Tags
bfa40d4e91ced7805cd4f74201b7624764fa9aba
Commit Graph
44 Commits
Author SHA1 Message Date
Tim van der Lippe 9c9fb12c56 [globals] self.UI.shortcutRegistry 
R=aerotwist@chromium.org

Bug: 1058320
Change-Id: I962f9a795b8e5ce12d00d35710ec92d3c3d424a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391227
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 15:41:19 +00:00
Christy Chen 13a12ff3de Fix background services recording button tooltip not updating 
When hitting the record button, the tooltip did not get updated from "start recording" to "stop recording"
https://imgur.com/a/KhHFT3k
This is due to that there are multiple views sharing a same action, so we can't toggle the action to change the tooltip like the ones in other tools (related change https://chromium-review.googlesource.com/c/chromium/src/+/1609707)

This CL update the button tooltip whenever the button is clicked
https://imgur.com/a/vyguTDV

Bug: 1117410
Change-Id: I53e71ce7f58ea94c04315027dcf63ec3a21538b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2362528
Reviewed-by: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Tony Ross <tross@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-08-21 03:05:45 +00:00
Tim van der Lippe 177c0b260b [globals] UI.ActionRegistry 
R=jacktfranklin@chromium.org

Bug: 1058320
Change-Id: I86fdc670c6667f37bfced2d9068106ec553d2210
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2364370
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-08-19 15:24:18 +00:00
Jan Scheffler 52b1f359a3 Migrate front_end/resources to devtools_entrypoint 
R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: I2a3e04996defaad7f77741f7e3fe985f283a4e61
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332225
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
 2020-07-31 15:14:20 +00:00
Simon Zünd 2c704cdc72 [cleanup] Move Date#toISO8601Compact to DateUtilities 
R=jacktfranklin@chromium.org

Bug: chromium:1050549
Change-Id: I445d6d0670ecfc2efa6ecae350b3bc48c1ddce96
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2228524
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-06-04 10:30:01 +00:00
Tim van der Lippe f49e23286b Replace single class invocations of createElementWithClass 
This applies the following replacement to the codebase:

(\S+) = createElementWithClass\('(\w+)', '([^'\s]+)'\);

to

$1 = document.createElement('$2');\n$1.classList.add('$3');

R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1011811, 1077215
Change-Id: I0d76b39f1ed8cd4a44f18f94e398db934ba4b09c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2176112
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-05-01 16:54:52 +00:00
Jack Lynch b8fb3c793d Centralize shortcut titles 
There are a few parts of the UI that assume that shortcuts will only be
one key (e.g. the shortcut tooltips displayed for some buttons), so this
CL updates them to access a new KeyboardShortcut.title() method to get
the name of a shortcut rather than just getting the name of a single
keypress from its Descriptor. The current/legacy Shortcuts settings tab
was one of these places, but I left it alone because it will be
obsoleted by the new custom shortcuts tab in the future and in the
meantime the only users who will have any chords enabled in the DevTools
will be those who have opted in to the custom shortcuts experiment and
enabled VS Code shortcuts.

Custom shortcuts doc: https://docs.google.com/document/d/1oOPSWPxCHvMoBZ0Fw9jwFZt6gP4lrsrsl8DEAp-Hy7o/edit#

Bug: 174309
Change-Id: Ic56fb14129a417ed441fc46401af226db52c8905
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2158086
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-04-21 20:35:58 +00:00
Tim van der Lippe 37a35fff86 Reland "Typecheck Object.js" 
This reverts commit f996a1c537.

Reason for revert: Fixed incorrect refactoring in this CL.

Original change's description:
> Revert "Typecheck Object.js"
>
> This reverts commit 258665aca5.
>
> Reason for revert: Suspected of breaking the roll (https://crrev.com/c/2083712)
> Bot failure: https://ci.chromium.org/p/chromium/builders/try/linux-rel/322462?
>
> Original change's description:
> > Typecheck Object.js
> >
> > To typecheck the file Object.js with Typescript I had to fix the type errors from all other classes
> > that were using addEventListener or removeEventListener incinsistently.
> >
> >
> >
> > Bug: 1011811
> > Change-Id: I2fccbbd07ef3d9a581baa34233580bc6a9dbbfc3
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2079794
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Jose Leal <joselea@microsoft.com>
>
> TBR=szuend@chromium.org,joselea@microsoft.com,tvanderlippe@chromium.org,jacktfranklin@chromium.org
>
> Change-Id: I30e3d75eee463362107d6e6ad25df2b7d50f9d54
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1011811
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081824
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: 1011811
Change-Id: I19ebbe0345a5c7380ed69d1ba2921adf0385228e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084580
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-03 14:09:44 +00:00
Simon Zünd f996a1c537 Revert "Typecheck Object.js" 
This reverts commit 258665aca5.

Reason for revert: Suspected of breaking the roll (https://crrev.com/c/2083712)
Bot failure: https://ci.chromium.org/p/chromium/builders/try/linux-rel/322462?

Original change's description:
> Typecheck Object.js
> 
> To typecheck the file Object.js with Typescript I had to fix the type errors from all other classes
> that were using addEventListener or removeEventListener incinsistently.
> 
> 
> 
> Bug: 1011811
> Change-Id: I2fccbbd07ef3d9a581baa34233580bc6a9dbbfc3
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2079794
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Jose Leal <joselea@microsoft.com>

TBR=szuend@chromium.org,joselea@microsoft.com,tvanderlippe@chromium.org,jacktfranklin@chromium.org

Change-Id: I30e3d75eee463362107d6e6ad25df2b7d50f9d54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011811
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081824
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-03-03 05:59:28 +00:00
Jose Leal Chapa 258665aca5 Typecheck Object.js 
To typecheck the file Object.js with Typescript I had to fix the type errors from all other classes
that were using addEventListener or removeEventListener incinsistently.



Bug: 1011811
Change-Id: I2fccbbd07ef3d9a581baa34233580bc6a9dbbfc3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2079794
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jose Leal <joselea@microsoft.com>
 2020-03-02 18:15:06 +00:00
Tim van der Lippe ff5ad47b82 Remove typedefs from {resources,sdk,search,security}-legacy.js 
Bug: 1006759
Change-Id: I1d04169013b54a4b78e9dfd1fa77ad97e49ca870
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2060006
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-18 15:20:16 +00:00
Tim van der Lippe 9a9aba8855 Remove typedefs from data_grid-legacy.js 
Bug: 1006759
Change-Id: I07c3fb9cc3840ffebd07c9dcd5dd2e3ab6ea006a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2057206
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-14 15:21:06 +00:00
Tim van der Lippe c02a97ca2c Fix imports for Common.Event typedef 
All references now use the fully qualified
"Common.EventTarget.EventTargetEvent". It renames it to
"EventTargetEvent" to prevent a name-clash with the native "Event" type.

Bug: 1006759
Change-Id: I13fcdfd613041da146d741a0d1f785bfc905a7a8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056481
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-14 15:21:06 +00:00
Tim van der Lippe 0efccf074b Migrate resources/ to import cross-module 
Bug: 1006759
Change-Id: I95a6b04dcbac41ca56036e0ff7ae70f74e9fa8e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2051994
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-12 16:07:52 +00:00
Rayan Kanso e9d4f6931b [BackgroundService] Show tooltip over other domains checkbox 
Bug: 1048978
Change-Id: I9594b0110fc4cb07ffbc6c2156fd697a57fbf750
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2038700
Auto-Submit: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-05 14:39:33 +00:00
Paul Lewis 05eb37fad0 [Global] Update refs to UI.shortcutRegistry 
Bug: 1006759
Change-Id: I7f5e50e80ec49429698737f79c555472c44fb68f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019549
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-24 15:34:35 +00:00
Paul Lewis 24cb740ff5 [Global] Update refs to UI.actionRegistry 
Bug: 1006759
Change-Id: I72e02ac9ec54c7d8a1edc8b3d4cb471dff7fde7c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019136
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-24 14:06:48 +00:00
Paul Lewis ddf58342e0 Migrates resources/ to ESM internally 
Bug: 1006759
Change-Id: I4176498edee62723421ce79639375f28a87bda0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002589
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-15 15:19:33 +00:00
Tim van der Lippe 472675db85 Migrate data_grid/ to ESM internally 
Bug: 1006759
Change-Id: Idb20304bcf3e72e4a0bba242e847e90ff9b8a8c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993342
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-09 15:04:51 +00:00
Tim van der Lippe 097cdecdfc Migrate resources/ to ESM 
Bug: 1006759
Change-Id: Idbbe06ab71b93bd2a2e2652f3ee4f5bd4b68f6ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985673
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-06 15:02:33 +00:00
Michael Liao 18769f2106 [Common - Data Grids]: bundling data grid parameters + Adding required name field for all data grids 
Issue:
- Data grids in DevTools do not have an aria-label
- There are a ton of DataGrid parameters and adding one is messy

Changes:
- Naming all data grids
- Created DataGrid.Datagrid.Parameters type to hold data grid parameters (including a required gridName field)

Bug: 963183
Change-Id: I83b130d468fb80034be264b45b86b799f650e978
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891652
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2019-12-12 19:12:26 +00:00
Tim van der Lippe 1d6e57a0e3 Always add braces to single-line if-statements 
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
 2019-09-30 11:55:34 +00:00
Rayan Kanso 42c0f9e54a [DevTools] Add a Learn More link to Background Service panes. 
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c40
Bug: 942174
Change-Id: I5d8b275671b78de6b96aa5f4704a2210bc1bd75f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760738
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#692458}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e61293ea18d25fb059dc474444cf704409ecc73a
 2019-09-02 12:21:09 +00:00
Rayan Kanso f402ef31c4 [DevTools] Add margin to Background Service inline button. 
On really small panels the button is covering part of the text. This CL
just adds some padding to avoid that from happening.

Bug: 990762
Change-Id: I52b292a8950ae01741cf3fa98b3ce1a9d40fa7a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736681
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#685966}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2aeeb644fd1ae34d6df21f6c36d0f53f22993cfb
 2019-08-12 13:05:18 +00:00
Rayan Kanso 5480967d95 [DevTools] Create a Background Service view for Periodic Sync 
Add a new material UI icon:
- https://material.io/tools/icons/?icon=schedule&style=baseline

The UI is hidden behind an experiment flag.

Screenshot:
- https://bugs.chromium.org/p/chromium/issues/detail?id=986437#c1

Bug: 986437
Change-Id: I744df74453e887e2ba61877b5e9e05ef2166add7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713505
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#680531}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 085effe8ebacd54e5e0c8c9c4e4a2f17b5a0c61c
 2019-07-24 18:40:28 +00:00
Rayan Kanso 4476ca576c [DevTools] Update Background Service UI strings. 
As per suggestions from UXW, make it clear that recording persists
and continues in the background.

Also make it clear when a metadata field is empty.

Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c34
Change-Id: Ief7b2dc23f00767fe4e87d37b652a4b0dbb1edd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708082
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#679514}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 02d9fc9da9c40566b18632473985d1d5d0fbc586
 2019-07-22 11:51:24 +00:00
Michael Liao (WPT) 8b0cac5360 DevTools: removing header 2 tag from EmptyWidget and BackgroundServiceView 
Reason:
- EmptyWidget elements should not be headers as they do not meet the criteria (https://www.w3.org/TR/WCAG20-TECHS/G141.html)
- Marking a non-header as a header will impede SR accessibility for the affected tools

Changes:
- Replacing <h2> tag from UI.EmptyWidget with <div>
- Removing <h2> tag from _showPreview(...) function with <div> in BackgroundServiceView.js (supposed to mimic UI.EmptyWidget element)
- Adding 'empty-bold-text' css in emptyWidget.css that mimics <h2> styling and adding the class to the <div> tags to retain h2 styling

Examples of UI.EmptyWidget use cases:
https://imgur.com/a/qpJeB2Y

BackgroundServiceView.js unique case:
https://imgur.com/cAW8Nu0

Change-Id: Iff3356f12b3dd1906141de4cfe9980b7b1d9c929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693808
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#678026}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 58d8c299b23fad86a6fe7e2b489f9cdded704011
 2019-07-16 23:19:40 +00:00
Joel Einbinder 346980e4b0 DevTools: Explicitly toggleable action buttons 
Before this patch, DevTools didn't distinguish between toggleable
actions and regular actions. When an action button was made, it was
always a toggle button. This worked because an untoggled button
and an untoggleable button are the same visually.

But for the accessibility tree, an untoggled button should have
aria-pressed=false, whereas an untogglable button should not have
aria-pressed at all. This means its important to distinguish
between toggleable and untoggleable actions.

This patch:
* Adds a new field to actions in module.json: toggleable.
* Dynamically returns the correct kind of button from createActionButton
* Refactors createLongPressActionButton into its own function.

Bug: 963183
Change-Id: Ie2ebbeab9d651b1823611d942bdc66e67ff293c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693175
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#677785}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92cb5705086497ab2c5e042265a18f7c3bb07ffc
 2019-07-16 15:35:48 +00:00
Rayan Kanso 8d7918af23 [DevTools] Add a Background Services view for the Payment API 
The new view is behind a flag.
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=980291#c3

Bug: 980291
Change-Id: I4c420c292a57796b7fc2042902be6661131fe5d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684995
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#674609}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4e07ff4d5a87dd7bdf8da9d64a1821faf0b436b3
 2019-07-03 21:03:38 +00:00
Rayan Kanso c79a8bb424 [DevTools] Fix Background Service metadata entry order. 
According to https://developers.google.com/protocol-buffers/docs/proto#maps
iteration ordering of map values is undefined. This CL sorts the
metadata entries before in the DevTools frontend so
they can be presented in a consistent order.

Also remove redundant test formatting, fix the OWNERS Background Service
regexp to include the handler, and make the row counting start from 1.

Change-Id: I36024f23fbb307b1160cd67120dcf67ca8697aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615251
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#664458}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8f2502b26e07d195dad80687b04b749406606eca
 2019-05-29 21:08:38 +00:00
Fergus Dall 0be4f4c13e Reland "[DevTools] Add Notifications & Push Messaging views." 
This reverts commit 7bfecf258f220ea375ffd376608d6ec71ca9d8ce.

Reason for revert: Revert my revert for breaking compilation

Original change's description:
> Revert "[DevTools] Add Notifications & Push Messaging views."
> 
> This reverts commit 793bf4990a4d8a6bffb0007e5f47f26e15791632.
> 
> Reason for revert: Guessing this is responsible for build failures on WebKit Mac10.13 (retina). See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/14445 for first failure.
> 
> Original change's description:
> > [DevTools] Add Notifications & Push Messaging views.
> > 
> > Add basic UI for Notifications & Push Messaging in Application >
> > Background Services.
> > One UI flag per feature is created.
> > 
> > TBR=caseq@chromium.org
> > 
> > Screenshot: crbug.com/942174#c28
> > Bug: 942174
> > Change-Id: Ifcdca9d3d78593968b0bd93d02d9dfea9419b822
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611612
> > Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> > Reviewed-by: Alexei Filippov <alph@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#661384}
> 
> TBR=alph@chromium.org,caseq@chromium.org,pfeldman@chromium.org,rayankans@chromium.org
> 
> Change-Id: I3ce9bf8bf06d4df371b8c2af2130b9d9dfce79d7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 942174
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621408
> Reviewed-by: Fergus Dall <sidereal@google.com>
> Commit-Queue: Fergus Dall <sidereal@google.com>
> Cr-Commit-Position: refs/heads/master@{#661533}

TBR=alph@chromium.org,caseq@chromium.org,pfeldman@chromium.org,rayankans@chromium.org,sidereal@google.com

Change-Id: I443ed2402908d9b43e68f5467281d7fdf2a89233
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 942174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621468
Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#661544}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4347761af471013bcb4e68b2cbf3f41cffa55814
 2019-05-21 00:01:29 +00:00
Fergus Dall 6c68f6dcd8 Revert "[DevTools] Add Notifications & Push Messaging views." 
This reverts commit 793bf4990a4d8a6bffb0007e5f47f26e15791632.

Reason for revert: Guessing this is responsible for build failures on WebKit Mac10.13 (retina). See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/14445 for first failure.

Original change's description:
> [DevTools] Add Notifications & Push Messaging views.
> 
> Add basic UI for Notifications & Push Messaging in Application >
> Background Services.
> One UI flag per feature is created.
> 
> TBR=caseq@chromium.org
> 
> Screenshot: crbug.com/942174#c28
> Bug: 942174
> Change-Id: Ifcdca9d3d78593968b0bd93d02d9dfea9419b822
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611612
> Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#661384}

TBR=alph@chromium.org,caseq@chromium.org,pfeldman@chromium.org,rayankans@chromium.org

Change-Id: I3ce9bf8bf06d4df371b8c2af2130b9d9dfce79d7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 942174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621408
Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#661533}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7bfecf258f220ea375ffd376608d6ec71ca9d8ce
 2019-05-20 23:48:30 +00:00
Rayan Kanso e5fe399940 [DevTools] Add Notifications & Push Messaging views. 
Add basic UI for Notifications & Push Messaging in Application >
Background Services.
One UI flag per feature is created.

TBR=caseq@chromium.org

Screenshot: crbug.com/942174#c28
Bug: 942174
Change-Id: Ifcdca9d3d78593968b0bd93d02d9dfea9419b822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611612
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#661384}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 793bf4990a4d8a6bffb0007e5f47f26e15791632
 2019-05-20 17:25:33 +00:00
Rayan Kanso 0b30abaa1c [DevTools] Fix Background Services shared record button state bug. 
Update the view's button instead of the action, since the action is
shared across multiple views.

Bug: 942174
Change-Id: I02c04486779591791b24567002bc14e08324babd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609707
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Auto-Submit: Rayan Kanso <rayankans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#660816}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9165cbfa52c9614f421e799c80bec21832004e81
 2019-05-17 13:39:59 +00:00
Rayan Kanso cc02ea37de [DevTools] Fix UI nits for Background Services. 
- Replace the SW Source column with SW Scope, as it is more informative.
- Add options to the record action, so that we can get Record/Stop
tooltips with the keyboard shortcut.

Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c25
Bug: 942174
Change-Id: I13251003051ba3c94f42f17a1f3edb2738036f71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591847
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#656191}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d9f19cad14f7421efe50f78d13dc122eea15e0e7
 2019-05-02 21:26:52 +00:00
Rayan Kanso 6156d22b16 [DevTools] dd a recording shortcut for Background Services. 
Map the Ctrl+E (or Cmd+E on Mac) to the recording functionality.
Also update the CSS to match that of other UI states.

Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c19

Bug: 942174
Change-Id: Ie3b0518022ca8e320bad6f939f9525595cd9889e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587884
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#655074}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1fea123688372477996125b02ecf2baa62447ee2
 2019-04-29 23:40:55 +00:00
Rayan Kanso c0bfdd861b [DevTools] Add more descriptive UI for state transitions. 
This CL incorporates some of the changes discussed in the latest UX meeting:
- Reorder the columns and toolbar buttons
- Display the metadata in a manner to a similar to the Network panel
- Add instructions for the inital landing page and other UI states

Bug: 942174
Change-Id: I7bd451377b241ec70d49c6d0b443522b43e5bcfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578554
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#653543}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7150235b5070ebb8d03e4b6f4dd4ae3650cab283
 2019-04-24 12:32:22 +00:00
Rayan Kanso b852ba8011 Add a Save button for Background Services in DevTools. 
The button is disabled if there are no events, and saves all events to a
file when clicked (JSON format).

Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c13
Bug: 942174
Change-Id: I2c2d3600814f19050083275f52acbe40e23b0e74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552854
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#648646}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 79d39f2bc7caea1fb114e8b79c66d91f7faece61
 2019-04-08 13:48:07 +00:00
Rayan Kanso b451b4f38e Update the DevTools Background Services UI. 
As per the UX meeting, the following changes have been made:
- Toolbar refresh/clear were removed and delete was renamed to clear.
- Instead of Popovers a container at the bottom will show the metadata.

Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c10
Bug: 942174
Change-Id: Ibb99ade117666367903c739ed5f3acee1f550c18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551661
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#647972}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cef97b945609619d937da359b0ccb36c0ef39494
 2019-04-04 23:12:11 +00:00
Rayan Kanso aca06e77d4 Add more functionality to the DevTools Background Services UI. 
Add an origin checkbox for filtering between events belonging to the
current origin or all origins.

Also replaces the Service Worker ID with the Service Worker source
(script name) to be more user-friendly.

Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c2

Bug: 942174, 927726
Change-Id: I5afb9929d1693d8c1faf0b166b671dddc8111d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526261
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644753}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a1c3a6e39a7a8f4641e08fb5318a8f14270940b1
 2019-03-27 11:57:06 +00:00
Rayan Kanso 3252d5e58b Add UI to show Background Service events in DevTools. 
Events are shown in a data grid. Clicking on a row will create a popover
to show metadata.

This CL also adds functionality for the refresh/clear buttons.

Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c1

Bug: 942174, 927726
Change-Id: Id6fc6dba7ddbc2e175992e76ffea3e29da947753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524290
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644745}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e728204c814742fb6fe33540619e0afc627a8d3a
 2019-03-27 11:37:24 +00:00
Rayan Kanso f40e315641 Add ability to clear logged background service events. 
Hook up the delete button, and make it clear all stored data for a
background service.

Also set up event listeners in the background services view.

Bug: 927726
Change-Id: I5475b3fb7c4653f6b83101bf79c1fc82f3026959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503460
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639473}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 23575eff5f5b3f5fd6c6a934d42f74874a9a8b28
 2019-03-11 13:49:43 +00:00
Rayan Kanso 8fe8ee2ff8 Create a protocol + handler for Background Service recording. 
- Create protocol for starting/stopping/querying recording mode
- Add handler which talks to the DevTools context
- Add a SDK model that the view communicates with
- flat_map -> array to avoid multi-thread access issues

Bug: 927726
Change-Id: I11e55a747c7c5c60465508485d6b869b976d40dd
Reviewed-on: https://chromium-review.googlesource.com/c/1477851
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#637287}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 31ad82ae99ed2a328d95fa6f73360a7c13561436
 2019-03-04 14:58:46 +00:00
Rayan Kanso 689042047c Setup Background Services DevTools UI. 
Sets up the side panel elements, and the view that will be used to
render the information. The view consists of the toolbar with the
buttons that will communicate with the DevTools protocol handlers.

This is just the UI without functionality.
UI mocks: https://bugs.chromium.org/p/chromium/issues/detail?id=927726#c6

Bug: 927726
Change-Id: I1d00ad98c481127e57054413db0ed0c298ab6546
Reviewed-on: https://chromium-review.googlesource.com/c/1477253
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#634174}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 955610c988beee8289ef73073de721da80c3fc48
 2019-02-21 14:16:25 +00:00