zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-11 14:14:36 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,097 Commits 45 Branches 79 Tags
c1912a4fbb17bc08e90bca109da7721cde84bc6e
Commit Graph
7097 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
devtools-ci-autoroll-builder c1912a4fbb Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/5e4c76e..83d82f4

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dabd965..13466d0

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ib54bdd79eefea541b0f0fec2e84daf1e90d07624
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2636603
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-19 03:29:46 +00:00
Andres Olivares f2a99e868d [module.json extensions] help views 
Bug: 1134103
Change-Id: I797fc82b277511f0aa11cb365c7dfd0f933b4ef4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629728
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 20:31:36 +00:00
Andres Olivares 4ce36a5a37 [module.json extensions] Wrap localizable fields in anonymous functions 
To be able to localize extensions' strings at declaration using the i18n
v2 model in meta files, we opt to wrap such fields in callbacks as the
i18n API cannot be invoked directly at declaration because it hasn't
been configured by the time the meta files are loaded.

Bug: 1134103
Change-Id: I432f3854f724b8c5b94993ce3ddd469f657c1014
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635820
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 19:04:06 +00:00
Andres Olivares 5135060ac7 [module.json extensions] issues views 
Bug: 1134103
Change-Id: I0a919093cf3463f248a50aaf3152c903928570af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630305
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 18:29:56 +00:00
Jan Scheffler b434291562 [JSDOC2TS]: Migrate animation 
Bug: chromium:1158760
Change-Id: I8750abb609adbd8b9f66cd70e180bbd25fb5ebeb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626302
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 17:42:46 +00:00
Jan Scheffler 72a05d8bb3 [JSDOC2TS]: Migrate event_listeners 
Bug: chromium:1158760
Change-Id: Id86aeb5f79ec9fced973d4eb74ccd9c2d20a97e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635667
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 17:18:56 +00:00
Jan Scheffler 394efde543 [JSDOC2TS]: Migrate layers 
Bug: chromium:1158760
Change-Id: I30ba04913a47ceb8d61da21e44459f1c8893dd10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631105
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 16:51:56 +00:00
Jack Franklin e6dcd249e6 Inject inspectorStyle.css into the component docs 
The interaction tests that have new values needed the change as the
inspectorStyle CSS changed the margins on the `body` element so some of the
tests had slightly different pixel values required when testing resizing.

Bug: chromium:1167724
Change-Id: I6569210264471f96040512e7f55158dec5c28bfd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635666
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 16:48:16 +00:00
Alex Rudenko 9c423651c0 UI to emulate the color-gamut media feature 
Screenshot: https://i.imgur.com/vnnqOHa.png

Doc: https://goo.gle/devtools-css-color
Backend CL: crrev.com/c/2632609
Fixed: chromium:1073887
Change-Id: I7c1c90ac94d394dc62938f301decb9a4589cdd39
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635664
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-01-18 16:05:46 +00:00
Jan Scheffler 9306b2bdd4 [JSDOC2TS]: Migrate coverage 
Bug: chromium:1158760
Change-Id: I08caa31931f201d4e6d7912304c4f60f3d274c61
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629552
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 15:42:26 +00:00
Jack Franklin 5afc7fed57 Lint inline CSS inside .ts components 
This CL introduces a new lint which runs CSS linting against our
TypeScript files, and changes the CSS to pass the linting.

Bug: chromium:1166108
Change-Id: Idb8dcf00d7c578f8db0e91633c89ae92ca85bcd8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635655
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2021-01-18 15:12:36 +00:00
Andres Olivares 49a36a120b [module.json extensions] resources views 
Bug: 1134103
Change-Id: Idb39a93006a87a885800b7e668e015fa7d65b37a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631962
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 14:39:26 +00:00
Alex Rudenko f572da65b8 Enable flexbox tooling experiment by default 
Fixed: chromium:1166710
Change-Id: Ieb2665733b2c9eace326df988a9a09c78eeb85ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631115
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-01-18 13:51:56 +00:00
Peter Marshall 913ec149dd [startup] Wait until settings are loaded to load locale data 
If we want to give users a setting to choose their locale, then we need
to wait until settings are available to load the locale data.

This CL reorders startup so that we load up settings/prefs first.
Also promisify prefs loading so that it's easier to follow ordering
in MainImpl.

Bug: 1167695
Change-Id: I0955e04a0b5f204c8784be2cad7e6b9fa5443b8b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635657
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2021-01-18 13:06:56 +00:00
devtools-ci-autoroll-builder b06ebb493f Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/43dd249..5e4c76e

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I6a95ac09312a0c5f2dc44f94e73a592a414f7f01
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635068
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-18 12:18:34 +00:00
Sigurd Schneider 7678bdd1a1 Extract issue text icon to svg file 
Bug: chromium:1098185
Change-Id: Ic951cbe01fcdfdddea251861ef5bddebcc14240f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631119
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-18 10:55:33 +00:00
Jan Scheffler 910b14985c [Recorder] Close opened targets 
Bug: chromium:1161512
Change-Id: I4e045fe9b4a3c37395f1201ef7bac9a80280e8ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631109
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2021-01-18 10:48:13 +00:00
Jack Franklin bc30234f61 Migrate run_lint_check_css to JS script 
As part of the work to move more scripts to Node, not Python, over time,
picked this one as the starting point. I changed its API slightly to
allow more flags to be taken in, as we'll need that to do a stylelint
pass against TypeScript files, but I will do that in a subsequent CL.

I had to make quite a few changes to devtools_paths.js, but I think it's
now calculating paths correctly. It took a bit of messing to get the
equivalent of Python's path.abspath(__file__), as you'll see from the
large comment that tries to explain what's going on!

Bug: chromium:1166108, chromium:1166572
Change-Id: Ia0b19ff8956b2ede2447530be57876a88046887e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631113
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 10:30:12 +00:00
Wolfgang Beyer 321f32e80c Use CSS grid for ReportView component 
This CL re-styles the new ReportView component to be based on CSS grid.
This removes the need to explicitly set a column width, since the first
column's width is now based on the widest cell's width.

Since grid styles apply only to direct descendants, `report-rows` have
been replaced by `report-key` and `report-value`.

Screenshot: (disregard font styling) https://i.imgur.com/LIaj1ft.png

Bug: chromium:1165710

Change-Id: Ibf2d02bcaccc1f471c80550311e2a95599231324
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626295
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-18 10:19:53 +00:00
Patrick Brosset 181045fd56 Adding component docs for MarkdowView and MarkdownImage 
This adds 2 basic component doc pages for these components so it's
easier for other people to see how they work.

Bug: 1154783
Change-Id: I23562ccaedc5e96f9c6b047dfe4a3104796a1668
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629450
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
 2021-01-18 10:07:22 +00:00
Jan Scheffler 403a40aa58 [JSDOC2TS]: Migrate developer_resources 
Bug: chromium:1158760
Change-Id: Idf4eb62db30617572d5b518b6cb596165454e02b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629553
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 09:59:12 +00:00
Jack Franklin 63fc645844 Add the DataGrid to the Protocol Monitor 
This CL adds the new DataGrid component to the ProtocolMonitor.

Bug: 1125968
Change-Id: I0b29b21a8419d217ff876eedc67b110ca9e4f2af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2532245
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-01-18 09:41:22 +00:00
Peter Marshall 5e5cb23c7e [overrides] Fix files showing up multiple times in folders 
Make sure we de-register for events when switching out the Workspace,
as we often do this as part of a general reset that actually keeps
the same workspace, meaning we end up registered multiple times
so we get multiple callbacks when files are added/removed.

Fixed: 1166654
Change-Id: I554694cbf36909f9b9f587b9b103dd1a78284d25
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629547
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-01-18 08:56:12 +00:00
Peter Marshall 9ef3c935b5 [overrides] Only delete confirmed overrides for 'Delete all overrides' 
Previously we deleted every file in the folder tree which was
causing people to accidentally delete all sorts of files they added by
mistake and not just overrides.

Bug: 1165300, 1143439
Change-Id: I6133606291210aab4304b82f84523296d98d44b4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626292
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-01-18 08:35:12 +00:00
Alex Rudenko a9f40de958 Round contrast ratio down 
Previously, the contrast ratio might have been rounded up (using
toFixed) giving confusing results. For example, the value 6.997
is below the threshold of 7.00, but it was shown as 7.00 and the
contrast value was still marked as insufficient.

Bug: chromium:1166128
Change-Id: I8e4539a3c8794e409606af5f211b341985078961
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631112
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-01-18 07:31:12 +00:00
devtools-ci-autoroll-builder 4cc12ef65f Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/3ecdb5e..43dd249

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ifa7f64c072b25cef8aea21ba8b74e855848100fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635286
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-18 03:31:42 +00:00
devtools-ci-autoroll-builder cb01823177 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/e3bf8c4..3ecdb5e

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/235cfe4..c38b5ab

Rolling buildtools/linux64: git_revision:595e3be7c8381d4eeefce62a63ec12bae9ce5140..git_revision:d62642c920e6a0d1756316d225a90fd6faa9e21e

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f79e432..dabd965

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Iafaadc044c979a3bf07b05365a03f546b6d1a7e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2634035
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-16 03:26:59 +00:00
Jan Scheffler ff5c7857d9 [JSDOC2TS]: Migrate cookie_table 
Bug: chromium:1158760
Change-Id: I560d063cc833b8f277c0b1b5d1ef16252a4dd5cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626306
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 19:47:29 +00:00
Jan Scheffler 86e4bd2600 [JSDOC2TS]: Migrate input 
Bug: chromium:1158760
Change-Id: I750a19ecfdfc7ca59929cb3d178f06b33d8b084d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630946
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 19:00:19 +00:00
Jan Scheffler 5bba5fdb77 [JSDOC2TS]: Migrate help 
Bug: chromium:1158760
Change-Id: Ie50704b20abd89450ecf5f0f7602826eb0225d3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630945
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 18:15:39 +00:00
vidorteg 1502a9ec07 [Loc] Migrate event_listener pane to Localization V2 
- Migrate event_listener to use Localization V2 APIs.
- Removed event_listener grdps

Tested with en-XL.json
https://imgur.com/a/hm7nJ9k

Bug: 1136655
Change-Id: I401023ddda8c557732cc25943b6062f59f1b6ca8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2632158
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-15 17:20:09 +00:00
Andres Olivares 3100aca993 [module.json extensions] inspector_main views 
Bug: 1134103
Change-Id: I469e5c7799f8286a41d7ecd59354ac6a91aaa8d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629730
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 14:45:10 +00:00
Andres Olivares 89be7404b9 [module.json extensions] Add unit tests for new setting extensions registration infrastructure 
Bug: 1134103, 1153091
Change-Id: I2f2f359e1629bfb026b5bc0b8defbe2bc082a1b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2607725
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 14:37:10 +00:00
Andres Olivares f125cbd2cc [module.json extensions] input views 
Bug: 1134103
Change-Id: Ia9ea0ccad3064a3c80a9902206a4b977b908df86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629729
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 14:33:00 +00:00
Andres Olivares 6d70b13800 [module.json extensions] Add unit tests for new action extensions registration infrastructure 
Bug: 1134103, 1153091
Change-Id: I538c167ad87dd5e4eee1b1dc23c360e4ae3178f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2606493
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 13:49:11 +00:00
Simon Zünd 31e1a68523 Disable flaky linear memory inspector e2e test 
Observed the test over the course of the week and it flaked
comparatively often (peak rate was 3 times in 11 runs).

R=bmeurer@chromium.org

Bug: chromium:1166106
Change-Id: I22cf02dc757ca7ef1916fb5694c4091e60637995
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631111
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2021-01-15 13:42:44 +00:00
devtools-ci-autoroll-builder 4ad0cccbc0 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/d64e599..e3bf8c4

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c603339..f79e432

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I381779f4807604fa19ae33c9439c251a5e1c3807
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2632911
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-15 13:20:10 +00:00
Sigurd Schneider b15de2ee0a Fix height of icon component 
The new icon component used a display: inline-block span in its
shadow DOM to display the icon as background of said span. The
problem is that inline elements have two heights: a line box
and a content box. The content box is correctly sized, but the
line height is dependent on other factors (some outside of the
actual component) such as font selection and line leight. This
resulted in the icon component getting a /different/ height that
what was specified. See the screenshots at here for an example:
https://imgur.com/a/reKweWU
This alignment problem was mitigated in the code-base by all kinds
of paddings and margin setting (some of which are undone in this CL).

This CL changes the span in the shadow DOM that has the actual
icon as background to a div by setting the display: block style.
This ensures that the height of the icon component is computed
as intended, and in turn, a bunch of "correction" values in a
bunch of places can be removed.

Screenshot: https://imgur.com/a/reKweWU
Bug: chromium:1126031
Change-Id: Ibe26f81817e0ef6e9564553ace070e61d75006c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629550
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-15 13:14:40 +00:00
Simon Zünd 6efb6287b5 Reland "[module.json extensions] Migrate @ViewLocationResolver in elements/" 
This reverts commit 3abe4703fa.

Reason for revert: The original CL was reverted in the course of investigating a CQ Tree closure. As the CL was not the cause we can safely reland.

Original change's description:
> Revert "[module.json extensions] Migrate @ViewLocationResolver in elements/"
>
> This reverts commit 29da6d23a9.
>
> Reason for revert: Reverting due to red tree. Low chance that this CL is the actual cause for the outage but we should confirm we reverting.
>
> Original change's description:
> > [module.json extensions] Migrate @ViewLocationResolver in elements/
> >
> > Bug: 1134103
> > Change-Id: I631b35747ede06d4d5377e09e3700e9d58ee2ac8
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629176
> > Commit-Queue: Andres Olivares <andoli@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> > Auto-Submit: Andres Olivares <andoli@chromium.org>
>
> TBR=tvanderlippe@chromium.org,andoli@chromium.org
>
> Change-Id: Ibc9cadba9680e65355801359f42960ea4d6b4921
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1134103
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631107
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

TBR=szuend@chromium.org,tvanderlippe@chromium.org,andoli@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1134103
Change-Id: I0585f3deab8c7140b5e0668cf8dc79b214b76873
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631110
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-01-15 13:12:30 +00:00
Jan Scheffler bc5d1e34e2 [JSDOC2TS]: Migrate js_profiler 
Bug: chromium:1158760
Change-Id: I8ee883c88291c43b0b0d2b41cfdf5051fceb9e9e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630947
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 12:54:55 +00:00
Tim van der Lippe 05149e9772 Remove ls from legacy-defs 
This adds all missing imports for `ls` to all files. After this change,
all usages of `ls` will now properly be resolved to a LocalizedString
rather than a normal string.

R=jacktfranklin@chromium.org

No-Presubmit: True
Change-Id: Icf6d8c3b8bea1f9e66f4b6b58e4ae4c7f99e6f9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629554
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-15 12:53:50 +00:00
Benedikt Meurer b6901af509 Fix display of floating point values with scientific notations. 
This removes the special casing for the scientific notation, which
wasn't working as designed (likely), and instead uses the general
formatting for number values consistently now.

Also-By: alexrudenko@chromium.org
Before: https://imgur.com/fb46SeU.png
After: https://imgur.com/XHGIFro.png
Fixed: chromium:1167032
Change-Id: I8dee6308122d5c1ac88253dde6a518023da61733
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631108
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2021-01-15 12:24:06 +00:00
Jan Scheffler eaa61fcb0f [JSDOC2TS]: Migrate devices 
Bug: chromium:1158760
Change-Id: Iac3f59bf9f17a372579f58a1426195a1f809749f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629556
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 11:40:16 +00:00
Simon Zünd 3abe4703fa Revert "[module.json extensions] Migrate @ViewLocationResolver in elements/" 
This reverts commit 29da6d23a9.

Reason for revert: Reverting due to red tree. Low chance that this CL is the actual cause for the outage but we should confirm we reverting.

Original change's description:
> [module.json extensions] Migrate @ViewLocationResolver in elements/
>
> Bug: 1134103
> Change-Id: I631b35747ede06d4d5377e09e3700e9d58ee2ac8
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629176
> Commit-Queue: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Auto-Submit: Andres Olivares <andoli@chromium.org>

TBR=tvanderlippe@chromium.org,andoli@chromium.org

Change-Id: Ibc9cadba9680e65355801359f42960ea4d6b4921
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1134103
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631107
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-01-15 09:01:18 +00:00
Sigurd Schneider 57654f96e3 Import ls in NetworkConfigView 
Bug: chromium:1136655
Change-Id: I7ea33934c1743fded49c2ff0dbe479c0425ea769
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626300
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 08:07:05 +00:00
Andres Olivares 29da6d23a9 [module.json extensions] Migrate @ViewLocationResolver in elements/ 
Bug: 1134103
Change-Id: I631b35747ede06d4d5377e09e3700e9d58ee2ac8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629176
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2021-01-14 22:03:38 +00:00
Andres Olivares 49de8bac91 [module.json extensions] Add unit tests for new view extensions registration infrastructure 
Bug: 1134103, 1153091
Change-Id: I773fb7dedb140df62a9e056169ad794517a809e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2606492
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-01-14 21:20:17 +00:00
vidorteg 18a45a67b2 [Loc] Migrate screencast panel to Localization V2 
- Migrate screencast to use Localization V2 APIs.
- Removed screencast grdps

Tested with en-XL.json
https://imgur.com/a/0i8xOyL

Bug: 1136655
Change-Id: I71fcaca0426e116a4466cc4f78b11bce8d692a44
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2628579
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-14 20:27:27 +00:00
Maks Orlovich fd433ed48a Emulation UA-ch editing: make help button tabable 
... And also give it a focus ring in CSS

Bug: 1164345
Change-Id: Id0fbfbaaf0c965f64e9bcde0434c4c7614e4c622
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2627090
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-14 18:35:18 +00:00
Andres Olivares 786a9e746b [module.json extensions] Add support for ViewLocationResolver 
Modules can now register extensions of type 'ViewLocationResolver' in
their meta files.

Bug: 1134103
Change-Id: I07eb5034634128c941d15507f72dcc53016ead5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2606489
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-14 17:39:57 +00:00