Michael Liao
9c1e0ce471
DevTools [Network Conditions]: adding error text for network condition tool custom user agent text input
...
Re-upload of https://chromium-review.googlesource.com/c/chromium/src/+/1730131 to DevTools repository
Changes:
- added error text div and needed css
- adding value length checks on creation and input
**Note: the text now reads "Custom user agent field is required"
Image of error text:
https://imgur.com/8PI75T3
GIF of error text behavior:
https://imgur.com/o8oZvcW
New error element spacing:
https://imgur.com/hE3Xmli
Bug: 963183
Change-Id: Ib5776ae72d4abaabf03efce5838ddb731283c0ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1871820
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com >
Commit-Queue: Michael Liao <michael.liao@microsoft.com >
2019-10-23 20:24:47 +00:00
Joel Einbinder
e1c93d9cb6
DevTools: Remove 20kb of unused CSS
...
These css rules used classes that don't exist anywhere in the
javascript. A script was written to find them, but manually checking
is still needed because some scripts generate class names by
string concatenation like 'icon-' + iconType
Change-Id: I15c4f26451b9fa371b366a8977021e2af7eca449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618043
Commit-Queue: Joel Einbinder <einbinder@chromium.org >
Reviewed-by: Alexei Filippov <alph@chromium.org >
Reviewed-by: Erik Luo <luoe@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#661630}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6f259d6e2834c9b0e2cbb0fdd7c9703e1fc6968
2019-05-21 06:16:13 +00:00
Joel Einbinder
7fbe24c094
DevTools: Convert to Shadow DOM and Custom Elements v1
...
Bug: 685385
Change-Id: I027e84d8003b7799492211d5fcf8348cd91fd799
Reviewed-on: https://chromium-review.googlesource.com/c/1422962
Reviewed-by: Dmitry Gozman <dgozman@chromium.org >
Commit-Queue: Joel Einbinder <einbinder@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#625513}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b00e6ea1c9b4db5d743c7c204b1f63abf89e0398
2019-01-24 05:19:01 +00:00
Erik Luo
10f8c92a21
DevTools: do not cap width of user agent override
...
Screenshot: https://imgur.com/a/8u2tq05
Bug: 845449
Change-Id: Ibe8ca7b40133891cfe2701f90d26a2850b7d7497
Reviewed-on: https://chromium-review.googlesource.com/1077101
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org >
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#577414}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b5274745377993f85702baf8a82fece7e7bc4124
2018-07-24 02:51:56 +00:00
Blink Reformat
4c46d0969f
The Great Blink mv for source files, part 2.
...
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org >
Commit-Queue: Blink Reformat <blink-reformat@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00
Michael Liao