zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-02 18:11:04 +08:00
Code Issues Packages Projects Releases Wiki Activity
16,424 Commits 43 Branches 79 Tags
cd97729fc828dda34c7dd5ec2c2d7f4e83060775
Commit Graph
71 Commits
Author SHA1 Message Date
Randolf Jung c866a154c3 Update DevTools symlink hook 
- `ensure_symlink.py` now actually _ensures_ the symlink is correct.
 - `os.symlink` is supported in Windows since 3.8, so the compat function was removed.
 - Some debugging information has also been added w.r.t. the gclient hooks.
 - Some attributes in the gclient file are not relevant.

Bug: 1095624
Change-Id: I7272da7980a1706ee624362ec0d5a3f71f9a6f04
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4533035
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2023-05-16 13:53:27 +00:00
cola119 01473b3dd4 Fix a broken link in architecture_of_devtools.md 
Bug: None
Change-Id: I64353a6abb03908bf6cb32285cab8d6a980c8d55
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4506113
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2023-05-15 14:11:55 +00:00
Ergun Erdogmus c04160f38a Add documentation for adding UMA metrics 
Bug: none
Change-Id: Id9475b61057dd086a2242889905171d1d00f1b78
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4521017
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2023-05-10 10:51:15 +00:00
Jaroslav Sevcik f20bfbfb29 [doc] Update the workflow doc for the hosted mode 
Bug: None
Change-Id: I62c20f63dd8f06b9faef6173020a9fad2d5b85e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4506637
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
 2023-05-05 07:54:21 +00:00
Danil Somsikov 4054d1ec6a Moved CDP docs from g3doc to chromium. 
Bug: None
Change-Id: I09df871f396c42a6d0e3086e3811b0bbb4c81c12
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4422586
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2023-04-13 10:39:53 +00:00
Wolfgang Beyer fc496a709a Fix internal links in localization documentation 
Bug: none
Change-Id: Iffffdb9cdad4a8113666c8d098339126adced829
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4334470
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2023-03-15 11:14:12 +00:00
Jack Franklin 859cba9471 Add docs on merging w/ git to workflows 
Bug: none
Change-Id: If2ff248c41c60463160c980c9c8dbcc7017da7f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4302730
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2023-03-02 09:57:31 +00:00
Philip Pfaffe 75e3ab637d Fix debug-test script and add it to workflow docs 
Bug: none
Change-Id: Ie09da21bc697643f3b62e52c27310f8af4a5e38f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4294987
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2023-03-01 12:17:55 +00:00
Benedikt Meurer 3d93ac6964 [docs] Link unittests documentation. 
Bug: chromium:1361214
Change-Id: Iad736444d08500af437b0b2f0f4f10e3d667399b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4219115
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2023-02-03 07:06:46 +00:00
Philip Pfaffe 5626e10094 Enforce language plugin icons to be data URLs 
R=jarin@chromium.org

Bug: none
Change-Id: Ie31d3828f448178df3d6b5e7b4480e9a6383e33e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4112009
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2022-12-16 10:55:19 +00:00
Philip Pfaffe 913156fb2f Language extension API docs 
Add docs for the language extension API.

Drive-by: Fix a comment on the API typings.

Bug: none
Change-Id: I411845a4bff8d1ecbfec41875e998234b8981b80
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4110802
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2022-12-16 10:33:25 +00:00
Connor Clark d842adb8d5 Add gclient sync to build section 
Bug: None
Change-Id: I4fa7bf3f8f5f7cb898e68e8a640341eb6fbe466e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4000842
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Thiago Perrotta <tperrotta@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2022-11-03 06:08:54 +00:00
Benedikt Meurer 088ffe6cbd [docs] Mention V8 debugger support checklist here. 
Bug: none
Change-Id: I7a9db5d0643c3765dc66ac24cd082056f0e07ef0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3976038
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-10-25 11:30:01 +00:00
Andrés Olivares 0650b4a669 Update documentation on DevTools application entrypoints 
Updates the location as well as the purpose of each entrypoint.

As a drive-by fix, the command prompt for showing the Node sources in
the Sources panel is corrected from "Node" to "Show Node".

Bug: none
Change-Id: I6d76bfb190925d3eb624c775fe134eda1b10b5f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3964271
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
 2022-10-19 11:58:47 +00:00
Charlie Harrison 822c80abac Clarify in workflows.md that rolling deps can cause breaking changes. 
Bug: none
Change-Id: Ib6a1498df2f4c807bbe8b2d8a280f1abf994df84
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3909123
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2022-09-21 16:22:20 +00:00
Simon Zünd 83ad6a40ba [docs] Restructure localization docs 
This CL re-structures the l10n docs: The various small docs are
combined into a single doc and linked from the root README.md.

This is a mechanical change  modulo adjustments to some header levels.

R=bmeurer@chromium.org

Bug: None
Change-Id: I6de8f100d1e5eae74acc6cdba2e328daa2636db1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3883941
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
 2022-09-09 09:12:50 +00:00
Benedikt Meurer e3a8a2f78e [docs] Add link to the Design Documents folder. 
Bug: chromium:1361214
Change-Id: Ibd150efaee8f6e628310a6f2fe52c0a87e1e6794
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3879846
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2022-09-08 08:21:25 +00:00
Benedikt Meurer cde66e4b13 [docs] Include links to Chromium and V8 docs. 
Bug: 1358806
Change-Id: I159055b6542d7cac718edb7fb89ed0cdb7826b77
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3864092
Commit-Queue: Victor Porof <victorporof@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
 2022-09-01 16:34:59 +00:00
Benedikt Meurer 69fc30e8b3 [docs] Reorganize project documentation. 
Going forward we want to have DevTools project documentation maintained
within the source repository, following the model that Chromium uses for
its project documentation[1].

This change sets up the basics for that, putting in place the main
entry point (in docs/README.md) and moving the architecture
documentation to the docs folders, as well as putting back the 3rd party
guidelines here. We also adopt the simpler structure for images, making
it easier to identify which document a given image file belongs to.

[1]: https://chromium.googlesource.com/chromium/src/+/main/docs/README.md

DISABLE_THIRD_PARTY_CHECK=reorganizing files

Fixed: chromium:1358806
Change-Id: I70f7f90b95c7311ca24bede04ca9cdd5e4c31eaf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3865393
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2022-09-01 08:23:39 +00:00
Thiago Perrotta 4d23b41db9 docs/workflows.md: miscellaneous documentation tweaks 
Bug: None
Change-Id: If0db92dfbe3d725162ba2ed002f77bc0556666c9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3831909
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Thiago Perrotta <tperrotta@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2022-08-16 14:07:47 +00:00
Thiago Perrotta 6d9cdf532a docs: add Ctrl+Shift+J open devtools shortcut to workflows 
Bug: None
Change-Id: I5ddbe92950ecc74dffcd9ab086dd771bd01adca5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3803047
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Thiago Perrotta <tperrotta@chromium.org>
 2022-08-02 06:13:34 +00:00
Benedikt Meurer 24334358cc [docs] Update triage guidelines. 
Bug: none
Change-Id: I0c54777f2e02c8f721cc2ed1d757693393391e53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3776455
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2022-07-20 10:44:44 +00:00
Benedikt Meurer 9e69fb8edd [docs] Update triage guidelines. 
Doc: http://go/chrome-devtools-bug-tracking-v3
Bug: none
Change-Id: I4e01bcf1fcb6255ba228ef272652dbf279eaa584
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3745381
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2022-07-05 09:52:53 +00:00
Kim-Anh Tran 8d2bc2d006 [workflows.md] Add guidelines on how to write CL descriptions 
This adds a guideline to our documentation on how to write
and format CL descriptions.

Also-by: jec@chromium.org, semel@google.com
Bug: none
Change-Id: I354f5c4b42ee4c3c711d29e7bbf3884cc2ea29fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3687724
Reviewed-by: Jecelyn Yeen <jec@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2022-06-13 10:24:48 +00:00
Nancy Li 4d1704224c Update workflows.md 
Bug: none
Change-Id: I61ffc74d1353a4535d9d6a3cab5c999163b0c481
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3688200
Auto-Submit: Nancy Li <nancyly@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2022-06-07 13:24:02 +00:00
Mathias Bynens 54303dcc64 Unify developer-facing and user-facing short URLs 
For any shortened URLs:

- Use goo.gle for Google Docs and chromium.org target URLs.
- Use g.co for everything else.

Bug: chromium:1321016
Change-Id: I09099dc62b92a14fa68d62155953262328476db2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3613872
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2022-04-29 10:46:23 +00:00
Takuto Ikuta d2b8719629 docs: mention about devtools_skip_typecheck 
Bug: 1278663
Change-Id: I945c81c8e42b38eb75361beb9d4863b886a1999b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3419395
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 2022-01-27 11:27:35 +00:00
Simon Zünd a6dbaacc70 Add documentation for projects, bindings and mappings 
Document some of the basic concepts how DevTools handles resource
files and handles related resources.

Draft doc: https://docs.google.com/document/d/1zzX-t2cXJggV-9UYj24jp9aypsrnLIC3jmLos1jrMnE/edit?usp=sharing

Bug: None
Change-Id: If20213fb0173245e743642c6add4487b6a5487ef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3416223
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-01-26 15:44:22 +00:00
Changhao Han 701f62d139 Fix Hotlist-DevTools-Triaged label 
Bug: None
Change-Id: I0780a0dcbc73bc19c4d5f4a08f676e1d7cba25e4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3329544
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2021-12-10 12:07:50 +00:00
Peter Müller dd677ac34c Fix formatting of triaging guidelines 
Bug: 1268306
Change-Id: I01512b07952c174fd33666d02d86197c11265ea9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3269832
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Peter Müller <petermueller@chromium.org>
 2021-11-09 13:34:20 +00:00
Peter Müller 9dc707d7c5 Add new triaging guidelines to triage_guidelines.md 
Bug: 1267220
Change-Id: I7ea5d2ab5636191c6d0bce0edfe1204f955c1116
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263410
Commit-Queue: Peter Müller <petermueller@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2021-11-08 16:46:59 +00:00
Philip Pfaffe 10f3538414 Add triage label to triage guide 
Bug: 1234358
Change-Id: Iab681891780c5a677a2fcd69ed21722273df00c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3097666
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2021-08-16 16:04:39 +00:00
Paul Lewis 2906222f2a Update Chromium source references 
Some comments in the code refer to the master branch. This CL updates
those comments to refer to the main branch instead.

Bug: 1226943
Change-Id: Ib01747a447f7fc462ed92ba2fbb961cd12c3e490
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3009819
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-07-07 10:11:57 +00:00
Johan Bay e7d193fc8b Fix link in design_guidelines.md 
Bug: none
Change-Id: Icec4837285930b30f8628242bcdd5e6018a0f72a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2929192
Commit-Queue: Johan Bay <jobay@google.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-06-01 13:16:25 +00:00
Tim van der Lippe 92bf1daa15 Add GN visibility and GRD file generation to ARCHITECTURE.md 
For visualization, an image of the module visibility rules is included as well.

R=aerotwist@chromium.org,alexrudenko@chromium.org,jacktfranklin@chromium.org

Bug: none
Change-Id: Id644119234d75ed643408751dbf03f100386c25b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2859918
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-04-30 15:18:23 +00:00
Tim van der Lippe 2e143870f7 Move owners files into config/owners 
The separate *_OWNERS files are related and can be grouped together
in a folder to make this distinction clear. This will allow us
to update the PRESUBMIT script to explicitly mark them as
exclusive change directory.

Note that the directory is named "owner", as we can't name it
"owners" as that is case-insensitive equivalent to "OWNERS",
which Windows can't handle in its presubmits.

DISABLE_THIRD_PARTY_CHECK=OWNERS update
R=yangguo@chromium.org

Bug: 1187573
Change-Id: Ib94a544c9dc01f788a8b75a5c8111ab52fbc27b8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2814658
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-04-08 12:25:52 +00:00
Tim van der Lippe 20e5ff211a Add ARCHITECTURE.md 
This document describes the high-level architecture of DevTools. While
not complete yet, this version adds the guiding principles and explains
the core-feature model used in the DevTools startup process.

Future updates will include an explanation of how individual high-level
features are implemented and what their building blocks are.

DISABLE_THIRD_PARTY_CHECK=OWNERS update for new file

Bug: none
Change-Id: I589ae3f646094ec92c27336b6282006ab4534d7f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2791341
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-04-07 07:00:59 +00:00
Peter Marshall faaef4e3e9 [l10n] Add docs for i18nLazyString 
Also remove old docs that are no longer relevant for V2.
Update links in the README to the new files.

Bug: 1136655
Change-Id: Iec0277912eb24d1a2bff00792cb616c06156fab8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2764221
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-03-17 06:49:45 +00:00
Peter Marshall e65a75f4e9 [l10n] Update the docs for writing UI string descriptions 
Add some more detail and examples, re-order to make location look less
important. Explain why some things are necessary.

Bug: 1163928
Change-Id: Iaa34477097210672462f4b3df8d018c050e6cc9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2735674
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2021-03-08 07:09:54 +00:00
Alex Rudenko aad7d9ade3 Add references to docs covering testing in DevTools 
Bug: none
Change-Id: I46e82b7c0aa22aa1539c6e6d61cc920309882ec0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2739599
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-03-08 07:03:24 +00:00
Vidal Guillermo Diazleal Ortega b57e5df914 [Loc] Removing Localization V1 remnants. 
Hi everyone,

Our plan for implementing Localization V2 considers 3 phases:

Infrastructure, Migration & Cleaning

This CL is part of the Cleaning phase, it's goal is to remove any
non-standard usage of V1 APIs (outside of the devtools_ui_strings.grd)
I'm splittling these changes into small pieces following this heuristic:
- make sense when logically grouped.
- keep them as small as possible
- can be atomically reverted.

I'll follow up with other changes removing usage on presubmit, scripts
and build.gn files (if any).

Bug: 1136655
Change-Id: I735dc8ba1045ed4afff7deb1a43cf02a7ab55865
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2733640
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-03-04 22:26:24 +00:00
Simon Zünd f34bb6c20d [l10n] Introduce i18n.i18n.lockedString 
R=petermarshall@chromium.org

Bug: chromium:1180760
Change-Id: Ie2174bd3d16ef9f73c1197a62d64e8b668811cb6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2731571
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-03-03 13:22:19 +00:00
Peter Marshall 3ec813d57b [l10n] Update plural forms, fix some errors 
- Clean up identical strings that had identical descriptions.
- Move whole plural text inside plural switches
- Add some notes to docs for plurals
- Use '=1' instead of 'one' for plurals because the linter for our
internal process requires this.


Bug: 1163928
Change-Id: Idba5a22424816225e4c8b0d465ec970a5b0f6e02
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2728075
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2021-03-02 08:34:56 +00:00
Peter Marshall a99c96c041 [l10n] Use ICU plural in Changes drawer 
Update documentation for V2 to include an example of this, too.

After: https://imgur.com/a/S0DadTT

Bug: 1163928
Change-Id: I2fa7599abbed945982378f382ed83f5ca46aee61
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2726564
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-03-01 12:23:28 +00:00
Tim van der Lippe f407ef2e64 Update build output location to gen/front_end 
Since resources/inspector is now a complete copy of gen/front_end,
we can update the workflows documentation and switch the
hosted_mode server to the original location.

R=jacktfranklin@chromium.org

Bug: 1174013
Change-Id: I32eda3b64cdd461e670222a47b1d424604a989b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2673831
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-04 14:53:47 +00:00
Jan Scheffler 698810c1ca Update workflow documentation 
Change-Id: I22ad5399a7cf562d1b1a5e303fd320fe8191f5db
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2505132
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2020-10-28 13:05:54 +00:00
Yang Guo ef36cec5b9 Apply governance change 
DISABLE_THIRD_PARTY_CHECK=no code changes
R=bmeurer@chromium.org

Change-Id: I2477c36f5ef2494ccae3efae3f1aee942f365fec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2489420
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-10-21 07:54:15 +00:00
Alfonso Castaño ae3dc89611 [Devtools docs] Add build directory parameter in layout tests 
The current proposed sequence of commands to run the layout tests is:

autoninja -C out/Default content_shell
third_party/blink/tools/run_web_tests.py http/tests/devtools

However, it leads to an error since by default it checks in out/Release. Therefore, it would be better to specify to use out/Default which was just built:

autoninja -C out/Default content_shell
third_party/blink/tools/run_web_tests.py -t Default http/tests/devtools

Change-Id: I2775e5ec9a6259d52b002126138e04c4a72d6120
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479130
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Alfonso Castaño <alcastano@google.com>
 2020-10-16 15:15:17 +00:00
vidorteg 6d2775c5ef Modifying scripts for i18nString localization call 
Modifying some scripts that verify the shape of localization calls
to work with the i18nString shorthand:

const i18nString = i18.i18n.getLocalizedString.bind(undefined, str_);

Bug: 1136655
Change-Id: I09a961136dd89e8af11ab33f413f315e61184078
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2469903
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
 2020-10-14 21:12:22 +00:00
Christy Chen 1148dc0fda Remove backtick for lock terms in en-US.ctc.json files 
In Lighthouse project, backtick is being used to indicate something that should not be localized.
(See 'inline code block' section in https://github.com/GoogleChrome/lighthouse/tree/master/lighthouse-core/lib/i18n)

We can adopt this with minor modification. When the lighthouse report is being rendered, the backtick in message will be converted to a special html tag and used to style the code snippets. Since we don't want to do special styling for locked terms, backtick can be removed after the term being converted to placeholder in en-US.ctc.json, then locale.json would have the term that is not translated and without the backtick .

For example
Before change: https://imgur.com/a/WqbVbXC
After change: https://imgur.com/a/EZjl6Gg

Note: There is no escape character for using backticks as part of the string, it can only be used for locked terms.

DISABLE_THIRD_PARTY_CHECK=Need to also update README that is in different folder
Bug: 1136655
Change-Id: I68ea305962beec4115d0a50f24e34546b92cadf7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2463990
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-10-13 19:24:29 +00:00