Philip Pfaffe
cdcca1ad4e
Check file access on the host side of the extension api
...
Fixed: 406034851
Change-Id: I125bfa572ba9e987569e8524da99de84db83d389
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6401296
Reviewed-by: Danil Somsikov <dsv@chromium.org >
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org >
2025-03-31 00:40:50 -07:00
devtools-ci-autoroll-builder
4091180134
Update Chrome (for Testing) PIN
...
Chromium pin updated to 136.0.7100.0
Roll created at https://cr-buildbucket.appspot.com/build/8718916799054713345
Bug: none
Change-Id: Ib19d46b065d15337c133c9cb494c214e7cc2f92b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414968
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
2025-03-31 00:24:22 -07:00
devtools-ci-autoroll-builder
bad7f7c656
Update DevTools DEPS (trusted)
...
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/ac0421e..6f35929
Roll created at https://cr-buildbucket.appspot.com/build/8718916799054713345
Bug: none
Change-Id: I082bdf9a7486eb31196b3bc0ea9942be83be8f0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414948
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
2025-03-31 00:23:18 -07:00
devtools-ci-autoroll-builder
e9da51da2e
Update Chrome (for Testing) PIN
...
Chromium pin updated to 136.0.7096.0
Roll created at https://cr-buildbucket.appspot.com/build/8719097992811764721
Bug: none
Change-Id: If18ae8511e3f7cc7a7dffb07580b16c9ef6db748
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410853
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
2025-03-28 20:46:08 -07:00
devtools-ci-autoroll-builder
70dd637939
Update DevTools DEPS (trusted)
...
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/244e7cf..ac0421e
Roll created at https://cr-buildbucket.appspot.com/build/8719097992811764721
Bug: none
Change-Id: Ie648e640d53007439852e425c770d7b798f07325
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6411136
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
2025-03-28 20:40:09 -07:00
Adam Raine
f2ba87197e
Revert "[NetworkRequestDetails] Fix initiator row styling"
...
This reverts commit 6333612700https://crrev.com/6404821
Original change's description:
> [NetworkRequestDetails] Fix initiator row styling
>
> The initiator row was separated because the link can be very long. This
> CL groups the initiator with everything else but applies `ellipis` to
> contain the size.
>
> Bug: 406864076
> Change-Id: I7088b64f7b3154e457a46f515b35908102c7cd5e
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404927
> Auto-Submit: Adam Raine <asraine@chromium.org >
> Commit-Queue: Adam Raine <asraine@chromium.org >
> Reviewed-by: Paul Irish <paulirish@chromium.org >
Bug: 406864076
Change-Id: I9fa423e170455f4235bb5feb7c77a35691f6b3a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410873
Commit-Queue: Adam Raine <asraine@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
2025-03-28 18:13:45 -07:00
Nikolay Vitkov
4eac8f8231
[eslint] Run type checking on custom rules
...
Currently behind a flag, as there are a lot of error.
This CL fixes some of them.
Bug: 407085691
Change-Id: I736472ff5a9d8c46e45a1ce89a42199774d9075f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410471
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org >
Reviewed-by: Danil Somsikov <dsv@chromium.org >
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org >
2025-03-28 16:08:54 -07:00
Connor Clark
1bbd38cc8d
[RPP] Remove table-layout: fixed from Table component
...
Bug: none
Change-Id: I29719ca6bbf4924c1a3066c34e76405f0e5d8abc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410711
Reviewed-by: Paul Irish <paulirish@chromium.org >
Commit-Queue: Connor Clark <cjamcl@chromium.org >
Commit-Queue: Paul Irish <paulirish@chromium.org >
Auto-Submit: Connor Clark <cjamcl@chromium.org >
2025-03-28 15:25:11 -07:00
Connor Clark
39b158a8da
[RPP] Remove Duplicated JavaScript insight from experimental
...
Also configures the "initialView" when opening the treemap from this
insight card.
Fixed: 394373632
Change-Id: Ic0ed412193a337d7d68e031d14a664516bb8d6ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6408022
Commit-Queue: Paul Irish <paulirish@chromium.org >
Commit-Queue: Connor Clark <cjamcl@chromium.org >
Auto-Submit: Connor Clark <cjamcl@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
2025-03-28 14:00:27 -07:00
Adam Raine
42fe2c4d98
[LiveMetrics] Render field data phase column on the right
...
Fixed: 406826928
Change-Id: I7bd68732e5db30c7e55f2c2b4eb446d0c677c93c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404928
Commit-Queue: Paul Irish <paulirish@chromium.org >
Commit-Queue: Adam Raine <asraine@chromium.org >
Auto-Submit: Adam Raine <asraine@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
2025-03-28 13:15:54 -07:00
Adam Raine
6333612700
[NetworkRequestDetails] Fix initiator row styling
...
The initiator row was separated because the link can be very long. This
CL groups the initiator with everything else but applies `ellipis` to
contain the size.
Bug: 406864076
Change-Id: I7088b64f7b3154e457a46f515b35908102c7cd5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404927
Auto-Submit: Adam Raine <asraine@chromium.org >
Commit-Queue: Adam Raine <asraine@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
2025-03-28 12:50:32 -07:00
Andrés Olivares
89847dd997
[RPP] Sort sample events after running SamplesIntegrator
...
With https://crrev.com/c/6394268 events created for samples with a trace
id were added after the ones created for all the obtained samples. As a
consequence, the containing array ended up unsorted. This can cause
an error where an unordered event is unexpectedly found when
building the tree hierarchy in the trace engine.
To fix this, the containing array is ordered at the end of the
buildProfileCalls, which contains the main implementation of the
SamplesIntegrator.
Bug: none
Change-Id: I9e26e7890b91f5be1510e4fbc7c29e577aed4ed0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6408651
Commit-Queue: Paul Irish <paulirish@chromium.org >
Auto-Submit: Andres Olivares <andoli@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
2025-03-28 11:57:01 -07:00
Connor Clark
61c9086ba8
[RPP] Fix type failure in insights AI getSuggestions
...
Back-to-back CLs with indirect impact on each other caused this.
Bug: 405925760
Change-Id: I44a00e678ec71a87717b57c70416d8f53f13909b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6409451
Commit-Queue: Paul Irish <paulirish@chromium.org >
Commit-Queue: Connor Clark <cjamcl@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
Auto-Submit: Connor Clark <cjamcl@chromium.org >
2025-03-28 11:55:58 -07:00
Jack Franklin
ed77ee4244
RPP: add default suggestions for each Insight
...
Bug: 405925760
Change-Id: I12b70506b58bf684fc55162d6be99df4012b6a41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397060
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Nancy Li <nancyly@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Nancy Li <nancyly@chromium.org >
2025-03-28 10:31:21 -07:00
Connor Clark
c029e350fc
[RPP] Add Legacy JavaScript insight model
...
Bug: 394373852
Change-Id: I97b0ee1af0b025dddfc691a11137c84f6c28c135
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405705
Commit-Queue: Paul Irish <paulirish@chromium.org >
Auto-Submit: Connor Clark <cjamcl@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
2025-03-28 10:09:03 -07:00
Jack Franklin
b12601e996
RPP: skip layout shift cluster unit test
...
Bug: 406981939
Change-Id: I0033bff92181ed9541b0dc05e1bedad07c5e2bd2
No-Tree-Checks: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6408652
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Andres Olivares <andoli@chromium.org >
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org >
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Andres Olivares <andoli@chromium.org >
Reviewed-by: Alina Varkki <alinavarkki@chromium.org >
2025-03-28 09:48:18 -07:00
Jack Franklin
d8698b71e3
Annotations: new prompt to reduce "responsiveness"
...
The mention of responsiveness in the prompt really made the AI use
it...a lot! This version seems better. By asking the AI to not focus so
much on "user visible impact" we reduce how much it talks about "user
interaction responsiveness" which really isn't helpful.
Bug: 400357484
Change-Id: Id9f594b3af34bd733e6a3fe61c21aeef0cb1a1ed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6408872
Commit-Queue: Alina Varkki <alinavarkki@chromium.org >
Reviewed-by: Alina Varkki <alinavarkki@chromium.org >
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
2025-03-28 09:44:33 -07:00
Andrés Olivares
cee49a9b62
[RPP] Fix network request details layout
...
Margins and spacing between items was off.
Before: https://screenshot.googleplex.com/3Rz759PHWKxbFqp
After: https://screenshot.googleplex.com/3xTGaLkE2E5dqco
Fixed: 406990013
Change-Id: I5f7ec7f1bb2ad5b5a2fab0acf5fc6eae3edfedb8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404821
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2025-03-28 09:27:48 -07:00
Philip Pfaffe
cb1e1ed98e
Automatically reopen tooltips on rerender
...
When a tooltip gets detached without being closed and then gets replaced by a tooltip with the same id, the new tooltip is automatically reopend once connected. This addresses an issue in the styles tab where property values are rerendered entirely on changes.
Fixed: 404720158
Change-Id: I9e0f40f42898343faf112dc92127463fc7cab7f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387117
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org >
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org >
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org >
2025-03-28 08:28:05 -07:00
Mike West
0a15a0f000
Refactor SRIMessageSignatureIssue.
...
This CL doesn't introduce any behavioral change, but simply reworks the
implementation of `SRIMessageSignatureIssue` for clarity and concision.
Bug: 381044049
Change-Id: I726aa4e5f9249f1d2f1992f64c1b9821cf3ac8c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395499
Commit-Queue: Mike West <mkwst@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
2025-03-28 08:13:19 -07:00
Kim-Anh Tran
7de602ae97
[GM3Restyling] Update swatch popover helper and CSSPlugin
...
Both open the color picker in different environments (GlassPane, and Codemirror Tooltips).
Screenshots: https://imgur.com/a/js6wjcU
Bug: 406706611
Change-Id: I14e78949c6246dada6897604e9d1f5c6169d398e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6400616
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org >
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org >
2025-03-28 07:56:51 -07:00
Eric Leese
3dffede8b4
Change error path rewriting to work in full chromium checkout
...
Instead of calculating the path relative to the root of the
DevTools source tree, we now just remove "../../" to get the
relative path. This makes terminal links in vscode work in
full Chromium checkouts as well as devtools only checkouts.
Bug: None
Change-Id: I7bf410c353c5929bc9a0ef064449fa88f3bc1264
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405079
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org >
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org >
2025-03-28 07:14:10 -07:00
Kateryna Prokopenko
4ec68419bb
[GM3Restyling] Update GlassPane tooltip styles
...
Screenshot: https://imgur.com/a/rhQmTVl
Bug: 406466030
Change-Id: I0444c3f8bd029b277ba17a0e8c445d5fc3827754
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403633
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org >
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org >
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org >
2025-03-28 07:12:28 -07:00
Mike West
3fd2e5f67c
[SRI Message Signatures] Add an issue for integrity mismatches.
...
We're now emitting a devtools issue when blocking a response due to
signature-based integrity mismatches. This CL allows devtools to render
those issues when they appear.
This is the Devtools side of a two-sided patch:
1. (Chromium) https://crrev.com/c/6394978
2. (Devtools) https://crrev.com/c/6396680 [You are here]
Bug: 406424762
Change-Id: Iab6817bc42e96ddb080324183c8ba8668b773b41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396680
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Mike West <mkwst@chromium.org >
2025-03-28 07:06:25 -07:00
devtools-ci-autoroll-builder
f8ac7f1115
Roll browser-protocol
...
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.
Roll created at https://cr-buildbucket.appspot.com/build/8719154614336360705
R=devtools-waterfall-sheriff-onduty@rotations.google.com
Bug: none
Change-Id: Icce628cee263057ad4833e080d972a50749ad771
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405895
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
2025-03-28 07:01:21 -07:00
Benedikt Meurer
1022e32645
[npm] Allow to select (unstable) features with npm start.
...
This adds an option `--enable-unstable-features`, which now also turns
on multimodal support for Freestyler.
It also adds `--enable-features` and `--disable-features`, to allow more
fine-grained control over the exact feature set when necessary.
Fixed: 406941932
Change-Id: I7fcecbba833a2e0a66166890aa5af218ae2a8f7e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404318
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org >
2025-03-28 06:40:16 -07:00
Wolfgang Beyer
6353dded50
[Patch agent] Remove first-run-disclaimer
...
The disclaimer was only needed for connecting workspaces from within
the patch agent UI. Since the patch agent now only uses workspaces if
they have already been set up before via the Sources panel, the
patch agent's first-run-disclaimer can be removed.
Fixed: 406686142
Change-Id: I18b28475ac9904fd65a8041f96d36986804169c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405319
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org >
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org >
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org >
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
2025-03-28 05:55:58 -07:00
devtools-ci-autoroll-builder
ea6ee6962f
Update Chrome (for Testing) PIN
...
Chromium pin updated to 136.0.7095.0
Roll created at https://cr-buildbucket.appspot.com/build/8719154614336360705
Bug: none
Change-Id: I0d6b6042aad05959fb0e59d209a92f9a66284584
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405894
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
2025-03-28 05:43:41 -07:00
Ergun Erdogmus
d0889db8ba
[Memory] Release all animations before memory operations
...
This is a workaround to remove user facing issue of having detached
elements in the profiles because of the animations panel.
What happens is, we keep the animations for replay in the animations panel.
However, when a DOM node is removed; we still keep the
animation related to the DOM node in the animations panel and
this causes the node to be retained and show up in the memory
profiles as detached elements.
Fixed: 400635410
Change-Id: I686799c1069978fbb78250d88ae6459a5ee26572
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6406316
Reviewed-by: Danil Somsikov <dsv@chromium.org >
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org >
2025-03-28 05:27:11 -07:00
Jack Franklin
2dfe19495e
RPP: disable flaking LayoutShiftDetails test
...
I will follow-up and investigate but disabling to get tree green.
Bug: 406981939
Change-Id: I7e2a546795ef26f218d4fea35086bf9e4ac77d7a
No-Tree-Checks: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6406895
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org >
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org >
2025-03-28 05:25:01 -07:00
Connor Clark
e7a6489e5c
Enable projectService for TypeScript files in eslint config
...
Enabling this is required for rules that need to use the types as
resolved by the TypeScript compiler.
The no-floating-promises rule was missing some stuff due to missing
types, so this CL resolves that too. Also, return-await kicked up more
stuff.
A warm run of `npm run lint` went from ~23s to ~35s on my M1 Mac.
Bug: 406518012
Change-Id: I0c413e2ca14ee903851fd8404e490335c7f8aae0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397499
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org >
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org >
2025-03-28 05:02:27 -07:00
Nikolay Vitkov
acf22bf573
Move to build deps to devDeps
...
This is not part of the bundled part.
Make that separation.
Bug: none
Change-Id: I9f8dda77b0526cb2b2f0cb7e8d4ac2469137894d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6406322
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org >
2025-03-28 05:01:24 -07:00
Jack Franklin
5c9a3b6b59
Karma: apply patch to prevent timeouts after test complete
...
In github.com/karma-runner/karma/pull/3852 it is suggested that the 30s
timeout issue with Karma can be seen when:
1. All the tests complete, which sets the state of Karma to
"disconnected"
2. But there is some async activity which logs, or something. This
causes Karma to restart its 30s timeout, but no more messages will be
received.
This is a bit experimental, but trying this patch to see if it has a
positive impact on CQ.
Bug: 406729910
Change-Id: Iaaa9247c801e193e5782a0da4857d804bcc45a92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407593
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
2025-03-28 04:41:42 -07:00
Philip Pfaffe
a792c7efee
Revert "[css value tracing] evaluate percentages in longhands"
...
This reverts commit a0c4c4a06chttps://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376104
> Reviewed-by: Eric Leese <leese@chromium.org >
> Auto-Submit: Philip Pfaffe <pfaffe@chromium.org >
> Commit-Queue: Eric Leese <leese@chromium.org >
Bug: 401213719
Change-Id: I19d3567542f9b53e57efa9747f70d3aa529acec2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405417
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org >
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
2025-03-28 04:38:07 -07:00
Danil Somsikov
d3465fc604
Replace top-level variables with a lit template
...
Bug: 400353541
Change-Id: Iab1b2a5b596ca7efe4922124253947419d41a2d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407493
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org >
Commit-Queue: Danil Somsikov <dsv@chromium.org >
2025-03-28 04:29:23 -07:00
Danil Somsikov
f83ed266a9
Support external expressions as children of DOM fragments
...
Bug: 400353541
Change-Id: Id29c4fa82500507fcde454afe21de6e0cac9d1e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405673
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org >
Commit-Queue: Danil Somsikov <dsv@chromium.org >
2025-03-28 04:19:35 -07:00
Danil Somsikov
282ff278ad
Only remove processed references to DOM fragments
...
Bug: 400353541
Change-Id: I9b93a605c7ae90705539a9293c4c9b1a9c998582
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405493
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org >
Commit-Queue: Danil Somsikov <dsv@chromium.org >
2025-03-28 04:15:41 -07:00
Nikolay Vitkov
0fa4f1a476
Support all Chrome channels
...
Also add support for binary to point to executable of your
choice.
Bug: none
Change-Id: I122ad4fd117241c0c0106e2896e4fca602791958
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397059
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org >
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org >
2025-03-28 04:02:57 -07:00
Jack Franklin
5211c836ea
Revert "RPP: create new annotations AI agent"
...
This reverts commit 9995b96203https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407494
> Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org >
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Bug: 406795908
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ic85d030aa8542818168b23b6c60f582aa68eaf52
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405418
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
2025-03-28 04:01:14 -07:00
Jack Franklin
9995b96203
RPP: create new annotations AI agent
...
Required mostly for metrics so we can track its usage accurately rather
than bundled in with the existing "Ask AI" integration.
(Googlers: see the attached bug for a link to the backend CL, this needs
to land first before this can land).
Bug: 406795908
Change-Id: Ibf0fff042f72a6e622e9d9d9e87769a71feb23af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407494
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org >
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
2025-03-28 03:57:43 -07:00
Eric Leese
5f7e033b32
Fix npm run start and build scripts to work in full Chromium checkout
...
Also simplified code for test script to use devtools_paths.js
Bug: none
Change-Id: I699808267782f55150eabaacf9f86298ab3741d1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403238
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org >
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
2025-03-28 03:39:01 -07:00
Nikolay Vitkov
1ffa94db7a
[cleanup] Build third_party with common tools
...
Bug: none
Change-Id: Ib87452b075ec3accf305c84dd97c4dc180b9311b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6402073
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
2025-03-28 03:37:58 -07:00
Danil Somsikov
1675d4de76
An abstraction to track class members and distinguish the class they belong to
...
Bug: 400353541
Change-Id: I5f8c6577407299d2c91980b40e1cc93ca74ef043
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403237
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org >
Commit-Queue: Danil Somsikov <dsv@chromium.org >
2025-03-28 03:36:29 -07:00
Wolfgang Beyer
32caf01d79
[Patch agent] Add saving to workspace
...
If all modified files have a binding to a file on disk, allow
saving the changes to disk.
Bug: 406217277
Change-Id: Ib2f0adffc885b467ba885eb00d7b8765a0ba2d9b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403240
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org >
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org >
2025-03-28 03:24:43 -07:00
Philip Pfaffe
48963ad553
[css value tracing] Fix highlighting in BinOps
...
Fixed: 404538338
Change-Id: Ic15007e85a415973057579db3d77c011b44015e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6368598
Reviewed-by: Eric Leese <leese@chromium.org >
Commit-Queue: Eric Leese <leese@chromium.org >
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org >
2025-03-28 03:07:32 -07:00
Nikolay Vitkov
cf70a057cf
[test] Fix types for selectors
...
Bug: none
Change-Id: I84974d640a005fbbf0f1aed3c802202731b40381
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404073
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org >
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org >
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
2025-03-28 02:25:44 -07:00
Ergun Erdogmus
0a63c31c96
[Workspace] Remove resetting working copy after text change
...
We started using `setWorkingCopy` to update UISourceCodes
programmatically from other parts of DevTools (e.g. Styles tab & PatchWidget).
Because of this, the logic for comparing the cleanliness of the
code needs fixing and crrev.com/c/6381859 attempted doing it.
However, somehow, with that change; updating styles from styles tab
and calling `setWorkingCopy` do not update the `UISourceCode` at
all and there are test failures attached to that CL.
Until we figure out what's going on, it's best to disable the logic
for resetting working copy when `isClean()` reports true on text change.
There is one more place where we have a similar logic:
activating the pretty toggle when the `isClean()` reports true on
text change but that's a smaller bug that we can afford right now.
Bug: 402699175
Change-Id: Id175cfaeb44ffa7728f30b28893654d73af6dd8e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405494
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org >
2025-03-28 02:15:20 -07:00
Simon Zünd
fca5397836
Roll browser-protocol
...
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.
Roll created at https://cr-buildbucket.appspot.com/build/8719188589721198481
R=devtools-waterfall-sheriff-onduty@rotations.google.com
Bug: none
Change-Id: I4a2bb839b39222597520735b1ce5cb808363c1dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6406914
Commit-Queue: Simon Zünd <szuend@chromium.org >
Reviewed-by: Danil Somsikov <dsv@chromium.org >
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org >
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
2025-03-28 02:00:57 -07:00
Nikolay Vitkov
1814397dc3
Update recommended GN extension
...
This extension is much more powerful as it provides more useful
information.
Bug: none
Change-Id: If7f81a0da236418225ef3f93acce347161ea65c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404754
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org >
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org >
2025-03-28 00:13:04 -07:00
Mike West
770cde9518
[SRI Message Signatures] Improve the network panel status.
...
This CL shifts the text in the network panel's status column from
"(blocked:other)" to "(blocked:integrity)", and causes clicks on that
column to expose the set of headers sent along with the response.
Bug: 381044049
Change-Id: Ifbb493030cf3327cfd6954ba9f9b61a46a7b0648
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397062
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Danil Somsikov <dsv@chromium.org >
Auto-Submit: Mike West <mkwst@chromium.org >
Reviewed-by: Danil Somsikov <dsv@chromium.org >
2025-03-28 00:03:51 -07:00
Philip Pfaffe