zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-29 16:57:00 +08:00
Code Issues Packages Projects Releases Wiki Activity
24,695 Commits 43 Branches 79 Tags
d36860c0b435511daa6223ffc77214222076fafd
Commit Graph
24695 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Nikolay Vitkov d36860c0b4 [eslint] Enable useful rules 
@typescript-eslint/no-inferrable-types Simplifies the code and makes
type be more specific.

@typescript-eslint/return-await In theory more performant, but also
provides better debugging experience.

@typescript-eslint/ban-ts-comment Disallow all but ts-expect-error, as
else the error may get fixed not remove and later mask unrelated issues

Bug: 397260638
Change-Id: I09f268eb9157336635c378fa76546a4196e448e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6281149
Reviewed-by: Victor Porof <victorporof@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-19 10:49:41 -08:00
Alex Rudenko dcf675078d [cleanup] remove lastCall assertions 
Bug: none
Change-Id: Id802a79d364053f9e163c0f48a403953fde6d219
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6282146
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2025-02-19 08:21:43 -08:00
Danil Somsikov 95a792f8dc Hide legacy DataGrid editCallback 
It is hard to use in the combination with creation node, all the existing users have been migrated to the <devtools-data-grid> and new users should also use it.

Bug: 394287937
Change-Id: Id529f390725a0df628638c19d5dc826f00785744
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6280748
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2025-02-19 07:26:33 -08:00
Benedikt Meurer c377d2326f [sources] Add infobar to Sources panel for automatic workspace folders. 
This adds a preliminary UI to the Workspace tab in the Sources panel,
which allows users to automatically connect workspace folders that are
reported via project settings.

Doc: http://go/chrome-devtools:automatic-workspace-folders-design
Bug: 395562934
Change-Id: If8f7cd03a830a9e6636a94d7e3e4209e061311b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6281767
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-19 07:12:20 -08:00
Danil Somsikov 43cfc0140e Add native support of highlighted rows in the data grid and use it in the cookies table 
Bug: 394287937
Change-Id: Ia6627aee14b7959e12f9d3ce4bcb1cd835dcd116
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6280733
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-19 07:04:43 -08:00
Yang Guo 0d1ecc7af9 Fix focus outline for network filter dropdown 
AFter a previous change that grows the filter input responsively,
the filter dropdown is often maximally to the right. The focus
outline is truncated in these cases.

Fixed: 397392111
Change-Id: Ia39809d7b6dab235679e8ca6b5c3b95c0a39fbeb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6280732
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-02-19 06:29:16 -08:00
Danil Somsikov 3045923c09 Give ViewportDataGrid render jobs a unique name. 
A single page can have multiple ViewportDataGrids. When they each try to schedule a render job with the same name, only the last one will ever execute.

Bug: 394287937
Change-Id: I39b65516a014f3129479f8e5130d1494afca52b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6281389
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2025-02-19 06:09:39 -08:00
Alex Rudenko fc61ee5069 [AI Assistance] test patch 
Bug: 393268664
Change-Id: Ice7a96a004fc066aafe3e7671198056737337a0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6281386
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2025-02-19 05:41:39 -08:00
Benedikt Meurer 815ca4b43f [application] Fix cropped focus ring for drop down. 
Fixed: 397561622
Bug: 390588608, 388445687
Change-Id: I3ff9fdf9c575df1ad35d01e0a4d2cd0aad5b7e17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6281388
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-19 05:39:35 -08:00
Kim-Anh Tran 808bd65c2e [GM3Restyling] Update event listeners empty states 
Screenshots: https://imgur.com/a/FNvetVN
Bug: 325443331
Change-Id: I79e9f6dc26a76ea419d4cf30ae81da0c4d5a8d46
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6280727
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2025-02-19 05:25:25 -08:00
devtools-ci-autoroll-builder 77fced7bcd Update Chrome (for Testing) PIN 
Chromium pin updated to 135.0.7023.0

Roll created at https://cr-buildbucket.appspot.com/build/8722506703809158993

Bug: none
Change-Id: I33391deb80e6d5b3a039b510a9190920f3cf1dfa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6280947
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-02-19 04:42:06 -08:00
devtools-ci-autoroll-builder 4aefe6c4c9 Update DevTools DEPS (trusted) 
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/2f50fd2..d1ed719

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e69b086..ee429f3

Roll created at https://cr-buildbucket.appspot.com/build/8722506703809158993

Bug: none
Change-Id: Ic5ddbeacb17c81b7846ed030a72679dcfc3023eb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6280946
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-02-19 04:37:52 -08:00
Changhao Han 6f7cc16cf6 Small cleanup for ElementsTreeElement 
This is one of a few cleanup efforts to pave the way for better
integrating squiggly line into ElementsTreeElement, including extracting functions that do not rely on the instance, and making functions more modular and testable.

Bug: None
Change-Id: I11ea69a5c408197028de7cb90f35ebceeed3d990
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276551
Reviewed-by: Eric Leese <leese@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2025-02-19 03:50:15 -08:00
Alex Rudenko 9748d8ef61 [AI Assistance] Add better integration with Workspace 
Bug: 393268664
Change-Id: I1a1acc1e1b2db365cc94c8f23cebb0913edfd259
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6280747
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2025-02-19 03:13:41 -08:00
Samiya Caur f9f582e701 [AiAssistance] Update freestylerSendsData and freestylerSendsDataNoLogging strings 
As per recent privacy review, we need to update these strings. No re-opt-is needed.

Fixed: 396300537
Change-Id: I0b2f11178a16ef5e4909fca64227a0a88b5789eb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6280765
Auto-Submit: Samiya Caur <samiyac@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Samiya Caur <samiyac@chromium.org>
 2025-02-19 02:36:08 -08:00
Nikolay Vitkov d396b27c46 [eslint] Enable @typescript-eslint/consistent-generic-constructors 
Bug: 397260638
Change-Id: Id9eb30ea776f9b4bb05dc6a095ff24d1c742b89c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6279125
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-19 01:18:37 -08:00
Alex Rudenko f1b287dab4 [AI Assistance] Remove patch suggestion label 
Bug: 393268664
Change-Id: I8839e068984cedd3876aa99f26f591f5cbefa1a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6275971
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-19 00:41:59 -08:00
Paul Irish 3835ed2c95 Skip git secrets error on known firebase API key 
Change-Id: I4f722ec9e051951ffd2714764eb0f4190f42893b
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6278903
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
 2025-02-19 00:31:46 -08:00
Nikolay Vitkov 65a5a91d89 [eslint] Run no-unnecessary-type-assertion 
This type duplication can happen because of two reasons. 1) TypeScript
was not smart enough to deduce the type correctly 2) During our
TypeScript migration not very was typed, so we need to type cast in a
lot of places.

The rule is disabled as its too aggressive in some places, will file
issues upstream.

Bug: 397260638
Change-Id: Ic1100fee1e5a1d160d366f65d969442909f16eaf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276556
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-19 00:30:23 -08:00
Danil Somsikov 011d249877 Use <devtools-data-grid> in a CookieTable 
Bug: 394287937
Change-Id: I125636798ebad6c9a3cf2338d739503bda795700
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276102
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-19 00:29:18 -08:00
Kateryna Prokopenko 1b29c94e43 Minor tab and outline view fixes 
Use primary color for annotations counter badge
Use purple bright color for overrides status dot
Decrease Event listeners line height to 16px

Bug:none
Change-Id: Icaa965b336652e8e95915d38665dc38672125d19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276553
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2025-02-18 21:27:08 -08:00
devtools-ci-autoroll-builder d9bbee5b9a Update Chrome (for Testing) PIN 
Chromium pin updated to 135.0.7022.0

Roll created at https://cr-buildbucket.appspot.com/build/8722540677811929697

Bug: none
Change-Id: I166f935929ac67be3e95e46256fa846b0cb0419d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6278477
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-02-18 19:51:17 -08:00
devtools-ci-autoroll-builder cf7f27d36a Update DevTools DEPS (trusted) 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6cf251b..e69b086

Roll created at https://cr-buildbucket.appspot.com/build/8722540677811929697

Bug: none
Change-Id: Icd487da2c3c5f42457948447c553747f624aa186
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6278476
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-02-18 19:35:22 -08:00
Ergun Erdogmus ee8f643d9a [AiAssistance] Move toolbar to use LitHtml 
Fixed: 396611915
Change-Id: Icd87972bf92cf1b1afed14fab45e6b2168325aab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6278505
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-02-18 09:55:11 -08:00
Benedikt Meurer 037082b1a3 [docs] Update documentation to mention LH and BA components. 
Bug: none
Change-Id: I015b6bb307508a1258ca06a1079d085a17d1718e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276555
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2025-02-18 09:08:49 -08:00
Danil Somsikov 37fb380eaa Simplify data management in the Cookie table 
Remove the unused "cookie folders" feature, stop painting the icon blue just to apply grayscale filter to them, and introduce a CookieData type which holds all the data needed to render a cookie.

The latter is particularly useful to simplify future migration to the <devtools-data-grid>

Bug: 394287937
Change-Id: Ib215000eead0f85df923e4e56759b25f4b38849c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276871
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-18 09:07:20 -08:00
Alex Rudenko 8260d0bc14 [AI Assistance] Implement file editing 
Bug: 393268664
Change-Id: I2461ecdecef9461c8cc9e3f611403af813566c76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6278506
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-02-18 08:08:56 -08:00
Samiya Caur 8648a37b02 [AiAssistance] Add screenshot image input to history 
There is a storage limit (similar to how it is set and calculated in
front_end/panels/recorder/models/ScreenshotStorage.ts)

Pending: A placeholder image in case image is no longer available in history

Bug: 394029490
Change-Id: I797eb9aa77145585e51cbb4df17034f1bc21d15e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276245
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Samiya Caur <samiyac@chromium.org>
 2025-02-18 07:46:56 -08:00
Nikolay Vitkov 91746ae20a [cleanup] Remove unnecessary code 
This code is obsolete with the current typings

Bug: none
Change-Id: I91d93df5a8053442af5c306abba7efaa9a1074d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276554
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2025-02-18 07:36:18 -08:00
Ergun Erdogmus 746bbd8029 [Animations] Fix animations freezing screencast view 
When an animation is captured, we start a screencast
for taking its screenshots for preview and after
finishing taking screenshots, we stop the screencast.

However, if there already exists a screencast (i.e.
if the user is inspecting a remote page using `chrome://inspect`),
after the animations finished taking screenshots, they
stop the screencast for `ScreencastView` too causing the
view to freeze.

This CL:
* Adds ability to stack screencasts in screen capture model.
When it receives a new `startScreencast`, it adds the
existing screencast to a stack and serves to the newly added
screencast.
* Then, when the newly added screencast is stopped, it resumes
the previous screencast from the stack.

Fixed: 395838062
Change-Id: I7ee6df0cbb4e9f7927cb1cb250ceb69e78355a77
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276143
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-02-18 06:18:51 -08:00
Benedikt Meurer f43c9c7f08 [persistence] Introduce initial AutomaticFileSystemManager. 
This adds a new singleton `AutomaticFileSystemManager` whose
functionality is gated behind the `DevToolsAutomaticFileSystems` feature
flag, which attempts to automatically connect workspace folders based on
project settings.

This CL doesn't provide any means in terms of UI in which the user could
trigger a first-time setup of an automatic file system. That will land
in a follow-up CL.

Bug: 395562934
Change-Id: I033b081e6859a04d47462ed916dd6de8edae5be8
Doc: http://go/chrome-devtools:automatic-workspace-folders-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276943
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-18 06:17:47 -08:00
Nancy Li 1b36370496 [RPP Insight] Rename the LongCriticalTree insight to NetworkDependencyTree 
For more information see here: https://docs.google.com/document/d/1zKpNkjJQbCuuPSXiZKwQu5qMscSDqXqjFHSiAHgDFug/edit?disco=AAABb9FRpzg

Bug: 372897712
Change-Id: Ia75da0808c128ffa7ffdf174de317538f1230c51
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6271743
Commit-Queue: Nancy Li <nancyly@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2025-02-18 05:56:49 -08:00
Nikolay Vitkov 2801cc647a [eslint] Add new test case for html tagged template 
With the new change of allowing destruction in the import,
create a test case for this rule as well.

Bug: 397260638
Change-Id: I276d185beb377599cec2cd7fdb526fc33fae98f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6278525
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-18 05:55:06 -08:00
Nikolay Vitkov cdeebfed96 [AI Assistance] Use prettier name for IsolatedWorld 
This user visible so use the name of the product

Bug: none
Change-Id: Ia1b441f1929d2a477e7a1c8cd03375f261f7b431
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6277284
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-18 05:34:20 -08:00
devtools-ci-autoroll-builder 7cdf94065b Update Chrome (for Testing) PIN 
Chromium pin updated to 135.0.7021.0

Roll created at https://cr-buildbucket.appspot.com/build/8722597299783425329

Bug: none
Change-Id: I76aab5c945eb88a7ab973af16b248fbda8899673
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6278350
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-02-18 05:12:48 -08:00
devtools-ci-autoroll-builder 1727dab4f5 Update DevTools DEPS (trusted) 
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/f6b9b8d..2f50fd2

Roll created at https://cr-buildbucket.appspot.com/build/8722597299783425329

Bug: none
Change-Id: I194bd332f96dccc024317d15a201d3f9540c2812
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6278349
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-02-18 05:08:17 -08:00
Jack Franklin bcab82b283 RPP: Add AI Query to fetch main thread activity 
Note: this CL does not give the LLM access to it, that will be a
follow-up.

This CL provides a function that, for a given insight, can return
relevant main thread activity. We might want to expand this in the
future or explore how much context window this might use, but this is a
good starting point.

Bug: 394552594
Change-Id: Iea4eeb8bd87e6d2e04acc84c86536bb3f69a90e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276942
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2025-02-18 04:55:03 -08:00
Jack Franklin b94e444d2b AI: define getNetworkActivity for Perf Insights agent 
This CL allows the LLM to call the function to get the network activity
for a given insight.

In the design doc I explored using time ranges, but so far I am going
for an approach where we query based on the active insight. I think this
reduces the chance of the AI incorrectly passing invalid or incorrect
times, but we can explore and experiment.

Bug: 394552594
Change-Id: I2d5c054391d5802ce46f5c149ee7ce194630fa68
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276941
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-02-18 04:20:46 -08:00
Alex Rudenko 40fc4f5120 [cleanup] assertions without destructuring 
Bug: none
Change-Id: I69770ce4064fd981d891509735c8cf102bb57e6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276101
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-18 04:04:36 -08:00
Changhao Han f4ee86a6a3 Add interest target linking 
This CL adds the frontend part for linking interesttarget=X to X in the
DOM tree.

Bug: 393244954
Change-Id: I088d32baff337f1372ffc68f6fd44e242d8c8f1c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6277291
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
 2025-02-18 02:26:33 -08:00
Jack Franklin 9412902c91 AI: Format and sanitize trace network requests 
Bug: 394552594
Change-Id: I87cd95fcc1d5b40f0c7377550241eb09ab78b73d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6277285
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2025-02-18 02:25:10 -08:00
Nikolay Vitkov 93062643d1 [eslint] Add rule only-throw-error 
https://typescript-eslint.io/rules/only-throw-error/

Bug: 397260638
Change-Id: I2dbdd6006ce21a99818fd6de2e4d727894194e35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6277290
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-18 02:23:53 -08:00
Jack Franklin b36a46bc54 RPP: add AIQueries to look up relevant data 
This CL adds the foundations for an `AIQueries` class that can, for a
given Insight, return the relevant parts of data. Right now we are
starting with network events.

For a given Insight, the querying code will:

1. Calculate the relevant bounds for the insight. This will be from the
   associated navigation (or start of trace) to the next navigation (or
   end of trace). For some insights (currently only "LCP by phase",
   although this will be expanded), we scope the bounds specifically to
   fit the insight.
2. Go through the network requests and find the ones that fit within the
   calculated bounds.

Note that the code to pass this data into the LLM is not written yet and
will be done in a follow-up.

Bug: 394552594
Change-Id: Id5f4f551535bdc33cc2d07a6552e1e583faa5e79
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276829
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
 2025-02-18 02:11:08 -08:00
Alex Rudenko 41614a4d54 [cleanup] unify test assertions style (part 1) 
Adds initial view input data to be returned
when creating the panel instance.

Bug: none
Change-Id: If0e260e1cb610b9ddc28b46f42e3badceb8bfe69
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276569
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
 2025-02-18 02:00:51 -08:00
Nikolay Vitkov 8e194a3244 [DataGrid] Add checkboxes to selected columns 
If the column is visible display a checkbox in front of it.

Bug: none
Change-Id: I6bacdd0a199eb84dd6469c2faa971b53386fab4d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276568
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2025-02-18 01:59:06 -08:00
Kim-Anh Tran f1fa68447c [GM3Restyling] Update Search empty state 
Before: https://i.imgur.com/4fseSiR.png
After: https://i.imgur.com/XPCCama.png
Bug: 325443331
Change-Id: I560c713285b8253678ace0d2e5dd973b39236d0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276530
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2025-02-18 01:39:00 -08:00
Paul Irish 9902d7e4c0 Memory: Swap overview canvas colors on theme change 
Followup from https://crrev.com/c/6265565

Bug:396430493
Change-Id: I961b45b50b8c0e2057174374ef3d6337c93e23f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6277687
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
 2025-02-18 01:21:48 -08:00
Paul Irish 7479044f96 Remove TimelineModel by moving TracingLayerTree into timeline 
Change-Id: Ib3834ead748079304ced7635a7de98f51296727e
Bug: 358583420
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6277145
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-02-18 01:20:44 -08:00
Kateryna Prokopenko a41948d5b5 [GM3Restyling] Update selfXSS dialog 
Also add an option to make dt-close-button small

Screenshot: https://imgur.com/a/6CVoKws

Bug: 325442935
Change-Id: I976ee79583a0b792e9f173eadb2a82d8c542e519
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276567
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2025-02-18 01:19:40 -08:00
Paul Irish bcea1c779b Remove TimelineJSProfile by merging it into SamplesIntegrator 
- Move createFakeTraceFromCpuProfile to SamplesIntegrator static. Hard to say it *belongs* there, but it's a decent home.
- DRY up duplicate nativeGroup impl; SamplesIntegrator's existing one gets a const enum upgrade.

Change-Id: I2d2d31c9a4dd6a8e96a89c627fb0b26f01491e20
Bug: 358583420
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6277146
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-02-18 01:18:36 -08:00