zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-11 06:04:55 +08:00
Code Issues Packages Projects Releases Wiki Activity
2,515 Commits 45 Branches 79 Tags
da7058fcd6d1af73024efd207c85bdacf691aadd
Commit Graph
2515 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Simon Zünd da7058fcd6 Move String#isWhitespace from the String prototype to a utiltiy function 
R=jacktfranklin@chromium.org

Bug: chromium:1050549
Change-Id: Ief2e7c72d6faecd3849e66cfc7300891e22055b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2080372
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-02 09:30:13 +00:00
Simon Zünd b867043d77 Prepare SourceFormatter.js for asynchronous live locations 
To support asynchronous source mapping, live locations must support
asynchronous updates. This CL prepares SourceFormatter.js for
asynchronous live location updates by properly {await}ing calls to
{updateLocations} on the different binding models.

R=sigurds@chromium.org

Bug: chromium:1032016
Change-Id: I347c69ffdd8d9d4870e62bf3bda17cd8dacb250c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2071877
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-03-02 07:51:53 +00:00
devtools-ci-autoroll-builder 463a43439d Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I8d84b5dc989fb8f5d86db4092a83b1fe51034691
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082008
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-03-02 04:12:33 +00:00
devtools-ci-autoroll-builder 6b7a2e6f7b Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/f0f1f40..b03644a

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I7dc1416f330196d2f752cf75c361fb1e5ce1ef2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082004
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-03-02 03:09:52 +00:00
Kham Udom 211ca5084f Fix high contrast in Coverage panel 
You are now able to see usage bar in the grid and the foreground
of the percentage text is set to the correct color on focused.

Before: https://imgur.com/a/NmTkhcl
After: https://imgur.com/a/lCJ7kWn

Bug: 1048378
Change-Id: I1512f8f07d9ca5f5003becacdd27745c5330326e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081872
Commit-Queue: Kham Udom <khamu@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-03-01 21:18:32 +00:00
devtools-ci-autoroll-builder fa12212d50 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/8c2d4f7..f0f1f40

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I45668031318706f092144adf5a4d7799d45691d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081996
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-03-01 12:25:22 +00:00
devtools-ci-autoroll-builder 14187ae25a Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I63dfdb1112843387d18960e9f51ed3c59bc205bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081993
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-03-01 04:19:42 +00:00
devtools-ci-autoroll-builder 16859219d5 Update DevTools DEPS. 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/55ab41d..9ca9c52

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I28cf87c84a35dfabdfea591b33746c144e6075e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081463
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-02-29 12:14:38 +00:00
devtools-ci-autoroll-builder 2b72ed2696 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/2b17c86..8c2d4f7

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/ef2f1b3..fa6ae42

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1e24705..55ab41d

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I9100df56c848cf0606e3631ea4089446224d3015
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081453
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-02-29 03:09:19 +00:00
Jack Lynch ad5c586c30 Add telemetry for keyboard shortcuts 
This CL adds telemetry for keyboard shortcut usage, which will help us
evaluate the success of the upcoming custom keyboard shortcut and
settings discoverability experiments. Discrete actions are added for
each of what we expect to be the most-used shortcuts in the most-used
tools (e.g. debugger.step), and other shortcuts are recorded in an
OtherShortcut bucket.

Dependent on this chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/2053084

Change-Id: Ia7bd751912fd39a09d330707e33fcc1ab13eebcf
Bug: 174309
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2053105
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Brian Cui <brcui@microsoft.com>
 2020-02-29 00:10:39 +00:00
Connor Clark 933525c2bd Audits: Roll Lighthouse to front_end/third_party 
Cherry-picked https://github.com/GoogleChrome/lighthouse/pull/10036 to the 5.7.1 branch.

Bug: 772558

Change-Id: Ia363faf4789d776ddb190126df5d3cb525bd434a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1933901
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: John Emau <John.Emau@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-28 20:18:38 +00:00
Simon Zünd 96c6bce9e4 [utilities] Remove Array#select 
R=mathias@chromium.org

Bug: chromium:1050549
Change-Id: I250037eb025f3e136923d6a75cca21c13bca5c67
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2080373
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-02-28 14:49:17 +00:00
Mathias Bynens f06e8c0758 Enable no-else-return lint rule with autofix 
This rule matches the Chromium-wide coding style.

Bug: chromium:1057042

Change-Id: I21ad946227ca7344146abace1d2f6146b3a6c207
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078924
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-28 14:17:07 +00:00
Paul Lewis 4eca785b40 [e2e] Ensures console messages are populated 
The console messages are populated asynchronously, which caused flakes /
race conditions as we weren't waiting for them to be populated. With
this CL we now wait for population before proceeding.

Fixed: 1056648

Change-Id: I6a5b5b8eb49ee3caf3230455df50c2748dd1f94e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2080371
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-28 13:25:17 +00:00
Tim van der Lippe abfdeeb02f Fix copy-paste error on dir check 
It was still using path, but that is an import. Instead, we should use
the proper computed directory

Change-Id: I5b606f61361082c71d0307225490b98db7d9e8c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078928
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-28 13:13:07 +00:00
Paul Lewis 1a3ae5481b Updates boot perf timing to be 2 decimal places 
TBR=jacktfranklin@chromium.org

Change-Id: I23fe514682101becc24872fdd0048b19b988c5a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078927
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-28 12:39:49 +00:00
Paul Lewis 36122adbd3 [e2e] Migrate http/tests/devtools/search/sources-search-scope.js to e2e 
Original test at https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/search/sources-search-scope.js;l=1;drc=77578ccb4082ae20a9326d9e673225f1189ebb63?originalUrl=https:%2F%2Fcs.chromium.org%2F

Bug: 1032561, 1046784
Change-Id: I3ba6790afedbb88ffbb0f79e8543d6d5440d9fb0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078234
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-28 12:35:48 +00:00
devtools-ci-autoroll-builder 722ed78979 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/0a67df9..2b17c86

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/780e6bf..1e24705

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I8e7c1a205c4a8ceff00b5c6d494682b3dd200460
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2080334
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-02-28 12:18:09 +00:00
Tim van der Lippe e43879a5a2 Fix clicking on labels for checkboxes 
This was a regression introduced in
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2062603
that broke the clicking of the labels corresponding to the checkboxes.

To fix that, we revert the changes to the labels, but keep the
`aria-label`. The label is necessary, as the label and input are in
shadow dom and otherwise do not show the correct descriptive name.

Fixed: 1056324
Change-Id: Ia34210961bcb7f5927dc3663633e27ed82b363ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077666
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-28 12:13:18 +00:00
Jack Franklin af2e27d9d2 Ensure we import errno in ts_library.py 
Without this change I was seeing an error when compiling TS:

```
  File "../../third_party/typescript/ts_library.py", line 119, in copy_all_typescript_sources
    if exc.errno == errno.EEXIST and os.path.isdir(path):
NameError: global name 'errno' is not defined
```

Change-Id: I16654d1a3d0d89346957599150c877b44f734ccc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078925
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-28 12:09:29 +00:00
Jack Franklin 4289552031 Remove String.prototype.computeLineEndings 
In favour of `StringUtilities.findLineEndingIndexes`.

Kept the old code around in the layout tests; I think the duplication is
fine here given these tests are largely deprecated in favour of e2e
tests.

Change-Id: I4f15097c6880a516d9dbc7bb4f5da68a938f63f9
Bug: 1050549
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2060002
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-28 12:03:08 +00:00
Jack Franklin 22b26bddbd Typecheck EventTarget.js 
Bug: 1011811
Change-Id: Icb024e170829bed95f433bf6b02d632ccfc5f06e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078856
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jose Leal <joselea@microsoft.com>
 2020-02-28 11:41:29 +00:00
Jack Franklin 83d3f62f0c TypeScript CharacterIdMap_test into Ninja 
Bug:  1011811
Change-Id: Ia6e1ea374cd6b50170ddef7967633bd2ffe4bd5a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078855
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-28 10:53:28 +00:00
Paul Lewis 65761161be [perf] Updates boot perf test 
Change-Id: I7d8f9cf62638230a1d912c7c12beca02a2883bfa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077658
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-28 10:40:09 +00:00
Jack Franklin aa8dd549d7 Typecheck Common.UIString 
Bug: 1011811
Change-Id: Ib7a1c126ed95ca659d9f73f44869b209f11e3f4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078853
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-28 10:05:28 +00:00
Tim van der Lippe 39fc2547aa Reland "Typescriptify FormattedContentBuilder + move tests" 
This reverts commit 51588addf9.

Reason for revert: Do not copy _test files in ts_library

Original change's description:
> Revert "Typescriptify FormattedContentBuilder + move tests"
>
> This reverts commit 4665866ae8.
>
> Reason for revert: Speculative fix for build breakage which mentions
> typescript:
> Traceback (most recent call last):
>   File "../../third_party/devtools-frontend/src/third_party/typescript/ts_library.py", line 113, in <module>
>     sys.exit(main())
>   File "../../third_party/devtools-frontend/src/third_party/typescript/ts_library.py", line 90, in main
>     copy_all_typescript_sources(sources, path.dirname(tsconfig_output_location))
>   File "../../third_party/devtools-frontend/src/third_party/typescript/ts_library.py", line 109, in copy_all_typescript_sources
>     shutil.copy(generated_javascript_location, dest)
>   File "/b/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/shutil.py", line 139, in copy
>     copyfile(src, dst)
>   File "/b/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/shutil.py", line 97, in copyfile
>     with open(dst, 'wb') as fdst:
> IOError: [Errno 2] No such file or directory: '/b/s/w/ir/cache/builder/src/out/Debug/resources/inspector/formatter_worker/FormattedContentBuilder_test.js'
>
> Original change's description:
> > Typescriptify FormattedContentBuilder + move tests
> >
> > DISABLE_THIRD_PARTY_CHECK=needed typescript gni fix
> >
> > Bug: 1011811
> > Change-Id: I78f4b1286763ab45449b86fba0527e68ab9c258f
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077664
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> > Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
>
> TBR=tvanderlippe@chromium.org,jacktfranklin@chromium.org
>
> Change-Id: I78cca47c227f4c152d0b90099f4a77c082129be8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1011811
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078916
> Commit-Queue: Mathias Bynens <mathias@chromium.org>
> Reviewed-by: Mathias Bynens <mathias@chromium.org>

DISABLE_THIRD_PARTY_CHECK=needed typescript gni fix

Change-Id: Id9d5e0b7f5ad55d23f7605319bca49cc7ca34a05
Bug: 1011811
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078923
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-28 10:02:08 +00:00
Simon Zünd f9f039ff81 Prepare BreakpointManager.js for asynchronous source mapping 
R=mathias@chromium.org

Bug: chromium:1032016
Change-Id: Ibae0f87be4d54f605753db3cd705f57aec6ca5f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2071880
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-02-28 07:08:58 +00:00
Mathias Bynens 51588addf9 Revert "Typescriptify FormattedContentBuilder + move tests" 
This reverts commit 4665866ae8.

Reason for revert: Speculative fix for build breakage which mentions
typescript:
Traceback (most recent call last):
  File "../../third_party/devtools-frontend/src/third_party/typescript/ts_library.py", line 113, in <module>
    sys.exit(main())
  File "../../third_party/devtools-frontend/src/third_party/typescript/ts_library.py", line 90, in main
    copy_all_typescript_sources(sources, path.dirname(tsconfig_output_location))
  File "../../third_party/devtools-frontend/src/third_party/typescript/ts_library.py", line 109, in copy_all_typescript_sources
    shutil.copy(generated_javascript_location, dest)
  File "/b/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/shutil.py", line 139, in copy
    copyfile(src, dst)
  File "/b/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/shutil.py", line 97, in copyfile
    with open(dst, 'wb') as fdst:
IOError: [Errno 2] No such file or directory: '/b/s/w/ir/cache/builder/src/out/Debug/resources/inspector/formatter_worker/FormattedContentBuilder_test.js'

Original change's description:
> Typescriptify FormattedContentBuilder + move tests
> 
> DISABLE_THIRD_PARTY_CHECK=needed typescript gni fix
> 
> Bug: 1011811
> Change-Id: I78f4b1286763ab45449b86fba0527e68ab9c258f
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077664
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

TBR=tvanderlippe@chromium.org,jacktfranklin@chromium.org

Change-Id: I78cca47c227f4c152d0b90099f4a77c082129be8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011811
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078916
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-02-28 07:00:47 +00:00
devtools-ci-autoroll-builder 50f6480b54 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/05fc2f5..0a67df9

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/29d5cf8..780e6bf

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I57a9d57053df774a5abfb437bae50aa3936dbc9e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2079415
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-02-28 03:10:57 +00:00
Ted Meyer 0aab746a16 Switch the Media tab to ES Modules 
crrev.com/c/2057206 broke the media tab by adding an import statement to a
non-module file. I figured that this was as good a catalyst as any to
switch to ES Modules. They seem to be the direction the frontend UI is
going and there doesn't seem to be any regression testing to prevent
breaking changes like this as things keep moving that way, so might as
well get out in front of it.

Bug:1054925
Bug:1006759
Change-Id: I99785423335d234a3d87743e08768f5f8cf56bce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2069297
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-27 20:35:47 +00:00
Jose Leal Chapa 1189a8634d Fix Grid accessibility name. 
This CL addresses a bug in how we read the accessible name of a Grid. It should include the row count when the grid is selected.

- Separate the logic of grid selection from row selection.
- Include the row count when the Grid gets focus.

Image: https://imgur.com/a/W8nILxB
Bug: 963183
Change-Id: I906a4d57191d5f8e0e07bcc2150e672ef8ff1f08
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2075517
Reviewed-by: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: John Emau <John.Emau@microsoft.com>
Commit-Queue: Jose Leal <joselea@microsoft.com>
 2020-02-27 19:07:07 +00:00
Jack Franklin 42c3df1e2d Move Trie test to being built with Ninja 
Bug:  1011811
Change-Id: If5926c20f1847447261ad524afba37d91106e243
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078854
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-27 18:46:57 +00:00
Jack Franklin 4665866ae8 Typescriptify FormattedContentBuilder + move tests 
DISABLE_THIRD_PARTY_CHECK=needed typescript gni fix

Bug: 1011811
Change-Id: I78f4b1286763ab45449b86fba0527e68ab9c258f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077664
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-27 18:25:37 +00:00
Kalon Hinds 025a8b12d0 Remove transparent border-top from Elements tree rows 
Previously, Elements tree rows had a transparent border-top to fix a bug
where there was unclick-able deadspace in between rows. This patch
removes the transparent border-top in favor of padding-top, since the
`forced-colors` heuristic makes these borders visible in high-contrast
mode.

Before: https://i.imgur.com/AEb8sSM.png
After: https://i.imgur.com/MAqFaxf.png
Bug: 1048378
Change-Id: I5c077d344f18d5b3f81419562ed030f5d0f8a9fc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2076623
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
 2020-02-27 17:43:47 +00:00
Tim van der Lippe f2d48b28a9 Run TypeScript without building mode 
We have been seeing spurious CQ runs that complain that Ninja leaves dirty
files behind. Re-reading the documentation [1] leads us to believe that
the usage of the `--build` flag is incorrect. We should led Ninja perform
these deps check, rather than TSC.

Changing the flag to `-p` (which is normal compilation) appears to work
fine. We will need to do additional profiling on the effect of this
change, but we are trying to figure out if this resolves the CQ failures
first, as they are blocking CL submissions.

[1]: https://www.typescriptlang.org/docs/handbook/project-references.html#caveats-for-project-references

Bug: 1011811
Change-Id: I473d610d042af1e0aba22f3d2a260eac4ceb9369
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078852
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-27 16:28:17 +00:00
Jack Franklin 9e6296cd62 Update screenshot testing to enable element screenshots 
Often when testing components we won't want to screenshot the entire
page but instead just a given element. This change updates our testing
API to expose two functions; one to test an element and one to test an
entire page.

Bug: 1051458
Change-Id: I1e410e0085e9038c4345dd815aa3f4b6fa39f9ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2074762
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-27 16:08:27 +00:00
Wolfgang Beyer 29c52f9caf Add toolbar showing count of warnings to issues panel 
Add a toolbar to the issues pane. Its only content for now is an icon
with the number of detected issues next to it. More content will be
added later. Explicitly displaying a count of 0 fixes the confusion
caused by the issues pane being completely empty when there are no
issues to display.

Screenshot: https://imgur.com/mWHVYc0

Fixed: chromium:1053466
Change-Id: I8a325f651d15f76960841b9b69a0693eb53fd63f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078232
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-02-27 15:13:47 +00:00
Al Muthanna Athamina 091710f87c Refactor Console E2E test to use helpers 
This CL attempts to modify the way we access
selectors and manipulate elements for the
Console E2E tests in order to reduce
duplication.

Change-Id: I08ec60712675f6ac8b99e26d9ccc8f0149d86cb0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077663
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-27 12:57:16 +00:00
Jack Franklin fa050212ad Typecheck Common/JavaScriptMetaData.js 
Bug: 1011811
Change-Id: Ib02677b3d65c17c905dfe0171af4b6b5ed2dd3d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2074770
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-27 12:37:36 +00:00
Changhao Han c5b9d9d430 migrate debugger/script-formatter-breakpoints-4.js to e2e test 
original layout test: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-4.js;drc=45107a2b20f840bd1833c33ffdd6383fb56de32d?originalUrl=https:%2F%2Fcs.chromium.org%2F

Bug: chromium:1044632
Change-Id: Ibaaeaf1acb875a59444d23d093f50bfed8fb4d8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077665
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-02-27 12:28:16 +00:00
devtools-ci-autoroll-builder c17b13d57d Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/ff66038..05fc2f5

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/005269a..29d5cf8

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I50c3d7026fa6b04984479befc65cb424f97d22d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078151
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-02-27 12:24:46 +00:00
Jack Franklin a5fd6acfb7 Reland "Extract toBase64 into StringUtilities" 
This reverts commit f0e3491726.

Reason for revert: Layout test that's failing is going to be deprecated.

Original change's description:
> Revert "Extract `toBase64` into `StringUtilities`"
> 
> This reverts commit 75f6eb9ec4.
> 
> Reason for revert: It broke a layout test: https://test-results.appspot.com/data/layout_results/devtools_frontend_linux_blink_light_rel/1731/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html
> 
> Original change's description:
> > Extract `toBase64` into `StringUtilities`
> > 
> > Continuing to get rid of prototype pollution.
> > 
> > Bug: 1050549
> > Change-Id: Id0d03c598b24a547f1b2802eaac680efe631194b
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056812
> > Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> 
> TBR=szuend@chromium.org,jacktfranklin@chromium.org
> 
> Change-Id: Ifc2fda93e8aea375f090f6f18cf6267dcb12fc72
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1050549
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2061731
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=szuend@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org

Change-Id: Ibc692293fa938f473b76b997d357e8dfc665c9df
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1050549
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2061732
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-27 11:55:27 +00:00
Tim van der Lippe 6d727653aa Typecheck common/Worker.js 
Bug: 1011811
Change-Id: I53ad43a7a17a93b32a8c829b77442748c3df964c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077657
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-02-27 11:34:06 +00:00
Simon Zünd 1468dd8d57 Typecheck Throttler.js using TypeScript 
R=tvanderlippe@chromium.org

Bug: chromium:1011811
Change-Id: I68624e230b8e50d3a80e3958e39e8b9b54ebe532
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077659
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-27 10:52:46 +00:00
Simon Zünd 9f5e435205 Revert "migrate debugger/script-formatter-breakpoints-4.js to e2e test" 
This reverts commit 8261847ee7.

Reason for revert: Compilation issue around e2e test
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8887309479570619344/+/steps/E2E_tests/0/stdout

Original change's description:
> migrate debugger/script-formatter-breakpoints-4.js to e2e test
> 
> original layout test: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-4.js;drc=45107a2b20f840bd1833c33ffdd6383fb56de32d?originalUrl=https:%2F%2Fcs.chromium.org%2F
> 
> Bug: chromium:1044632
> Change-Id: I4b3a3d56afdc79c1c5c9bb577d514872d56dce97
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2074763
> Commit-Queue: Changhao Han <changhaohan@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org,changhaohan@chromium.org

Change-Id: I909774787d7595bf6f251027144c6bb9c6676219
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1044632
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077661
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-02-27 10:26:16 +00:00
Changhao Han 8261847ee7 migrate debugger/script-formatter-breakpoints-4.js to e2e test 
original layout test: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-4.js;drc=45107a2b20f840bd1833c33ffdd6383fb56de32d?originalUrl=https:%2F%2Fcs.chromium.org%2F

Bug: chromium:1044632
Change-Id: I4b3a3d56afdc79c1c5c9bb577d514872d56dce97
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2074763
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-27 10:10:16 +00:00
Sigurd Schneider 951d1b78a6 [e2etest] Port layout test to e2e test 
This CL is introducing an e2e test that replaces the layout test

https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/startup/resources/database-open.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63?originalUrl=https:%2F%2Fcs.chromium.org%2F

to an end2end test.

Bug: chromium:1044632
Change-Id: I498959c0c7368ca9b806de20d6530a4b68e3f6b7
Also-by: tvanderlippe@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2074760
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-27 08:47:51 +00:00
Simon Zünd 77bd460583 Prepare DebuggerPlugin.js for asynchronous source mapping 
R=sigurds@chromium.org

Bug: chromium:1032016
Change-Id: Ic422aaabb7ecb676241c2085f3417338daad1a31
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2071881
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-02-27 08:46:46 +00:00
Gabriel Luong c11ee67062 Typecheck common/AppProvider.js, common/Runnable.js and common/StringOutputStream.js with TypeScript 
Bug: 1011811
Change-Id: Ie47abb211cdab5b9cfbb88505143a75b41d59394
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077157
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-27 08:22:16 +00:00
Yang Guo d8e762cd82 Add Jack to OWNERS 
R=aerotwist@chromium.org

Change-Id: I967bde6842785c20b82b9193304eecf0b8a312ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077177
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-27 07:01:26 +00:00