zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-29 16:57:00 +08:00
Code Issues Packages Projects Releases Wiki Activity
23,969 Commits 43 Branches 79 Tags
dadb165d35b12c0a7c62a5bf9830fd67d1538f73
Commit Graph
23969 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jack Franklin dadb165d35 Add @types/yargs 
Useful for scripts that we write.

Bug: none
Change-Id: I2732c6af54cf0575aec338e4c5512231a1bc1df1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6172330
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2025-01-13 21:07:49 -08:00
devtools-ci-autoroll-builder 6735e27bb2 Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/bbdae0b..f1eca0e

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/59f9fba..a660247

Rolling buildtools/linux64: git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd..git_revision:ed1abc107815210dc66ec439542bee2f6cbabc00

Rolling buildtools/mac: git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd..git_revision:ed1abc107815210dc66ec439542bee2f6cbabc00

Rolling buildtools/win: git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd..git_revision:ed1abc107815210dc66ec439542bee2f6cbabc00

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a912cd2..b576ab3

Roll created at https://cr-buildbucket.appspot.com/build/8725802167614214817

Bug: none
Change-Id: I0991a9542e9473da9ef8e6d1bd62a409dd95832a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6174234
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-13 19:43:58 -08:00
devtools-ci-autoroll-builder 0b2e395290 Update Chrome (for Testing) PIN 
Chromium pin updated to 134.0.6955.0

Roll created at https://cr-buildbucket.appspot.com/build/8725802167614214817

Bug: none
Change-Id: I7c61d633e10fdcc5834e22fb56145eefff2a06bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6173843
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-13 19:38:06 -08:00
Seth Brenith 1ea78154d9 Reduce the number of inferred interfaces for heap snapshots 
When implementing categorization of objects by interface, I used an
arbitrary limit of 1000 interfaces. After using this implementation, I
believe that 1000 is far too high: it creates a long tail of low-value
categories that don't help analysis. In this change, I propose a
different heuristic, where each inferred interface must match at least
1 in 1000 Objects. The exact number of interfaces generated with this
approach varies; I've seen from 52 to 117 in some brief manual testing.

Bug: 356183770
Change-Id: I8604130503e0c03212294bee07cdd4c3892bc5cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164863
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2025-01-13 08:29:48 -08:00
Ergun Erdogmus 79efda09d9 [Animations] Fix animation toolbar not rendering pause button 
We were setting `display: inline-block` on the animation toolbar
and this started overriding `display: flex` property
from the base template.

This CL removes setting `display: inline-block`
to correctly display all items of the toolbar on
the same horizontal area.

Bug: 388445687
Change-Id: I9876bf4fedeb584af0ed9a3ca514170038289956
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6170214
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-13 06:23:09 -08:00
Andrés Olivares 5c7ee90f94 Manually roll puppeteer-core 
Manual changes are in PuppeteerConnection, which removes the `product`
param when calling `Browser._create`

Bug: none
Change-Id: I90c86874785c19be5cde4e60b158511327f14b22
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6167551
Auto-Submit: Andres Olivares <andoli@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2025-01-13 06:01:14 -08:00
Changhao Han 2ec355e93c Add visual hints to the patterns docs 
Bug: None
Change-Id: Ie4008dd5549365c8ebcf0637afcacdeb74e471fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6171574
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2025-01-13 04:59:14 -08:00
devtools-ci-autoroll-builder 73474d9bdd Update DevTools DEPS (trusted) 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fd65288..a912cd2

Roll created at https://cr-buildbucket.appspot.com/build/8725858791531212081

Bug: none
Change-Id: If315560a93ebbe116a96a7e4bb31e4871dfaca4a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6169178
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-13 04:48:25 -08:00
devtools-ci-autoroll-builder 1d30495825 Update Chrome (for Testing) PIN 
Chromium pin updated to 134.0.6954.0

Roll created at https://cr-buildbucket.appspot.com/build/8725858791531212081

Bug: none
Change-Id: Ied4789f81b79b0efb78b6bcdcb08de6b637c050a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6169179
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-13 04:47:22 -08:00
Ergun Erdogmus b371fc2718 [Elements] Render animated styles & update them in real time 
This CL:
* Integrates `getAnimatedStylesForNode` method in CSSMatchedStyles
initialization if the feature flag is enabled.
* Listens to `COMPUTED_STYLE_CHANGED` events from ComputedStyleModel
if the feature flag is enabled and, upon receiving it, goes over
animated styles from matched styles and either updates the values
or re-renders the Styles tab if the cascade might have changed.

Fixed: 349566291
Change-Id: I5f428f54aa4fdf42b17710dd38a1dead4a601b2b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6088224
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2025-01-13 04:23:21 -08:00
Jack Franklin e8b619ebb2 AutoAI: create tests for parseComments 
Ahead of making some changes to the splitComments function, this CL
moves it into its own file that can easily be tested. The function has
also been renamed to `parseComments` which is a bit more accurate.

I considered just exporting the function from auto-run.js, but
auto-run.js assumes it is invoked on the command line, so rather than
restructure it to support being imported for tests, it was easier to
move the function into a separate helpers file.

Bug: 383120286
Change-Id: Icdd3a730def908fa180152981f2765cbf6e55c6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6171176
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-01-13 04:12:27 -08:00
Ergün Erdoğmuş 9e13313a48 Update translations for M133 
Fixed: 389598244
Change-Id: Ic0aa0ed02f999645fd0f2b7b115ce1ace741eeed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6170693
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2025-01-13 03:24:39 -08:00
Yang Guo 8256a54a5d Add context menu item to copy console to clipboard 
Fixed: 384967020
Change-Id: I67301b77cf485c633875dd914e11bf3af9fbe570
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6170694
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-01-13 03:20:09 -08:00
Kim-Anh Tran 3da950f835 [GM3Restyling] Update DOM breakpoint empty states 
This CL introduces general css classes for empty states and updates
the DOM breakpoint empty states UI.

Before: https://i.imgur.com/bMeGCqE.png
After: https://i.imgur.com/CDKRE7o.png
Bug: 325443331
Change-Id: Iee914e2d9441b536953ca7233311edc8dd8c7398
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6152575
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-01-13 02:43:53 -08:00
Wolfgang Beyer 40f57f86c5 [AI settings] Update disclaimer bullet points 
Screenshots: https://imgur.com/a/s8eXtu0

Bug: 372196790, 381375534
Change-Id: I8eb7cdbe2bf9dc014abc369bb5836840b13a2c66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6170691
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2025-01-13 02:15:42 -08:00
Jack Franklin e93ae5e5cc Lantern: remove ts-nochecks from tests 
- Simulator
- ConnectionPool
- DNS Cache
- BaseNode

Bug: 348449529
Change-Id: I4ca7c72ceccdabbcdd1dc21f899cdf81d25f5c2d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6167550
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
 2025-01-13 01:25:00 -08:00
Changhao Han f856b1657a Add patterns to UX guideline 
Bug: None
Change-Id: I7a9dc66990aee65ed5a24677b75ebdd29dbf4e52
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6171573
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2025-01-13 01:10:22 -08:00
Benedikt Meurer ffc29994a0 Fix Performance/Network panel toolbar. 
The Network and Performance panels keep the settings button on the
right always, even when the rest of the toolbar items wrap around.
This fixes the CSS to restore this looks.

Fixed: 388956590
Bug: 388445687
Change-Id: I302720c1325eca73ca5f81b2af2803df775cfd85
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6171170
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2025-01-12 23:06:09 -08:00
devtools-ci-autoroll-builder a9ffd92dbe Update Chrome (for Testing) PIN 
Chromium pin updated to 134.0.6953.0

Roll created at https://cr-buildbucket.appspot.com/build/8725892765520615393

Bug: none
Change-Id: I7da2f97bf0b35d3f39b3264b4f6116ebb9386b26
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6169173
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-12 20:08:19 -08:00
devtools-ci-autoroll-builder 68a2bfd526 Update DevTools DEPS (trusted) 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6cbd7a8..fd65288

Roll created at https://cr-buildbucket.appspot.com/build/8725892765520615393

Bug: none
Change-Id: I0315120a1d3b1dad7b0960f04a8987e684119ea7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6169253
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-12 20:01:12 -08:00
devtools-ci-autoroll-builder e79621229e Update Chrome (for Testing) PIN 
Chromium pin updated to 134.0.6952.0

Roll created at https://cr-buildbucket.appspot.com/build/8725949388033057009

Bug: none
Change-Id: I68849443973c0c36cabe9ebefcf5a3b0681ffd5c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6169171
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-12 04:46:40 -08:00
Benedikt Meurer 4b78c22ab7 [cleanup] Remove .checkbox CSS class and unused small parameter. 
Bug: 388445687
Change-Id: I5389d6fed8f3127c99612d1c073fc179b570de2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164905
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-01-12 02:15:21 -08:00
devtools-ci-autoroll-builder c7b23e12d4 Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/7b5248c..bbdae0b

Roll created at https://cr-buildbucket.appspot.com/build/8725983362512687729

Bug: none
Change-Id: I628feca86c37aaf9f1a8df9a889a881abd874dc8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6169169
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-11 19:48:07 -08:00
devtools-ci-autoroll-builder 4590d3a54c Update Chrome (for Testing) PIN 
Chromium pin updated to 134.0.6950.0

Roll created at https://cr-buildbucket.appspot.com/build/8726039986252838097

Bug: none
Change-Id: If8c47032042ba16c7ee97222cba5b527fbfc6bf3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6169651
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-11 04:45:57 -08:00
devtools-ci-autoroll-builder 441ec12c25 Update DevTools DEPS (trusted) 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/423f1e1..6cbd7a8

Roll created at https://cr-buildbucket.appspot.com/build/8726039986252838097

Bug: none
Change-Id: Ie39f0e1ce50baea29cd36852698f15bd52a59b3b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6169067
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-11 04:39:53 -08:00
devtools-ci-autoroll-builder 516123f515 Update Chrome (for Testing) PIN 
Chromium pin updated to 134.0.6949.0

Roll created at https://cr-buildbucket.appspot.com/build/8726073958862424801

Bug: none
Change-Id: I73b55cd8c18c5face8e4b906e697a44476de8b84
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6169648
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-10 19:58:19 -08:00
devtools-ci-autoroll-builder cd709e509d Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/b2b443d..7b5248c

Roll created at https://cr-buildbucket.appspot.com/build/8726073958862424801

Bug: none
Change-Id: I58d062b304754582cf33e9dc698e67a2c915a125
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6169647
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-10 19:56:29 -08:00
“jalonthomas” 8245ed1528 Add VE logging for Flag Controls and Cookie Report elements 
We will now track clicks on the "Controls" and
"Third-party cookies" sidebar elements. Also, tracks clicks
on each of the controls tool's checkboxes and the toggle.

Bug: 386355192
Change-Id: I7e5f5ce1cf03cb931a47d3e86d29f1e83c568ee5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6125938
Reviewed-by: Shuran Huang <shuuran@chromium.org>
Commit-Queue: Jalon Thomas <jalonthomas@google.com>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-01-10 15:54:33 -08:00
Connor Clark ed19c1e898 Add calibrated CPU throttling presets 
Adds two CPU throttling presets - low-tier mobile and mid-tier mobile - and a calibration process that determines the best throttling rate to
match the given preset.

The calibration process uses a benchmark and experimentally adjusts the
applied CPU throttling to discover the rate that produces the most
similar results.

See go/cpq:adaptive-throttling for more detail.

Bug: 311438112
Change-Id: Iee049f6c8e9c33ec1dee9799eeb8e370c32d9f0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6151074
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2025-01-10 10:23:29 -08:00
Connor Clark 8284692127 Update test function in heap_profiler_test_runner.js 
Bug: 388589515
Change-Id: I8093c20087ba15276fe0a0706060d1ac5f2bfc9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164864
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2025-01-10 10:05:14 -08:00
Alina Varkki 4b3bc1a8b7 [RPP] Open the shortcuts dialog on the timeline load instead of the performance panel load 
Bug: 388605257
Change-Id: Idf5ae01a45fd6a1618404ee5e39ea276359e2c60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6163609
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
 2025-01-10 10:03:13 -08:00
Adam Raine 7157865129 [LargestImagePaintHandler] Ignore image paints after LCP 
This refactors the handler to find largest image paints only by their
node id and process id (since node ids are only unique within their
renderer process).

Bug: 389074106
Change-Id: I1022db9eaf80ccf51fe412bd2aa1d05e35243fdc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6166302
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2025-01-10 09:03:06 -08:00
Eric Leese be9c8f491f Display option to force :open pseudo class 
Bug: 383157184
Change-Id: Ib12a89c8914fe4ff2761dfea823979b8966d4fed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164989
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Eric Leese <leese@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2025-01-10 07:59:18 -08:00
Shuran Huang ec4c0fcc20 Update strings to use mode b language. 
Bug: b/388845293
Change-Id: I9f9200ba6401c01dda92077914b7c48be70e1371
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6165443
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Shuran Huang <shuuran@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-01-10 07:28:23 -08:00
Benedikt Meurer 11d8d4ca89 [ui] Switch ListWidget to render toolbar via lit-html. 
While this isn't the perfect example yet, it's a great initial
proof-of-concept.

Bug: 388445687
Change-Id: I024a0a4ef0eb4c93d465c34fa59bb114c573a1eb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164906
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2025-01-10 07:21:09 -08:00
Benedikt Meurer 461ebb8b02 [cleanup] Fix and unify Toolbar.createActionButton. 
Bug: 388445687
Change-Id: I39b26edd649c6d783a4eeaf6ddb9265889e643d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164907
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2025-01-10 06:50:09 -08:00
devtools-ci-autoroll-builder 25c4d59791 Update Chrome (for Testing) PIN 
Chromium pin updated to 134.0.6948.0

Roll created at https://cr-buildbucket.appspot.com/build/8726130581979273233

Bug: none
Change-Id: Ia2f04249ba717f33a0ef8bded87162f42f093913
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6165446
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-10 04:58:32 -08:00
devtools-ci-autoroll-builder fbe5f4a8ef Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/39929a4..b2b443d

Roll created at https://cr-buildbucket.appspot.com/build/8726130581979273233

Bug: none
Change-Id: If2b68907351ce2d9e83f494eb292bf20465be7b8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164395
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-10 04:54:15 -08:00
Benedikt Meurer 32ab302551 [cleanup] Remove Toolbar.orientation. 
We really misused vertical toolbars in the past, as a way to build the
UI of the settings panes within the Network, Console, and Performance
panels.
These weren't really toolbars, and there's also no good reason to even
need the toolbar here, since what we really want is a stupid grid.

Bug: 388445687
Change-Id: Ibd531823c5e5ad09829630656409a1e32b5d43ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164904
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-01-10 04:48:02 -08:00
Nancy Li 1929397ba2 [RPP icicle blowtorch] Clean the test code 
Before this change, the interactions in the previous tests will affect the later ones. So just clear the ignore list before each test so the tests are individual and can be run separately.

Fixed: 383099297
Change-Id: I2c847fc10885bf834953c41b99dfc86622ddd468
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164903
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
 2025-01-10 02:20:50 -08:00
Benedikt Meurer c4bb18a354 Unify <select> styling and remove .chrome-select. 
With this CL, we remove the `.chrome-select` CSS class and the two
different ways of styling a `<select>` element (excluding the completely
custom thing in the Recorder panel), and only have one set of styles
that we use consistently for all `<select>` elements (modulo the one in
the Recorder panel b/c LitElement), independent of whether the
`<select>` is used in a toolbar or elsewhere.

That means we can now simply put a `<select>` directly into a
`<devtools-toolbar>` and it will work as expected.

Drive-by-fix: Skip the test from crbug.com/383478771 completely now,
since even though the `<select>` in the Recorder panel is unaffected
by these changes, some surrounding (likely) timing changes now make that
test fail consistently, not only on Mac.

Bug: 383478771, 388445687
Change-Id: I01d7835d5858cac8863a7337a8e43a49b55820f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6163607
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-10 00:45:56 -08:00
devtools-ci-autoroll-builder e6bffbe169 Update Chrome (for Testing) PIN 
Chromium pin updated to 134.0.6947.0

Roll created at https://cr-buildbucket.appspot.com/build/8726164555022836113

Bug: none
Change-Id: If20d52c9d69548feee99b7a11ce6c990a02a9ece
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164393
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-09 20:05:29 -08:00
devtools-ci-autoroll-builder 9fb0b35deb Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/fdd1d9a..39929a4

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/dc74188..59f9fba

Roll created at https://cr-buildbucket.appspot.com/build/8726164555022836113

Bug: none
Change-Id: Ia4b9379d2038562df0833eaf6941f171047098f4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6165445
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-01-09 19:54:44 -08:00
Adam Raine 82e6b18a38 [WebVitals] Do not store interaction target nodes 
This is a manual modification of the web-vitals.js library to prevent
it from retaining DOM nodes. In some cases the DOM node may be removed
before DevTools can make a reference for it, but that is preferable to
keeping the node in memory when the user does not expect it.

Bug: 376777343
Change-Id: I507273c93a4bbe5f2f5111e1a17e179efc583ef4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6159204
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
 2025-01-09 15:30:49 -08:00
Benedikt Meurer 6bfc05159d [cleanup] Remove the .toolbar-item CSS class. 
This is the next step required to eventually be able to just add
elements to the <devtools-toolbar> without having to go through the
imperative Toolbar API.

Bug: 388445687
Change-Id: I912f2d4a1285af7fab63a5268c5c0a3baa556462
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6163603
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-01-09 11:14:08 -08:00
Connor Clark 7710a43187 Use i18n.ByteUtilities.bytesToString in heap profiler 
This replaces displaying bytes as big numbers of bytes, to dynamically
adjusting the unit.

Bug: 388589515
Change-Id: I6d13841c1b5b13df424f00e2ea4c7c740ed7857e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6159568
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
 2025-01-09 10:55:06 -08:00
Jack Franklin 7cb1b26c46 Lantern: remove nocheck from NetworkAnalyzer.test.ts 
Bug: 348449529
Change-Id: Ifd958402e040db705ced9d774759c2172cc5e318
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6162515
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2025-01-09 10:33:42 -08:00
Joshua Thomas 5cc20c1a5a Add setCookieControls CDP command to frontend 
This CDP command is intended to be fired every time a related
setting is changed.

This CL also removes the infobar whenever the page is reloaded
instead of only when the infobar is pressed.

Bug: 375352611
Change-Id: I261e5d4bba0f63f0199f8387733816b8beb1d4db
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6105875
Reviewed-by: Shuran Huang <shuuran@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Joshua Thomas <masnoble@chromium.org>
 2025-01-09 10:05:26 -08:00
Wolfgang Beyer bc4066f67b [Console Insights] Search RAG direct citations: link to references 
section and highlight

The direct citations/footnotes rendered via MarkdownView now link to
the references section instead of directly to the source URL. On
click, the references section is expanded and the corresponding URL
highlighted.

Polished the code by using extended markdown's footnote syntax for
direct citations.

Also added a sub-heading for indirect citations if there are both
direct and indirect citations.

Screencast: https://i.imgur.com/VP6vRV6.mp4

Bug: 381228083
Change-Id: I479b299a609a2b63690c53593af1507ba2ba269a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6157982
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2025-01-09 07:17:05 -08:00
Adam Raine a2d550676e Fix PRESUBMIT.py bug allowing excluded files to be checked 
Bug: None
Change-Id: Ieee9b46650d75fa5a5e5aca5dc6d5c70efc4312c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6163963
Auto-Submit: Adam Raine <asraine@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2025-01-09 07:16:02 -08:00