zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-01 01:38:07 +08:00
Code Issues Packages Projects Releases Wiki Activity
6,528 Commits 43 Branches 79 Tags
e4d64e7ae0f7d449ce3f8b1364b28362baae4c80
Commit Graph
6528 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Tim van der Lippe e4d64e7ae0 Remove unrestricted from comments that include other annotations 
For all comments that contained both the unrestricted annotation
and any other potential annotation, remove only the unrestricted
annotation.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: I27dd67f657cdb1a9233d768eea81cabe2591f5f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569759
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-02 15:31:52 +00:00
Tim van der Lippe 2e38eeaf9f Remove all comments with only the unrestricted annotation 
The unrestricted annotation is Closure-specific and can be removed.
This patch removes all comments with only the unrestricted annotation
in them.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: Iba0723644f53f5307c3077d341271af86becc32a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569758
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-02 15:25:32 +00:00
Wolfgang Beyer cf7f240714 [DarkMode] issuesPane.css 
Migrate issuesPane.css to new dark mode.
Drive-by: disable legacy-patching for cspViolationsListView.css, which
contains no color values.

Bug: 1152736

Change-Id: Ia4e44d07a0eb72f794fa89a011a7a0d090b1b928
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569755
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-02 14:54:29 +00:00
Tim van der Lippe 3fa8654ce6 [DarkMode] Migrate files without color definitions 
For all of these files, there was no occurrence of the word "color"
in them. Therefore, most of these files were complete noops.

There were two exceptions: some white backgrounds and a box shadow
used for image previews in the sources panel. For the latter, a new
CSS variable is extracted into themeColors.css

R=jacktfranklin@chromium.org

Bug: 1152736
Change-Id: I40f2f1e28cc3c7038b831003f1eb32cc923b411a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567113
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-02 14:52:49 +00:00
Jack Franklin fc495906c3 Enforce no TS non-null bang assertions 
This CL bans the TS `!` operator which is used to assert not null.

Typically when we use this we are making errors harder to track down
should the value actually end up being null. Checking it takes more work
but will give nicer errors.

Fixed: 1154182
Change-Id: I11599541c199204e4ca21c9fd81a256614d70389
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566804
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-02 14:46:50 +00:00
Philip Pfaffe 708087ed38 [Sources] Fix the code mirror context menus 
Fixing the sources panel's gutter context menu broke the editor's
context menu. This CL adds back seperate handling for the editor.

R=bmeurer@chromium.org

Bug: chromium:1154101
Change-Id: I1333c1a7b74146ebeed454f6aea5751bccbde5cf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567957
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2020-12-02 14:14:09 +00:00
Tim van der Lippe bfcaca046e Update remaining outdated packages 
- Update yargs to 16.1.1
- Update @rollup/plugin-commonjs to 17.0.0
- Update @types/codemirror to 0.0.100
- Update Puppeteer to 5.5.0
- Update Rollup to 2.34.0

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Change-Id: Ie3ed95b7c83ec615122643769ff5c53ac4111c09
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567910
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-02 13:07:39 +00:00
Simon Zünd 7ba7696cf1 Prepare Trust Token report view for result section 
This CL adds the trust token operation result to NetworkRequest and
forwards the data to the Trust Token tab in the Network panel.
As the operation result can arrive after the report was initially
rendered, this CL adds a new event to trigger a re-render as
necessary.

The CL doesn't yet add the rendering for the result itself, just
prepares the component to have the necessary data.

R=jacktfranklin@chromium.org

Bug: chromium:1126824
Change-Id: I9c6c080de9268219cd8b4b12804a7ca7c4de39a8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567783
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-12-02 12:48:49 +00:00
Jack Franklin 4ad73a3220 Move --drop-shadow into themeColors.css 
Peter Muller & I chatted and decided that the `--drop-shadow` variable
is fine as is and doesn't need changing. Moving it out of
`inspectorStyle.css` into `themeColors.css` to signify that so people
know they can use it when doing dark mode migration work.

Bug: 1152736
Change-Id: Ia492ae6c2f31c44892a1cba2b7f5a6eceb7f135a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567965
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-02 12:46:29 +00:00
Jack Franklin ea36cd3b48 [Dark mode]: network/requestInitiatorView.css 
Bug: 1152736
Change-Id: I7072e3b46805811cc57777bf3b60db6098759920
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567964
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-02 12:44:19 +00:00
devtools-ci-autoroll-builder 099f037728 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/4fd0dec..96c0729

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6d2a0fe..80cea4f

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I73419c8448e9048a59eebeb057da3f7de7a887d1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569610
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-12-02 12:26:54 +00:00
Jack Franklin d03553a552 [Dark Mode]: inspector_main/renderingOptions.css 
Bug: 1152736
Change-Id: I1eef2d545afc7ca2dcc42094770e92e2489026ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567962
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-02 12:25:49 +00:00
Jack Franklin d1cf72489a [Dark mode]: network/RequestHTMLView.css 
Bug: 1152736
Change-Id: I04d2b1cf567d45a240ff55b30cfa813326b8acd6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567963
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-02 12:19:03 +00:00
Jack Franklin eefa5f3d78 [Dark Mode] swatchPopover.css 
I've left the --drop-shadow variable alone for now and pinged Peter to
ask about the plan for those variables moving forward.

Bug: 1152736
Change-Id: I15c9853be7c6775a70b7ea0eb2713d5d8ac9d9ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567959
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-02 12:17:09 +00:00
Philip Pfaffe e0f6048d5a Wait explicitely for expected number of scope values 
Bug: chromium:1154188
Change-Id: Ia1336bda2e6ce7327062629053f823bef966b7c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567786
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-02 10:01:57 +00:00
Alex Rudenko 9c8adb72dd Disable flaky recorder test 
Bug: 1154575
Change-Id: Ia13da28f270b202fe0a7c35288c83e21e2ea88aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567784
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-02 09:59:17 +00:00
Philip Pfaffe f2c25cd3bf [wasm-debug] Less eagerly start typing watch expressions 
The new debugger language plugins error messages test is flaking. One
possible reason could be that we're trying to type into the watch
expression window too eagerly.

Bug: chromium:1154188
Change-Id: I9f6e1868cdb94f1536399b0da51544e0e3180b64
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566797
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-02 09:26:47 +00:00
Alex Rudenko 71d19252cc Remove obsolete global types in overlay tests 
Change-Id: Ia00f2073049d9caac096f07623f2cadf002dfe0c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567114
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-02 09:01:17 +00:00
Alfonso Castaño 256c919c0d E2E Tests for CSP Violations tab 
Apart from the actual tests, it introduces a helper to get the content of the cells of a Datagrid.

Bug: chromium:1137837
Change-Id: I167507d932a633d6f5d92c9ca59e99106d73935f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2563822
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-02 08:54:47 +00:00
Yisi 0aa8412cfb Fix: the copy() function respect the indentation in settings 
This CL change will be consistent with[1]

[1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2549205

Bug: 1150797

Change-Id: I277a75f6cd6d41ab659b741a6d654aeaff774c43
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560322
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-12-02 08:32:47 +00:00
Alex Rudenko d5071440f3 Disable flaky font editor e2e tests 
Bug: 1154560
Change-Id: I67f4a2719f7bbd9e7bd0f1fdb7672ac9cddb4be5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567780
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-02 08:16:47 +00:00
Christy Chen 5d7848d54d Reland "[Loc] Migrate changes tool to localization V2" 
This reverts commit 9e5ab71e50.

Reason for revert: The Cl was reverted due to devtools pak file limitation. That issue has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2558341

Original change's description:
> Revert "[Loc] Migrate changes tool to localization V2"
>
> This reverts commit abcb8f7aa8.
>
> Reason for revert: Consistently causing autoroll issues when rolling devtools-frontend into Chromium - see https://chromium-review.googlesource.com/c/chromium/src/+/2554521 for an example.
>
> To recreate this, do a debug build of Chromium with this patch applied to DevTools. It's causing an issue with duplicate keys in the pak files. No DevTools Frontend builds do a debug build of Chromium with the DevTools frontend patch applied so our CQ will be green despite causing an issue.
>
> You can run this locally in Chromium to reproduce via:
>
> autoninja -C out/Default chrome:packed_resources_extra
>
> Which will show the error. 
>
> Original change's description:
> > [Loc] Migrate changes tool to localization V2
> >
> > Migrate changes tool
> > Tested with en-XL: https://imgur.com/a/hFDBjQV
> >
> >
> > Bug: 1136655
> > Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
> > Commit-Queue: Christy Chen <chrche@microsoft.com>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> TBR=szuend@chromium.org,chrche@microsoft.com
>
> Change-Id: I94b27434562f6a6bff3be381ab8a5802bd8b03f9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1136655
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557044
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

TBR=szuend@chromium.org,chrche@microsoft.com,jacktfranklin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1136655
Change-Id: I35166a6f4f38462073b933c01c169b3c8d14311b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567344
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-12-02 06:13:17 +00:00
Kalon Hinds de5da1203d [Loc] Migrate snippets to Localization V2 
Bug: 1136655
Change-Id: I724747d248b047ce85761b9ec7c6ae512c939ddb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548691
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-01 21:54:27 +00:00
Michael Liao 6035f4a583 [Font Editor Prototype]: Implements Experimental Typography CSS Editor in Styles Pane 
Reference Document: https://docs.google.com/document/d/1zvmKDfdgVgL-QX2W4nKfgoeG_69YDF0AsLerIzL3rPE/edit?usp=sharing

Explainer: https://docs.google.com/document/d/1TmvbZuJR4fHuViE0X23y_1kUT43qt98mdj5GZxWf_W0/edit

Bug: 1093229
Change-Id: I0a8d049bd564a5ba547466067a12185565af7820
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2305613
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Tony Ross <tross@microsoft.com>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
 2020-12-01 19:54:05 +00:00
Changhao Han 225d4f420c Sort HAR exported logs by startedDateTime 
This CL ensures that the exported HAR logs are sorted by startedDateTime
both for requests and for pages.

Fixed: chromium:1116462
Change-Id: I1f47d598462d8ad3e8e66e8a0d7874f603f3dfd5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2564873
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-12-01 17:49:45 +00:00
Tim van der Lippe efb716af67 Update linter packages 
- Updates stylelint to 13.8.0
- Updates ESLint to 7.14.0
- Updates @typescript-eslint to 4.9.0

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Change-Id: I207e204607ede782710e042c17d6510c7f696905
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566806
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-01 16:04:40 +00:00
Jack Franklin 3425b19038 Fix missing DEP to CSS files from unit tests 
This fixes a bug where on an empty build `npm run auto-unittest` would fail with errors about loading CSS files. There were two problems:

- in the build graph, the unit tests did not have an explicit dep to the
  legacy_css group
- the legacy_css group was missing some deps itself, so some modules did
  not have their CSS put into the right place.

Fixed: 1153625
Change-Id: Ib08f14a3d61ee0e55e492cc824ddf806d751e787
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567116
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-01 16:03:35 +00:00
Jack Franklin e2fe0e4a4b [Dark Mode]: migrate CSS files with no colors 
This CL batches up changes to multiple CSS files where they had either
no colors to change, or one very easy color to change.

Bug: 1152736
Change-Id: I061ebd909539dfaca7e8c3a70b0e97f0a0ba5f07
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567115
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-01 15:59:15 +00:00
Jack Franklin 79636f9246 [Dark Mode]: components/jsUtils.css 
No colors in the actual CSS File.

Bug: 1152736
Change-Id: I839a9ab1a6e0cc626dc9aad49514fcf514c7d39f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567112
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-01 15:14:55 +00:00
Alfonso Castaño b2302644f8 Display CSP Violations in a new tab drawer 
This CL introduces a new experimental tab drawer listing all CSP Violations.
It enables searching, sorting and filtering by categories of violations.

Design-doc: https://docs.google.com/document/d/1Zqd6Fq1g_Wb8Ies40OU1TSQ4f402cILFk4Nn_kP-_Cc/
Screenshot: https://i.imgur.com/ivAo61u.png
Bug: chromium:1137837
Change-Id: Ib7997b9ab59658871234ba557da8c20f50019311
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2538838
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Alfonso Castaño <alcastano@google.com>
 2020-12-01 15:12:35 +00:00
Andres Olivares 0e3a9e8db9 Migrate ui/ActionRegistration.js to .ts 
Bug: 1134103
Change-Id: I05c38b489df32c87c770f10c2b930b21be005f41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566441
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-01 15:10:55 +00:00
Kim-Anh Tran b11a912940 [LMI] Bind lifetime of Uint8Array to Linear Memory Inspector 
This binds the lifetime of the remote object that represents
the Uint8Array to an object group corresponding to the
linear memory inspector. This allows the user to step and finish
execution, and still inspect the same object.

Also-By: bmeurer@chromium.org
Bug: chromium:1110202
Change-Id: I1489f01ab30aee4ce87b995a7e23a19c8acce941
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2564862
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-01 13:46:35 +00:00
Tim van der Lippe 08ecb1751c [module.json extensions] browser_debugger views 
R=andoli@chromium.org

Bug: 1134103
Change-Id: I6751bbf874b4e42b4650398d8d5c121e748fed6e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2565573
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-01 13:20:55 +00:00
Tim van der Lippe 75c2c9cff5 Disable @typescript-eslint/no-unused-vars 
The newest version of @typescript-eslint errors on declare globals.
While this is usually good to point out, we have legitimate usages
of these statements. Based on the discussion in
https://github.com/typescript-eslint/typescript-eslint/issues/2519
it seems unlikely this will be fixed anytime soon. Therefore, let's
disable these specific lines to unblock our upgrade of the linter.

R=jacktfranklin@chromium.org

Change-Id: Iee6339428eef0d5496783850a9026fed00942bcb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566807
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-01 13:18:25 +00:00
Yisi 3ceec8ebf9 Fixed copy declaration(context menu) with no space after colon 
Before: padding:10px; or padding:   10px;
After: padding: 10px;

This is more readable and consistent with `Copy all declarations`.

Bug: 1152391
Change-Id: I636c3e110325b09effe69cc1c5fb722b336ced17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566428
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-12-01 12:51:16 +00:00
Tim van der Lippe e44bf09b3c Speed up running NPM analysis commands 
Whenever we do NPM package upgrades, we run `npm run install-deps -- outdated`
or `npm run install-deps -- audit`. However, this would then always
reinstall all packages with `npm ci`, which is timeconsuming, yet
unnecessary as the analysis does not change the installation output.

Therefore, we check if the custom command starts with either outdated
or audit and bail out of unnecessarily reinstalling.

R=jacktfranklin@chromium.org

Change-Id: I475e74ebe626e1c1973399ea65a31ea57f4b6fb5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566805
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-01 12:47:56 +00:00
Simon Zünd 9385f00880 Implement dark mode for ReportView component 
The initial prototype re-used the colors from ReportView.js. This CL
updates the colors to use the CSS variables that work with light/dark
mode out of the box.

Screenshots: https://imgur.com/a/OtUV5ES

R=jacktfranklin@chromium.org

Bug:chromium:1126824, chromium:1152736
Change-Id: I1df1b96265a5c685c5b04880635769ec28b1f25d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566800
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-01 12:28:35 +00:00
devtools-ci-autoroll-builder a1ca6aa1f2 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/23fe346..4fd0dec

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1af7968..6d2a0fe

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ib935db0308210ec246cca9cf87fdea0ed9cb026e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567798
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-12-01 12:26:55 +00:00
Jack Franklin ae2142c5b9 [Dark mode] land new theme colors 
These have been added by Peter Muller.

Although `--color-link` refers to `--color-primary` for now, we are
splitting it out such that we can update links more easily in the future
should we need to.

Bug: 1152736
Change-Id: Ife8d501b93b73ceccaeeb6ffc343cfc5b6af4dbf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566801
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-01 12:24:36 +00:00
Simon Zünd a37afbf4ab Roll deps from Chromium into DevTools 
Generated by:
 1) './scripts/deps/roll_deps.py'
 2) 'npm run generate-protocol-resources'

Manual modifications to make TS happy:
 - AccessibilityStrings.js, add UI strings for the new enum value.
 - NetworkManager.js, implement empty handlers for new protocl events.

DISABLE_THIRD_PARTY_CHECK=Manual roll

Change-Id: I570c0a4e24ced581edc78fff8d3c0f1d4485ba42
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566794
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-12-01 10:55:15 +00:00
Simon Zünd 9cfe927efc Add Trust Token tab for requests in the network panel 
The tab currently shows only the passed parameters to the Trust Token
API. Future CLs will extend the tab to also contain the result of
the Trust Token operation in a seperate section.

Screenshots: https://imgur.com/a/FmI0pIR

R=jacktfranklin@chromium.org, sigurds@chromium.org

Bug: chromium:1126824
Change-Id: Ib189c080965cac7264fab3fb965bc1cade51d3c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2564871
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-01 10:43:35 +00:00
Benedikt Meurer 7025b99c73 Preserve absence of column number when persisting breakpoints. 
Bug: chromium:1153123, chromium:1055327
Change-Id: I8a3e78c25797d7c78232ac85dc2de9bf73e25a98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2565576
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2020-12-01 10:18:45 +00:00
Alex Rudenko 64b040d8a0 [DarkMode] turn off legacy patching for imagePreview.css 
Bug: 1152736
Change-Id: I0599b821192fc353e289a913c90f3c345a7eb807
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566793
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-01 10:09:35 +00:00
Jack Franklin 9c05e07265 [Dark Mode] migrate sources/sourcesPanel.css 
Bug: 1152736
Change-Id: I1416baa982ec8a1010041aefe2f7b589f1c7905f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566792
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-01 09:44:25 +00:00
Alex Rudenko 0d1b77b298 Use deviceEmulationFactor to position grid labels 
To properly support the device emulation mode, grid label
helpers have to make use of the deviceEmulationFactor parameter when
placing grid labels.

Bug: 1151864
Change-Id: Iefa17be6e376f08cb2760bf747782d13487a2edf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2565373
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-01 09:07:55 +00:00
Mathias Bynens 256dfcc939 [Dark Mode]: migrate accessibility/accessibilityProperties.css 
Bug: chromium:1152736
Change-Id: I0525a376a0a9f1f818071b174122970398c37067
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2564876
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-01 08:28:55 +00:00
Mathias Bynens ec8113a86a [Dark Mode]: migrate accessibility/axBreadcrumbs.css 
Bug: chromium:1152736
Change-Id: I493e6944c3437dd17fafa9051158f77eb09b7750
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2564877
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-01 08:11:35 +00:00
Mathias Bynens f0db74b3cc [Dark Mode]: migrate accessibility/animationTimeline.css 
Bug: chromium:1152736
Change-Id: Ic03372da95c4375ddc04f4b721a43daf85154bdd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2565372
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-12-01 08:09:55 +00:00
Andres Olivares 4c68008935 Migrate elements/ extensions of type 'setting' 
Bug:1134103
Change-Id: I61e2523ad9ada88b8c00c07bb388d5834128f92c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560765
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-01 07:22:16 +00:00
devtools-ci-autoroll-builder b5641a5253 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/3328d0b..23fe346

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dc7b108..1af7968

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I39dd6f59f99370ea7022531f59d34996f828b7e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566525
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-12-01 07:21:10 +00:00