Tim van der Lippe
2e38eeaf9f
Remove all comments with only the unrestricted annotation
...
The unrestricted annotation is Closure-specific and can be removed.
This patch removes all comments with only the unrestricted annotation
in them.
R=szuend@chromium.org
No-Presubmit: True
Bug: 1011811
Change-Id: Iba0723644f53f5307c3077d341271af86becc32a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569758
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
2020-12-02 15:25:32 +00:00
Andres Olivares
30a60c8869
[ts] Typecheck css_overview/CSSOverviewController.js with TypeScript
...
Bug: chromium:1011811
Change-Id: I6dfe7eb704943e0ff267f54fef01a66b7ba7a9b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2394593
Auto-Submit: Andres Olivares <andoli@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2020-09-08 14:53:29 +00:00
Jan Scheffler
e348fe9424
Migrate front_end/css_overview to devtools_entrypoint
...
R=aerotwist@chromium.org , jacktfranklin@chromium.org
Bug: 1101738
Change-Id: I406acc5e456237fda0d5c6b468f66d6c0b66fbc8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2323621
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
Auto-Submit: Jan Scheffler <janscheffler@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-07-28 19:16:12 +00:00
Paul Lewis
daac106699
[global] Remaps self.SDK.targetManager
...
This CL changes references to self.SDK.targetManager (the global
instance of SDK.SDKModel.TargetManager) over to
SDK.SDKModel.TargetManager.instance(). To keep both TypeScript and
Closure happy we must make a method on the TargetManager class itself,
since it only allows private constructors to be accessed by static
methods on the class.
Bug: 1058320
Change-Id: I6ca35024c21cf24254fd6273138a1ab3e163ee00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2088092
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2020-03-05 14:58:03 +00:00
Tim van der Lippe
7946bbcb95
Migrate css_overview/ to import cross-module
...
Bug: 1006759
Change-Id: I2130d4ba17bb592090c202cfe2b97da2558e72ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2054544
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-02-13 17:06:10 +00:00
Paul Lewis
4ae5f4f5ce
[Global] Update refs to SDK.targetManager
...
Bug: 1006759
Change-Id: I0686ef929b89e75c2ea8a731c593d955eca85935
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2015119
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
2020-01-23 10:56:40 +00:00
Tim van der Lippe
9d0cb5f9ee
Migrate css_overview/ to ESM internally
...
Bug: 1006759
Change-Id: I9119e12293f3765cae9432201d7e94f11352e552
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993340
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-01-09 14:58:01 +00:00
Paul Lewis
4da3b30c38
Migrates css_overview/ to esm
...
Bug: 1006759
Change-Id: Idf78688fa354b7e169edd508667dd2e298eacea4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928914
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2019-11-21 14:37:54 +00:00
Paul Lewis
2c46c0a1f5
[CSS Overview] Reduce the eagerness of reset
...
We currently observe the InspectedURLChanged event to decide if the
CSS Overview needs to be reset, but this can be fired, it seems, for
changes internal to the page (seems like iframes, perhaps). As such
with this CL we confirm that the inspected URL itself has changed
before triggering the reset.
Change-Id: I32b721b66bd75875ecd61426573131407c455a4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1887791
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
2019-10-30 16:32:35 +00:00
Paul Lewis
de0224ccdd
[CSS Overview] Uses snapshot; adds element highlight
...
Change-Id: If58dd20c6f4b3c8f730b39c48c14826e402018a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1873759
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
2019-10-23 09:55:00 +00:00
Paul Lewis
8cddf9931f
[DevTools] Adds CSS Overview Panel
...
Creates a panel that steps through the page to build statistics on CSS
used, such as colors, fonts, specificity, and other items of note.
Note: this is a DevTools experiment.
Bug: 1007284
Change-Id: Ib8d8b2af6bb65d6ff4816ca23b48b76980cd80db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806736
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#700745}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0e4a3c81f343d15e2121280d332659778ad07323
2019-09-27 16:40:07 +00:00
Tim van der Lippe