Michael Liao
6035f4a583
[Font Editor Prototype]: Implements Experimental Typography CSS Editor in Styles Pane
...
Reference Document: https://docs.google.com/document/d/1zvmKDfdgVgL-QX2W4nKfgoeG_69YDF0AsLerIzL3rPE/edit?usp=sharing
Explainer: https://docs.google.com/document/d/1TmvbZuJR4fHuViE0X23y_1kUT43qt98mdj5GZxWf_W0/edit
Bug: 1093229
Change-Id: I0a8d049bd564a5ba547466067a12185565af7820
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2305613
Commit-Queue: Michael Liao <michael.liao@microsoft.com >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Songtao Xia <soxia@microsoft.com >
Reviewed-by: Tony Ross <tross@microsoft.com >
Reviewed-by: Shane Clifford <shanejc@microsoft.com >
2020-12-01 19:54:05 +00:00
Tim van der Lippe
7dcef88d8b
Remove skip_compilation from module.json files
...
R=aerotwist@chromium.org
Bug: 1011811
Change-Id: I4c4fd280adb4f5f7b327239d08d80b2cb98b203b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560248
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-11-25 13:19:08 +00:00
Tim van der Lippe
89e82cecd3
Use TypeScript-authored files in inline_editor/
...
R=aerotwist@chromium.org
Bug: 1011811
Change-Id: I2f9023a438e3a5c39a62a66bab4a5b5fc49792b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2546921
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-11-18 14:47:08 +00:00
Paul Lewis
1f7a820653
[unit test] Fix remaining non-entrypoint imports
...
Bug: 1148296
Change-Id: If6673aff7755e78b29d4a602fac1baa84e4890e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2536408
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2020-11-13 15:19:21 +00:00
Changhao Han
8655e96a00
Move CSSAngle-related files from elements/ to inline_editor/
...
In the future, I expect more type components to reside in inline_editor/
because it's where current type-component-like components live, e.g.
ColorSwatch, BezierSwatch, etc.
Bug: chromium:1126178
Change-Id: Icfc9553c5f3e54ef94e04de50cda8b7ef7a9bc8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2509573
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Auto-Submit: Changhao Han <changhaohan@chromium.org >
2020-10-30 11:25:26 +00:00
Patrick Brosset
284a5933e2
Refactor the ColorSwatch to use TypeScript and LitHTML web component
...
This will make it possible to reuse this component in other new-style
web components like CSSVarSwatch (which, today, duplicates the logic).
The ColorSwatch has a number of different consumers today that require
different things from it. I looked at all these consumers and based on
them defined an API that should work for everything:
- renderColor: which accepts either a parsed color or a string to be
parsed as well as an optional format (or flag to use the format from the
user settings) and an optional tooltip.
- swatch-click event: to alert consumers when the swatch is clicked, so
they can hook up the colorpicker to it.
- format-changed event: to alert consumers when the swatch is
shift-clicked so they can react to the new format.
This component has 1 slot that consumers can use to display the color
value as text.
This is useful mostly for the Styles pane. Indeed, the way properties
are edited in that pane relies on them having an available textContent.
So the color string needs to be in the light DOM, not only in the shadow
DOM.
This is why you'll see the slotted element being updated when the format
changes.
Bug: 1137438
Change-Id: I27b757e63a54be2899d9d6b0e94d1af54f3ee22d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2480042
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com >
Reviewed-by: Shane Clifford <shanejc@microsoft.com >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
2020-10-23 08:04:21 +00:00
Tim van der Lippe
46e1bcace9
Remove pre_generates_legacy from module.json files
...
This was a temporary flag used during the build_release_applications
to GN migration.
R=aerotwist@chromium.org
Bug: 1131500
Change-Id: I8a772bcc4bee31dbd3270bf7ef62d8c97941024a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484716
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-10-19 16:12:09 +00:00
Tim van der Lippe
c20afe742b
Move legacy files from ui modules to GN
...
R=aerotwist@chromium.org
Bug: 1131500
Change-Id: I8ece4d0b8373584333b9639e2ba3f4a584088619
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2476335
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-10-16 11:03:37 +00:00
Patrick Brosset
d93ee76664
New jump-to-var feature in the Styles pane
...
This implements a new feature called jump-to-var.
It allows users to quickly jump from a custom property used in a var()
CSS function to where this property is defined.
A simple link underline is displayed for those.
If the property used does not exist, then no underline appears.
The explainer for this feature can be found here:
https://docs.google.com/document/d/1LRwH_lIO-gqe8hWzVq8QGFsJ27eEl158nFsuPlLGfnU/edit#
Demo: https://imgur.com/fI6YBBq.gif
Bug: 1124707
Change-Id: Ie9360f7dcace7621e4352fc4e6301e4c991b166e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2425340
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com >
Reviewed-by: Songtao Xia <soxia@microsoft.com >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-10-05 17:30:41 +00:00
Tim van der Lippe
cac65d4fa0
Remove skip_rollup
...
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.
R=jacktfranklin@chromium.org ,aerotwist@chromium.org
Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-09-08 15:44:09 +00:00
Jan Scheffler
b12601a5b1
Migrate front_end/inline_editor to devtools_entrypoint
...
R=aerotwist@chromium.org , jacktfranklin@chromium.org
Bug: 1101738
Change-Id: Iaae55e2a78c212b2bb6d5f4d66a8106466cc6d07
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2323637
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
Auto-Submit: Jan Scheffler <janscheffler@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-07-29 13:18:21 +00:00
Tim van der Lippe
37512b0d25
Remove empty script arrays from module.json files
...
If the module uses `modules` to load the JavaScript files, then
we can remove the `scripts` array altogether. Note that there
are still some modules left that use `scripts`, most notably
the `lighthouse_worker`, which is a remote module.
R=aerotwist@chromium.org
Bug: 1105476
Change-Id: Ie303e9835f5ce6d42ccae7b3a305d8f3df1af84c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2302597
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-07-17 10:05:33 +00:00
Mathias Bynens
5e43b27e8b
Reformat module.json files
...
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.
Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.
Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
2020-04-14 05:35:23 +00:00
Tim van der Lippe
4a6bb80154
Migrate inline_editor/ to ESM internally
...
Bug: 1006759
Change-Id: Ic2ddd497f048211b11a61000917c1ed558275aa5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994965
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-01-14 14:25:48 +00:00
Tim van der Lippe
f7987871f0
Migrate inline_editor/ to ESM
...
Bug: 1006759
Change-Id: Ia51fa371c7077596d0373bd1b5307f767c4118c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1903476
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2019-11-09 19:58:23 +00:00
Blink Reformat
4c46d0969f
The Great Blink mv for source files, part 2.
...
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org >
Commit-Queue: Blink Reformat <blink-reformat@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00