Tim van der Lippe
2e38eeaf9f
Remove all comments with only the unrestricted annotation
...
The unrestricted annotation is Closure-specific and can be removed.
This patch removes all comments with only the unrestricted annotation
in them.
R=szuend@chromium.org
No-Presubmit: True
Bug: 1011811
Change-Id: Iba0723644f53f5307c3077d341271af86becc32a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569758
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
2020-12-02 15:25:32 +00:00
Jack Franklin
d1cf72489a
[Dark mode]: network/RequestHTMLView.css
...
Bug: 1152736
Change-Id: I04d2b1cf567d45a240ff55b30cfa813326b8acd6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567963
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
2020-12-02 12:19:03 +00:00
Jack Franklin
71519f8efb
Introduce enableLegacyPatching flag for CSS patching
...
As part of the dark mode migration we are adding
`enableLegacyPatching:true` to all call sites of `appendStyle` (and
related methods). If a user passes `false` for that flag, no CSS colour
patching will occur.
This CL is therefore a no-op from a user's perspective as we pass `true`
on every call to maintain existing behaviour, but once we start
migrating we will turn the option to `false`. Long term, once all code
is migrated and the old patching is removed, we will remove this flag
entirely once again.
Bug: 1122511
Change-Id: I76b818e83b7d5ee0175e1548759373f53481e0ab
No-Presubmit: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2516345
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2020-11-03 14:11:46 +00:00
Simon Zünd
4cf3e66775
[ts] Type-check network/RequestHTMLView.js with TypeScript
...
R=alexrudenko@chromium.org
Bug: chromium:1011811
Change-Id: Id00664d58f936e64e319029b857e10981bda2d86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2460921
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Commit-Queue: Simon Zünd <szuend@chromium.org >
2020-10-08 13:55:47 +00:00
Jan Scheffler
6c0cc69f17
Migrate front_end/network to devtools_entrypoint
...
R=aerotwist@chromium.org , jacktfranklin@chromium.org
Bug: 1101738
Change-Id: Id895c6e1a9083c22334ae1afad467c08e8dfa6a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332228
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Auto-Submit: Jan Scheffler <janscheffler@chromium.org >
2020-07-31 14:44:50 +00:00
Tim van der Lippe
0ed1d2b857
Migrate network/ to import cross-module
...
Bug: 1006759
Change-Id: I3fc6be48f30ca087b6396cb046c0fbc0f43e018f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2035946
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-02-04 18:12:02 +00:00
Tim van der Lippe
119690cd73
Migrate network/ to ESM internally
...
Bug: 1006759
Change-Id: I90014b2af71ca1945cb8bcfe011bb5d34874b258
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994979
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-01-14 14:47:58 +00:00
Paul Lewis
5650965324
Migrates network/ to esm
...
Bug: 1006759
Change-Id: Ic94d5954605d7d368dfe395532c92a98dfee7a3c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1953615
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
2019-12-09 11:08:02 +00:00
Rob Paveza
7d28181e7d
DevTools: Network preview for HTML frame-title rule violation
...
Accessibility Insights identifies an issue in which the iframe
which contains the HTML preview of network requests does not have
a title, which could present a difficulty for assistive technology.
Because, particularly among HTML content, it's highly likely that
the HTML content is going to be presented on the web application,
and the preview itself is not intended to be interactive, this
change adds a role="presentation" attribute. This is intended to
make the element semantically meaningless to assistive tech [1].
[1] https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_presentation_role
Bug: 963183
Change-Id: I0f0fd02b13595f4787ebf0919abe8cf5a721884e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841940
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com >
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com >
Cr-Original-Commit-Position: refs/heads/master@{#703997}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a8b79105be56245a0cf8c1a1fc779a728ecad1d
2019-10-09 00:41:08 +00:00
Joey Arhar
e26a4573c5
[DevTools] Escape '#' in request HTML previews
...
Bug: 930061
Change-Id: I768fa91d406f8d987fea16cb8a429e0d5119821d
Reviewed-on: https://chromium-review.googlesource.com/c/1464327
Reviewed-by: Joel Einbinder <einbinder@chromium.org >
Commit-Queue: Joey Arhar <jarhar@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#631380}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 19a660f847586dd64de525db4452a60c8f25c09d
2019-02-12 21:08:08 +00:00
Joey Arhar
976c0b8a46
[DevTools] Fix request preview for URI encoded html
...
Bug: 895081
Change-Id: I49c6131e1cc432e470e4b04353282d3ebebcb063
Reviewed-on: https://chromium-review.googlesource.com/c/1286758
Reviewed-by: Dmitry Gozman <dgozman@chromium.org >
Commit-Queue: Joey Arhar <jarhar@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#601792}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0238c6b5064859f39ff5f6d3265712093934b2a7
2018-10-23 00:12:40 +00:00
Erik Luo
7e5bdf2677
DevTools: restore pointer events in HTML preview
...
- Restores pointer events (including scrolling) to HTML preview.
- Prevents accidentally focusing inputs/links inside the preview
iframe when tabbing via keyboard.
Bug: 849204
Change-Id: Iea5dc6117decbe1d9e746139dd5974a8bfb45c62
Reviewed-on: https://chromium-review.googlesource.com/1107250
Reviewed-by: Dmitry Gozman <dgozman@chromium.org >
Commit-Queue: Erik Luo <luoe@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#569093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 122037b2541bf0932fd6fbcb29a98d487525c4ec
2018-06-20 23:54:16 +00:00
Blink Reformat
4c46d0969f
The Great Blink mv for source files, part 2.
...
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org >
Commit-Queue: Blink Reformat <blink-reformat@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00
Tim van der Lippe