Mathias Bynens
ca9fa2d73f
Consistently format CSS color and opacity values
...
- Prefer the modern comma-free CSS color function syntax over the
legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
the value as a number, again to clarify the range.
[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color
Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
2020-05-19 16:50:26 +00:00
Mathias Bynens
b0c1f4bce2
Fix stylelint-config-standard violations
...
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
2020-05-15 17:05:27 +00:00
Kham Udom
e22500101f
High contrast update for Network panels
...
The patch updates the common styles, not only for Network, but other
panels that uses data grid. It fixes the hover, focus and selected
states.
Fixed hover, focus and selected on all individual panels within
Network. Fixed the filter and the cursor and resize handle within
the timeline.
Before: https://imgur.com/a/HR5topn
After: https://imgur.com/a/Gpph5BI
Bug: 1048378
Change-Id: Id0715ac873826471b35a400895efa5c178a589d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2059527
Commit-Queue: Kham Udom <khamu@microsoft.com >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-02-18 07:19:36 +00:00
Jan Scheffler
341eea56a8
Show blocked cookies in cookies panel
...
This cl adds a temporary list collecting blocked cookies
from network requests to also surface them in the application
panel to increase the chance of developers being able to
see when their cookies have been blocked.
Screenshot: https://imgur.com/a/wyPDynT
CL to disable failing test: crrev.com/c/1949470
Bug: chromium:1030258
Change-Id: I8e813337f033893ce1f0e1499559a83585989a76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1950166
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Sigurd Schneider <sigurds@chromium.org >
2019-12-12 10:22:26 +00:00
Joey Arhar
1c4df4f53e
[DevTools] Fix request cookies view with no cookies
...
This fixes a small issue where blocked request cookies aren't shown if
there were no request cookies in the first place.
It also fixes a spacing issue with the list of cookies in "Malformed
Response Cookies"
Screenshots before: https://imgur.com/SeCHwKm
Screenshots after: https://imgur.com/M3NKlqQ
Bug: 856777
Change-Id: I1a2039b535869f16280fd74a9ba7f1dfcdced160
Change-Id: I165ac29eaafb8a74c3483238bd42c5aca1e91555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795316
Commit-Queue: Joey Arhar <jarhar@chromium.org >
Reviewed-by: Erik Luo <luoe@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#700365}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5c20d5d98dd313cecd32b6946f4de1dfd291b169
2019-09-26 18:59:13 +00:00
Joey Arhar
d4139c8f33
[DevTools] Show blocked cookie information in frontend
...
This patch rewrites the request cookies view panel to include new
information about blocked cookies emitted by the new Network ExtraInfo
events, including:
- Splitting the cookie table into multiple tables to make it easier to
read.
- Modifying CookiesTable to highlight and add an icon to cookies which
were blocked.
- Fixing some bugs in RequestCookiesView and NetworkRequest which
caused the cookies panel to not appear when it should.
- Modifying SDK.Cookie and SDK.CookieParser to store blocking
information and the original cookie line.
Screenshots before: https://imgur.com/I7WBSgz
Screenshot after: https://imgur.com/uHTU3ID
Bug: 856777
Change-Id: I044aa7fcd4fe8db121fd7aaa13ff9d6cd829aae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756252
Commit-Queue: Joey Arhar <jarhar@chromium.org >
Reviewed-by: Erik Luo <luoe@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#694530}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4f13a2518b054a7e8d218aaf3213de2e1c74ea4e
2019-09-07 03:54:39 +00:00
Blink Reformat
4c46d0969f
The Great Blink mv for source files, part 2.
...
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org >
Commit-Queue: Blink Reformat <blink-reformat@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00
Mathias Bynens