a. Originally: User could not use shift-tab to tab out of the console (tab trapping issue).
Problem: Focus on the container was tied to focus on the prompt.
After Fix: Shift+Tab works as expected, lets you tab out of the container.
b. Originally: There was a tab stop in each of the datgrid query outputs.
Problem: If you used shift+tab, it would go through each of the data grids.
Same for tabbing, unless you tabbed directly into the container.
After Fix: Can use up and down arrow keys to navigate table outputs.
Can use context menu to sort the datagrids as expected.
Only the container of the datagrids get focus, dataGrids do not.
c. Add a visible selection background for DataGrid query outputs.
d. Originally: Up and Down arrow keys were handled by the input as Home and End keys.
Problem: Could not reach previous error messages and prompt inputs.
Couldn't read information even in browse mode.
After Fix: Browse mode works as expected.
Gif uploaded here: https://imgur.com/a/zYgVtfk
Bug: 963183
Change-Id: I62bf7f385a922c1d7c57a45e0be88c44d5aa9d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1874406
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Jose Leal <joselea@microsoft.com>
Commit-Queue: Anubha Mathur <anubmat@microsoft.com>
Issue:
- Data grids in DevTools do not have an aria-label
- There are a ton of DataGrid parameters and adding one is messy
Changes:
- Naming all data grids
- Created DataGrid.Datagrid.Parameters type to hold data grid parameters (including a required gridName field)
Bug: 963183
Change-Id: I83b130d468fb80034be264b45b86b799f650e978
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891652
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.
This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.
Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
1. Focus the prompt when the view is focused.
2. Do not hide the query while waiting for the results.
3. Show query in history if it does not produce results
(e.g. DELETE ... FROM)
Bug: 798785
Change-Id: I7cc86301256e0370f03282e044bb59fef0a26dbe
Reviewed-on: https://chromium-review.googlesource.com/1056072
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#558085}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4b4a5822e6c6c522db2d3803c4632f9346f92a1e
Tim van der Lippe