The separate *_OWNERS files are related and can be grouped together
in a folder to make this distinction clear. This will allow us
to update the PRESUBMIT script to explicitly mark them as
exclusive change directory.
Note that the directory is named "owner", as we can't name it
"owners" as that is case-insensitive equivalent to "OWNERS",
which Windows can't handle in its presubmits.
DISABLE_THIRD_PARTY_CHECK=OWNERS update
R=yangguo@chromium.org
Bug: 1187573
Change-Id: Ib94a544c9dc01f788a8b75a5c8111ab52fbc27b8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2814658
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
This document describes the high-level architecture of DevTools. While
not complete yet, this version adds the guiding principles and explains
the core-feature model used in the DevTools startup process.
Future updates will include an explanation of how individual high-level
features are implemented and what their building blocks are.
DISABLE_THIRD_PARTY_CHECK=OWNERS update for new file
Bug: none
Change-Id: I589ae3f646094ec92c27336b6282006ab4534d7f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2791341
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Hi everyone,
Our plan for implementing Localization V2 considers 3 phases:
Infrastructure, Migration & Cleaning
This CL is part of the Cleaning phase, it's goal is to remove any
non-standard usage of V1 APIs (outside of the devtools_ui_strings.grd)
I'm splittling these changes into small pieces following this heuristic:
- make sense when logically grouped.
- keep them as small as possible
- can be atomically reverted.
I'll follow up with other changes removing usage on presubmit, scripts
and build.gn files (if any).
Bug: 1136655
Change-Id: I735dc8ba1045ed4afff7deb1a43cf02a7ab55865
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2733640
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
The current proposed sequence of commands to run the layout tests is:
autoninja -C out/Default content_shell
third_party/blink/tools/run_web_tests.py http/tests/devtools
However, it leads to an error since by default it checks in out/Release. Therefore, it would be better to specify to use out/Default which was just built:
autoninja -C out/Default content_shell
third_party/blink/tools/run_web_tests.py -t Default http/tests/devtools
Change-Id: I2775e5ec9a6259d52b002126138e04c4a72d6120
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479130
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Alfonso Castaño <alcastano@google.com>
In Lighthouse project, backtick is being used to indicate something that should not be localized.
(See 'inline code block' section in https://github.com/GoogleChrome/lighthouse/tree/master/lighthouse-core/lib/i18n)
We can adopt this with minor modification. When the lighthouse report is being rendered, the backtick in message will be converted to a special html tag and used to style the code snippets. Since we don't want to do special styling for locked terms, backtick can be removed after the term being converted to placeholder in en-US.ctc.json, then locale.json would have the term that is not translated and without the backtick .
For example
Before change: https://imgur.com/a/WqbVbXC
After change: https://imgur.com/a/EZjl6Gg
Note: There is no escape character for using backticks as part of the string, it can only be used for locked terms.
DISABLE_THIRD_PARTY_CHECK=Need to also update README that is in different folder
Bug: 1136655
Change-Id: I68ea305962beec4115d0a50f24e34546b92cadf7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2463990
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
“Unconfirmed” is a lower state than “Untriaged”. Untriaged issues
that also have the `TE-NeedsTriageHelp` label should be considered
when triaging.
Here are the relevant states with their descriptions as displayed
in Monorail:
1. Unconfirmed = New, has not been verified or reproduced
2. Untriaged = Confirmed, not reviewed for priority and assignment
3. Available = Triaged, but no owner assigned
4. Assigned = In someone's queue, but not started
5. Started = Work in progress
At the time of writing, 233 DevTools issues are in the Unconfirmed
state. 57 of those also have the `TE-NeedsTriageHelp` label.
Bug: chromium:1022301
Change-Id: Ia05a46e87139a4168c48e746e2cad855c4e1bbff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2232948
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
We prefer single quotes by default, but still want to allow double
quotes in cases where that helps avoid quote-escaping, and also want
to allow template literals in cases where string interpolation is
used. For example:
const a = 'xxx'; // ok
const b = "xxx"; // not ok, should use single quotes
const c = "xxx'xxx"; // ok, double quotes avoid an escape sequence
const d = `xxx`; // not ok, frivolous use of template literal
const e = `xxx ${42}`; // ok
Per https://github.com/eslint/eslint/issues/12976, setting
the `allowTemplateLiterals` option for the `quotes` lint rule to
`false` gives us the desired behavior.
Note that the above lint rules are auto-fixed when running the linter;
there should be no need to manually make any changes to appease the
linter.
Per review feedback, this patch also removes the following escape
sequences for printable non-ASCII symbols:
- U+00D7 → ×
- U+2026 → …
- U+2019 → ’
Chromium CL temporarily updating test expectations:
https://chromium-review.googlesource.com/c/chromium/src/+/2083147
Cq-Depend: chromium:2083147
Bug: chromium:1057042
Change-Id: Id6bec3f96ca694d2fbc07dd8629fce305a58df8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082372
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Johan Bay