zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 20:39:31 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 43 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
7706 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jack Franklin fdf2a0cecd [TreeOutline] custom renderer support 
Adds the basic support for custom renderers to tree nodes.

Bug: chromium:1166669
Change-Id: Iaa271384ea1798c234d131b27cd08ecb8a49623d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696651
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-17 11:18:59 +00:00
Alex Rudenko b265fb501a Improve UIStrings descriptions 
Bug: chromium:1163928
Change-Id: Ie87088617b4da0812feab2c39090b6098c3110e4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698837
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2021-02-17 10:54:30 +00:00
Jack Franklin bcfd6ad499 Disable explicit return types in front_end/component_docs 
It leads to very verbose examples, to little gain. So let's let the
developer decide in the docs if they would like explicit returns or not.

Bug: none
Change-Id: I5756fbf738a47e699ee1cf47f04efd7adba4cd01
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696656
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-17 10:34:59 +00:00
Jack Franklin 0b9f84a294 Fix message shown on web socket connection close. 
And clarify the l10n with an extra description.

Bug: chromium:1163928, b/180142943
Change-Id: I3f15272d2ded15fe77fb420dd189878429962855
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698836
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-17 10:15:49 +00:00
Sigurd Schneider b7fdb60b51 Update link for CORS issues 
Bug: chromium:1128885
Change-Id: Ife9324f0f53adb5c186ea429431c21eb57f40eb4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698833
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-02-17 09:51:49 +00:00
Simon Zünd 562d32ce33 Provide more context in some l10n descriptions and lock some terms 
R=petermarshall@chromium.org

Bug: chromium:1163928
Change-Id: I1fd4e54c052cbbd1a3cf575c56c82397ee5ec778
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698834
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2021-02-17 09:41:01 +00:00
Yang Guo 6760a12b23 Better l10n description for ShowMoreDataGridNode 
R=jacktfranklin@chromium.org

Bug:1163928
Change-Id: I9f898262ca48777ff7f0510c3baa8a52ad0e4adf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697607
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-17 09:39:39 +00:00
Sigurd Schneider 5789074c16 Improve localization description 
Bug: chromium:1163928, b/180119019
Change-Id: I03430d86ba79db079613e8fd5b703dd628a524ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698832
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-17 09:23:41 +00:00
Sigurd Schneider c65995a229 Roll protocol and adapt tests 
Corresponding back-end CL: https://crrev.com/c/2584499

DISABLE_THIRD_PARTY_CHECK=protocol update pending

Bug: chromium:1170548, chromium:1142606
Change-Id: Ied86cccacceb08db16deea512dafcbd7b5f5dbc2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698829
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-17 09:03:39 +00:00
Peter Marshall 266ab2ecb8 [l10n] Update another round of descriptions 
Bug: 1163928
Change-Id: Ieb30026912c17f7f366c04be91a371b07e634ef2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697610
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-02-17 07:56:09 +00:00
Alex Rudenko 2f57b45726 Revert "[console] Escape double quotes when printing strings." 
This reverts commit f34ad08ea1.

Reason for revert: causes a test failure on Windows bots https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8855087583563203648/+/steps/browser_tests__with_patch__on_Windows-10-18363/0/logs/Deterministic_failure:_DevToolsSanityTest.TestDeviceEmulation__status_FAILURE_/0

Original change's description:
> [console] Escape double quotes when printing strings.
>
> This aligns the behavior of Chromium DevTools with the existing behavior
> found in Firefox DevTools, making it easier for Web Developers to copy
> and paste strings from the console (with fewer surprises when the
> strings happen to contain double quotes).
>
> Before: https://imgur.com/yoo2UT6.png
> After: https://imgur.com/eMnbmPi.png
> Fixed: chromium:1178530
> Change-Id: Ia85758beb39f01e706e88bd826980c67a9c1adc6
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697190
> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>

Change-Id: Ie5de20e53b8c36a24aafafc3c2fc4d3971fdd08e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698828
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-17 07:04:01 +00:00
devtools-ci-autoroll-builder 1893bb9944 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/ef6ad25..a42736b

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/228b1c1..fe293b0

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7386a1e..0391863

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ie8709d6155a19157980674652bd4edbd34a2dd48
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698378
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-02-17 03:37:12 +00:00
Vidal Guillermo Diazleal Ortega 83edb474b3 [Loc] Migrate Sources to Localization V2 
- Migrate sources to use Localization V2 APIs.
- Removed sources grdps

Tested with en-XL.json
https://imgur.com/a/vDrfTAv

Bug: 1136655
Change-Id: I01d4fcdc3f115e9edb3fae933c7d5c6b9ffb77c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692743
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-16 19:14:49 +00:00
Benedikt Meurer f34ad08ea1 [console] Escape double quotes when printing strings. 
This aligns the behavior of Chromium DevTools with the existing behavior
found in Firefox DevTools, making it easier for Web Developers to copy
and paste strings from the console (with fewer surprises when the
strings happen to contain double quotes).

Before: https://imgur.com/yoo2UT6.png
After: https://imgur.com/eMnbmPi.png
Fixed: chromium:1178530
Change-Id: Ia85758beb39f01e706e88bd826980c67a9c1adc6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697190
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-02-16 16:55:23 +00:00
Alex Rudenko bd87ec9993 Adjust Flexbox editor styles 
Increases the min-width for the container and forbids wrapping in
case text exceeds the container area.

Bug: 1175699
Change-Id: I86762319b22fd313ead36bcf910bf807797e0633
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697197
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-16 16:10:08 +00:00
Tim van der Lippe 6bf7790bb5 Remove heap_snapshot_model/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: I655263170bab9126997efb882bc9f8470e925339
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697204
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-16 16:02:52 +00:00
Andres Olivares 2ace7ee3a9 Update description of the 'Pattern' UIString to be more clear 
R=petermarshall@chromium.org

Bug: chromium:1163928
Change-Id: I3da0c8cb6eadcd56b4e536cbc19dbe306c3b1ee4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697247
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2021-02-16 15:55:00 +00:00
Tim van der Lippe b391dcebc9 Add files generated in gen/front_end to runtime_deps 
The previous attempt of this fix was in https://crrev.com/c/2687497
That CL was reverted, as it inadvertently added more files to the
runtime_deps then was intended. Most notably, it erroneously included
`tsconfig.json`, `tsbuildinfo` and `d.ts` files.

Instead, we should manually filter out only those files that we are
interested in. In this case, these are the `js` and `js.map` files.
Once these are added to the runtime_deps, the layout tests can access
them, as they are pushed to the bots.

I have verified that the following command shows the expected output:

gn desc out/Default front_end/platform:bundle runtime_deps

R=jacktfranklin@chromium.org

Bug: 1174013
Change-Id: I6bc25665f06b5968bbd9748696a5723edac84ddc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697201
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-16 15:53:01 +00:00
Sigurd Schneider 2b937aa7ec Prevent icon from clipping at non-standard zoom levels 
Bug: chromium:1119806
Change-Id: I4514760704cfe87ac7dca8a9083a3e6c745a8f4b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697347
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-16 15:34:10 +00:00
Kim-Anh Tran c4c1fba6f0 Revert "Add helper functions for adding breakpoints in sources" 
This reverts commit 2fe6522550.

Reason: Causing flaky tests on waterfall

Bug: chromium:1178804
Change-Id: I38e46d9e786467e9bbdcbbf7301da1e363bd0f57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697200
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Almothana Athamneh <almuthanna@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
 2021-02-16 14:52:45 +00:00
Sigurd Schneider 2a1afff3af Fix displaying bug in IconButton 
IconButton was not inheriting font size, family, color from
the outside, resulting in wrong values.

Bug: chromium:1178785
Change-Id: I299a5792908d403edc56f11e181b70e2d2bf2d53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697193
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-16 14:29:42 +00:00
Tim van der Lippe 9993972bf2 Update localization descriptions in LighthouseController 
R=petermarshall@chromium.org

Bug: 1163928
Change-Id: Ia90334bdcfdc30f486e3b1f09a4cde578ead9bf8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696663
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-16 14:27:52 +00:00
Alex Rudenko 594bd00cb0 Refactor loading of child nodes in AccessibilityNode 
This CL contains the following changes:
- replaces children, numChildren, hasOnlyUnloadedChildren and
loadChildren() with children() and hasChildren() in the AXNode
interface.
- children will be loaded when the element is expanded, and then cached.
- the responsibility to expand preloaded nodes belongs to
AccessibilityTree now. I think previously it'd expand indefinitely
given that the nodes are preloaded.

Bug: 887173
Change-Id: I6c16ca169fa58be0554199c9367024b78b43fa09
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692207
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
 2021-02-16 14:26:18 +00:00
devtools-ci-autoroll-builder 394d69d667 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/bc28354..ef6ad25

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I341075d23da08343dcd9bf6d1e910df35decc984
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696890
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-02-16 13:17:43 +00:00
Alex Rudenko 6755031e1b Use common setting types in Layout panel 
Bug: none
Change-Id: Id164a7fba185d16816ceb52e3cac81f6609b83ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696665
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-16 13:01:06 +00:00
Jack Franklin 5bb7528e13 Update check_license_header rule with new year 
It was inserting comments with 2020 in. I've updated it to figure out
the current year. This theoretically could cause problems if people are
either side of a year on New Years eve, but I'm hoping people are busy
not working then :D

Bug: none
Change-Id: I9f6cc9329189d89e6994cc0963fa70617cb446c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696660
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-16 12:53:28 +00:00
Sigurd Schneider a86d1166dc Move AffectedCookiesView to its own .ts file 
Bug: chromium:1072335
Change-Id: I5b91fb17482d513482667b5f736ddbb2baffec81
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696657
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-02-16 12:50:41 +00:00
Wolfgang Beyer d39b5ab0b6 [Issues] Add new issue types to UMA tracking 
Backend CL: https://crrev.com/c/2694408
Bug: 1072335
Change-Id: Id7ec58804e5bc5f88f5050c1825b011daefe9da2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692913
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-16 12:37:28 +00:00
Peter Marshall ec86188f2b [l10n] Update a bunch of UI string descriptions 
Bug: 1163928
Change-Id: Ibbab9aa19141ce6051de8b3c757c6a78993f733a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696664
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-02-16 12:19:30 +00:00
Alex Rudenko b794078d87 Clarify the focus text 
Bug: chromium:1163928, b/180034761
Change-Id: Ia34094454eebf6b6f5bee83ad22b7214d6ad4971
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696650
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-16 11:52:17 +00:00
Sigurd Schneider fb6464a642 Improve descriptions a little 
Bug: chromium:1163928, b/180037722, b/180042841
Change-Id: I08f83b0beb91480a86bef71f4c761e24f2c98e3c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696329
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-16 11:47:35 +00:00
Simon Zünd 29984780ba [settings] Use const enum for SettingType 
R=andoli@chromium.org, tvanderlippe@chromium.org

Bug: None
Change-Id: Ie5de59552683d2f2fdbf6aff03d302b74e445c7c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696654
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-16 11:12:58 +00:00
Simon Zünd 96e613b268 [settings] Use new category enum for pre-ordered sections list 
The SettingsScreen has a preference for the ordering of the setting
sections of the various modules. This list was previously hardcoded
with the english terms of the various categories.

After the module.json migration, the category names used the
translated names, causing a mismatch if a locale other then english
was used. For non-english locales, no settings would show up, as the
different sections did not exist.

This CL fixes this by using the previously introduced SettingCategory
enum to define the preferred ordering.

R=andoli@chromium.org, tvanderlippe@chromium.org

Bug: None
Change-Id: I18448b6cfe6338fb55e327644707b4999c99cd47
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696328
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-16 11:08:48 +00:00
Yang Guo 3e670100ae Better l10n descriptions for Application panel's storage view 
R=szuend@chromium.org

Bug:1163928
Change-Id: Ia81782714d4cc040262e185bcde8fa2b8d0ffe02
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696658
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2021-02-16 11:03:36 +00:00
Sigurd Schneider 2e7a3f8d8b Remove unnecessary eslint-disable 
Bug: chromium:1072335
Change-Id: Ie74910982c9e4e1075088597525f4ebb7e98c038
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696653
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-02-16 10:14:17 +00:00
Sigurd Schneider 7985f65e4f Make toolbar 'Clear' clear timeline overview if log is preserved 
Bug: chromium:1176346
Change-Id: I4a675b100e8216ffc20720368bc3b895f87c49ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696649
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-16 09:52:37 +00:00
Jack Franklin 6b7065cfd3 [DarkMode] inputTimeline.css 
Bug: chromium:1152736
Change-Id: I8c1a64b049ce5142ac184e5f5121e7f7e289cb94
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692770
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-16 09:38:59 +00:00
Jack Franklin 33d6c34b79 Fix typo in data-grid docs 
Bug: none
Change-Id: I45c146c93d8d05805b52ceb57f03cc7c7a2e5aa9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696647
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-02-16 08:55:32 +00:00
Simon Zünd b7e27c6c87 [settings] Introduce true enum for SettingCategory 
The current code uses localized strings that serve as both enum values
as well as UI strings. This CL fixes this by introducing a true enum
for SettingCategory as well as a method that provides a translated UI
string given a SettingCategory enum value.

R=andoli@chromium.org, tvanderlipp@chromium.org

Bug: None
Change-Id: If0103c10cbea3f1aa5042999b108c30db4f6b591
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692910
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-16 07:02:03 +00:00
Wolfgang Beyer e56f2dc16d Update translation description 
Translation bug: http://b/180043103
'Unclear Meaning: Element is hidden by active modal dialog'

Bug: 1163928
Change-Id: I271b17c2a1ef01e0b76ddf7330392c3a923f60e0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2695577
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-16 06:38:52 +00:00
devtools-ci-autoroll-builder 804af3339c Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I2af8feb358439121f9e3614c4b4d1a9340175538
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696191
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-02-16 06:35:10 +00:00
devtools-ci-autoroll-builder 8011416292 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/251bfc5..bc28354

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I5a6b942b4661c9c210edf61b12fdeb3ba8b24506
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2695514
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-02-16 03:51:11 +00:00
Andres Olivares d5acd03638 [module.json extensions] @Common.AppProvider 
Bug: 1134103
Change-Id: I8339a3082d9d009f919e217cac59bec59921fb3d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692891
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-15 20:11:47 +00:00
Tim van der Lippe e7446350b3 Remove diff/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: Icc937903dd2e4fdab76451b86e1d5b5be2014de8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686665
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-15 16:57:50 +00:00
Alex Rudenko 02f3797b19 Add links to the low text contrast issue's description 
Screenshot: https://i.imgur.com/3ptvJ9Y.png
According to https://docs.google.com/document/d/1a8ArU1jOKmPPedvoTPBSBWc9OZv0SJKB9e0M2EKGI9A

Bug: chromium:1155460
Change-Id: Ic3659e71197eddf633aeb20a4c2bc7a5b9b265b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692917
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-15 15:56:34 +00:00
Andres Olivares 53a3aa0328 [module.json extensions] @SourceFrame.LineDecorator 
Bug: 1134103
Change-Id: I5548d5d4af8a60ecb1c178c4cc3041e8cfaec5ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692888
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-15 15:48:02 +00:00
Peter Marshall deb3ccbdd7 [l10n] Update description for CPU peak usage 
Bug: 1163928
Change-Id: Ibe7080c234d5498bebebb706c2aa37d03a75d418
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2695569
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-02-15 15:46:12 +00:00
Alex Rudenko 49aa146a7a Integrate Flexbox editor into the Styles panel 
Screenshot: https://i.imgur.com/HblODzc.png
Design doc: https://goo.gle/devtools-flex-v2

Bug: chromium:1175699
Change-Id: I7699a8e1ec980c7eddc6d40ff3c88bf37db54988
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2690329
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-02-15 15:33:09 +00:00
Mathias Bynens 6bab158cb5 Use an actual map for MappedCharToEntity 
Bug: chromium:1178365
Change-Id: I425f11b98b03f3aa6461a78a9564c05e6ed21b1f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2695567
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2021-02-15 15:25:10 +00:00
Alex Rudenko afa17b48cf Disable flaky e2e tests 
Bug: 1178496, 1178497, 1145969
Change-Id: I5fab85bfbabb3073f99824242183668875a38d87
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2695571
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2021-02-15 15:23:00 +00:00