zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-10 13:44:39 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
267 Commits
Author SHA1 Message Date
Vidal Guillermo Diazleal Ortega 83edb474b3 [Loc] Migrate Sources to Localization V2 
- Migrate sources to use Localization V2 APIs.
- Removed sources grdps

Tested with en-XL.json
https://imgur.com/a/vDrfTAv

Bug: 1136655
Change-Id: I01d4fcdc3f115e9edb3fae933c7d5c6b9ffb77c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692743
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-16 19:14:49 +00:00
Sigurd Schneider a86d1166dc Move AffectedCookiesView to its own .ts file 
Bug: chromium:1072335
Change-Id: I5b91fb17482d513482667b5f736ddbb2baffec81
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696657
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-02-16 12:50:41 +00:00
Alex Rudenko 49aa146a7a Integrate Flexbox editor into the Styles panel 
Screenshot: https://i.imgur.com/HblODzc.png
Design doc: https://goo.gle/devtools-flex-v2

Bug: chromium:1175699
Change-Id: I7699a8e1ec980c7eddc6d40ff3c88bf37db54988
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2690329
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-02-15 15:33:09 +00:00
Sigurd Schneider 982ec5a825 Add CORS RFC-1918 issue 
Bug: chromium:1128885
Change-Id: Ia4fc5ee0fd03ad568eccc374db787dc705ee3cef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2687501
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-12 08:45:19 +00:00
Alex Rudenko 822f5bcc2b Flexbox editor 
This CL implements Flexbox editor as a standalone web
component.

Screenshots:
- https://i.imgur.com/9kjuOiQ.png
- https://i.imgur.com/ulZb2Lm.png

Design doc: https://goo.gle/devtools-flex-v2

Bug: chromium:1175699
Change-Id: I9a7eef1ec445621f02d98ad10c20aa6e2fccbaff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2685121
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-02-11 09:58:14 +00:00
Peter Marshall 428508ab36 [l10n] Remove unused ModuleUIStrings files 
As directories are migrated to the new -meta files, they no longer
need their ModuleUIStrings file.

Bug: 1136655
Change-Id: Iae983195fa24f6262d1d47d6093e82f4ce3df537
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686658
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-10 16:37:51 +00:00
Sigurd Schneider ad47ab8556 Generalize CounterButton component to IconButton component 
Bug: chromium:1140516
Change-Id: Ied4eefd029ed612e4e63e6de240e4c6ba0c64f56
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2684494
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-10 10:54:21 +00:00
Peter Marshall a9ac1bee7a [l10n] Rename the bundled i18n to i18n-bundle for clarity 
There's a lot of i18n.js files in the repo and it's a bit hard to keep
track.

Bug: 1136655
Change-Id: I7c6343fee15ecf9fb2a2ce71f43f05ff48714b89
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2659336
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-09 11:37:00 +00:00
Vidal Guillermo Diazleal Ortega 0a997bb8b6 [Loc] Migrate resources(Aplication) to Localization V2 
- Migrate resources(Aplication)to use Localization V2 APIs.
- Removed resources grdps

Tested with en-XL.json
https://imgur.com/a/hsH7AEm

Bug: 1136655
Change-Id: Iba7fef0b87f7aab7625f4e013f1a120baa268889
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2677336
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-09 05:17:17 +00:00
Sigurd Schneider 0ddc59337e Refactor IssueView to a separate file 
This change refactors the IssueView to a separate file and converts
IssuesPane to TypeScript.

Bug: chromium:1072335
Change-Id: Ibb9a6944858730fd8efa72b6b6da78df3c1851d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678099
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-08 09:16:09 +00:00
Sigurd Schneider b54b602422 Rename ClearStorageView to StorageView 
This CL also converts the layout test storage-view-reports-quota.js
to an e2e test.

Bug: chromium:945786
Change-Id: I9ae73e41e564318474089e7ba312f3379893e847
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2667200
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-05 15:45:29 +00:00
Changhao Han c8b7352435 Add AdornerManager for adorner settings 
The AdornerManager is responsible for handling the business logic of
loading, syncing, and updating adorner settings. It will be responsible
for more adorner-related business logic as adorner gets gradually
evolved.

The next CL will build upon AdornerManager and create a settings pane.

Bug: chromium:1066772
Change-Id: Iab585aba703b09c0b9e46a24cd261e1fd3944cc4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2666686
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-05 14:35:28 +00:00
Jack Franklin e265d92525 [TreeOutline] Initial component structure. 
IMPORTANT: this component is *not* ready for production use.

Rather than build the entire TreeOutline and land it in one huge CL, I
am instead landing it in small pieces. This CL includes:

* the basic TreeOutline component
* full keyboard navigation [following the WAI-ARIA guidelines:
  https://www.w3.org/TR/wai-aria-practices/examples/treeview/treeview-2/treeview-2b.html]
* support for recursively expanding and collapsing from nodes.
* thorough unit tests and component doc examples.

It does not include work on being able to customise rendering of nodes
(that's next), or CSS work, so it doesn't look like it is meant to
currently.

Bug: chromium:1166669
Change-Id: I4a3ce6e0553453067d05359ae9ef3150081250d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2647587
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-02-05 12:03:03 +00:00
Alex Rudenko d6594130ef Report low contrast issues 
This CL adds the logic to trigger contrast checks on DevTools
startup or on page load events. The check is only triggered if
the corresponding experiment (contrastIssues) is enabled.
Deduplication of the reported issues happens in the IssueManager
on the frontend since the same issue might be reported twice
if there are multiple documents on the target page.

Bug: chromium:1155460
Change-Id: Ib0d5115c527ceb9da9d2ed2dfa48cfdca6f82f60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2573360
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-02-04 12:39:48 +00:00
Christy Chen c62d7a4460 [Loc] Migrate issues to localization V2 
Migrate issues panel
Tested with en-XL: https://imgur.com/a/kEhfKAt


Bug: 1136655
Change-Id: I8801bf6b84d2355612133b82d15640b656a3d82e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2675006
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-04 10:55:57 +00:00
Vidal Guillermo Diazleal Ortega b6b7eef7ed [JSDOC2TS]: Migrate i18n 
migrating i18n module to typescript.

Bug: chromium:1158760
Change-Id: Ic291accddb89069851af78be9fcf705f7f0be92d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2664803
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-03 18:52:11 +00:00
Jan Scheffler 05b80aa7bd [Recorder] Explicitly wait for navigations 
This patch identifies actions that lead to navigations and modifies
the outputted scripts to also wait for navigations to happen when
replaying those scripts.

Fixed: chromium:1161461
Change-Id: Iab50784605d801d0f84bdbe9f1c3bf989d045892
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2667195
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-03 16:36:31 +00:00
Christy Chen cac3f1096e [Loc] Migrate network to localization V2 
Migrate network panel
Tested with en-XL: https://imgur.com/a/7F7vWv4


Bug: 1136655
Change-Id: Idd0ab59e021a2be919ceca1def21537d6d25607d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2662325
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-02-03 10:44:54 +00:00
Alex Rudenko d6276ae69a Extract AffectedElementsView to a separate file 
Bug: chromium:1155460
Change-Id: I36163cfb0523142bed628b332ac145d5e7eb4cd3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2667201
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-02 15:02:24 +00:00
Christy Chen 7a2ead3d36 [Loc] Migrate browser_debugger to localization V2 
Migrate brwoser_debugger
Tested with en-XL: https://imgur.com/a/61y0spd


Bug: 1136655
Change-Id: Ie9a831313a8d47a3b370b2248948a65881ab6685
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2667107
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-02 13:37:58 +00:00
Ella Ge f2e77172e6 Add Trusted Web Activity issue 
This CL adds the Trusted Web Activity issue to devtools issue tab.

Issue descriptions:
http://doc/1nlYeWlwCOva7M9EoT6YKQZ4s-Ug8aXbQIp4Oc1cL8WE/

Bug: 1147479
Change-Id: I977fd008c40f7c2fa249d1c73d285db0c3d54b28
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650237
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-02-01 15:56:58 +00:00
Wolfgang Beyer 44b95595c9 Add until directive from lit-html 
lit-html's until directive will be needed in an upcoming CL
(https://crrev.com/c/2640576), adding it here separately for simplicity.

Bug: 1165710
Change-Id: I1a939bd45062370efd3b618ac856d0a9d10e437a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2662824
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-01 12:30:04 +00:00
Sigurd Schneider 286466e0c8 Reland "Show issues on SAB instantiation" 
This reverts commit b3759d720b.

Reason for revert: A chrome test binary roll changed e2e test
behavior between running CQ on the CL and landing it.

Original change's description:
> Revert "Show issues on SAB instantiation"
>
> This reverts commit f366a4ca99.
>
> Reason for revert: Fails on a lot of CQ and trybots.
> E.g.: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/5128/overview
>
> Original change's description:
> > Show issues on SAB instantiation
> >
> > Bug: chromium:1051466
> > Change-Id: I39f1110d370e3d5cca801112c2b776f697875d64
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2652505
> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
>
> TBR=sigurds@chromium.org,jacktfranklin@chromium.org,wolfi@chromium.org
>
> Change-Id: I8a6a8b7aa57be0521615f9569bfdcad86463d8d0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1051466
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2655246
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

TBR=sigurds@chromium.org,szuend@chromium.org,jacktfranklin@chromium.org,wolfi@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: chromium:1051466
Change-Id: Id3858c9b38d4f0dbcbc47dcc86500e8e27258305
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2655248
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-01-28 11:50:08 +00:00
Simon Zünd b3759d720b Revert "Show issues on SAB instantiation" 
This reverts commit f366a4ca99.

Reason for revert: Fails on a lot of CQ and trybots.
E.g.: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/5128/overview

Original change's description:
> Show issues on SAB instantiation
>
> Bug: chromium:1051466
> Change-Id: I39f1110d370e3d5cca801112c2b776f697875d64
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2652505
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>

TBR=sigurds@chromium.org,jacktfranklin@chromium.org,wolfi@chromium.org

Change-Id: I8a6a8b7aa57be0521615f9569bfdcad86463d8d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1051466
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2655246
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-28 10:02:18 +00:00
Paul Lewis 1ca937bc72 Adds component render coordination support 
Currently our components don't orchestrate their DOM updates, which
leads to interleaved reading and writing layout-centric values, e.g.
clientHeight, scrollTop etc.

This CL introduces a helper to ensure that we do reads, writes, and
scrolls at the correct point in the frame lifecycle. Future work would
be to lint the use of the various layout-centric DOM APIs and to ensure
that they are wrapped in the correct callbacks.

Bug: 1171202
See: https://gist.github.com/paulirish/5d52fb081b3570c81e3a
Change-Id: Ie70df412ebb2db006bcbc50608d8855e093e7a07
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650530
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-28 09:33:07 +00:00
Sigurd Schneider f366a4ca99 Show issues on SAB instantiation 
Bug: chromium:1051466
Change-Id: I39f1110d370e3d5cca801112c2b776f697875d64
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2652505
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-01-28 08:52:47 +00:00
Tim van der Lippe 0fcccc317b Remove Remote Devices panel 
This has been deprecated in https://crrev.com/c/1909383 in Chrome 80,
which is 10 Chrome releases ago. To reduce the amount of technical debt,
we are fully removing the panel now. Users can still use chrome://inspect
which provides the same functionality as the Remote Devices panel once did.

R=petermueller@chromium.org

Bug: None
Change-Id: I660cc98d840a0b350fa08cb7b0a0037a14e06c76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2640573
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Peter Müller <petermueller@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-27 11:30:14 +00:00
Christy Chen e936c00ec7 [Loc] Migrate source_frame to localization V2 
Migrate source_frame directory
en-XL: https://imgur.com/a/WOKixNs


Bug: 1136655
Change-Id: I9266985045a7068b0d1ae8a8a371f7e84a5171b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2648577
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-27 07:55:44 +00:00
Jack Franklin 9f9dc5bbad Create KeyboardUtilities module 
It's small right now, but I've noticed writing the exact same code in my
branch that has the TreeOutline component in, and I expect as we build
more components we will end up with some more keyboard navigation helper
code, so I'd like to put it in a shared place.

Bug: chromium:1170357
Change-Id: If4acbf58da98c1cadff536ca82d6d74a5c46c77a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2647588
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-25 17:18:25 +00:00
Christy Chen 59f6cf5697 [Loc] Migrate browser_sdk to localization V2 
Migrate browser_sdk directory


Bug: 1136655
Change-Id: Ied83b93ee62b4e3d85799c0518b006f97066087a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2644600
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-25 07:35:53 +00:00
Jack Franklin 1dbdce5fbb Improves render performance of DataGrid 
Also-By: jacktfranklin@chromium.org
Bug: 1169021
Change-Id: Ibfacfea53dbc35f22b315971b94b1181ddfa7a3c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2644897
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-22 17:27:23 +00:00
Annabel Zhou be163e76ce Basic rendering and click handler unit tests for AccessibilityNode 
This change includes an AccessibilityTreeUtils file to convert between
an SDK.AccessibilityNode and new AXNode.
Design doc: https://goo.gle/devtools-a11y-tree

Bug: 887173
Change-Id: I1b8987e1d246e98094f1e49a04d6d25eb5f3f824
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2636102
Commit-Queue: Annabel Zhou <annabelzhou@google.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
 2021-01-22 00:06:50 +00:00
vidorteg 7c153a21c2 [Loc] Migrate profiler to Localization V2 
- Migrate profiler to use Localization V2 APIs.
- Import the strings declared in the heap_snapshot_worker
- Removed event_listener grdps

Tested with en-XL.json:
https://imgur.com/MoxBmKK
https://imgur.com/cW0nelm
https://imgur.com/A99ofNG

Bug: 1136655
Change-Id: I282ff0a8ccd374dab95412eda1c974a587d1c78a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2632164
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-21 21:39:48 +00:00
Peter Marshall c17d077274 [surveys] Move SurveyLink component into ui/components 
Rename and move the SurveyLink component in preparation for making it
more generic so that we can use it from different modules. Right now
there are still some parts which are specific to the Issues drawer
but I'll remove them in a follow-up.

Bug: 1112738
Change-Id: Id7fe78092ccb5cb668689fa1fa8fc3a1fddb0ca8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2642353
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2021-01-21 14:20:03 +00:00
Simon Zünd 30152edff6 Add Trust Token pane in the Application Panel 
Screenshot: https://imgur.com/a/VFj6w7B

This CL adds a new pane in the storage section of the Application
panel that displays all available Trust Tokens in the current
browsing context.

R=jacktfranklin@chromium.org, petermueller@chromium.org

Bug: chromium:1126824
Change-Id: Ic47e1cf21a6ff37f59d8c31b428ad976117768c2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626291
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Müller <petermueller@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-21 13:33:14 +00:00
Christy Chen f9033fa039 [Loc] Migrate perf_ui to localization V2 
Migrate perf_ui

Bug: 1136655
Change-Id: I000de6662e48aa7e8e236c550584a1e5947dbad7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2641894
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2021-01-21 11:51:33 +00:00
Wolfgang Beyer 309863f0a8 Port FrameDetailsView to TypeScript 
FrameDetailsView is moved to a separate file and ported to TypeScript.
Since https://crrev.com/c/2640576 follows up with refactoring into a
custom component, the TypeScript code in this CL is not polished.

Change-Id: I6e02c0c1db9ff94d9bc879ef51767e402417064a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2641769
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-01-21 10:02:03 +00:00
Songtao Xia 40fbf57386 Service Worker Update Cycle Timeline 
This CL adds SW update cycle timeline to the Service Workers
view, Application pane. See the explainers below for
requirements.

A summary of features implemented:
- For the service worker associated with the current target, for
every version still alive (including redundant ones), show a
timeline of the install, wait, or activate events.
- The timeline is a waterfall style, different than in the explainer
but similar to that in network timing.
- Such a timeline is based on the observation in the frontend and
is intended to show for example, if an event takes extra long
time in waiting. It is not meant to be a measurement of execution
time of the event handler at the backend.
- Each event's timeline may be expanded to reveal details of
the event handler, such as the starting and ending time of
the event handling.
- Other details in the explainer are not included.

Timeline for an active sw.
https://imgur.com/o2OHnYq

Timeline for one active and one redundant sw. Note the bar is ultra thin
https://imgur.com/4VBKrH5

Bug:1066604

Explainer:
https://docs.google.com/document/d/1M2xKrlFHrojGHIJ9AVpQdGrmUUU0G8YVToa3kZz3RZA/edit?usp=sharing

Change-Id: I0b3725b342eeb32470ef759bab8a7da5a350dba9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2409192
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Brian Cui <brcui@microsoft.com>
 2021-01-20 17:50:51 +00:00
Sigurd Schneider ea4488d496 Refactor ErrorWarningCounter to use a new CounterButton component 
Bug: chromium:1140516
Change-Id: I1c2f87184e6458c631828ac4c396de7040cba8e5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635662
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-19 08:26:06 +00:00
Jack Franklin 63fc645844 Add the DataGrid to the Protocol Monitor 
This CL adds the new DataGrid component to the ProtocolMonitor.

Bug: 1125968
Change-Id: I0b29b21a8419d217ff876eedc67b110ca9e4f2af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2532245
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-01-18 09:41:22 +00:00
Jack Franklin 9f1d0d5811 Create a helper for setting CSS props inside custom element 
Just tidies up the code a bit but mainly removes everyone from having to do that
typecast of `shadow.host`.

Bug: chromium:1166108
Change-Id: Iee55c9aa7453b7f8ee3623cc1bbc349e15edc400
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626303
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-14 16:17:56 +00:00
Annabel Zhou fb0f3c75c8 Add AccessibilityNode web component and display non-interactive tree 
This change is hidden behind experiment flag "fullAccessibilityTree".

Design doc: https://goo.gle/devtools-a11y-tree
Follow-up CLs: expanding/collapsing of child containers, adding click
handlers for adding new children into the model if they haven't been
requested, tying it to the DOM inspector.
Screenshots linked in bug.

Bug: 887173
Change-Id: I62a35bb913fff46856fa87c7030be16631d2dbc7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2613072
Commit-Queue: Annabel Zhou <annabelzhou@google.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
 2021-01-14 05:11:13 +00:00
Tim van der Lippe 28a79aace9 Move assertNotNull into platform 
R=jacktfranklin@chromium.org

Fixed: 1154208
Change-Id: I3729d0f06577a3bb065ea362dec9e83d096965b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2618318
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-11 17:14:27 +00:00
Annabel Zhou 39974fe062 Added AccessibilityTree web component and toggle switch between 
accessibility and DOM tree in ElementsPanel

This change is hidden behind experiment flag "fullAccessibilityTree".
Design doc: https://goo.gle/devtools-a11y-tree

Bug: 887173
Change-Id: Ib3eb0cd22a45198c5718f2f00bbdad419d3de06f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2613074
Commit-Queue: Annabel Zhou <annabelzhou@google.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2021-01-10 23:39:15 +00:00
Tim van der Lippe 677a98d1c4 Remove component_docs from GRD 
These files are not intended to be included in the DevTools release
bundle and therefore should be treated as testonly. This also means
that we should be using `ts_library` instead of `devtools_module`,
as we don't intend to copy these files into `resources/inspector`.

R=jacktfranklin@chromium.org

Fixed: 1152777
Change-Id: Id23d403c64445dd1c0ea59e36117dfc667f7e8e5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2617796
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-08 16:09:47 +00:00
Jack Franklin 3fcecc1172 Add body context menu to data-grid 
This CL adds support for the context menu that appears when you right
click on the body row of the data-grid.

This menu shows columns you can sort by and you can toggle column
visibility via "Header Options" (the text is identical to the legacy
data grid). It also provides a hook for the user to customise and add
their own items to the context menu.

Bug: 1150793
Change-Id: I6a6d8c6c67156a575477c1e6d438261b85d9b034
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610967
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-06 16:11:55 +00:00
Changhao Han 81727eac8f Move CSSAngleRegex to CSSAngleUtils and remove unnecessary file 
Bug: chromium:1126178
Change-Id: I514de076a9c1af6e28fe6da7e4a5cf9c8682c9dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610784
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-01-05 13:09:59 +00:00
Sigurd Schneider 683143d8d5 Show an issue if a SAB is passed to postMessage 
Back-end CL: https://crrev.com/c/2593087

Bug: chromium:1051466
Change-Id: Iaf0a5f4df879406bc098cc5215110709fb979205
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2593127
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-12-17 15:43:16 +00:00
chait pinnamaneni 8a5112747f adding image and icon support for markdownview.ts 
Markdown image example:
https://i.imgur.com/NDgsEA4.png

MarkdownImagesMap entries
```
[
  'settingIcon',
 {
  src: 'Images/settings-gear.svg',
  isIcon: true,
  width: '20px',
  height: '20px',
  color: 'var(--color-primary)'
 }
],
[
  'lighthouseLogo',
 {
  src: 'Images/lighthouse_logo.svg',
  isIcon: false,
 }
]
```

Markdown
```
Following is settings icon ![phone icon](settingIcon)
Image in markdown can be done like this ![alt title](lighthouseLogo)
```
Bug:1154783
Change-Id: Ia13e5d2c40de3c457429d7d550dbb326511873c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587634
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
 2020-12-16 18:11:25 +00:00
Wolfgang Beyer 08a5d41a75 Rename frameworkBlackboxSettingsTab to frameworkIgnoreListSettingsTab 
This patch replaces unwelcoming language with better terms.

Bug: 1152082
Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k

Change-Id: I2d8930e68e30d0467dc70044d3089451d4cbad39
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587018
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-16 10:04:38 +00:00