zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-10 21:54:47 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
24 Commits
Author SHA1 Message Date
Alfonso Castaño 68cf42e8f2 Refactor to use Map rather than Object in PresentationConsoleMessageHelper.js 
Bug: chromium:1150883
Change-Id: I07e30d249acd1fb5d88b6f795d720ca8a246f24a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2591130
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Alfonso Castaño <alcastano@google.com>
 2020-12-16 13:02:14 +00:00
Tim van der Lippe 2e38eeaf9f Remove all comments with only the unrestricted annotation 
The unrestricted annotation is Closure-specific and can be removed.
This patch removes all comments with only the unrestricted annotation
in them.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: Iba0723644f53f5307c3077d341271af86becc32a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569758
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-02 15:25:32 +00:00
Mathias Bynens a0d60451e1 Remove custom setImmediate implementation 
All of the existing callsites passed only a callback parameter, with
no additional `args` parameters, and so this functionality is
equivalent to the built-in queueMicrotask().

Note that there are some upstream tests that currently still use
setImmediate. These tests are ported in [1], which should be merged
before this patch can land.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/2563476

Bug: chromium:1050549
Change-Id: Iee3d286d38bcb17d9b78ca89f9897e8ca37b6d94
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2554560
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-30 14:20:29 +00:00
Alfonso Castaño 0316e13cbc Fix row messages not appearing in Source Tab without refreshing 
Messages whose script object was not available yet were not being resolved once the script is available.
The reason is that they were getting lost during the actual check.

Bug: chromium:1152731
Change-Id: Id6e216ca8d90103f9f40bec245e21e56b09b62f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2562702
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-11-27 13:22:06 +00:00
Philip Pfaffe 7b285898df TypeScriptify PresentationConsoleMessageHelper 
Bug: chromium:1011811
Change-Id: Ib4f190f7e5878f8f48b6a6540bd963fa38bd6a07
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484713
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2020-10-19 09:54:01 +00:00
Jack Franklin 2c1e944aad Migrate front_end/bindings to devtools_entrypoint 
Bug: 1101738
Change-Id: I0d43818334425984a160fa9b79076f7413a6a52b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2306155
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-07-20 10:47:17 +00:00
Paul Lewis 4a896b29ab [global] Remaps self.SDK.consoleModel 
Moves self.SDK.consoleModel to an instance() method.

Bug: 1058320
Change-Id: I52e403c85e6d478e43f7f82d48a34cba0c4fe47d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107626
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-20 12:32:37 +00:00
Paul Lewis 23883e36f5 [global] Remaps self.Bindings.debuggerWorkspaceBinding 
Moves self.Bindings.debuggerWorkspaceBinding to an instance() method.

Bug: 1058320
Change-Id: Id9090073eb4a0b8715bba82ded470d15d718dcc6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107529
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-03-18 12:06:08 +00:00
Simon Zünd 29781ded1b Make live location update handlers async and properly await {uiLocation} 
Retrieving the {uiLocation} of a LiveLocation can involve source
mapping (via rawLocationToUILocation). As source mapping will be
async in the future we have to properly await {uiLocation} in these
LiveLocation update delegates.

Note that support for asynchronous LiveLocation updates has already
landed.

Bug: chromium:1032016
Change-Id: I81be755581b6347c8d510de3216503e32481e470
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077667
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-03-17 19:49:48 +00:00
Paul Lewis daac106699 [global] Remaps self.SDK.targetManager 
This CL changes references to self.SDK.targetManager (the global
instance of SDK.SDKModel.TargetManager) over to
SDK.SDKModel.TargetManager.instance(). To keep both TypeScript and
Closure happy we must make a method on the TargetManager class itself,
since it only allows private constructors to be accessed by static
methods on the class.

Bug: 1058320
Change-Id: I6ca35024c21cf24254fd6273138a1ab3e163ee00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2088092
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-05 14:58:03 +00:00
Tim van der Lippe 37a35fff86 Reland "Typecheck Object.js" 
This reverts commit f996a1c537.

Reason for revert: Fixed incorrect refactoring in this CL.

Original change's description:
> Revert "Typecheck Object.js"
>
> This reverts commit 258665aca5.
>
> Reason for revert: Suspected of breaking the roll (https://crrev.com/c/2083712)
> Bot failure: https://ci.chromium.org/p/chromium/builders/try/linux-rel/322462?
>
> Original change's description:
> > Typecheck Object.js
> >
> > To typecheck the file Object.js with Typescript I had to fix the type errors from all other classes
> > that were using addEventListener or removeEventListener incinsistently.
> >
> >
> >
> > Bug: 1011811
> > Change-Id: I2fccbbd07ef3d9a581baa34233580bc6a9dbbfc3
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2079794
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Jose Leal <joselea@microsoft.com>
>
> TBR=szuend@chromium.org,joselea@microsoft.com,tvanderlippe@chromium.org,jacktfranklin@chromium.org
>
> Change-Id: I30e3d75eee463362107d6e6ad25df2b7d50f9d54
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1011811
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081824
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: 1011811
Change-Id: I19ebbe0345a5c7380ed69d1ba2921adf0385228e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084580
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-03 14:09:44 +00:00
Simon Zünd f996a1c537 Revert "Typecheck Object.js" 
This reverts commit 258665aca5.

Reason for revert: Suspected of breaking the roll (https://crrev.com/c/2083712)
Bot failure: https://ci.chromium.org/p/chromium/builders/try/linux-rel/322462?

Original change's description:
> Typecheck Object.js
> 
> To typecheck the file Object.js with Typescript I had to fix the type errors from all other classes
> that were using addEventListener or removeEventListener incinsistently.
> 
> 
> 
> Bug: 1011811
> Change-Id: I2fccbbd07ef3d9a581baa34233580bc6a9dbbfc3
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2079794
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Jose Leal <joselea@microsoft.com>

TBR=szuend@chromium.org,joselea@microsoft.com,tvanderlippe@chromium.org,jacktfranklin@chromium.org

Change-Id: I30e3d75eee463362107d6e6ad25df2b7d50f9d54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011811
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081824
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-03-03 05:59:28 +00:00
Jose Leal Chapa 258665aca5 Typecheck Object.js 
To typecheck the file Object.js with Typescript I had to fix the type errors from all other classes
that were using addEventListener or removeEventListener incinsistently.



Bug: 1011811
Change-Id: I2fccbbd07ef3d9a581baa34233580bc6a9dbbfc3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2079794
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jose Leal <joselea@microsoft.com>
 2020-03-02 18:15:06 +00:00
Tim van der Lippe c02a97ca2c Fix imports for Common.Event typedef 
All references now use the fully qualified
"Common.EventTarget.EventTargetEvent". It renames it to
"EventTargetEvent" to prevent a name-clash with the native "Event" type.

Bug: 1006759
Change-Id: I13fcdfd613041da146d741a0d1f785bfc905a7a8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056481
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-14 15:21:06 +00:00
Tim van der Lippe 55cd4ef58c Migrate bindings/ to import cross-module 
Bug: 1006759
Change-Id: If69c4e96c0042e60282bf0d6450518e456a12ad1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2017502
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-24 10:18:08 +00:00
Paul Lewis e504fd6a5f [Global] Updates refs to SDK.consoleModel 
Bug: 1006759
Change-Id: Ifa6d7f177a22a38eaa4f3a16a26c797659ddee98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2017145
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-23 17:10:50 +00:00
Paul Lewis 2ddc6313de [Global] Updates refs for bindings globals 
Bug: 1006759
Change-Id: Ib73c3ce4b014126da088851bfeccdff49d6ba0ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016754
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-23 13:37:40 +00:00
Paul Lewis 4ae5f4f5ce [Global] Update refs to SDK.targetManager 
Bug: 1006759
Change-Id: I0686ef929b89e75c2ea8a731c593d955eca85935
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2015119
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-23 10:56:40 +00:00
Paul Lewis ef05f96d6d Migrates bindings/ to ESM internally 
Bug: 1006759
Change-Id: I24fa605a4aa9dcc25cf7ff76609b8ae86cf09905
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993350
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-10 11:37:56 +00:00
Tim van der Lippe c96ccd99f0 Remove unused globals 
By using the script in crrev.com/c/devtools/devtools-frontend/+/1942289
we can prune all globals that are not actually global. Most of these are
internal private variables that are now module-scoped. Some variables
were also completely unused, which ESLint nicely reported.

Change-Id: I43689ac7544ad1239acc7d0eeec4dcd563d7fea9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1942290
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2019-11-29 16:38:40 +00:00
Tim van der Lippe 0723204a47 Migrate bindings/ to ESM 
Bug: 1006759
Change-Id: Iaf9bc50583ed4936998f73c29c915d9c6f086195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847286
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#703749}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 476a2598349667b31c75170c3912dc75867883a9
 2019-10-08 15:58:07 +00:00
Tim van der Lippe 1d6e57a0e3 Always add braces to single-line if-statements 
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
 2019-09-30 11:55:34 +00:00
Alexey Kozyatinskiy 68bab06a07 [DevTools] remove separate event for FailedToParseScriptSource 
Everywhere on the frontend side, we use both events and process them
in the same way.

R=lushnikov@chromium.org

Bug: none
Change-Id: I3ab9b196921ff9e7e8eac86e9217b0869f0c2313
Reviewed-on: https://chromium-review.googlesource.com/1163838
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580974}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c4c3cc18a3d51687dd25a9998a6f45e5a436ac9f
 2018-08-06 20:33:01 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2. 
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
 2018-04-07 15:32:37 +00:00