zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-09 13:18:29 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
76 Commits
Author SHA1 Message Date
Tim van der Lippe e7446350b3 Remove diff/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: Icc937903dd2e4fdab76451b86e1d5b5be2014de8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686665
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-15 16:57:50 +00:00
Sigurd Schneider 91147d8f00 Enforce camelCase for functions 
Bug: chromium:1057042
Change-Id: I6a3e3dcf810884129420e0deaf0e6d54874b5449
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692211
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
 2021-02-15 11:16:45 +00:00
Peter Marshall 428508ab36 [l10n] Remove unused ModuleUIStrings files 
As directories are migrated to the new -meta files, they no longer
need their ModuleUIStrings file.

Bug: 1136655
Change-Id: Iae983195fa24f6262d1d47d6093e82f4ce3df537
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686658
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-10 16:37:51 +00:00
Tim van der Lippe 4d072bbb6d Remove workspace/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: I579833ff45462768b69ad9f3fa151f74385bb176
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686661
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-10 14:05:40 +00:00
Andres Olivares c3b9beaf2e [module.json extensions] @Common.Revealer Part 1 
Bug: 1134103
Change-Id: If3f28f0b3787facc1c967b221eaadd286c02851c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2681887
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-09 15:39:32 +00:00
Jack Franklin 49a9481a74 Lint color usage in background and border-* properties. 
The list of CSS properties we check for colors wasn't thorough and
didn't include `border-left/right/top/bottom` or `background` on its
own. This CL fixes that and disables the rule for any current
violations.

Bug: 1152736
Change-Id: Ic732d653fdfab0462a04dc891bcece1f44e5d471
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676157
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-05 15:39:39 +00:00
Tim van der Lippe 5c423509db Remove i18n/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: I700e6d5fc8941ef54d4af10af01989ddf62165cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676144
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-05 10:48:08 +00:00
Tim van der Lippe 13a46caab1 Remove bindings/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: I4ed2fefd511271ef2ec845c6fad165217a1477c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676142
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-04 17:07:19 +00:00
Sigurd Schneider 1576186355 Enforce member delimiters 
This CL enforces member delimiters following
https://google.github.io/styleguide/tsguide.html#member-property-declarations

Bug: chromium:1057042
Change-Id: I2553aeebb8187235cdf0e7f0585da36ea53388bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2672032
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-04 09:03:57 +00:00
Sigurd Schneider 9c07567fdd Properly enable dangling comma conventions in TypeScript 
The eslint rule 'comma-dangle' isn't enough to enforce dangling
commas in TypeScript, we must use '@typescript-eslint/comma-dangle'
instead.

Bug: chromium:1174055
Change-Id: I589e1016ab578c965b54f17da3eab7ea542a2f7a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2672028
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-03 14:01:11 +00:00
Jack Franklin 8064d3ba7a Lint against non-theme-color variables 
This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.

There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.

Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.

Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-02-03 11:02:09 +00:00
Andres Olivares 26fcbec6a0 Use l10n V2 in animation and changes meta files 
These modules had been migrated to V2 but the meta files were created
using V1.

Bug: 1134103
Change-Id: I711d614c55be2639b234823d56ced6604a8a17c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2648587
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-26 14:07:05 +00:00
Andres Olivares f138902e8f Change commandPrompt type to LocalizedString in ViewRegistration 
Bug: 1169065, 1134103
Change-Id: If647a6f51309f87f3da8a895c96db463494554d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2642909
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-25 18:00:55 +00:00
Andres Olivares 4ce36a5a37 [module.json extensions] Wrap localizable fields in anonymous functions 
To be able to localize extensions' strings at declaration using the i18n
v2 model in meta files, we opt to wrap such fields in callbacks as the
i18n API cannot be invoked directly at declaration because it hasn't
been configured by the time the meta files are loaded.

Bug: 1134103
Change-Id: I432f3854f724b8c5b94993ce3ddd469f657c1014
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635820
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 19:04:06 +00:00
Jan Scheffler 4c33ac288f [JSDOC2TS]: Migrate changes 
Bug: chromium:1158760
Change-Id: I696fb9d21431d73620f299516881f77a44c594af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2623940
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
 2021-01-14 14:02:45 +00:00
Jack Franklin 056c40022b Migrate String#compareTo to utilities 
Renamed it to `compare` as `compareTo` doesn't make sense when it's not on the
prototype.

Bug: chromium:1050549
Change-Id: I5175db423fecf0ec74ad148b44d962f629d146de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2627267
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-13 14:29:02 +00:00
Tim van der Lippe 2f1ea1c2ca [module.json extensions] changes 
R=andoli@chromium.org

Bug: 1134103
Change-Id: Ic2d249ae33f7e291ff7bdf921e35c92d8f5649ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612853
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-13 10:55:43 +00:00
Tim van der Lippe d7cfd14814 Fix no-implicit-coercion errors in front_end/ 
R=jacktfranklin@chromium.org

No-Presubmit: True
Bug: 1082789
Change-Id: Ic77884bf7e9b5dc74053915b3b10699368841b66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2595268
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-07 12:40:16 +00:00
Christy Chen 5d7848d54d Reland "[Loc] Migrate changes tool to localization V2" 
This reverts commit 9e5ab71e50.

Reason for revert: The Cl was reverted due to devtools pak file limitation. That issue has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2558341

Original change's description:
> Revert "[Loc] Migrate changes tool to localization V2"
>
> This reverts commit abcb8f7aa8.
>
> Reason for revert: Consistently causing autoroll issues when rolling devtools-frontend into Chromium - see https://chromium-review.googlesource.com/c/chromium/src/+/2554521 for an example.
>
> To recreate this, do a debug build of Chromium with this patch applied to DevTools. It's causing an issue with duplicate keys in the pak files. No DevTools Frontend builds do a debug build of Chromium with the DevTools frontend patch applied so our CQ will be green despite causing an issue.
>
> You can run this locally in Chromium to reproduce via:
>
> autoninja -C out/Default chrome:packed_resources_extra
>
> Which will show the error. 
>
> Original change's description:
> > [Loc] Migrate changes tool to localization V2
> >
> > Migrate changes tool
> > Tested with en-XL: https://imgur.com/a/hFDBjQV
> >
> >
> > Bug: 1136655
> > Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
> > Commit-Queue: Christy Chen <chrche@microsoft.com>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> TBR=szuend@chromium.org,chrche@microsoft.com
>
> Change-Id: I94b27434562f6a6bff3be381ab8a5802bd8b03f9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1136655
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557044
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

TBR=szuend@chromium.org,chrche@microsoft.com,jacktfranklin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1136655
Change-Id: I35166a6f4f38462073b933c01c169b3c8d14311b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567344
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-12-02 06:13:17 +00:00
Tim van der Lippe 7dcef88d8b Remove skip_compilation from module.json files 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I4c4fd280adb4f5f7b327239d08d80b2cb98b203b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560248
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-25 13:19:08 +00:00
Jack Franklin 9e5ab71e50 Revert "[Loc] Migrate changes tool to localization V2" 
This reverts commit abcb8f7aa8.

Reason for revert: Consistently causing autoroll issues when rolling devtools-frontend into Chromium - see https://chromium-review.googlesource.com/c/chromium/src/+/2554521 for an example.

To recreate this, do a debug build of Chromium with this patch applied to DevTools. It's causing an issue with duplicate keys in the pak files. No DevTools Frontend builds do a debug build of Chromium with the DevTools frontend patch applied so our CQ will be green despite causing an issue.

You can run this locally in Chromium to reproduce via:

autoninja -C out/Default chrome:packed_resources_extra

Which will show the error. 

Original change's description:
> [Loc] Migrate changes tool to localization V2
>
> Migrate changes tool
> Tested with en-XL: https://imgur.com/a/hFDBjQV
>
>
> Bug: 1136655
> Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
> Commit-Queue: Christy Chen <chrche@microsoft.com>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

TBR=szuend@chromium.org,chrche@microsoft.com

Change-Id: I94b27434562f6a6bff3be381ab8a5802bd8b03f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1136655
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557044
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-24 10:54:09 +00:00
Christy Chen abcb8f7aa8 [Loc] Migrate changes tool to localization V2 
Migrate changes tool
Tested with en-XL: https://imgur.com/a/hFDBjQV


Bug: 1136655
Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-23 18:46:16 +00:00
Tim van der Lippe 43efdd17a9 Use TypeScript-authored files in changes/ 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I2d7ae3b530fa5e7e406ff226b846e383069d18c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2534206
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-12 16:31:18 +00:00
Tim van der Lippe 9534205dbf Typecheck changes/ChangesHighlighter.js with TypeScript 
Unfortunately the typings in `@types/CodeMirror` are most of the
time incorrect and require several upstream patches to make them
pass. For now, we are ignoring these issues, to unblock numerous
other build infrastructure changes we need to make.

R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I730663b0dc6ef9ff85d5d4a2cc58403a39d7d921
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2534203
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-11-12 16:24:03 +00:00
Tim van der Lippe 3a34cdfe5a Typecheck changes/ChangesTextEditor.js with TypeScript 
R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: I90f983c10cf6855a07f1ce9e077a47d4c2a10974
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2526687
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-10 16:29:28 +00:00
Jack Franklin 71519f8efb Introduce enableLegacyPatching flag for CSS patching 
As part of the dark mode migration we are adding
`enableLegacyPatching:true` to all call sites of `appendStyle` (and
related methods). If a user passes `false` for that flag, no CSS colour
patching will occur.

This CL is therefore a no-op from a user's perspective as we pass `true`
on every call to maintain existing behaviour, but once we start
migrating we will turn the option to `false`. Long term, once all code
is migrated and the old patching is removed, we will remove this flag
entirely once again.

Bug: 1122511
Change-Id: I76b818e83b7d5ee0175e1548759373f53481e0ab
No-Presubmit: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2516345
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-03 14:11:46 +00:00
Yang Guo ef36cec5b9 Apply governance change 
DISABLE_THIRD_PARTY_CHECK=no code changes
R=bmeurer@chromium.org

Change-Id: I2477c36f5ef2494ccae3efae3f1aee942f365fec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2489420
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-10-21 07:54:15 +00:00
Tim van der Lippe 46e1bcace9 Remove pre_generates_legacy from module.json files 
This was a temporary flag used during the build_release_applications
to GN migration.

R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I8a772bcc4bee31dbd3270bf7ef62d8c97941024a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484716
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-10-19 16:12:09 +00:00
Tim van der Lippe ead1fa43d0 Move remaining legacy files to GN 
R=aerotwist@chromium.org

Bug: 1131500
Change-Id: Ibb247dd02a5032604824517be4276c4b83c8fc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479140
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-10-19 09:25:50 +00:00
Paul Lewis d428614454 TypeScriptify ChangesSidebar.js 
R=szuend@chromium.org

Bug: 1011811
Change-Id: Id99df0184feffdb8138bc8e10c5def9d14be1225
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479131
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-10-16 12:10:37 +00:00
Tim van der Lippe d87271d132 Remove usages of Runtime.sharedInstance 
For all classes that were retrieved via Runtime.sharedInstance,
migrate them to the singletong instance pattern. This removes
the indirection via Runtime and improves code navigation as
well as typechecking.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ifcf0b73be703308fbdbad0c585f0d945cee9b3b7
Fixed: 1131423
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2434340
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-29 10:59:08 +00:00
Tim van der Lippe 7f2002c598 [globals] self.runtime 
Migrate all usages of self.runtime to Root.Runtime.Runtime.instance().

This also requires various type updates, as now Closure/TypeScript
can better understand the code and discover issues.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ice07aa0ca959e61a6acdf4618b9a272d8c1096b8
Fixed: 1081614
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2434339
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-29 10:52:39 +00:00
Mathias Bynens 601f7f247f Migrate ChangesView to TypeScript 
Preparatory CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2426531

Bug: 1011811
Change-Id: I86d72b61805fc15b7f819a708f88d5e484ec3593
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431505
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-09-28 10:49:52 +00:00
Mathias Bynens fd016bf307 Remove the global spacesPadding and numberToStringWithSpacesPadding helpers 
Their functionality can be expressed more easily with inline
String.prototype.padStart calls.

This simplifies the upcoming TypeScriptification of ChangesView.js.

Bug: chromium:1011811, chromium:1050549
Change-Id: I1b39d7e4ff6d71968ec2cfdff9dc24fb072f1a47
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2426531
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-09-24 14:57:15 +00:00
Tim van der Lippe cac65d4fa0 Remove skip_rollup 
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-08 15:44:09 +00:00
Tim van der Lippe 19a45dfd55 Remove is_legacy_javascript_entrypoint 
This removes the now-obsolete is_legacy_javascript_entrypoint build flag,
which was used as part of the devtools_entrypoint migration.

This uncovered that accessibility was still using devtools_pre_built
and a file was missing from the GRD variable.

R=aerotwist@chromium.org,jacktfranklin@chromium.org

Fixed: 1101738
Change-Id: Ie1556ccc1d1563c855417de18e896308de0cfe19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2356305
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-08-28 12:32:29 +00:00
Jan Scheffler a5c5b34d67 Migrate front_end/changes to devtools_entrypoint 
R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: Ie26902cda0e64b14670026bfc92ed9c65e9fdaa3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332221
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-07-31 13:24:59 +00:00
Tim van der Lippe 37512b0d25 Remove empty script arrays from module.json files 
If the module uses `modules` to load the JavaScript files, then
we can remove the `scripts` array altogether. Note that there
are still some modules left that use `scripts`, most notably
the `lighthouse_worker`, which is a remote module.

R=aerotwist@chromium.org

Bug: 1105476
Change-Id: Ie303e9835f5ce6d42ccae7b3a305d8f3df1af84c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2302597
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-07-17 10:05:33 +00:00
Tim van der Lippe 1b2c52bbfa Remove tvanderlippe@ as explicit OWNER from several front_end subfolders 
As part of the initial seeding of the OWNERS, the automated scripts added
myself as OWNERS to pretty much every single folder in `front_end/`. This
is an artifact of the widespread infrastructure I have done, with in
particular the ES Modules migration that touched every single file in
DevTools.

In the past few weeks, several times I have received CLs were I was asked
to perform a domain review on the feature in question. Most of the time,
I have no knowledge of that particular feature.

To reduce confusion and roundtrips asking for different domain reviewers,
I removed myself as explicit OWNERS of these files. Note that I can still
use my INFRA_OWNERS to land changes, but as usual these are infra-only.
E.g. these will include the larger refactorings that span multiple features,
but not a single feature in particular.

I have kept myself OWNERS of folders that are part of the core
architecture of DevTools, as I am comfortable reviewing these as domain
reviewer.

R=yangguo@chromium.org,aerotwist@chromium.org

Change-Id: Ib1be70b97c5395498795b4b28ce7001731305d41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2282516
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-07-06 12:36:21 +00:00
Mathias Bynens 42f585a5ad Fix -theme-preserve styles 
Previously, many CSS rules were written as:

    -theme-preserve {
      foo: bar;
    }

Note that the selector is `-theme-preserve`, which in theory matches
any <-theme-preserve> elements — but we don’t use any such elements,
and it’s an invalid custom element name [1] anyway.

The only reason these selectors are used is to mark a CSS rule as
unaffected by DevTools theming; `_patchProperty` in `UIUtils.js` checks
if the selector contains `'-theme-'`.

stylelint-config-standard complains about this selector for good
reason, so we should use something else. A simple fix is to use a class
selector instead:

    .-theme-preserve {
      foo: bar;
    }

There is one gotcha: `-theme-preserve` gets applied as an actual class
name to some <input> elements in the memory timeline under the
Performance panel. To prevent those elements from getting all the
`-theme-preserve` styles, this patch changes the class name for that
specific case to `-theme-preserve-input`.

This works great: stylelint is now happy, and `_patchProperty` in
`UIUtils.js` still works correctly, since it only checks if the
selector contains `-theme-` anywhere.

[1]: https://mothereff.in/custom-element-name#-theme-preserve

Bug: chromium:1083142
Change-Id: I923f12de6d581e9fef71a9a58bda184e40dee796
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2252017
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-06-19 13:07:31 +00:00
Yang Guo 3852a23f96 Seed more owners to front_end directories 
Bug: chromium:1082687
Change-Id: I07ad07fba7513d674eb8b6e84d8296bf64d37230
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2207319
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Reviewed-by: Leo Lee <leolee@microsoft.com>
 2020-05-20 07:20:27 +00:00
Mathias Bynens ca9fa2d73f Consistently format CSS color and opacity values 
- Prefer the modern comma-free CSS color function syntax over the
  legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
  clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
  the value as a number, again to clarify the range.

[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color

Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2020-05-19 16:50:26 +00:00
Mathias Bynens b0c1f4bce2 Fix stylelint-config-standard violations 
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-05-15 17:05:27 +00:00
Tim van der Lippe e7f27058f4 Replace double class invocations of createElementWithClass 
This applies the following replacement to the codebase:

(\S+) = createElementWithClass\('(\w+)', '([^'\s]+) ([^'\s]+)'\);

to

$1 = document.createElement('$2');\n$1.classList.add('$3');\n$1.classList.add('$4');

R=aerotwist@chromium.org

Bug: 1011811, 1077215
Change-Id: I0ac37f594bd12dd7b1ffb53d7ca9ef04761df5f0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2176114
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-05-04 09:49:41 +00:00
Mathias Bynens 5e43b27e8b Reformat module.json files 
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.

Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.

Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-14 05:35:23 +00:00
Alex R 8475bb3343 Make TreeOutline in Changes not focusable until there is content 
When the empty TreeOutline in Changes panel gets focus via keyboard,
the outline is shown without any content. This change disable focus
until there is some content in the aforementioned TreeOutline.

Bug: 1048986
Change-Id: I9aa9c24a0197a9fd23a862cc803ce785196a6a2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2132236
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
 2020-04-03 08:54:03 +00:00
Paul Lewis 75c7d0decc [global] Remaps self.UI.viewManager 
Moves self.UI.viewManager to an instance() method.

Bug: 1058320
Change-Id: I0c444101da59ba9eba4745d1dc551bb8906a0a4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107624
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-03-19 12:39:32 +00:00
Kalon Hinds 1574c49c4f High contrast support for Changes Panel 
This patch provides forced-colors overrides to make sidebar icons
on the changes panel visible in high contrast mode.

Screenshots: https://imgur.com/a/GG665sc
Bug: 1048378
Change-Id: I6f285eca8abafc40de17a8606a5f9c59aea0a384
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107112
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-03-18 22:24:39 +00:00
Mathias Bynens 23ee1aad0a Reconfigure lint rule w.r.t. quotes 
We prefer single quotes by default, but still want to allow double
quotes in cases where that helps avoid quote-escaping, and also want
to allow template literals in cases where string interpolation is
used. For example:

    const a = 'xxx';  // ok
    const b = "xxx";  // not ok, should use single quotes
    const c = "xxx'xxx";  // ok, double quotes avoid an escape sequence
    const d = `xxx`;  // not ok, frivolous use of template literal
    const e = `xxx ${42}`;  // ok

Per https://github.com/eslint/eslint/issues/12976, setting
the `allowTemplateLiterals` option for the `quotes` lint rule to
`false` gives us the desired behavior.

Note that the above lint rules are auto-fixed when running the linter;
there should be no need to manually make any changes to appease the
linter.

Per review feedback, this patch also removes the following escape
sequences for printable non-ASCII symbols:

- U+00D7 → ×
- U+2026 → …
- U+2019 → ’

Chromium CL temporarily updating test expectations:
https://chromium-review.googlesource.com/c/chromium/src/+/2083147

Cq-Depend: chromium:2083147
Bug: chromium:1057042
Change-Id: Id6bec3f96ca694d2fbc07dd8629fce305a58df8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082372
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2020-03-02 16:18:16 +00:00
Tim van der Lippe 4abec848cb Remove typedefs from changes-legacy.js 
Bug: 1006759
Change-Id: I83d4c4ad7f8dd247c8a27ef6e83bbe27a7eec17b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2057204
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-14 15:21:06 +00:00