Commit Graph
15 Commits
Author SHA1 Message Date
Tim van der Lippe 54780f2bca Remove platform/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: I036bc21f0ebf7f2e65c7d9a89281c1fbcb4a9033
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676156
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
2021-02-05 13:39:48 +00:00
Tim van der Lippe 5c423509db Remove i18n/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: I700e6d5fc8941ef54d4af10af01989ddf62165cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676144
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-02-05 10:48:08 +00:00
Tim van der Lippe 13a46caab1 Remove bindings/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: I4ed2fefd511271ef2ec845c6fad165217a1477c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676142
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-02-04 17:07:19 +00:00
Christy Chen 3e5de8a135 [Loc] Migrate components to Localization V2
Bug: 1136655
Change-Id: I69678b0f06027cd0b4b3715d959a41fa592a60bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2585954
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2020-12-11 19:25:57 +00:00
Tim van der Lippe 46e1bcace9 Remove pre_generates_legacy from module.json files
This was a temporary flag used during the build_release_applications
to GN migration.

R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I8a772bcc4bee31dbd3270bf7ef62d8c97941024a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484716
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-10-19 16:12:09 +00:00
Tim van der Lippe c20afe742b Move legacy files from ui modules to GN
R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I8ece4d0b8373584333b9639e2ba3f4a584088619
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2476335
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-10-16 11:03:37 +00:00
Tim van der Lippe cac65d4fa0 Remove skip_rollup
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-09-08 15:44:09 +00:00
Songtao Xia e3af1e3f7d Fix issues when reloading DevTools after setting change
DevTools has some settings that requires a reloading of DevTools
after changing them.

If DevTools frontend is undocked, several issues were noticed.
1) device mode button does not work.
2) clicking on "Reload devtools" button, a tab appears instead of
that the devtools is reloaded.

The cause of the issue is that when "Reload DevTools" is clicked,
the reloading logic fails to consider the case when DevTools is
undocked.

Fix is to use the same logic as frontend.components.reload in
frontend.ui. We move the DockController.js from components to ui as
1) ui cannot depend on component and 2) DockController is arguably
a legitimate part of ui.

The after gif is below, where we tested both cases.
https://imgur.com/8LVLPMW

Bug: chromium:1105779, chromium:1113601
Change-Id: Ie8e1e60c49ff733de53ab7ad1409d8c44e99162a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2354551
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2020-08-19 04:59:57 +00:00
Simon Zünd 700b12b147 Migrate 'front_end/components' to 'devtools_entrypoint'
R=aerotwist@chromium.org

Bug: chromium:1101738
Change-Id: Ieb5134f468e0679d5e559287469998c99a2d9818
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2317311
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-07-24 14:51:53 +00:00
Tim van der Lippe 37512b0d25 Remove empty script arrays from module.json files
If the module uses `modules` to load the JavaScript files, then
we can remove the `scripts` array altogether. Note that there
are still some modules left that use `scripts`, most notably
the `lighthouse_worker`, which is a remote module.

R=aerotwist@chromium.org

Bug: 1105476
Change-Id: Ie303e9835f5ce6d42ccae7b3a305d8f3df1af84c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2302597
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-07-17 10:05:33 +00:00
Mathias Bynens 5e43b27e8b Reformat module.json files
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.

Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.

Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2020-04-14 05:35:23 +00:00
Tim van der Lippe 5d1c0dd1f6 Migrate components/ to ESM internally
Bug: 1006759
Change-Id: I1b7ad16f09ef1c7fe3a404f073953baf739ec8e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991513
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-01-10 12:37:57 +00:00
Tim van der Lippe 6db3920903 Migrate components/ to ESM
Bug: 1006759
Change-Id: Ifa7e245a9bbdfc02a5885efb6907e488afdca6e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847912
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#704189}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a275c8489110bacc08ec22496de42c01159e1a4
2019-10-09 14:50:54 +00:00
Pavel Feldman 18d135653c DevTools: bring back network log into the core sdk.
Change-Id: If11eab039bdc86257da197d9adbe6ff64764c627
Reviewed-on: https://chromium-review.googlesource.com/1154435
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579305}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fc2871307820380d66feb9948098629998b0365c
2018-07-31 03:31:18 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00