zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-09 21:28:43 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
4 Commits
Author SHA1 Message Date
Alex Rudenko 2f57b45726 Revert "[console] Escape double quotes when printing strings." 
This reverts commit f34ad08ea1.

Reason for revert: causes a test failure on Windows bots https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8855087583563203648/+/steps/browser_tests__with_patch__on_Windows-10-18363/0/logs/Deterministic_failure:_DevToolsSanityTest.TestDeviceEmulation__status_FAILURE_/0

Original change's description:
> [console] Escape double quotes when printing strings.
>
> This aligns the behavior of Chromium DevTools with the existing behavior
> found in Firefox DevTools, making it easier for Web Developers to copy
> and paste strings from the console (with fewer surprises when the
> strings happen to contain double quotes).
>
> Before: https://imgur.com/yoo2UT6.png
> After: https://imgur.com/eMnbmPi.png
> Fixed: chromium:1178530
> Change-Id: Ia85758beb39f01e706e88bd826980c67a9c1adc6
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697190
> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>

Change-Id: Ie5de20e53b8c36a24aafafc3c2fc4d3971fdd08e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698828
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-17 07:04:01 +00:00
Benedikt Meurer f34ad08ea1 [console] Escape double quotes when printing strings. 
This aligns the behavior of Chromium DevTools with the existing behavior
found in Firefox DevTools, making it easier for Web Developers to copy
and paste strings from the console (with fewer surprises when the
strings happen to contain double quotes).

Before: https://imgur.com/yoo2UT6.png
After: https://imgur.com/eMnbmPi.png
Fixed: chromium:1178530
Change-Id: Ia85758beb39f01e706e88bd826980c67a9c1adc6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697190
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-02-16 16:55:23 +00:00
Sigurd Schneider 17c7445384 Enforce camelCase for variables.. 
..except for top-level `const` for which we allow
camelCase, PascalCase and UPPER_CASE for the time being
to accomodate the status quo in DevTools FE.

Also allow `UIStrings` and `str_` which are used for localization
all over the place.

Bug: chromium:1057042
Change-Id: Ifa0445ac08c78997499ac5f9f33c9a9dc03d37fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692779
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-15 13:08:10 +00:00
Jan Scheffler 19cd7eca6c [JSDOC2TS]: Migrate console 
Bug: chromium:1158760
Change-Id: I6d2aadda23109fb8c9581ecb3810c77fd9341b10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692147
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-12 15:19:11 +00:00