 John Emau
|
7776e78f01
|
[console] make context selector subtitle contrast WCAG compliant
The console context selector subtitle displays useful product information
to help differentiate between contexts. This feature was added in response
to https://crbug.com/719058.
In the original implementation a text foreground color value of #999 was
used (light theme) which does not meet WCAG 1.4.3 compliance:
https://www.w3.org/WAI/WCAG21/quickref/#contrast-minimum
Changing the CSS color value to use `--selection-inactive-fg-color` sets
the color value to #5a5a5a in light theme and #cdcdcd in dark theme, which
meets contrast minimum.
Before (Light Theme) Colors: https://webaim.org/resources/contrastchecker/?fcolor=999999&bcolor=FFFFFF
Before (Dark Theme) Colors: https://webaim.org/resources/contrastchecker/?fcolor=666666&bcolor=242424
After (Light Theme) Colors: https://webaim.org/resources/contrastchecker/?fcolor=5A5A5A&bcolor=FFFFFF
After (Dark Theme) Colors: https://webaim.org/resources/contrastchecker/?fcolor=CDCDCD&bcolor=242424
Additionally using the CSS variable makes the tool more theme-able,
`--selection-inactive-fg-color` was chosen because the item colored
is an inactive selection and aligns with usage in the tree outline control [1].
It took me a minute to get used to but I now prefer the new colors because
of how easy it is to see all the information, especially in dark theme.
[1]: https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/front_end/ui/treeoutline.css?originalUrl=https:%2F%2Fcs.chromium.org%2F
Screenshot: https://imgur.com/sZ4iAvX
Change-Id: Ic97fdef1ad2ed6989dcc9e6d7263b28babc077a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2202665
Commit-Queue: John Emau <John.Emau@microsoft.com>
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Tony Ross <tross@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
|
2020-05-15 23:06:39 +00:00 |
|
|
Mathias Bynens
|
b0c1f4bce2
|
Fix stylelint-config-standard violations
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
|
2020-05-15 17:05:27 +00:00 |
|
|
Jonathan Garbee
|
3f710c7412
|
DevTools: scroll console scopes if more exist than can be seen
The scope menu is restricted to a specific height. However if a user
was to have more than would fit in that, they were unable to reach them.
This patch applies automatic overflow on the y axis to the menu.
If the amount of scopes fits in that height, they will have no scrollbar.
A scrollbar will appear when more than can fit within the menu
are present.
This allows users to get access to all scopes available regardless
of the menu height.
Screenshots:
[Before] - https://drive.google.com/file/d/1QK6n3HLUFPKPKRmKMp_K0z-s7E7fmOKc/view?usp=sharing
[After] - https://drive.google.com/file/d/16pFNHUe5oCNfasdpPcw_a5PSZrHFrRIX/view?usp=sharing
Bug: 1038461
Change-Id: Ia36b00d0b991a9614c1c7a2a2cf6e95540ca75e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2061128
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
|
2020-02-18 16:13:37 +00:00 |
|
|
Blink Reformat
|
4c46d0969f
|
The Great Blink mv for source files, part 2.
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
|
2018-04-07 15:32:37 +00:00 |
|