zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-10 13:44:39 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
6 Commits
Author SHA1 Message Date
Sigurd Schneider 17c7445384 Enforce camelCase for variables.. 
..except for top-level `const` for which we allow
camelCase, PascalCase and UPPER_CASE for the time being
to accomodate the status quo in DevTools FE.

Also allow `UIStrings` and `str_` which are used for localization
all over the place.

Bug: chromium:1057042
Change-Id: Ifa0445ac08c78997499ac5f9f33c9a9dc03d37fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692779
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-15 13:08:10 +00:00
Sigurd Schneider cb2d45671e Enforce naming convention for properties 
This CL enforces general camelCase naming for properties,
with the following exceptions:
  - public properties are allowed to have a leading underscore until
    we've migrated them (they were probably introduced by the
    JSDOC -> TS automated script).
  - static readonly class properties must use CONSTANT_CASE. For
    non-static readonly class properties camelCase is enforced,
    and I think this gives the right intuition.

Bug: chromium:1057042
Change-Id: I482b5b7cfe2b856e83fba8b78be222d60761db19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692210
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-15 09:21:50 +00:00
Sigurd Schneider 1576186355 Enforce member delimiters 
This CL enforces member delimiters following
https://google.github.io/styleguide/tsguide.html#member-property-declarations

Bug: chromium:1057042
Change-Id: I2553aeebb8187235cdf0e7f0585da36ea53388bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2672032
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-04 09:03:57 +00:00
Sigurd Schneider 9c07567fdd Properly enable dangling comma conventions in TypeScript 
The eslint rule 'comma-dangle' isn't enough to enforce dangling
commas in TypeScript, we must use '@typescript-eslint/comma-dangle'
instead.

Bug: chromium:1174055
Change-Id: I589e1016ab578c965b54f17da3eab7ea542a2f7a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2672028
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-03 14:01:11 +00:00
Tim van der Lippe cbdf5f2baa Migrate upperBound to array-utilities 
R=szuend@chromium.org

Bug: 1050549
Change-Id: Icee0883ab986fe08d9766272549f5ed66aee8574
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2644901
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-25 12:21:23 +00:00
Jan Scheffler 9306b2bdd4 [JSDOC2TS]: Migrate coverage 
Bug: chromium:1158760
Change-Id: I08caa31931f201d4e6d7912304c4f60f3d274c61
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629552
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 15:42:26 +00:00