Jack Franklin
49a9481a74
Lint color usage in background and border-* properties.
...
The list of CSS properties we check for colors wasn't thorough and
didn't include `border-left/right/top/bottom` or `background` on its
own. This CL fixes that and disables the rule for any current
violations.
Bug: 1152736
Change-Id: Ic732d653fdfab0462a04dc891bcece1f44e5d471
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676157
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
2021-02-05 15:39:39 +00:00
Jack Franklin
8064d3ba7a
Lint against non-theme-color variables
...
This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.
There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.
Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.
Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2021-02-03 11:02:09 +00:00
Jack Franklin
0d88cbb6fd
Ban named-colors in our CSS
...
Used
https://css-tricks.com/snippets/css/named-colors-and-hex-equivalents/ as
the reference and did a bunch of find and replaces. Should be no visible
changes; have checked by running DevTools locally and looking for
anything that looks off.
Note that system colors (e.g. HighlightText) are still permitted.
Fixed: chromium:1171775
Bug: chromium:1104187
Change-Id: I99c281886822deb5a5292ac8691a4f2f9e026428
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2656243
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2021-02-01 09:33:45 +00:00
Sigurd Schneider
702a287b86
Fix stylelint-config-standard issues in coverage/coverageListView.css
...
R=mathias@chromium.org
Bug: chromium:1083142
Change-Id: Ib516e2c64b828cbba3115404771fceb8e0dfecac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2264113
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Auto-Submit: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-06-24 14:06:19 +00:00
Mathias Bynens
b0c1f4bce2
Fix stylelint-config-standard violations
...
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
2020-05-15 17:05:27 +00:00
Kham Udom
211ca5084f
Fix high contrast in Coverage panel
...
You are now able to see usage bar in the grid and the foreground
of the percentage text is set to the correct color on focused.
Before: https://imgur.com/a/NmTkhcl
After: https://imgur.com/a/lCJ7kWn
Bug: 1048378
Change-Id: I1512f8f07d9ca5f5003becacdd27745c5330326e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081872
Commit-Queue: Kham Udom <khamu@microsoft.com >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-03-01 21:18:32 +00:00
Benedikt Meurer
a62d7f895a
[devtools] Improve code coverage color selection.
...
The color selection for code coverage (red+green) is not ideal for
developers that are impacted by color blindness. This changes the
colors to a brighter red and some blueish green that, a combination
that is known to work well enough for people impacted by different
kinds of color blindness.
https://pbs.twimg.com/media/EEU9fCzUUAItz4n?format=jpg shows an
example of how these two colors look like now.
Bug: chromium:1003671
Change-Id: I9c3e08fb350a6086624d63f44e069813c618588e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801762
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org >
Commit-Queue: Yang Guo <yangguo@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#696727}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 71d06de626d5e15fae7534df8fe0bb1613838aa7
2019-09-16 08:00:24 +00:00
Blink Reformat
4c46d0969f
The Great Blink mv for source files, part 2.
...
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org >
Commit-Queue: Blink Reformat <blink-reformat@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00
Jack Franklin