Commit Graph
28 Commits
Author SHA1 Message Date
Andres Olivares 53a3aa0328 [module.json extensions] @SourceFrame.LineDecorator
Bug: 1134103
Change-Id: I5548d5d4af8a60ecb1c178c4cc3041e8cfaec5ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692888
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-02-15 15:48:02 +00:00
Tim van der Lippe e6ddf27aac Remove formatter/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: Ib45084e1f0d23c02b22ae74afb6c7c5f73546513
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686664
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-02-12 14:14:59 +00:00
Tim van der Lippe 4d072bbb6d Remove workspace/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: I579833ff45462768b69ad9f3fa151f74385bb176
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686661
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-02-10 14:05:40 +00:00
Tim van der Lippe 2ffd98c98c Remove text_utils/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: Ic0a02daa6c1435d65b2b29fd3279d09f3015894b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2682483
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-02-09 16:06:38 +00:00
Tim van der Lippe f1d02ad898 Remove sdk/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: Ic4d840aff08bcbc4b5aaf4f98e1a7e8a5c7882f6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2682479
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-02-09 16:00:18 +00:00
Tim van der Lippe 54780f2bca Remove platform/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: I036bc21f0ebf7f2e65c7d9a89281c1fbcb4a9033
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676156
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
2021-02-05 13:39:48 +00:00
Tim van der Lippe 79e4d8531a Remove host/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: I3015c907604c739ee3d50a003f47faa6861215ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676145
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-02-05 10:55:28 +00:00
Tim van der Lippe 5c423509db Remove i18n/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: I700e6d5fc8941ef54d4af10af01989ddf62165cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676144
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-02-05 10:48:08 +00:00
Tim van der Lippe 49f2cf1f4e Remove common/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: Ie7556606b481d34e32fc46f684fa21fc04e1bd2d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676143
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-02-05 10:44:28 +00:00
Tim van der Lippe 13a46caab1 Remove bindings/module.json
R=andoli@chromium.org

Bug: 1127902
Change-Id: I4ed2fefd511271ef2ec845c6fad165217a1477c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676142
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-02-04 17:07:19 +00:00
Andres Olivares dd92fb29ff [module.json extensions] coverage actions
Bug: 1134103
Change-Id: If001d1c607e1dfb9775331f99e0ec87d26a39df0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2648914
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-01-26 16:02:15 +00:00
Tim van der Lippe a71272ea25 [module.json extensions] coverage
R=andoli@chromium.org

Bug: 1134103
Change-Id: Iefcbb03583eaeb7d008abb0d4cbce7256747a149
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612857
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-01-12 15:38:31 +00:00
Tim van der Lippe 7dcef88d8b Remove skip_compilation from module.json files
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I4c4fd280adb4f5f7b327239d08d80b2cb98b203b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560248
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-11-25 13:19:08 +00:00
Tim van der Lippe f0a1510035 Use TypeScript-authored files in coverage/
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: Ibb4345721cd288095343d0ae3215db63bc420867
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2550693
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-11-20 15:52:02 +00:00
Christy Chen 2e411e2f84 [Loc] Migrate coverage to Loc V2
- Migrate coverage panel to use LocV2 apis.
- Removed unused grdps

Tested with en-XL.json
https://imgur.com/a/61yoUNo

Bug: 1136655
Change-Id: Ie5de60d4e62a1496f9642d8eeed0e326727f17d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2504408
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
2020-11-03 17:06:17 +00:00
Tim van der Lippe 46e1bcace9 Remove pre_generates_legacy from module.json files
This was a temporary flag used during the build_release_applications
to GN migration.

R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I8a772bcc4bee31dbd3270bf7ef62d8c97941024a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484716
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-10-19 16:12:09 +00:00
Tim van der Lippe ead1fa43d0 Move remaining legacy files to GN
R=aerotwist@chromium.org

Bug: 1131500
Change-Id: Ibb247dd02a5032604824517be4276c4b83c8fc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479140
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-10-19 09:25:50 +00:00
Tim van der Lippe cac65d4fa0 Remove skip_rollup
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-09-08 15:44:09 +00:00
Jan Scheffler 688afaac76 Migrate front_end/coverage to devtools_entrypoint
R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: I28a7cc3e6f4abeb83fffb0b0110ec6a83e1de04f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329776
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-07-30 15:04:30 +00:00
Tim van der Lippe 37512b0d25 Remove empty script arrays from module.json files
If the module uses `modules` to load the JavaScript files, then
we can remove the `scripts` array altogether. Note that there
are still some modules left that use `scripts`, most notably
the `lighthouse_worker`, which is a remote module.

R=aerotwist@chromium.org

Bug: 1105476
Change-Id: Ie303e9835f5ce6d42ccae7b3a305d8f3df1af84c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2302597
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-07-17 10:05:33 +00:00
Sigurd Schneider 307d82aaac Modernize CoverageView/CoverageListView
This makes improvements towards TypeScriptification, but much more work
is required.

Bug: chromium:1011811
Change-Id: Ic3c00cfc640dce0fdd6f132a19975436ff2a4617
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2277986
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2020-07-03 09:15:35 +00:00
Mathias Bynens 5e43b27e8b Reformat module.json files
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.

Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.

Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2020-04-14 05:35:23 +00:00
Tim van der Lippe 6a3f48ef1e Migrate coverage/ to ESM internally
Bug: 1006759
Change-Id: If91b5c08dc40166640e8e7e2a24364d8b2b51f95
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991519
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-01-09 14:46:41 +00:00
Sigurd Schneider 810aa6cba2 [coverage] Fix formatting from coverage list view
We won't support cyclic dependencies, so after the introduction of
the CoveragePlugin in source, the SourceFormatter must move to a
package up in the hierarchy to be usable by both Source.* and
Coverage.*.

Bug: chromium:1004203, chromium:1034005
Change-Id: Ia5fcf0e7b2caa6d44620b6e4dc712086df49ef0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1964332
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2019-12-16 10:13:57 +00:00
Jan Scheffler 0027820ae2 Add coverage information to status bar
This patch adds a new statusbar item to the sources panel
to inform developers about the coverage of the current file
or to open the coverage panel if no coverage has been reported yet.

https://imgur.com/a/axWRJvJ

This cl depends on crrev.com/c/1955587 to disable tests.

Fixed: 1022013
Change-Id: Ibd57bc6fa8a0730574abe8e009f67b245f43d0e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1905828
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
2019-12-09 14:06:22 +00:00
Paul Lewis 595a273cfc Migrates coverage/ to esm
Bug: 1006759
Change-Id: I4bcbfad6d9512331df9394a0a182521cadb8e6dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928917
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
2019-11-21 11:35:23 +00:00
Joel Einbinder 346980e4b0 DevTools: Explicitly toggleable action buttons
Before this patch, DevTools didn't distinguish between toggleable
actions and regular actions. When an action button was made, it was
always a toggle button. This worked because an untoggled button
and an untoggleable button are the same visually.

But for the accessibility tree, an untoggled button should have
aria-pressed=false, whereas an untogglable button should not have
aria-pressed at all. This means its important to distinguish
between toggleable and untoggleable actions.

This patch:
* Adds a new field to actions in module.json: toggleable.
* Dynamically returns the correct kind of button from createActionButton
* Refactors createLongPressActionButton into its own function.

Bug: 963183
Change-Id: Ie2ebbeab9d651b1823611d942bdc66e67ff293c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693175
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#677785}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92cb5705086497ab2c5e042265a18f7c3bb07ffc
2019-07-16 15:35:48 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00