Tim van der Lippe
5e8c855ced
Remove css_overview-legacy.js
...
Its extensions have been moved into the css_overview-meta.ts file
and all other content of the module.json is unused. Since none
of the layout tests use the CSSOverview symbols, we don't have
to add them to the integration_test_runner.js either.
R=aerotwist@chromium.org
Bug: 1127902
Change-Id: I10c70babc913b80d8b751386805520caa84640d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587021
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-12-15 11:47:57 +00:00
Tim van der Lippe
28d5ad7efb
[module.json extensions] css_overview
...
R=andoli@chromium.org
Bug: 1134103
Change-Id: Icef477bfebec409bdcb7fa1d2af6d5d034968b9d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587020
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Andres Olivares <andoli@chromium.org >
2020-12-14 16:06:46 +00:00
Tim van der Lippe
7dcef88d8b
Remove skip_compilation from module.json files
...
R=aerotwist@chromium.org
Bug: 1011811
Change-Id: I4c4fd280adb4f5f7b327239d08d80b2cb98b203b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560248
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-11-25 13:19:08 +00:00
Tim van der Lippe
3eadbdc258
Use TypeScript-authored files in css_overview/
...
R=aerotwist@chromium.org
Bug: 1011811
Change-Id: Ie8dd4ed28fbcb0a246e7066685e3da071692f674
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2520823
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-11-05 13:49:31 +00:00
Tim van der Lippe
46e1bcace9
Remove pre_generates_legacy from module.json files
...
This was a temporary flag used during the build_release_applications
to GN migration.
R=aerotwist@chromium.org
Bug: 1131500
Change-Id: I8a772bcc4bee31dbd3270bf7ef62d8c97941024a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484716
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-10-19 16:12:09 +00:00
Tim van der Lippe
ead1fa43d0
Move remaining legacy files to GN
...
R=aerotwist@chromium.org
Bug: 1131500
Change-Id: Ibb247dd02a5032604824517be4276c4b83c8fc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479140
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-10-19 09:25:50 +00:00
Alex Rudenko
d55e18c512
Add Contrast Issues section to CSS Overview
...
This CL adds a new section for contrast issues to CSS Overview.
A follow-up CL will add the contrast information for particular
elements in the grid view.
Screenshot: https://i.imgur.com/8tLlJWF.png
Bug: 1120316
Change-Id: I12dcd269454a43567619c811e4107c00dc8ee654
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2421696
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org >
2020-09-24 07:24:05 +00:00
Tim van der Lippe
cac65d4fa0
Remove skip_rollup
...
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.
R=jacktfranklin@chromium.org ,aerotwist@chromium.org
Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-09-08 15:44:09 +00:00
Jan Scheffler
e348fe9424
Migrate front_end/css_overview to devtools_entrypoint
...
R=aerotwist@chromium.org , jacktfranklin@chromium.org
Bug: 1101738
Change-Id: I406acc5e456237fda0d5c6b468f66d6c0b66fbc8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2323621
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
Auto-Submit: Jan Scheffler <janscheffler@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-07-28 19:16:12 +00:00
Tim van der Lippe
37512b0d25
Remove empty script arrays from module.json files
...
If the module uses `modules` to load the JavaScript files, then
we can remove the `scripts` array altogether. Note that there
are still some modules left that use `scripts`, most notably
the `lighthouse_worker`, which is a remote module.
R=aerotwist@chromium.org
Bug: 1105476
Change-Id: Ie303e9835f5ce6d42ccae7b3a305d8f3df1af84c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2302597
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-07-17 10:05:33 +00:00
Mathias Bynens
5e43b27e8b
Reformat module.json files
...
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.
Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.
Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
2020-04-14 05:35:23 +00:00
Tim van der Lippe
9d0cb5f9ee
Migrate css_overview/ to ESM internally
...
Bug: 1006759
Change-Id: I9119e12293f3765cae9432201d7e94f11352e552
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993340
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-01-09 14:58:01 +00:00
Paul Lewis
4da3b30c38
Migrates css_overview/ to esm
...
Bug: 1006759
Change-Id: Idf78688fa354b7e169edd508667dd2e298eacea4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928914
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2019-11-21 14:37:54 +00:00
Paul Lewis
ed808ce4cf
[CSS Overview] Updates UI
...
Change-Id: Ifdc7645399b9a5b8dd5d13c8d4dacaf8a67fc5bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1899518
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2019-11-06 14:44:25 +00:00
Paul Lewis
8aef901f3f
[CSSOverview] Add unused rules
...
This is the first pass at adding unused rules to the CSS Overview.
The CL adds support for checking width & height to inline elements
as well as position values to static elements. Further CLs will
add additional checks for other cases, e.g. the use of flex or grid
values against non-flex and non-grid elements respectively.
Change-Id: I2fb4fd557d67065a5753587624195920c22b3edc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1886818
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2019-10-29 14:36:57 +00:00
Paul Lewis
de0224ccdd
[CSS Overview] Uses snapshot; adds element highlight
...
Change-Id: If58dd20c6f4b3c8f730b39c48c14826e402018a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1873759
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
2019-10-23 09:55:00 +00:00
Paul Lewis
ebc4719819
[DevTools] Adds media queries to CSS Overview
...
Bug: 1007284
Change-Id: I8c24adddf91da3bd621b61db6eac49233b8a1db4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849671
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#704192}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 193ed603a6eaec431f9d0f339f697ab03f99c838
2019-10-09 15:06:41 +00:00
Paul Lewis
8cddf9931f
[DevTools] Adds CSS Overview Panel
...
Creates a panel that steps through the page to build statistics on CSS
used, such as colors, fonts, specificity, and other items of note.
Note: this is a DevTools experiment.
Bug: 1007284
Change-Id: Ib8d8b2af6bb65d6ff4816ca23b48b76980cd80db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806736
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#700745}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0e4a3c81f343d15e2121280d332659778ad07323
2019-09-27 16:40:07 +00:00