zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-10 05:35:05 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
34 Commits
Author SHA1 Message Date
Peter Marshall 428508ab36 [l10n] Remove unused ModuleUIStrings files 
As directories are migrated to the new -meta files, they no longer
need their ModuleUIStrings file.

Bug: 1136655
Change-Id: Iae983195fa24f6262d1d47d6093e82f4ce3df537
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686658
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-10 16:37:51 +00:00
Tim van der Lippe 2ffd98c98c Remove text_utils/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: Ic0a02daa6c1435d65b2b29fd3279d09f3015894b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2682483
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-09 16:06:38 +00:00
Tim van der Lippe f1d02ad898 Remove sdk/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: Ic4d840aff08bcbc4b5aaf4f98e1a7e8a5c7882f6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2682479
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-09 16:00:18 +00:00
Jack Franklin 49a9481a74 Lint color usage in background and border-* properties. 
The list of CSS properties we check for colors wasn't thorough and
didn't include `border-left/right/top/bottom` or `background` on its
own. This CL fixes that and disables the rule for any current
violations.

Bug: 1152736
Change-Id: Ic732d653fdfab0462a04dc891bcece1f44e5d471
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676157
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-05 15:39:39 +00:00
Jack Franklin 8064d3ba7a Lint against non-theme-color variables 
This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.

There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.

Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.

Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-02-03 11:02:09 +00:00
Andres Olivares f138902e8f Change commandPrompt type to LocalizedString in ViewRegistration 
Bug: 1169065, 1134103
Change-Id: If647a6f51309f87f3da8a895c96db463494554d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2642909
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-25 18:00:55 +00:00
Tim van der Lippe 98308ad184 Remove modules from migrated folders 
These extensions have been migrated and therefore we can only
import them for the layout tests.

R=andoli@chromium.org

Bug: 1131500
Change-Id: I7aebcf446cd267b4479d1ceb14274b3ccfb1624c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2644805
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-25 13:34:53 +00:00
Tim van der Lippe c50df856d6 Fix localization of developer-resources 
The console was showing all kinds of errors for this panel.
There were multiple issues:
- The registration call was using `*.js` rather than `*.ts`
- The meta file used `ls` instead of `i18nString`

R=petermarshall@chromium.org

Change-Id: I6063ce357ced424fcbc3d224c8e67ee97ebd279b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635665
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-19 16:03:59 +00:00
Tim van der Lippe b81bf5f2ec Fix styling of Developer Resources 
The developer resources tab was converted to a meta-file, but it turns
out that its styling got broken: crbug.com/1167625

The root cause was that the `data_grid` CSS files were not loaded yet
and thus were causing issues when `developer_resources-meta.js` would
have loaded before that had happened.

R=jacktfranklin@chromium.org

Fixed: 1167625
Change-Id: I2aea8e0c81c0a92eb30f8a963517d5bf4411ed37
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635659
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-19 11:10:06 +00:00
Andres Olivares 4ce36a5a37 [module.json extensions] Wrap localizable fields in anonymous functions 
To be able to localize extensions' strings at declaration using the i18n
v2 model in meta files, we opt to wrap such fields in callbacks as the
i18n API cannot be invoked directly at declaration because it hasn't
been configured by the time the meta files are loaded.

Bug: 1134103
Change-Id: I432f3854f724b8c5b94993ce3ddd469f657c1014
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635820
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 19:04:06 +00:00
Jan Scheffler 403a40aa58 [JSDOC2TS]: Migrate developer_resources 
Bug: chromium:1158760
Change-Id: Idf4eb62db30617572d5b518b6cb596165454e02b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629553
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 09:59:12 +00:00
Tim van der Lippe 6d5bdf4f7e [module.json extensions] developer_resources 
R=andoli@chromium.org

Bug: 1134103
Change-Id: I433c9a8d02541ace0fbf7662f6689faaa7f0607a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612856
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-13 12:40:02 +00:00
Tim van der Lippe d7cfd14814 Fix no-implicit-coercion errors in front_end/ 
R=jacktfranklin@chromium.org

No-Presubmit: True
Bug: 1082789
Change-Id: Ic77884bf7e9b5dc74053915b3b10699368841b66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2595268
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-07 12:40:16 +00:00
Jack Franklin e2fe0e4a4b [Dark Mode]: migrate CSS files with no colors 
This CL batches up changes to multiple CSS files where they had either
no colors to change, or one very easy color to change.

Bug: 1152736
Change-Id: I061ebd909539dfaca7e8c3a70b0e97f0a0ba5f07
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567115
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-01 15:59:15 +00:00
Tim van der Lippe 7dcef88d8b Remove skip_compilation from module.json files 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I4c4fd280adb4f5f7b327239d08d80b2cb98b203b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560248
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-25 13:19:08 +00:00
Tim van der Lippe 70842f313f Replace title property setter with Tooltip install invocation 
ui/Tooltip.js overrides the HTMLElement prototype to override the
title property. Rather than using this property, we shoul be
calling Tooltip.install directly. This makes sure that new
components are not relying on the behavior of the legacy
prototype patching.

These usages have been manually audited using the following regexes:

Search: ([\S]+)\.title = ([^;]+);
Replace: UI.Tooltip.Tooltip.install($1, $2);

Note that there are classes in DevTools that also have a title
property. Most notably `TreeElement`. We should not be replacing
these, as they do not inherit from HTMLElement. Luckily, we are
running TypeScript to make sure we don't call `Tooltip.install`
with a non-HTMLElement.

A follow-up CL will clean up the getters.

R=jacktfranklin@chromium.org

Bug: 1150762
No-presubmit: True
Change-Id: I5928e75c70293531849e0576f4fb2a2a8b3e02d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2555060
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-23 17:16:46 +00:00
Kalon Hinds 361d02972a [Loc] Migrate developer_resources to Localization V2 
Bug: 1136655
Change-Id: I01278b1c215dd7efa7255223a520df3524c53897
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2552105
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-11-20 19:47:24 +00:00
Tim van der Lippe 1cd66597f7 Use TypeScript-authored files in developer_resources/ 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I3d1719406777114a7179ca115f4d6c7f4092ffaa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2520997
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-11-06 10:57:32 +00:00
Christy Chen 2e411e2f84 [Loc] Migrate coverage to Loc V2 
- Migrate coverage panel to use LocV2 apis.
- Removed unused grdps

Tested with en-XL.json
https://imgur.com/a/61yoUNo

Bug: 1136655
Change-Id: Ie5de60d4e62a1496f9642d8eeed0e326727f17d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2504408
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
 2020-11-03 17:06:17 +00:00
Jack Franklin 71519f8efb Introduce enableLegacyPatching flag for CSS patching 
As part of the dark mode migration we are adding
`enableLegacyPatching:true` to all call sites of `appendStyle` (and
related methods). If a user passes `false` for that flag, no CSS colour
patching will occur.

This CL is therefore a no-op from a user's perspective as we pass `true`
on every call to maintain existing behaviour, but once we start
migrating we will turn the option to `false`. Long term, once all code
is migrated and the old patching is removed, we will remove this flag
entirely once again.

Bug: 1122511
Change-Id: I76b818e83b7d5ee0175e1548759373f53481e0ab
No-Presubmit: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2516345
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-03 14:11:46 +00:00
Andres Olivares 21ab05b27a Make template type of data_grid/DataGrid.js more specific to prepare for migration to TS 
Bug: chromium:1011811
Change-Id: I6395a1839cc22aebf410c5e6423f40d785dbd1c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2476853
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-10-21 14:25:55 +00:00
Yang Guo ef36cec5b9 Apply governance change 
DISABLE_THIRD_PARTY_CHECK=no code changes
R=bmeurer@chromium.org

Change-Id: I2477c36f5ef2494ccae3efae3f1aee942f365fec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2489420
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-10-21 07:54:15 +00:00
Tim van der Lippe 46e1bcace9 Remove pre_generates_legacy from module.json files 
This was a temporary flag used during the build_release_applications
to GN migration.

R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I8a772bcc4bee31dbd3270bf7ef62d8c97941024a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484716
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-10-19 16:12:09 +00:00
Tim van der Lippe ead1fa43d0 Move remaining legacy files to GN 
R=aerotwist@chromium.org

Bug: 1131500
Change-Id: Ibb247dd02a5032604824517be4276c4b83c8fc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479140
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-10-19 09:25:50 +00:00
Andres Olivares 660580a68a [ts] Typecheck data_grid/ViewportDataGrid.js with TypeScript 
Bug: chromium:1011811
Change-Id: I96e96c4a31ad849659268fcd260996080493ce5b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2459646
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-10-08 21:09:27 +00:00
Andres Olivares 03d9c75f88 [ts] Typecheck data-grid/SortableDataGrid.js with TypeScript 
Bug: chromium:1011811
Change-Id: I35a0f5694cc8d701ae3f78155ec0647e3d87e9a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2440272
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2020-10-01 15:46:41 +00:00
Sigurd Schneider 7a3bd578c6 Improve Settings types for checkboxes 
Bug: chromium:1011811
Change-Id: I24a0115e036ecd0f4af221f202aa95c28bfeedd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2440496
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-10-01 08:35:24 +00:00
Sigurd Schneider 78bdf4a64d Make load-through-target configurable 
Bug: chromium:1069378
Change-Id: I26e0ffd4afa86897ed07aa2ab36d025977ca9992
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2438460
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-09-30 13:28:17 +00:00
Sigurd Schneider 2533de14e2 Show initiator URL in developer resources view 
Drive-by: Enable TS checking for front_end/developer_resources
Drive-by: Properly export IOModel

Bug: chromium:1069378, chromium:1011811
Change-Id: I50b7ae66067d426c8dda0d8829c35b6f6aa9696e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2428331
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-09-24 14:08:06 +00:00
Tim van der Lippe cac65d4fa0 Remove skip_rollup 
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-08 15:44:09 +00:00
Tim van der Lippe 054314154c Migrate developer_resources to devtools_entrypoint 
R=jacktfranklin@chromium.org

Bug: 1101738
Change-Id: I98099c5cba48d3ae28711c7a9a432670f6025b8b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2390626
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-03 08:54:31 +00:00
Tim van der Lippe 37512b0d25 Remove empty script arrays from module.json files 
If the module uses `modules` to load the JavaScript files, then
we can remove the `scripts` array altogether. Note that there
are still some modules left that use `scripts`, most notably
the `lighthouse_worker`, which is a remote module.

R=aerotwist@chromium.org

Bug: 1105476
Change-Id: Ie303e9835f5ce6d42ccae7b3a305d8f3df1af84c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2302597
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-07-17 10:05:33 +00:00
Wolfgang Beyer d376239b44 Move FrameManager from browser_sdk to sdk 
Change-Id: I4a14a449d1de6ea21912bb130d5ca03bf8b28d57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2287519
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-07-08 15:29:26 +00:00
Sigurd Schneider 9190780721 Add developer resources tab (behind a flag) 
This ads a tab where all developer resources (that is source maps
and source code referenced from them) are listed once a load is
triggered. The tabs main function is to display the network load
status of the resources: It lists whether the load was successful
or not, and provides an error description. This is useful for
debugging when we enable a different source map loading mechanism.

The tab is currently gated behind a flag.

Screenshot: https://imgur.com/a/raMhmB5
Design Doc: https://docs.google.com/document/d/1RGxUa8yg_gF-G9exoXQa7a9ZyIMFOrUHtq9T793XTbY
Bug: chromium:1069378
Change-Id: I84e880cc45c6520066d12310aff119fee5749fe1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2273188
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-07-08 09:17:16 +00:00